- 27 Aug, 2018 14 commits
-
-
Trent Apted authored
TBR=grt@chromium.org Bug: 877815 Change-Id: Ie8145b1bce2354365fc0284374bef442e67cf10c Reviewed-on: https://chromium-review.googlesource.com/1189510 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586186}
-
Trent Apted authored
Equality for chrome.app.window.AppWindow objects is not well-defined. In fact, testGetAllMultipleWindows was passing even though it was comparing arrays in different orders. Fix the tests by comparing the `id` property of the objects. Bug: 877129 Change-Id: I1a262b5f17c97320f9602f5d4251a044ec49220e Reviewed-on: https://chromium-review.googlesource.com/1188727Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586185}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9d69ae47cad64ee01e4635f78d22d4059c07db0e Reviewed-on: https://chromium-review.googlesource.com/1189210Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#586184}
-
Jinsuk Kim authored
Moves |WebContents.isSelectPopupVisibleForTesting| from the public interface to test-only util class. Bug: 875742 Change-Id: I51e5368b862cf1bbe4fd94ee0bba8435ae1e35a5 Reviewed-on: https://chromium-review.googlesource.com/1180943 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#586183}
-
Raymes Khoury authored
This removes content settings set for embedded sites for the geolocation, protected media and midi sysex permissions when permission delegation is enabled. If one of these permissions is set, the permission for the top level origin will also be reset. This is because some users may have allowed a top level origin while blocking a site embedded in it. In those cases the top level site could delegate permission to an embedded site they had previously blocked. Clearing access to the top level site gives those users another opportunity. Bug: 802945 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie858ff005078326d9b04b82a03ebc9febe81aebe Reviewed-on: https://chromium-review.googlesource.com/1166620 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#586182}
-
Stuart Langley authored
Part of ongoing work to cleanup various file system callbacks from repeating to once callback, to match the actual desired semantics of the operaton flow. Introduces no logic changes. Bug: 875700 Change-Id: I397368e27816ec11262e2cb4501677f7ccc02623 Reviewed-on: https://chromium-review.googlesource.com/1188725Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586181}
-
Noel Gordon authored
Sending Enter to the file-list container after sending an Enter key to the list renaming text input element causes flaky failures on the bots due to [renaming] complete racing with the processing of the file-list container Enter key handling. To verify that the Folder cannot be entered while it is being renamed, send Enter to the file-list container before sending Enter to the text input [renaming] element. Bug: 874954,877557,410163 Change-Id: Icf8ec215b4a4658e16940ab8ce9b1778f19f6235 Reviewed-on: https://chromium-review.googlesource.com/1188726Reviewed-by:
-
Trent Apted authored
Fails reliably on macOS 10.12 since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15035 NOTRY=true TBR=dpapad@chromium.org, scottchen@chromium.org, rbpotter@chromium.org Bug: 877109, 876990 Change-Id: I360d6766bffd48178894d9023fcc1758c0e7eba3 Reviewed-on: https://chromium-review.googlesource.com/1189683 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Alan Cutter authored
Currently it's not obvious how to remove a PWA on platforms other than Chrome OS. The user needs to navigate to chrome://apps, right click icon and pick "Remove from Chromium". This CL adds a hosted app menu option to uninstall the hosted app. Screenshots: Menu option: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354298&signed_aid=_QBTIue6dZ9AK09Q11Ppzw==&inline=1 Confirmation: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354299&signed_aid=XgFqjDNSIfIOnosVYz-B6w==&inline=1 Disabled option: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354300&signed_aid=GLxQI_0xEXHLyc8ZG3IKwA==&inline=1 Bug: 876560 Change-Id: Idc95eb5f8f48db5033cd61a944c7d172fe96842b Reviewed-on: https://chromium-review.googlesource.com/1184128 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#586178}
-
Yoshisato Yanagisawa authored
Bug: 874754 Change-Id: Id9ef555874ddf4977d11f47ae0ee6d168d536b1e Reviewed-on: https://chromium-review.googlesource.com/1188214 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#586177}
-
Noel Gordon authored
Comment only change, no change in behavior. Bug: 876267 Change-Id: Ia5d46aafb094ea8e01ba5ec40397742b4a2d0dc9 Reviewed-on: https://chromium-review.googlesource.com/1189243Reviewed-by:
-
Yue Li authored
Bug: 867919 Test: Local Compile Change-Id: Icf219704c8640b5112ed9c3b434643757fda4688 Reviewed-on: https://chromium-review.googlesource.com/1183947 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586175}
-
Jinsuk Kim authored
Java UserDataHost/UserData is modeled after native C++ SupportsUserData/Data class to allow users to attach random class/data to a 'host' class by key. Considering the limitation of Java disallowing multiple inheritance, UserData itself is designed as interface, and UserDataHost a final class that a host class defines as member variable. Host class Foo exposes UserDataHost so that the classes to be attached to Foo can be managed without Foo actually knowing about them. An object of FooBar can be retrieved from UserHostData of Foo by: public class Foo { // Defines the container. private final UserDataHost mUserDataHost = new UserDataHost(); public UserDataHost getUserDataHost() { return mUserDataHost; } } public class FooBar implements UserDataHost.UserData { public FooBar from(UserDataHost host) { FooBar foobar = host.getUserData(FooBar.class); // Instantiate FooBar upon the first access. return foobar != null ? foobar : host.setUserData(FooBar.class, new FooBar()); } } Foo foo = new Foo(); ... FooBar bar = FooBar.from(foo.getUserDataHost()); ... The design doc is here: https://goo.gl/2uWDja The method |destroy| is defined in Userdata interface to have the lifecycle entirely under control. Note that it is not *yet* possible to make it work for WebView. Change-Id: Iaae038a2b6577b07328917724c610c4efda9bb2e Reviewed-on: https://chromium-review.googlesource.com/1179507Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#586174}
-
Stuart Langley authored
Start changing various file system callback types to be once callback rather than the default repeating callback. They are only repeating callback because that was the previous default and this can introduce subtle and hard to find bugs that would be more obvious if the types were once callback. An example of this is crbug.com/875140. Bug: 875700 Change-Id: I3f37be3ca9f7622116db83fae287056203ff723e Reviewed-on: https://chromium-review.googlesource.com/1187859Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
- 26 Aug, 2018 17 commits
-
-
Darren Shen authored
When in laptop mode, we sometimes need to show the virtual keyboard ( e.g. from the IME tray menu). Currently we just temporarily enable the accessibility virtual keyboard in order to show the keyboard. However, this has two downsides: 1) It shows the accessibility keyboard, which has a different layout / size than the non-accessibility keyboard. 2) Sometimes, there are bugs where the accessibility keyboard is accidentaly enabled/disabled permanently. We add a new switch in keyboard_util to show the virtual keyboard. We then enable the switch when showing the VK in laptop mode. This solves both problems. Bug: 875096 Change-Id: I712fbe42dbeec99dfea4f1aeddbe1db0cc50ed45 Reviewed-on: https://chromium-review.googlesource.com/1186284 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#586172}
-
David Black authored
Previously, Assistant always handled ManagedWebContents navigation attempts by either handling a deep link, or launching a new browser tab. Now, we will do the following: 1. If the navigation URL is a recognized deep link, we always handle the navigation event ourselves. 2. If WebContents represents an Assistant card, we always handle navigation attempts by opening a new browser tab. 3. Otherwise we allow the WebContents to navigate freely. This allows us to support Assistant Settings which should be able to navigate freely within the Assistant container but still needs to support deep links. Bug: b:111705022 Change-Id: I4657a5601f38809ecb19ba96caac65f192e2debb Reviewed-on: https://chromium-review.googlesource.com/1176829 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#586171}
-
Travis Skare authored
BUG: 876426 Change-Id: I5045773f933d9920ac79a043adc7ac0f2d68257f Reviewed-on: https://chromium-review.googlesource.com/1173396 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#586170}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5729c94f9a7..420696961c8c git log b5729c94f9a7..420696961c8c --date=short --no-merges --format='%ad %ae %s' 2018-08-26 fmalita@chromium.org [skottie] Relax constant keyframe parsing Created with: gclient setdep -r src/third_party/skia@420696961c8c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ic2110bd5dece3037405b635321368815cd8711cf Reviewed-on: https://chromium-review.googlesource.com/1188806Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586169}
-
Haeun Kim authored
Use ContainsValue() instead of std::find() in chrome/browser Bug: 561800 Change-Id: I6c2af9884029644de51bbf19507edac55b8f57b9 Reviewed-on: https://chromium-review.googlesource.com/1188723 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586168}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/471a946cf126..b5729c94f9a7 git log 471a946cf126..b5729c94f9a7 --date=short --no-merges --format='%ad %ae %s' 2018-08-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@b5729c94f9a7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I106e8e100ae89da4358649cb9cfdc2e660724209 Reviewed-on: https://chromium-review.googlesource.com/1188805Reviewed-by:
-
Victor Costan authored
Passing smart pointes by reference / const reference is strongly discouraged by the Chromium C++ style guide and makes the ownership semantics unclear. Change-Id: I937d29c18fcb7213dda5df6e5a26941b8ef484e2 Reviewed-on: https://chromium-review.googlesource.com/1189173Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586166}
-
BUG=762641 TBR=derat@chromium.org Change-Id: I04a0960c2e99376f9367483647fb484b277ca4e9 Reviewed-on: https://chromium-review.googlesource.com/1189193Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586165}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89e0fadc..51e736ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe3f493b2607efd60b49dd69ded3f6494e403fb4 Reviewed-on: https://chromium-review.googlesource.com/1189544Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586164}
-
David Black authored
Previously, dismissing virtual keyboard with Assistant visible would leave it suspended mid-air. Bug: b:112846308 Change-Id: I2ce4e7da2495e6ba13059108e3982725a0a754db Reviewed-on: https://chromium-review.googlesource.com/1189447Reviewed-by:
-
David Black authored
When modifying view borders, we need to trigger a PreferredSizeChanged event because our preferred size may have indeed changed. When we don't do this, space may be robbed from other views during a layout pass to accomodate these borders. This manifested itself in some cases by stealing space from the UiElementContainerView which caused clipping of its content. Before: https://drive.google.com/open?id=1YkbyNdjtIMwa5fH8BclncCkhEiyCPzJZ Bug: b:112277188 Change-Id: Id223c7882f164ac44b989fb394170247ca9c045f Reviewed-on: https://chromium-review.googlesource.com/1188459Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I93647d276e2f99f832d11cdc1c6ed90abe27883c Reviewed-on: https://chromium-review.googlesource.com/1189207Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/305498942654..471a946cf126 git log 305498942654..471a946cf126 --date=short --no-merges --format='%ad %ae %s' 2018-08-26 fmalita@chromium.org [skottie] Make AnimationBuilder available for value parsing Created with: gclient setdep -r src/third_party/skia@471a946cf126 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Iee66ebdf510bc87691cbbc704fe64068e0b645b2 Reviewed-on: https://chromium-review.googlesource.com/1189036Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0093536e..89e0fadc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11fccb2163a3f3dbcef17377e2e71797621c041e Reviewed-on: https://chromium-review.googlesource.com/1189442Reviewed-by:
-
Alexei Filippov authored
The patch makes OOPHP use base::SamplingHeapProfiler in the sampling mode. BUG=876581 Change-Id: I179dbc9a40127a3fe9370c9ed0222ee45fc0556d Reviewed-on: https://chromium-review.googlesource.com/1184229 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586158}
-
Alexander Alekseev authored
Bug: 862853 Change-Id: I5277cc404c9829353e38614b1fa94223e52152c8 Reviewed-on: https://chromium-review.googlesource.com/1188426 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#586157}
-
Stefan Zager authored
BUG=874677 R=pdr@chromium.org Change-Id: I55cf0111906307211668dd6a1448787b7e971586 Reviewed-on: https://chromium-review.googlesource.com/1188586Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#586156}
-
- 25 Aug, 2018 9 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc09ed9d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23310 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I38e313b5edc66ad8b93a2f171b3f769263385bd6 Reviewed-on: https://chromium-review.googlesource.com/1189443 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586155}
-
Farah Charab authored
Test disabled on Linux due to flakiness. However, it wasn't linked to a relevant bug. Also, I run this for 2+ hours on a Linux workstation and I got no failures. So, I am landing this unit test again. Bug: 875170 Change-Id: Ic6719945d85c0d0e707aa809cbbb18d10ed9bfb3 Reviewed-on: https://chromium-review.googlesource.com/1188320 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586154}
-
Alexey Kozyatinskiy authored
V8 roll won't contatin hack that we used to calculate source position of EOS. This hack was introduced long time ago and is not needed now. TBR=dgozman@chromium.org Bug: v8/8092 Change-Id: I981fa08fb2bb9b9ecfb9a262571b0e07dce9ed07 Reviewed-on: https://chromium-review.googlesource.com/1188700Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#586153}
-
Wez authored
This reverts commit e0a83f96. Reason for revert: ContentTestSuiteBase is used as the base for both ContentTestSuite and ContentBrowserTestSuite, as well as for Chrome and extensions browser-test suites, so putting RegisterPathProvider() in the base class causes duplicate-registration errors in browser-tests. e.g see: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)/73970 Original change's description: > Move RegisterPathProvider() from ContentTestSuite to ContentTestSuiteBase > > Fixes network_service_content_browsertests RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler > failing to find the utility service process exe on Windows, like: > [FATAL:utility_process_host.cc(263)] Check failed: false. Unable to get utility process binary name. > > Bug: 876947 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ia7f51366e4b4db27ec8c3bbee3d57866c1bd67b9 > Reviewed-on: https://chromium-review.googlesource.com/1185628 > Commit-Queue: Matt Mueller <mattm@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586063} TBR=jam@chromium.org,mattm@chromium.org Change-Id: I649f105c58d9643dd4cab5aa685b3c6e4556097e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876947 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1189444Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586152}
-
Wez authored
The test assumes specific values of DummyRefCounted::ref_invokes_count_ without re-setting it to zero at the start of the test. TBR: haraken Change-Id: I265fad41cbfa5b8692a7f620d4fa253736d32c74 Reviewed-on: https://chromium-review.googlesource.com/1188701Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I9069bc96da6719441fb0ef627f55cd9fa073dcdf Reviewed-on: https://chromium-review.googlesource.com/1188699Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586150}
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: chromium:646849 Change-Id: I8141bcdcfef7d9734ee9f1c97bfa552160fdcd9d Reviewed-on: https://chromium-review.googlesource.com/1182865 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#586149}
-
Alexey Kozyatinskiy authored
Blackbox manager may update location that we show for console message when top frame is blackboxed / unblackboxed. R=luoe@chromium.org Bug: chromium:873789 Change-Id: I8500d07877dfa6f08b57ccfb7236ad44e124137a Reviewed-on: https://chromium-review.googlesource.com/1183682Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f582e98..0093536e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a2091733637a84c9ebba2ba05698ba6d2fe084a Reviewed-on: https://chromium-review.googlesource.com/1188693Reviewed-by:
-
