GitLab

R=sky@chromium.org

Bug: 667892
Change-Id: Ia354d4cc615983d0ac6650a98a70903484e5ecb8
Reviewed-on: https://chromium-review.googlesource.com/657807
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501424}

94c367a Exclude UTF-16 encoding for automatic detection

BUG=630113
Test=gclient sync, make
TBR=brettw@chromium.org

Change-Id: I8457204afbeb489a8259bda34314b1dca30135fe
Reviewed-on: https://chromium-review.googlesource.com/662082Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501423}

Previously MessageLoopHelper was starting a periodic timer that quits 
a run loop. It kept that timer running even after
WaitUntilCacheIoFinished() returns and used QuitCurrentWhenIdleDeprecated().
As result MessageLoopHelper::TimerExpired() would sometimes quit a RunLoop
that's not owned by MessageLoopHelper. This made DiskCache*AsyncIO* tests
flaky on Fuchsia. This change fixes both problems: the timer is stopped
after WaitUntilCacheIoFinished() returns and TimerExpired() uses
RunLoop::Quit(), so it won't quit a wrong RunLoop.

Bug: 731302
Change-Id: Ie7f7444c7f1bb662c1de511cae3de0a9efc46349
Reviewed-on: https://chromium-review.googlesource.com/661357Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501422}

This will be used to work around Android Bluetooth bugs.

Bug: 764386, 672263
Change-Id: I0e13a94c50c9c91e9f6957917f595ed30a76b7d1
Reviewed-on: https://chromium-review.googlesource.com/663206Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501421}

Bug: 734230
Change-Id: I721e6db444b685f56d4cc884995cba3cbddf84ba
Reviewed-on: https://chromium-review.googlesource.com/663844
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501420}

This patch fixes not to break before <br> tag, preserved newline and
tabulation characters.

The break-before-space behavior of LazyLineBreakIterator is designed
for strings before whitespace collapsing. Since LayoutNG uses it after
whitespace collapsing was processed, it needs to follow normal break-
after-space behavior for newline and tabulation characters.

This patch adds the 3rd mode, break-before-space for whtiespace
collapsed strings.

Tried to switch to break-after-space mode completely in LayoutNG, but
there are some more work to do the switch, and its performance
implication isn't well understood yet.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib85bbc7aa8fe8528c6673cf1c30042f36239c481
Reviewed-on: https://chromium-review.googlesource.com/657750Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501419}

There are several steps of the Bluetooth connection flow which call into
Bluetooth APIs and wait for an asynchronous response. These asynchronous
callbacks *should* be getting invoked in a timely manner by Bluetooth,
but this is not happening in practice. This CL adds timeouts for each
step of the connection process in which we wait for an asynchronous
reply.

Bug: 763176, 672263
Change-Id: Ia7a538e0de8280346a3c113c7dccd5c18cc7086d
Reviewed-on: https://chromium-review.googlesource.com/657811
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501418}

Chrome is unconditionally installed in "Program Files (x86)".

BUG=763606

Change-Id: I5c4d81c34a166f61969e0698536636e5bcb6bbf9
Reviewed-on: https://chromium-review.googlesource.com/663257
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501417}

This reverts commit d5840e2a.

Reason for revert: CrOS eve is slow to update because eve-release builder hasn't got green for a week, and haven't got the Harfbuzz update yet.

Revert this for now, we'll reland when CrOS is updated. Tracking in crbug.com/763981

Original change's description:
> Implement safe-to-break for ShapingLineBreaker
> 
> Compute offsets where line breaks may occur without requiring re-shaping
> of the two sides by checking the HarfBuzz UNSAFE_TO_BREAK flag and store
> all such suitable offsets in the new safe_to_break vector on the RunInfo
> struct for each run in a ShapeResult.
> 
> This allows for faster and higher quality line breaking as only suitable
> breaking positions are considered candidates for line breaking if at all
> possible. Only re-shapes if a line has no suitable safe-to-break offset.
> 
> Change-Id: Iaa43079152e3c9b42662877f9821c5c125f7bafe
> Reviewed-on: https://chromium-review.googlesource.com/614766
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500741}

TBR=eae@chromium.org,kojii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 763981
Change-Id: I0e2ccb3c0ffa469fcda59e56d42b0606fbed8b15
Reviewed-on: https://chromium-review.googlesource.com/663917
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501416}

Bug: 760412
Change-Id: I636562f761b0574369b40b64c0e9f180a1eed1e5
Reviewed-on: https://chromium-review.googlesource.com/663675Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501415}

https://boringssl.googlesource.com/boringssl/+log/e3bb51cb2360fca5b87d559fc263b2763bd14739..683ffbbe57de2163b24993e0d03650cf393bc640

BUG=none

Change-Id: I8ad8c7d3a0731e15beba733092a914ae73b75d15
Reviewed-on: https://chromium-review.googlesource.com/664098
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501414}

https://chromium.googlesource.com/angle/angle.git/+log/9d81537..9df395c

BUG=762377,chromium:764036

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ifb7bc5b6ea8c4a1495e17269e23ed74d3e36d705
Reviewed-on: https://chromium-review.googlesource.com/664078Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501413}

This reverts commit 3b6c1aa7.

Reason for revert: SUMMARY: AddressSanitizer: heap-use-after-free chromeos/network/network_state.h:56:33 in visible

Original change's description:
> NetworkStateHandler: Add EnsureCellularNetwork
> 
> This CL provide support for Cellular devices with no service:
> * Cellular networks all use the same specifier so that the guid
>   remains consistent (we only support one Cellular Service)
> * Assume a SIM may be present unless Cellular.NetworkTechnology
>   is CDMA so that the SIM UI shows up even if NetworkTechnology
>   is unset (e.g. because there is no Service).
> * Create a dummy Cellular NetworkState when none exists so that
>   Cellular Device properties are translated and passed to the UI.
>   This also allows Cellular network UI to be shown so that
>   Device properties can be viewed and SIM and FoundNetworks may
>   be selected.
> 
> Bug: 717063
> Change-Id: I1e23e7ba48821124ad219bb67fea2ca86e2d6ccd
> Reviewed-on: https://chromium-review.googlesource.com/653723
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Ben Chan <benchan@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501337}

TBR=stevenjb@chromium.org,benchan@chromium.org,khorimoto@chromium.org

Change-Id: I073a95d8160812923cbcc192f0afe934db672a40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717063
Reviewed-on: https://chromium-review.googlesource.com/662958Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501412}

Process for this was to look at the bot currently running
blink_perf.owp_storage, and see if the bot had time. This is fairly
manual right now; in the future we'll make this much more automated.

Bug: 762468
Change-Id: I259a72919f113e99cf0dea8f3881059401271f79
Reviewed-on: https://chromium-review.googlesource.com/663837Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501411}

Currently we mark targets as 'other' based on WebContents being present
in TabStripModel, which is timing-dependent. This patch marks everything
not quialified for other types as 'page', making target type consistent.

Bug: 759783
Change-Id: I0b26ee12474b004121e3e0083d67eb809b4eba11
Reviewed-on: https://chromium-review.googlesource.com/639024Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501410}

Bug=713655

Change-Id: I0f5d91caf5568bfd2048c4895b45c9ab58067380
Reviewed-on: https://chromium-review.googlesource.com/651549
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501409}

Add a feature flag ("OverflowIconsForMediaControls") to
hide/show icons on the overflow menu displayed on the
native media controls.

BUG=763301

Change-Id: I719e46b690ca52d5bfdd3619c18cbd1f1d9ebd2b
Reviewed-on: https://chromium-review.googlesource.com/659917Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501408}

cert_verify_proc_builtin.cc, cert_verify_proc_android.cc, cert_issuer_source_aia.cc

Bug: 
Change-Id: I94988d1de99cb8395701b4ce50c302cb504a51d3
Reviewed-on: https://chromium-review.googlesource.com/662157Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501407}

Revert changes to gl_tests that worked around the missing default
framebuffer.

BUG=665521

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d7f69790eba8a8a13c240708e3143b726c7e05c
Reviewed-on: https://chromium-review.googlesource.com/639193Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501406}

This CL removes SDCH code from src/chrome/.

This CL is one of the CLs to remove SDCH from Chromium.

SDCH has been disabled in Chrome since M59. For more details please see
Issue 690070 and blink-dev@ thread linked below.

Bug: 762686
Change-Id: If9dbf8ce17aa026f9b0f2ce631669756f4be1e28
Reviewed-on: https://chromium-review.googlesource.com/663621
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501405}

In my previous attempt to fix Japanese keyboard behavior
(https://chromium-review.googlesource.com/636107),
I was finishing composition text *after* restoring deleted text.
This works on most Japanese keyboards, but Google Japanese keyboard
behaves weirdly, as it calls setComposingText([text], 1) again which
moves the cursor position.

This can be fixed by finishing composition first, and then restoring
text.

BUG=758443

Change-Id: I1f3f4b64e1fa6aa6bdec198f4693be919e50681e
Reviewed-on: https://chromium-review.googlesource.com/663202Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501404}

UDPSocketTest.PartialRecv depends on MSG_TRUNC, which wasn't supported
in older versions of SDK. The test needs to be disabled temporarily
because the recent SDK roll had to be reverted.

TBR=scottmg@chromium.org
NOTRY=true

Bug: 731302
Change-Id: I5b4ec03ccabb60d1719ce2088831183a8a54c045
Reviewed-on: https://chromium-review.googlesource.com/662881
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501403}

This patch removes the gaming seat implementation for evdev. All the
gamepad support will use ozone implementation.

This patch also removes the dummy interface for gaming_input_v1 in Wayland
server. The dummy interface was there to make sure the system is robust
when we moved the protocol to v2.

Bug: 717246
Change-Id: I70b29d3c6a81761d1e15c502f78fd0615bf768fe
Reviewed-on: https://chromium-review.googlesource.com/661100
Commit-Queue: Jingkui Wang <jkwang@google.com>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501402}

from AwSettings.

Change-Id: Id4092f3588713e76419c87afa5dabec0168e5bd5
Reviewed-on: https://chromium-review.googlesource.com/651748
Commit-Queue: Alex Chu <alexchu@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501401}

This reverts commit 4de6f139.

Reason for revert: net_unittests failures

Original change's description:
> Roll Fuchsia SDK to d7db7f4e971de73ccec78eaf6c34a0f424e8831f
> 
> Following issues are fixed in this version:
> 1. NET-170: MSG_TRUNC support in recvmsg().
> 2. NET-120: asynchronous connect().
> 
> NOTRY=true
> 
> Bug: 731302, 707030
> Change-Id: I74047a9d86fe4bce6c384658676903b115ed437a
> Reviewed-on: https://chromium-review.googlesource.com/661298
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501096}

TBR=sergeyu@chromium.org,scottmg@chromium.org

Change-Id: I30e9140ea3d7a1119a234e74828d527b9214c782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731302, 707030
Reviewed-on: https://chromium-review.googlesource.com/663498Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501400}

This is a reland of 54a27d88
Original change's description:
> Switch RPM packager to use new dependency system
> 
> BUG=758654
> R=thestig@chromium.org
> 
> Change-Id: Ib64eb4ace73d7803b083f4d40795193dedc288f7
> Reviewed-on: https://chromium-review.googlesource.com/655943
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501104}

Bug: 758654
Change-Id: I120e58c8535e86b1504422af3847cdc899e3110a
Reviewed-on: https://chromium-review.googlesource.com/663567Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501399}

For go/mustash chrome browser code cannot call directly into ash.
ash/wm/window_util.h is one of the most common ash headers used in chrome,
so eliminate some usage.

Replace ash::wm::Foo() calls with their core wm::Foo() equivalents where
the windows are clearly browser windows or browser-owned windows (like
platform apps).

Convert GetActiveWindow() usage to IsActiveWindow() where the activation
client is not known.

Fix DEPS to ban this header.

Bug: 678705, 756085
Test: browser_tests, unit_tests, manually switch multiprofile users with multiple browser windows open

Change-Id: Ifde5f1119b4818a7bde58dcdd3eafaef187ace71
Reviewed-on: https://chromium-review.googlesource.com/661793
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501398}

This ensures that there is no possibility for pending network connection
or disconnection requests when shutdown occurs. Leaving these pending
could leave the network stack in a bad state.

The original CL landed as [1] and was reverted as [2] due to an ASAN bot
failure. I've uploaded the original CL as patch 1 on this CL, and my fix
as patch 2.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/656570
[2] https://chromium-review.googlesource.com/c/chromium/src/+/659377

Bug: 761541, 672263
Change-Id: I3e9beb0ad62fb92ca202f391229dbc46c9110b18
Reviewed-on: https://chromium-review.googlesource.com/663673Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501397}

In the WebAPKs' dialog, there are 12dp padding between the title and the
content. Currently, these padding are added as the top padding of the
content, leaving no padding below the title. It looks fine on L+, but looks
tight on pre-L which has a blue line between the title and the content.
In this CL, we split the padding as 6dp above the blue line, and 6dp
under the blue line.

Before:
https://drive.google.com/open?id=0B7zEF5GgyYmpLU9SendyX00zZlk

After:
https://drive.google.com/open?id=0B7zEF5GgyYmpTEVBUnB6UXhaMDg

Bug: 759582
Change-Id: Iabc96357fb0741889751d2c59ba35c829e6b6863
Reviewed-on: https://chromium-review.googlesource.com/663614Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501396}

bindings: generate_conditional_features.py and generate_init_partial_interfaces.py should support snake_case generated files.

Bug: 760462
Change-Id: I328d61432cbfb74e2490831543632f779940368a
Reviewed-on: https://chromium-review.googlesource.com/662502
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501395}

This CL expands the usage of cr-link-row into settings. This doesn't
replace all instances of link rows. It's a sampling of a few different
cases. Changes UI for: device display overscan, customize fonts,
passwords and forms links.

Bug: 757663, 763177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id63d8b8c5a6c3c36e6804018ea66d8d03679f1ad
Reviewed-on: https://chromium-review.googlesource.com/656527Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501394}

https://skia.googlesource.com/skia.git/+log/79a1256c2233..a640c49b7ecf

$ git log 79a1256c2..a640c49b7 --date=short --no-merges --format='%ad %ae %s'
2017-09-11 csmartdalton Minor cleanups for CCPR
2017-09-12 rmistry Fix behavior of automatically adding 'Cq-Include-Trybots' in presubmit
2017-09-12 rmistry Add checks for 'DO NOT''SUBMIT' in description and file content
2017-08-25 wangxianzhu Optimize filterBounds() of SkArithmeticImageFilter/SkXfermodeImageFilter

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I7ccba3de4e805caa2fe6bf54d44bd807bafe2b1a
Reviewed-on: https://chromium-review.googlesource.com/664060Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501393}

Usage:
"--enable-features=EnableCastDiscovery,EnableCastChannelRetry<MyStudyName
 --force-fieldtrials=MyStudyName/Group1 
 --force-fieldtrial-params=
    MyStudyName.Group1:initial_delay_ms/20000/max_retry_attempts/20/exponential/3.0"

- Added a finch feature "EnableCastChannelRetry" and made retry strategy parameters configurable
- Added CastMediaSinkServiceImpl::InitRetryParameters to parse feature parameters

Bug: 752310
Change-Id: I13d4c3eb8d27de32bbe08fe62a8d4f3cd096776d
Reviewed-on: https://chromium-review.googlesource.com/639671
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501392}

A few times, I've seen the a download complete exceptionally quickly and
leave the filename positioned as if there's status text, but there
isn't. I can't reproduce it consistently, but one possibility is that
`statusTextView_.hidden` is a bad signal for whether the layout needs to
change (it can be hidden for other reasons, like a dangerous download).

This change stops using `hidden` to decide whether to change states,
which is an improvement either way.

Bug: 589943
Change-Id: I491c06f57860315068fa719f046032353cb2db1e
Reviewed-on: https://chromium-review.googlesource.com/664137Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501391}

This CL adds an assertion to make sure that the user specified profile
data file exists.

Bug: 763962
Change-Id: I2a8830ad8fc7ca1a5f91e739ba3107ac70e3a2eb
Reviewed-on: https://chromium-review.googlesource.com/662237
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501390}

This change introduces the concept of 'state change reason' to the
bottom sheet. Once setSheetState is called with a reason, that
reason persists through all the events until the sheet reaches its
final state or setSheetState is called again. This change allows
users of the API to make more nuanced decisions based on what
caused the bottom sheet to, for example, open.

The first change to use this API is the placeholder content in the
content controller. If the sheet is opened because of the omnibox
focusing, the placeholder will be shown instead of suggestions.
Previously this was done by immediately replacing the suggestions
content when the omnibox gained focus.

BUG=764391

Change-Id: I4fb129037b9fc8981ad5793fff5589524300b5a2
Reviewed-on: https://chromium-review.googlesource.com/656078
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501389}

https://pdfium.googlesource.com/pdfium.git/+log/4588792ebfcf..8ac74971a335

$ git log 4588792eb..8ac74971a --date=short --no-merges --format='%ad %ae %s'
2017-09-12 rharrison Remove ASSERT that was added to understand what was occuring

Created with:
  roll-dep src/third_party/pdfium
BUG=763369


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ia6cc6d39429b22eebd3b830226173c444609deef
Reviewed-on: https://chromium-review.googlesource.com/663604
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501388}

Bug: 764382
Change-Id: Ife477677e89c55257ba0cf537dedb0000e8c7d54
Reviewed-on: https://chromium-review.googlesource.com/663559
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501387}

BUG=None

Change-Id: If8af3d78990904f6b934f54bc853ed690e0a1eeb
Reviewed-on: https://chromium-review.googlesource.com/660718Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501386}

This CL should not change behavior. We could probably remove the param
from WebContentsDelegate::AddWebContents but some delegates actually
set it, so the change would be more complicated and could change
behavior.

Bug: None
Change-Id: I2b25c7ae4fb86c2aad386697832bb5017ea7744f
Reviewed-on: https://chromium-review.googlesource.com/655126Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501385}