GitLab

This CL makes a few changes in the direction of removing dependencies
on ErrorCode by pushing them up a layer:

- Trap now simply uses TrapKeys directly to store trap function and
metadata instead of needlessly encoding them as ErrorCode.

- MakeTrap returns a bare trap ID and it's instead the caller's
responsibility to encode in an ErrorCode if needed, which is now
handled by ErrorCode's trap constructor.

- Also, ErrorCodeFromTrapId() is replaced by IsSafeTrapId() to answer
the one question that SandboxBPF was interested in knowing about
existing traps.

- Change a few SandboxBPF trap-constructing functions into static
functions since they don't depend on any SandboxBPF instance member
variables.

BUG=414363

Review URL: https://codereview.chromium.org/572753002

Cr-Commit-Position: refs/heads/master@{#295121}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/576503002

Cr-Commit-Position: refs/heads/master@{#295120}

Implements an OutputSurface that uses render-to-texture and overlays
to display the main surface. Buffering of frames is implemented
internally as there is no system-provided surface.

BUG=380861

Review URL: https://codereview.chromium.org/516663003

Cr-Commit-Position: refs/heads/master@{#295119}

Review URL: https://codereview.chromium.org/576823002

Cr-Commit-Position: refs/heads/master@{#295118}

BUG=352290

Review URL: https://codereview.chromium.org/573843002

Cr-Commit-Position: refs/heads/master@{#295117}

I came across this while investigating slowness. Without this we would
end up unnecessarily toggling visibility a couple of times. While not
the end of the world, toggling visibility for the bookmarkbar can take
a while (mostly because it can end up containing a ton of views).

BUG=none
TEST=covered by test now
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/573893003

Cr-Commit-Position: refs/heads/master@{#295116}

BUG=414066
TEST=none

Review URL: https://codereview.chromium.org/557363004

Cr-Commit-Position: refs/heads/master@{#295115}

BUG=none
R= mkearney@chromium.org, smain@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/511963004

Cr-Commit-Position: refs/heads/master@{#295114}

This removes the last known dependency on guava_javalib.

Full list of changes:

r340 Removing guava dependency for the invalidation client (part of an effort to reduce method count in Android applications)
r341 Fixing package name in AndroidListenerManifest.xml and ordering factory methods by corresponding proto field in AndroidService.java

BUG=412673
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/573733004

Cr-Commit-Position: refs/heads/master@{#295113}

BUG=414725

Review URL: https://codereview.chromium.org/577643003

Cr-Commit-Position: refs/heads/master@{#295112}

Refactor the RendererFreezer class so that untestable code is moved into
a delegate and add unit tests.  Modify FakePowerManagerClient so that it
provides more information for tests.

Also use a CancelableClosure for the asynchronous suspend readiness
callback in case we get a SuspendDone before we've had a chance to run
OnReadyForSuspend().

BUG=364339,414396
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/543303002

Cr-Commit-Position: refs/heads/master@{#295111}

BUG=414408

Review URL: https://codereview.chromium.org/562203006

Cr-Commit-Position: refs/heads/master@{#295110}

We should not call PlayerGone only for MSE case, we should call it for all cases.

BUG=414066

Review URL: https://codereview.chromium.org/576813002

Cr-Commit-Position: refs/heads/master@{#295109}

Fix a bug where reording actions in the browser action overflow container can
cause them all to become visible.

BUG=414177

Review URL: https://codereview.chromium.org/570403002

Cr-Commit-Position: refs/heads/master@{#295108}

We now always abort invalid loads. According to UMA, they don't happen
anymore, so this should only affect future bugs.

Also, move the UMA reporting to the right thread.

BUG=none
R=mmenke@chromium.org,mef@chromium.org,nasko@chromium.org

Review URL: https://codereview.chromium.org/572273002

Cr-Commit-Position: refs/heads/master@{#295107}

SpdyNetworkTransactionSpdy*Test has been removed in https://crrev.com/16816010.
SpdyHttpStreamSpdy*Test has been removed in https://crrev.com/17004007.  These
two exclusions are now obsolete.

BUG=118883
NOTRY=true

Review URL: https://codereview.chromium.org/579463002

Cr-Commit-Position: refs/heads/master@{#295106}

These histograms are no longer being monitored, so removing them from Chromium.

 - Net.DhcpWpad*
 - Net.MTPR_*
 - Net.ProxyResolver*
 - Net.ProxyPollConfigurationTime [1]
 - Net.GetProxyForURL*:  [1]

[1] Removed from histograms.xml; the histogram is not present in the code.

Review URL: https://codereview.chromium.org/573893004

Cr-Commit-Position: refs/heads/master@{#295105}

as it provides a loophole around const.

I've removed const from platform_canvas() and sk_canvas(), if
anyone tries to access these from a const instance of Canvas, it
won't compile.

Review URL: https://codereview.chromium.org/560463004

Cr-Commit-Position: refs/heads/master@{#295104}

Make PasswordSyncableServiceTest.* more readable. Add -Wexit-time-destructors warning for the password manager.

Review URL: https://codereview.chromium.org/562833003

Cr-Commit-Position: refs/heads/master@{#295103}

The visibility check was checking the origin of deps[i] instead of
datadeps[i].

Review URL: https://codereview.chromium.org/551843006

Cr-Commit-Position: refs/heads/master@{#295102}

https://chromium.googlesource.com/chromium/blink/+log/8cc576a35676fa4829ee37d9d40e791354e16df1..435acf076b2d5f0243b4a87c5d5ef904ae59bed3
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/572333002

Cr-Commit-Position: refs/heads/master@{#295101}

https://skia.googlesource.com/skia/+log/8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e..a32f1758b7ebd889eecfdc67c935e7edcedc5be3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/574643005

Cr-Commit-Position: refs/heads/master@{#295100}

This updates Chromium's clang version to r216630 with
r216684 cherry-picked to fix an ASan issue.

It also changes the build script for Clang to use CMake
instead of Autoconf. The ASan team say this configuration
is better tested, and it also makes us consistent with
the Windows Clang build which already uses CMake.

BUG=400849
R=thakis@chromium.org
TBR=brettw

Review URL: https://codereview.chromium.org/578623002

Cr-Commit-Position: refs/heads/master@{#295099}

R=agl@chromium.org

Review URL: https://codereview.chromium.org/574033004

Cr-Commit-Position: refs/heads/master@{#295098}

Provide a method to reset the device color profile for tests, and
make TestRunner call it prior to each layout test.

This to reset the Page color profile to its default state, to let
Page choose the default color profile, rather than TestRunner.

BUG=369787,368663

Review URL: https://codereview.chromium.org/561453004

Cr-Commit-Position: refs/heads/master@{#295097}

This contains an ancient version of gold, which has not been
updated since 2012. Back in times the NDK didn't provide a 64-bit
version of the linker for Android.
This seems to be unused today. It's cleanup time.

BUG=

Review URL: https://codereview.chromium.org/572233003

Cr-Commit-Position: refs/heads/master@{#295096}

the path to the canvas instead of using the canvas's built in round rect
function. Changing these to the canvas round rect could allow skia to
optimize their drawing.

This change switches the status bubble to the canvas round rect.

Review URL: https://codereview.chromium.org/568343002

Cr-Commit-Position: refs/heads/master@{#295095}

Configure Breakpad to run in-process on Yosemite by setting the
BREAKPAD_IN_PROCESS option.

Roll breakpad r1359 -> r1375.

r1375 Mac: Add support for in-process crash reporting to Breakpad.
r1374 This CL initialize NSData in HTTPMultipartUpload.m to nil.
r1373 Update processor.gyp file with new files added as part of microdump
r1372 Introduce stub microdump processor classes.
r1371 Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.
r1370 Extract DumpContext base class from MinidumpContext
r1369 Back out trunk r1367.
r1368 Adding possibility for client to upload the file
r1367 Support for multiple upload files in CrashReportSender/HTTPUpload
r1366 constructor init list in wrong order in CrashGenerationServer
r1365 update svn:ignore
r1364 make "make install" also install headers and pkgconfig files
r1363 Set 32 bits iOS app to use vm_region_recurse_64.
r1362 update svn:ignore lists
r1361 Update lss from r24 to r31.
r1360 upload_system_symbols: Use the Go1.3 improvements to debug/macho.

BUG=414239

Review URL: https://codereview.chromium.org/571663002

Cr-Commit-Position: refs/heads/master@{#295094}

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/571373002

Cr-Commit-Position: refs/heads/master@{#295093}

Blink now has methods that don't take the rect out-param so use those.
Then we can delete the old methods with the out-param in blink.

R=vmpstr
BUG=413479

Review URL: https://codereview.chromium.org/572873005

Cr-Commit-Position: refs/heads/master@{#295092}

For apps v1, authentication involves navigating away from the app and
then back again, so loading browser_test.js before authentication doesn't
work. I don't know why this is a recent regression though--AFAICT it should
have been failing from day 1.

BUG=414498

Review URL: https://codereview.chromium.org/571273002

Cr-Commit-Position: refs/heads/master@{#295091}

Blink CL https://codereview.chromium.org/559423002/ depends on this.

BUG=406094

Review URL: https://codereview.chromium.org/564423002

Cr-Commit-Position: refs/heads/master@{#295090}

NESTABLE_ASYNC APIs
(https://codereview.chromium.org/536503002/) to log NetLog
entries in Tracing. This CL is a part of the effort to get
NetLog data into Tracing.

Design Doc:
https://docs.google.com/document/d/1Z2uqj59UEts5IiXX78mkdU4kd6e7kE3JUKPoDK97bVs/edit?usp=sharing

BUG=399701

Review URL: https://codereview.chromium.org/468083004

Cr-Commit-Position: refs/heads/master@{#295089}

While installing on non-ubuntu systems, the shell script,
build/install-build-deps.sh has an option '--unsupported' to override
the system checks. The same is not applied while installing the android
deps. The parameters to install-build-deps-android.sh should be passed
on to install-build-deps.sh.

R=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/578503002

Cr-Commit-Position: refs/heads/master@{#295088}

This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.

* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
  src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.

FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).

BUG=397165
TEST=unit_tests, extensions_unittests

Review URL: https://codereview.chromium.org/572813002

Cr-Commit-Position: refs/heads/master@{#295087}

BUG=411260

Review URL: https://codereview.chromium.org/578593002

Cr-Commit-Position: refs/heads/master@{#295086}

This can be used from the renderer process or the browser
process. Requesting the manifest can be done via one call, a
callback has to be passed and will run with the manifest
passed as parameter. A failure will return the empty
manifest.

Some more logic could be added like caching the manifest in
the browser process or keeping track of the manifest dirty
state in the browser process but those things can be added
transparently later.

BUG=366145

Review URL: https://codereview.chromium.org/537053002

Cr-Commit-Position: refs/heads/master@{#295085}

Changing in the intialization order of WeakPtrFactory in src/components module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/573623002

Cr-Commit-Position: refs/heads/master@{#295084}

Partial revert of android_webview: stop using system ICU. (patchset #1 id:1 of https://codereview.chromium.org/541753002/)

Reason for revert:
We can't accept this size increase at present; revert until we've worked out what to do about it.

Original issue's description:
> android_webview: stop using system ICU.
>
> To support unbundled updates we need to stop depending on system
> libraries. Disable using the system version of ICU and instead link
> Chromium's copy.
>
> This increases binary size by ~7MB.
>
> BUG=409851
>
> Committed: https://crrev.com/48e43572c0bfef2b1434d7f330da86cc7770b592
> Cr-Commit-Position: refs/heads/master@{#293510}

BUG=409851

Review URL: https://codereview.chromium.org/570383002

Cr-Commit-Position: refs/heads/master@{#295083}

BUG=none
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/574023002

Cr-Commit-Position: refs/heads/master@{#295082}