- 20 Mar, 2020 40 commits
-
-
Wei Lee authored
Bug: 980846 Test: Manually tested Change-Id: Icbc8788df1c58b90f7676e6de365899d6e07d943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064231Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751942}
-
Yuly Novikov authored
Speculative fix for flaky timeouts. Per http://anglebug.com/4396, SwiftShader backend causes TLS descriptor leak. Reducing the batch size stops running the tests before the OS limit on TLS descriptor number is reached. Side-effect: --test-launcher-retry-limit=0 and --test-launcher-batch-limit=256 apply now not only to desktop, but to Android as well. Thus, using 256 as the batch limit, which is the default on Android, in order to not introduce a regression there. TBR=kbr Bug: 1062692 Change-Id: I7aee19ef3765bf3cfe65417c0bf039bc59e9f6a1 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110397 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751941}
-
arthursonzogni authored
The bug has been fixed, the instrumentation is no longer useful. R=clamy@chromium.org,mkwst@chromium.org Bug: 1037776 Change-Id: I3f36b1de3f9b02ffb3f10d4943ebe18950325c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108735 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#751940}
-
Tim Song authored
BUG=1050966 Change-Id: I45aa288e721760fee374e97d38116dd53dec9d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109455Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#751939}
-
Robert Woods authored
In Linux, an association between an app and a particular file is made on the basis of the file's MIME type. Where an app supports handling MIME types that aren't known to the OS, those types must be registered calling `xdg-mime` [1] on an XML file containing a mapping of MIME types to file extensions per the freedesktop.org Shared MIME-info Database specification [2]. This CL implements methods for generating a compliant XML file from a set of file handlers, writing it to a temp file, and calling `xdg-mime` on that file to register the new MIME types. These are invoked as part of the web app install process on Linux. [1] https://linux.die.net/man/1/xdg-mime [2] https://freedesktop.org/standards/shared-mime-info Bug: 938103 Change-Id: If7e4cb0063e1688cb69d2b2b503235658c087366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101398 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#751938}
-
Daniel Cheng authored
This is a reland of 9e64c392 Original change's description: > Set a limit on how shared memory can be mapped in one process. > > Allowing arbitrary amounts of shared memory to be mapped can make it > easier for an attacker to bypass ASLR as documented in > https://googleprojectzero.blogspot.com/2019/04/virtually-unlimited-memory-escaping.html > > Bug: 1056572 > Change-Id: I812542e2b3d9e7842a7ae54bdd837fa956a99177 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083447 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750211} Bug: 1056572 Change-Id: Ie7bc186a4a5f134a3b30104913602cce372fe84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106334Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751937}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af23eb1122f2..566d53f9a533 git log af23eb1122f2..566d53f9a533 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@566d53f9a533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e4bd0302e5078e672db91bf30d4bb6d06988978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751936}
-
Bang Lee authored
Change-Id: I8d8c40d85abd6b24f5d255d0707029cee7767616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108402 Auto-Submit: Bang Lee <banl@microsoft.com> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#751935}
-
Christopher Lam authored
gogoy@ has indicated that non-refresh Google colors are no longer to be used for Chrome OS. As such, remove them from the palette, and OS Settings. Also, add a PRESUBMIT to prevent them from getting added back to OS Settings. Bug: 1062154 Change-Id: I73465f867b5916bdd234a2a7c292038cd805f2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100556Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#751934}
-
Christopher Lam authored
This CL makes the Files App dialog buttons lower case which is in line with the rest of Chrome OS. Bug: 1060060 Change-Id: Iac267363d17d7c308c2bc965214c90970c98d13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102940 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751933}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ife002cfd8ff254f87e8b6d1c6a1b4cda5c22aa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112132Reviewed-by:
-
Nicolas Arciniega authored
Extracting the interface allows for alternate proxy resolution implementations. For example, the ConfiguredProxyResolutionService relies on fetched proxy configs to make a decision while a future implementation (to be implemented later in crbug.com/1032820) will rely entirely on the system to make proxy decisions. Bug: 1032820 Change-Id: If43f293b5e53ad0ca5727dd72dbd6d8e6cc75537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065412 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#751931}
-
Christopher Cameron authored
With this in place, we can call AppShimRegistry from BookmarkAppShortcutManager instead of AppShortcutManager. Note that some tests are built around extensions, and will need to be substantially modified. Those are moved to platform_apps, because the new bookmark-based versions will continue to exist alongside the old extensions-based versions. R=loyso TBR=avi (chrome/) Bug: 1057195 Change-Id: I4784eedcb270fb679e12375d3a729107ada37f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109272 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#751930}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/27622ce1c54f..7c24b6b2ff19 git log 27622ce1c54f..7c24b6b2ff19 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 jiawei.shao@intel.com Revert "Check bind group layout with storage texture in pipeline descriptors" 2020-03-20 jiawei.shao@intel.com Check bind group layout with storage texture in pipeline descriptors Created with: gclient setdep -r src/third_party/dawn@7c24b6b2ff19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic2ba03ee8af51d6df4768905e459aa75c38124ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111788Reviewed-by:
-
Alex Danilo authored
Adds a hover background color for the action-icon buttons and tasks button for files-ng. Bug: 1061819 Change-Id: Ib21df907ce8033932608443e2f9a36203ea76f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111655Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1eb44bf8f33..ca45852d0907 git log b1eb44bf8f33..ca45852d0907 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 ynovikov@chromium.org Skip flaky TransformFeedbackTest.MultiContext on Win Intel Vulkan Created with: gclient setdep -r src/third_party/angle@ca45852d0907 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I7e6d6b408472390cc29acc10056b5f884d9f0f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111785Reviewed-by:
-
Julie Jeongeun Kim authored
This CL returns -1 for the index in parent when BrowserAccessibility doesn't have a platform parent to update the index from platform implementations since when it is a root node of WebContent, |unignored_index_in_parent_| is not updated. Bug: 1046636 Change-Id: I3b283fff46b48836e22b11fdd84aaf3d75f0fdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087234 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#751926}
-
Istiaque Ahmed authored
Worker can legitimately fail to start, this CL clears worker's PendingTasks when that happens. In addition to this, this CL makes ServiceWorkerTaskQueue factory dependent on ProcessManager factory as pending tasks can call out to ProcessManager (courtesy of https://crbug.com/1019161#c16) upon ServiceWorkerTaskQueue's destruction. This CL adds a test for this ensuring a worker's pending_tasks_ is cleared when start worker failure is seen. The test rejects a service worker's install event to trigger the failure. Bug: 1019161 Test: See bug description for repro steps Change-Id: I384ec0d2830f07fb3b50632ee806e77fd33b7dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103306 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751925}
-
Wei-Yin Chen (陳威尹) authored
Bug: 930892 Change-Id: I85583fa6d0e6db62fb5519ed7d043870b47c9afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080925 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#751924}
-
Eugene Zemtsov authored
Previous CL removed hand made memory related UMAs for WMP. This CL uses the standard way to expose similar memory metrics. The only interesting part is where we change memory dump naming format from: media/webmediaplayer/player_%d/{video|audio} to media/webmediaplayer/{video|audio}/player_%d This is done in order to have readily available aggregating top level nodes where total video or audio memory consumption can be found. Bug: 1056839 Change-Id: Ibf8d57da47f54b90ff4e3fe207d351ee043aa41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109461 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751923}
-
Eugene Zemtsov authored
According to Dale Curtis these metrics are not used and won't be missed. We should consider whitelisting media player memory dumps for background collection. Bug: 1056839 Change-Id: I46056dd24b8f54153849fb4181749b51a4fdf68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090972Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751922}
-
rbpotter authored
Note: Currently SiteList test is disabled for flakiness. Re-enabled to test locally, and fixed a few consistent errors that likely appeared since the test was disabled. Did not observe any failures in 10 runs locally so will try to re-enable this test in a separate CL. Bug: 1026426 Change-Id: I72eead1d0fe4d70052ad7c1333a9c7b2ed104c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109410 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751921}
-
Lei Zhang authored
Bug: 1062179 Change-Id: Icf81d6363d27f460d32f1ba7e03dabaece8f94eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107721 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#751920}
-
Victor Costan authored
Bug: 1062925 Change-Id: I075bd135bf334f511480bcdccd04e91f99ad54ea Tested: Compared old and new output on macOS 10.15.3, via DLOGs. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104102 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#751919}
-
Nicholas Hollingum authored
Bug: 1062860 Change-Id: I1d0d8281c01bc471b6c020513101738225110f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108408Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#751918}
-
Lei Zhang authored
Check in a .plist file since NSMutableDictionaries created in memory get sorted when written out to disk. Bug: 1062179 Change-Id: I4c8fd6876b138094855ae76dea982b040877aca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108001Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fa0f9e0706b..c9453ffe96c1 Created with: gclient setdep -r src-internal@c9453ffe96c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4feb60d805a6c9502e86bf49f0de58b74ad53aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111779Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751916}
-
Patrick Monette authored
Fixes PerProfileWorkerTaskTracker so that the WorkerTaskTracker is notified when there are outstanding tasks that are about to be deleted. Bug: 1060506 Change-Id: Ic81ad1557c1e27a8fc96fc079f7447efcc2ce7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110350 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751915}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/c400416ee6a2..1618f0d88fdc $ git log c400416ee..1618f0d88 --date=short --no-merges --format='%ad %ae %s' 2020-03-19 bnc gfe-relnote: Ignore CANCEL_PUSH frames on the control stream. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-03-18 fayang gfe-relnote: In QUIC, remove is_config_negotiated_ from QuicStreamIdManager. No functional change expected, not protected. 2020-03-18 quiche-dev Internal QUICHE change 2020-03-18 fayang Use 1-RTT instead of 0-RTT write key to send H3 SETTINGs in quic_spdy_stream_test. 2020-03-18 fayang Add a OnCoalescedPacketSent to QuicConnectionDebugVisitor. This will used for net-log in chromium. 2020-03-18 quiche-dev Add byte counters to the bonnet in addition to the existing packet counters. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=zhongyi@chromium.org Change-Id: I80ac216bf85943d28aaa91f665dc5b74f94daff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110174Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#751914}
-
Jason Lin authored
Some of the default tab menu items (e.g. reload, move to existing window) does not make sense or work well with the terminal SWA, so we want to remove them. This CL adds GetTabMenuModelFactory() to AppBrowserController to allow an app to specify the tab menu model that it wants. Before screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=438083&signed_aid=ucqPxHzsGWc98617EvvGUQ==&inline=1 After Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=438084&signed_aid=R3gAlYCzETMUFNVq8NvAxw==&inline=1 Bug: 1060861 Change-Id: If1c318663690f2db637c31330299f95fb2b06ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105676Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Iaa7a05279f158dbdc332d4bb6ba9a683f9ea9c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112070Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751912}
-
Brian Sheedy authored
Switches the GPU Win10 Intel experimental bot to trigger tests on machins with driver 26.20.100.7870 to test the stability. TBR=ynovikov@chromium.org Bug: 1053803 Change-Id: I3fa8467656312288add0658a3e4b7dfb9c5ac2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111470Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch fixes hit test on position:relative inline element by changing |NGInlineCursor::PositionForPointInInlineBox()| and |LayoutInline::NodeAtPoint()| with descendants to pass assertions in following tests: - All/LayoutViewHitTestTest.HitTestHorizontal/* - All/LayoutViewHitTestTest.HitTestVerticalLR/* - All/ParameterizedLayoutInlineTest.MultilineRelativePositionedHitTest/1 This patch also changes |LayoutViewHitTestTest| class to check whether LayoutNG is enabled or disabled by |RuntimeEnabledFlag| instead of gTest's parameter for ease of working with |LayoutNGFragmentItem| runtime enabled feature. Note: Changes of |LayoutInline::NodeAtPoint()| is brought by http://crrev.com/c/2109575. Bug: 982194 Change-Id: I5d13542a2f57ca8ddd9dcf61a90f3ebbe4b2e0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104812 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751910}
-
David Tseng authored
This test attempted to wait for "foo" (the initial window title to be correctly read), however, we were getting " 'Untitled - Chromium - User 1' properties={"category":"nav"}" read out instead. This may indicate some races in the population of the window title under heavy load. This wasn't the intent of the test though which covers only the reading of the title once it changes (from the initial value). Removing this first expectation makes the test run without flaking. Fixed: 1060001 Change-Id: I354f08c99299c315b980d15ab69fa11a0eddaa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111275Reviewed-by:Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751909}
-
Andrew Grieve authored
Bug: 1059928 Change-Id: I8b39bc87abfecea5cc9f43a9cdd9cea3a228eed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108925 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#751908}
-
Martin Kreichgauer authored
When handling makeCredential requests in the caBLEv2 authenticator, pass request arguments from the native side where they are unmarshaled over to the Java side, so they can be used to construct the GMSCore FIDO API request. When receiving a response from the FIDO API, pass response parameters back to native code where they are converted into a CTAP response. Both sides were previously using hard-coded fake data. Move CtapMakeCredentialRequest and CtapGetAssertionRequest parsing code out of VirtualCtap2Device so that caBLEv2 authenticator native code can reuse them. Add a Parse() factory method to AttestationObject because the native code needs to parse the CBOR Java response from Java in order to convert it into a CTAP message. Also switch native code to make use of //base/android JNI type conversion helpers throughout. Bug: 1002262 Change-Id: Ie24adec8c2b8f64e4330aa1fc4b3bf8a273617e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109037 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#751907}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d812d033..02c1ddad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie034967a3f5f5c56c764256862d4ef1e0c96802b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111570Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751906}
-
Jing Wang authored
A bunch of nits were raised in https://crrev.com/c/2049013 post-commit, so making another change to fix them. Test: tested with Linux emulator. Bug: 1042084 Change-Id: I44d5835c21658e475dbba33c49a92c4b2e40d816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109573 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751905}
-
Julie Jeongeun Kim authored
This CL fixes the assertion 'G_IS_OBJECT (object)' with an early return if AXPlatformNodeAuraLinux doesn't have AtkObject as GetOrCreateAtkObject() could return nullptr if AX mode is not enabled. It also updates |accessibility_mode_| from BrowserAccessibilityStateImpl using AddAccessibilityModeFlags instead of direct assigning since it should call NotifyAddAXModeFlags() together when the mode is updated to sync it with the mode from AXPlatformNodeAuraLinux. Bug: 1061429 Change-Id: I0b4fa09d8d788608a403383c9e2c6123c618ccc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103997Reviewed-by:
-
John Palmer authored
There was a small cut and paste mistake in the earlier CL. Also, actually make the feature available for the keyboard to query. Bug: 1046641 Change-Id: I9f4abdf48e0436b2f4feb7f56b4c5cf3e68f86b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105672 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751903}
-
