GitLab

This option allows Cronet embedders to do end-to-end testing which
requires pointing requests to a particular test server.

BUG=594601

Review-Url: https://codereview.chromium.org/1817553002
Cr-Commit-Position: refs/heads/master@{#413454}

WindowManagerObserver can operate on the WMShell instance when the
WindowTreeClient is destroyed (e.g. AcceleratorRegistrarImpl). So
notify the observers before destroying the WMShell instance.

BUG=639039

Review-Url: https://codereview.chromium.org/2269473003
Cr-Commit-Position: refs/heads/master@{#413453}

This allows metrics to survive and be collected even if a
subprocess terminates before reporting.

Only the GPU process is monitored with this CL but it should
be trivial to add the remaining ones going forward.

BUG=546019

Review-Url: https://codereview.chromium.org/2224063002
Cr-Commit-Position: refs/heads/master@{#413452}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d2cc7436caf8acae3d3c8ac94858cc2afaf356bf chromium_trybot: extract chromium_tests.trybot_steps (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2267803002
Cr-Commit-Position: refs/heads/master@{#413451}

This CL adds isPaintable() to OffscreenCanvas which mimics HTMLCanvasElement::
isPaintable() with some adjustments. Certain common constants and utility
functions shared by OffscreenCanvas and HTMLCanvasElement have been moved to
platform/graphics/. This CL is to facilitate toBlob implementation.

BUG=563830
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2255683005
Cr-Commit-Position: refs/heads/master@{#413450}

The new result is wrong, more wrong than the old result, but
having it as a failure in test expectations means we do not
catch any regressions. We did not, for instance, catch the
regression that made the test result worse.

TBR=fmalita@chromium.org
BUG=502531,636475

Review-Url: https://codereview.chromium.org/2260193002
Cr-Commit-Position: refs/heads/master@{#413449}

This patch just moves some expectations around to enable
efficient triage.

TBR=chrishtr@chromium.org
BUG=636475

Review-Url: https://codereview.chromium.org/2263223002
Cr-Commit-Position: refs/heads/master@{#413448}

BUG=

Review-Url: https://codereview.chromium.org/2260073005
Cr-Commit-Position: refs/heads/master@{#413447}

BUG=623986
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2263503002
Cr-Commit-Position: refs/heads/master@{#413446}

I am using it for the LayoutNG transition; there does not seem to be a need
to limit this to grid items as nothing else currently sets this.

This change also makes LayoutNG use this new function.

R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2257223002
Cr-Commit-Position: refs/heads/master@{#413445}

Revert of Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory (patchset #5 id:80001 of https://codereview.chromium.org/2244213002/ )

Reason for revert:
Somehow breaks timestamping. Reverting for investigation. To reproduce, run

./browser_tests --gtest_filter='WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest*' --run-manual --ui-test-action-max-timeout=200000

This produces lots of warnings like

[1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906110 <= 3680861906110) for incoming frame. Dropping.
[1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906042 <= 3680861906042) for incoming frame. Dropping.

Original issue's description:
> Delete the class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory
>
> Instead, use the AdaptFrame and OnFrame methods of the VideoCapturer
> base class.
>
> This cl also applies the new timestamp aligner logic, to translate
> Chrome's camera timestamps into the timescale of rtc::TimeMicros(). No
> other change in behavior is intended.
>
> BUG=webrtc:5682, webrtc:5740, 516700
>
> Committed: https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f
> Cr-Commit-Position: refs/heads/master@{#413093}

TBR=perkj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682, webrtc:5740, 516700

Review-Url: https://codereview.chromium.org/2263183002
Cr-Commit-Position: refs/heads/master@{#413444}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/57476cefd25ae2063bd373156fefab4f756ed90d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e328cf9c78a02f44b24dfa809284a6e94bcec935 git cl issue: add --json switch for machine-readable output (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2261193002
Cr-Commit-Position: refs/heads/master@{#413443}

Change the API around a little so that we can mock out the callback to
ensure that we are calling in the correct scenarios.

BUG=637640

Review-Url: https://codereview.chromium.org/2259823007
Cr-Commit-Position: refs/heads/master@{#413442}

UpdatePreferredLoginState needs to update PasswordStore with a slightly
modified version of some of the forms in PasswordFormManager's |best_matches_|.
Currently it does so by modifying |best_matches_| directly, and then updating
the PasswordStore.

That has the advantage of keeping an up-to-date copy in |best_matches_| without
reloading from PasswordStore (and also sparing PasswordForm copies inside
UpdatePreferredLoginState.

It also has a disadvantage: |best_matches_| cannot be const. That will become
a problem once the ownership of |best_matches_| will be transferred from
PasswordFormManager to a new class, FormFetcher, shared by multiple
PasswordFormManager instances. While it is possible to let all
PasswordFormManager instances modify the forms owned by a FormFetcher, that
will make the code hard to understand and prone to unexpected side-effects.

The advantage seems limited -- at the point UpdatePreferredLoginState is called,
the PasswordFormManager is saving a password form, and will be deleted soon.
It will not need the |best_matches_|. Once FormFetcher starts owning them,
it will need to wait for a refresh from PasswordStore to get them updated.
But that's not worse than today, when different PasswordFormManager instances do
not share their |best_matches_| at all.

BUG=621355

Review-Url: https://codereview.chromium.org/2261723002
Cr-Commit-Position: refs/heads/master@{#413441}

BUG=skia:5227

Review-Url: https://codereview.chromium.org/2264673003
Cr-Commit-Position: refs/heads/master@{#413440}

Since the RootScroller proposal allows arbitrary elements to become the outer
viewport scroll layer, the scroll chaining behavior need a bit of an
adjustment. Specifically, we shouldn't chain past the outer viewport scroll
layer. The current code assumes that once we hit the outer viewport scroll
layer, we can continue chaining since we'll get to the inner viewport scroll
layer.

In this CL, we'll add the inner viewport scroll layer to the scroll chain and
immediately break when we encounter the outer viewport scroll layer, relying on
the fact that the scrolling code will use cc::Viewport to scroll the inner
viewport scroll layer.

Also added a test to make sure TopControls movement works correctly when a non-
default outer viewport layer is used.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2243973002
Cr-Commit-Position: refs/heads/master@{#413439}

It's possible for frame_ to be deleted after this call, so add null
checks after call sites.

BUG=639688, 639689
TEST=No more OnStop or NavigateInternal crashes in RenderFrameImpl.

Review-Url: https://codereview.chromium.org/2260383002
Cr-Commit-Position: refs/heads/master@{#413438}

It turns out that the original patch
(https://codereview.chromium.org/2133093002) didn't actually enable
browser logging in the System Health smoke tests.

BUG=623058,639538

Review-Url: https://codereview.chromium.org/2267663003
Cr-Commit-Position: refs/heads/master@{#413437}

Inside PasswordFormManager and FormSaver, the |credentials_to_update| argument is used to pass copies of non-best matches with a modified password, in order to be saved to PasswordStore.

Currently, the PasswordForm in |not_best_matches_| is changed directly, and a pointer to it is passed in |credentials_to_update|. However, |not_best_matches_| will need to become constant as its ownership transfers to the coming FormFetcher class, to avoid potential for surprising side-effects when multiple PasswordFormManager change the shared object inside one FormFetcher.

This CL makes that possible by changing the element type of |credentials_to_update| from a pointer to a PasswordForm to a PasswordForm itself. That way it is possible to modify just the copy inside |credentials_to_update| and not the original in |not_best_matches_|. The fact that |not_best_matches_| fall out of sync with the PasswordStore at that point does not matter: the current PasswordFormManager is currently saving a PasswordForm, so it will be destroyed soon and will not need |not_best_matches_|.

BUG=621355

Review-Url: https://codereview.chromium.org/2263683002
Cr-Commit-Position: refs/heads/master@{#413436}

Google Cloud Messaging recently started including a "google.sent_time"
Long in the incoming message Bundle from Google Play Services. This
patch filters out non-String values to prevent warnings about
ClassCastExceptions.

BUG=639313

Review-Url: https://codereview.chromium.org/2265543002
Cr-Commit-Position: refs/heads/master@{#413435}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e0e1556b..e0af8c62

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2264013003
Cr-Commit-Position: refs/heads/master@{#413434}

In mus+ash, toplevel windows don't share the same focus_client,
so we have to use exo::WMHelper for handling window focus.

BUG=637914

Review-Url: https://codereview.chromium.org/2259243002
Cr-Commit-Position: refs/heads/master@{#413433}

GMSCore uses Parcelables for IPCs, and so we can't safely rename
anything.

BUG=639722

Review-Url: https://codereview.chromium.org/2269553003
Cr-Commit-Position: refs/heads/master@{#413432}

CrashDumpManager watches for generated microdumps when child processes
die, and CrashMicroDumpManager is responsible for aborting the WebView
browser process. Both share similarities that can be combined, and doing
so allows us to eventually support generating a minidump and then dying
in WebView.

BUG=633979

Review-Url: https://codereview.chromium.org/2200693002
Cr-Commit-Position: refs/heads/master@{#413431}

RenderThreadImpl::Shutdown has been trying to shut down Blink and V8 gracefully,
but the graceful shutdown has caused tons of use-after-free bugs
(and many engineers has spent lots of time fixing ordering issues around the shutdown).

As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion)
and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion),
there is no reason we have to shut down the renderer gracefully.
It's just causing use-after-free bugs and wasting performance.
Hence, this CL stops calling blink::shutdown, which had been
shutting down *some things* in Blink and V8 gracefully.
(Remember that blink::shutdown hadn't been shutting down everything;
a lot of objects in Blink and V8 had already been left as is without getting destructed.)

Ideally we should just call ProcessDied() at an earlier stage of
RenderThreadImpl::Shutdown(), but I'd like to defer the change to a separate CL.

BUG=639244

Review-Url: https://codereview.chromium.org/2249353002
Cr-Commit-Position: refs/heads/master@{#413430}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d0987fac..e0e1556b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2266863002
Cr-Commit-Position: refs/heads/master@{#413429}

Since there is ContentSuggestionsProvider::Observer::OnCategoryStatusChanged(),
there is no need for ContentSuggestionsProvider::GetProvidedCategories().

BUG=639282

Review-Url: https://codereview.chromium.org/2260703004
Cr-Commit-Position: refs/heads/master@{#413428}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/c71fa13c8ea4fef24f23d0894e8c636f3d66fe7a Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/b8f8dd796be3ff39f4801f81e6ec8d4fe0c12032 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/990f604880743564b4d20029026487d7477c3ed3 fetch: set remote.origin.url to correct value rather than failing (phajdan.jr@chromium.org)

NOTRY=true
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2268523002
Cr-Commit-Position: refs/heads/master@{#413427}

BUG=615825

Review-Url: https://codereview.chromium.org/2262733002
Cr-Commit-Position: refs/heads/master@{#413426}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2c034e723e150b21ed4ddcd346e3d9746e4c622a Add cloudtail start/stop in recipe_modules/goma (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=544330

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2263073002
Cr-Commit-Position: refs/heads/master@{#413425}

Let a video resume automatically when changing the playback position after the playback has finished

BUG=418441
TEST=manually tested

Review-Url: https://codereview.chromium.org/2263033002
Cr-Commit-Position: refs/heads/master@{#413424}

Extracted VolumeInfo interface so that our modules which depend on only the VolumeInfo's interface
don't need to have dependencies on the VolumeInfo's implementation.

BUG=636289
TEST=third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2260133002
Cr-Commit-Position: refs/heads/master@{#413423}

In addition the code performs small related refactoring. No functional changes should happen.

BUG=555132

Review-Url: https://codereview.chromium.org/2253233005
Cr-Commit-Position: refs/heads/master@{#413422}

There are 2 places the spec uses "report the exception"[1]:

1. The document parser invokes constructors synchronously.
2. Upgrade.

Currently Blink has 2 different code paths for each, and each has
different issues:
1. The synchronous constructor uses SetVerbose(true), which works for
   thrown exceptions, but ExceptionState::throwIfNeeded() only puts
   the exception into pending exceptions, which will be cleared when
   TryCatch scope exits.
2. Upgrade fires error events and calls
   ExecutionContext::reportException() to avoid it, but it always uses
   NotSharableCrossOrigin. This works in run-layout-test where the
   origin has m_unversalAccess, but not in, for instance, file URL.

This patch unifies the 2 code paths.

[1] https://html.spec.whatwg.org/multipage/webappapis.html#report-the-exception

BUG=632940

Review-Url: https://codereview.chromium.org/2244203002
Cr-Commit-Position: refs/heads/master@{#413421}

isTerminating() is used for making sure whether a worker execution context is
still valid after V8 API calls, but this is no longer necessary thanks to
graceful shutdown mechanism for WorkerThread (https://crbug.com/487050)

BUG=614272, 638877

Review-Url: https://codereview.chromium.org/2265863002
Cr-Commit-Position: refs/heads/master@{#413420}

This makes sure order of script execution in HTML imports,
which define custom elements.

BUG=594918

Review-Url: https://codereview.chromium.org/2269493002
Cr-Commit-Position: refs/heads/master@{#413419}

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst

Review-Url: https://codereview.chromium.org/2264503002
Cr-Commit-Position: refs/heads/master@{#413418}

This change enables the stopNotifications function for remote GATT
characteristics on Android. In order to do so, two distinct refactorings have been done;

1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class.

2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications.

BUG=584370

Committed: https://crrev.com/d41af3adfd8500c81c827ab03ed2736909cf1ee8
Review-Url: https://codereview.chromium.org/2051333004
Cr-Original-Commit-Position: refs/heads/master@{#412498}
Cr-Commit-Position: refs/heads/master@{#413417}

This CL adds a parameter to the WaitUntilCondition of Earl Grey wait_util to
display a more explicit custom error message if the condition is not met at
the end of the timeout.

BUG=none

Review-Url: https://codereview.chromium.org/2252723008
Cr-Commit-Position: refs/heads/master@{#413416}

- enums, including those defined inside structs and interfaces.
- struct and union internal data types (i.e., the wire format definition).

BUG=632061

Review-Url: https://codereview.chromium.org/2247083003
Cr-Commit-Position: refs/heads/master@{#413415}