GitLab

To test the lifecycle of a memory buffer we used to use
glCopyTextureCHROMIUM. This has some limitations due to the extension
spec (i.e: limited subset of formats), and doesn't test the general
lifecycle of the memory buffer.

This patch changes GpuMemoryBufferTest.Lifecycle to test the lifecycle
of the GpuMemoryBuffer writing directly to the backbuffer.

BUG=

Review URL: https://codereview.chromium.org/1066073002

Cr-Commit-Position: refs/heads/master@{#324123}

This makes CalculateVisibleRects try to re-use the to_target and
from_target transforms stored in transform nodes whenever it needs to
compute a transform. Since these baked transforms incorporate the
target's sublayer scale, the fallback path now also includes sublayer
scale for consistency.

Testing locally on a z620, this improves property tree computation time
by 7% on Gmail, and by 20% on rAF-driven poster circle.

BUG=474725

Review URL: https://codereview.chromium.org/1060413002

Cr-Commit-Position: refs/heads/master@{#324122}

When both a URL as Intent.EXTRA_TEXT and a screenshot as Intent.EXTRA_STREAM
present, most apps favor the latter.
So we need to use a new extra name for a screenshot so that a URL could be
prioritized as it is.

BUG=455996

Review URL: https://codereview.chromium.org/1060243002

Cr-Commit-Position: refs/heads/master@{#324121}

Don't access the canvas() through the PaintContext, to allow the
PaintContext to be backed by a DisplayItemList instead of a Canvas in
the future.

R=piman@chromium.org, sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1064103002

Cr-Commit-Position: refs/heads/master@{#324120}

BUG=473408
TBR=davidben

Review URL: https://codereview.chromium.org/1067723002

Cr-Commit-Position: refs/heads/master@{#324119}

1. Use window.performance.timing instead of statsCollectionController to get page loading time.
2. Fix waiting condition to avoid racing condition

BUG=472603,467964

Review URL: https://codereview.chromium.org/1056533003

Cr-Commit-Position: refs/heads/master@{#324118}

Now that android_webview_build is no longer supported, the extra level
of indirection of including cpufeatures.gypi instead of directly
depending on the cpufeatures target is not necessary. Remove the cases
in the Chromium tree. Other references appear in projects pulled in via
DEPS that will have to be fixed separately before cpufeatures.gypi can
be entirely deleted.

BUG=440793

Review URL: https://codereview.chromium.org/1045123005

Cr-Commit-Position: refs/heads/master@{#324117}

BUG=471292
TEST=the new test, NavigationControllerBrowserTest.ErrorPageReplacement

Review URL: https://codereview.chromium.org/1048963002

Cr-Commit-Position: refs/heads/master@{#324116}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

R=oshima
BUG=466426

Review URL: https://codereview.chromium.org/1066113002

Cr-Commit-Position: refs/heads/master@{#324115}

Revert of Disable Slimming Paint rasterize_and_record (patchset #1 id:1 of https://codereview.chromium.org/1053303002/)

Reason for revert:
Re-enabling by reverting this temporary revert.

Original issue's description:
> Disable Slimming Paint rasterize_and_record
>
> We need to revert
> https://src.chromium.org/viewvc/blink?view=rev&revision=192695
>
> Reverting will cause this benchmark to crash, which is bad.
>
> TBR=pdr,sullivan
> NOTRY=true
> BUG=457054
>
> Committed: https://crrev.com/798e40fff8abe7d608cd44515ef29ee8158ca97c
> Cr-Commit-Position: refs/heads/master@{#323781}

TBR=pdr@chromium.org,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457054

Review URL: https://codereview.chromium.org/1066143002

Cr-Commit-Position: refs/heads/master@{#324114}

of HttpProxyClientSocket and SpdyProxyClientSocket. Instead,
contruct a "URL" from the endpoint used in the CONNECT request.

Review URL: https://codereview.chromium.org/1060883002

Cr-Commit-Position: refs/heads/master@{#324113}

BUG=b/18275087

Review URL: https://codereview.chromium.org/1064903003

Cr-Commit-Position: refs/heads/master@{#324112}

Refactored these two functions into a single one to ease the
transition of https://codereview.chromium.org/920443003.

Tested on Android (with Nexus 5 device) with the following command
lines:

$ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android
$ ninja -C out_android/Debug content_unittests content_unittests_apk
$ export CHROMIUM_OUT_DIR=out_android
$ build/android/test_runner.py gtest -s content_unittests --debug

BUG=338338
TEST=see above
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/1064033002

Cr-Commit-Position: refs/heads/master@{#324111}

https://chromium.googlesource.com/angle/angle/+log/51a1db16..ae2d8a3af

BUG=436191

Review URL: https://codereview.chromium.org/1066623003

Cr-Commit-Position: refs/heads/master@{#324110}

When you run `gn gen out-gn/Debug` on Mac you get the following:

ERROR at //build/toolchain/mac/BUILD.gn:200:12: Build argument has no effect.
      os = current_os
           ^---------
The variable "os" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

BUG=None
TEST=`gn gen out-gn/Debug` passes without the above error
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1064063002

Cr-Commit-Position: refs/heads/master@{#324109}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/44fc33d..0cdfa90

TBR=falken@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/1060373002

Cr-Commit-Position: refs/heads/master@{#324108}

Refine interfaces, implementation, formatting and comments according to the C++
style guide and Chrome coding standards. Behavior is unaltered except for a few
edge cases and Win32 API error handling.

This change is done as part of the readability review process. Original review:
https://crrev.com/1016563004.

Review URL: https://codereview.chromium.org/1030923002

Cr-Commit-Position: refs/heads/master@{#324107}

BUG=472038

Review URL: https://codereview.chromium.org/1068623002

Cr-Commit-Position: refs/heads/master@{#324106}

BUG=none

Review URL: https://codereview.chromium.org/1063153002

Cr-Commit-Position: refs/heads/master@{#324105}

Noticed this was missing on all the new android bots.

BUG=

Review URL: https://codereview.chromium.org/1067923002

Cr-Commit-Position: refs/heads/master@{#324104}

This will help us track down how an invalid resource is ending up in
the frame hopefully.

R=enne, piman@chromium.org
BUG=455931

Review URL: https://codereview.chromium.org/1062043003

Cr-Commit-Position: refs/heads/master@{#324103}

BUG=468201
TEST=Follow the repro steps in the bug and ensure there's no crash.

Review URL: https://codereview.chromium.org/1069043002

Cr-Commit-Position: refs/heads/master@{#324102}

Tile manager and eviction tile priority queues are using combined
priorities to schedule tiles, so tiling set eviction queues should use
those same priorities in order to return tiles in expected order.

R=vmiura, danakj, vmpstr

Review URL: https://codereview.chromium.org/1051473002

Cr-Commit-Position: refs/heads/master@{#324101}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5965b73..bb4a1cf

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1067853004

Cr-Commit-Position: refs/heads/master@{#324100}

This allows to have multiple Disabled group, e.g. Disabled/Disabled_control, and thus eases experimentation.

TBR=sky@chromium.org
BUG=465815

Review URL: https://codereview.chromium.org/1062243002

Cr-Commit-Position: refs/heads/master@{#324099}

In the past eglSwapBuffers used to return early, before the swap actually happened and descheduling in the driver. This resulted in the scheduler beginning the next frame early and hitting the page flip deadline in time more often.

Freon returns swap ack when page flip actually happened, but with the side effect of scheduling shifted forward, resulting in more missed vblanks and reduced performance.

This change restores original performance on freon.

BUG=465599

Review URL: https://codereview.chromium.org/1059503003

Cr-Commit-Position: refs/heads/master@{#324098}

http://crrev.com/1047223004 added experimental icon NTP support and
changed default "white-space: nowrap" to "white-space: pre-wrap", then
make current Material Design select the old one. This is broke 3rd-party
NTPs that don't have the same setting. This CL changes the defaults back,
and adds a new "ntl" to signal intent of having multiline titles. Also
updated single-iframe NTP to match.

BUG=474164

Review URL: https://codereview.chromium.org/1061163003

Cr-Commit-Position: refs/heads/master@{#324097}

BUG=

Review URL: https://codereview.chromium.org/1067003002

Cr-Commit-Position: refs/heads/master@{#324096}

Also ported gcd_client_unittests to use mock_xhr as a proof of concept,
but left original test as a supplement to xhr_unittests.

BUG=471928

Review URL: https://codereview.chromium.org/1055313002

Cr-Commit-Position: refs/heads/master@{#324095}

Move the implementation of doing power related actions from device_utils to battery_utils.

BUG=472763

Review URL: https://codereview.chromium.org/1067853003

Cr-Commit-Position: refs/heads/master@{#324094}

Adds a new junit_binary template for gyp which makes it easy to
make new Junit test suites by setting a lot of the options and
necessary dependencies for you.

Also, adds a new java_binary.gypi file which uses the
create_java_binary_script.py similiar to how the java_binary
GN template works when main_class is specified. This lets
GYP and GN work similiar when building a junit binary, so
our test runner can run them the same way.

Finally, because of the slightly different way were now running
the junit binary, the java classpath contains all of the jars
instead of just the test jar (before we were running
java -jar test_jar.jar which set the classpath to just be
test_jar.jar). Therefore, we can simplify things and just look
in the classpath for the paths to the Robolectric dependencies
when running Robolectric junit tests.

BUG=

Review URL: https://codereview.chromium.org/1057783002

Cr-Commit-Position: refs/heads/master@{#324093}

This test was invalid on modern glibc:
asprintf errors EOVERFLOW without attempting an allocation
when the size is at least INT_MAX - 32. INT_MAX - 33 is the
largest size that can attempt to trigger allocation failure,
and will not necessarily accomplish that on some systems.

Create a library that is specified to wrap malloc trivially,
to accomplish the goal of the test without external dependencies
or inconsistently implemented behavior.

BUG=428211

Review URL: https://codereview.chromium.org/1064793002

Cr-Commit-Position: refs/heads/master@{#324092}

BUG=

Review URL: https://codereview.chromium.org/1069033002

Cr-Commit-Position: refs/heads/master@{#324091}

BUG=467260

Review URL: https://codereview.chromium.org/1053423002

Cr-Commit-Position: refs/heads/master@{#324090}

BUG=424436,467287

Review URL: https://codereview.chromium.org/1068603002

Cr-Commit-Position: refs/heads/master@{#324089}

Revert of Reland Track memory consumption of SP on top 7 sites. (patchset #1 id:1 of https://codereview.chromium.org/1052843002/)

Reason for revert:
I think the original CL meant to make changes to memory.py, not run-perf-test.cfg. We shouldn't be submitting changes to run-perf-test.cfg, this file is used by the perf-try bots to pass try job parameters.

Original issue's description:
> Track memory consumption of SP on top 7 sites.
>
> Tests:
> android: https://codereview.chromium.org/1023783006/
> linux & mac: https://codereview.chromium.org/1013723006/
> win: https://codereview.chromium.org/1038773002/
>
> All above pass the "Running With Patch" step.
>
> BUG=None
>
> Committed: https://crrev.com/82b8e167143a5f0d4dd4515c6d0e14a64f654083
> Cr-Commit-Position: refs/heads/master@{#323680}

TBR=pdr@chromium.org,sullivan@chromium.org,prasadv@chromium.org,pan.deng@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1062253002

Cr-Commit-Position: refs/heads/master@{#324088}

BUG=474654

Review URL: https://codereview.chromium.org/1067903003

Cr-Commit-Position: refs/heads/master@{#324087}

This is a step towards unifying the various ways to "notify"
MemoryPressureListeners.

This also provides "GetCurrentPressureLevel" to a more general-purpose
place so we'll be able to use it on other platforms.
(Especially Windows, so we can use it in renderer_frame_manager).

See:
https://docs.google.com/a/chromium.org/document/d/1z3SR3JfKOwVaZxrsfHLOrPjo4-IVtnijaX86LKYPEQs/edit#
for more on the rationale and design, and
https://codereview.chromium.org/1045433002/
for what this might look like for ChromeOS's memory
monitor.

BUG=463546

Review URL: https://codereview.chromium.org/1048983006

Cr-Commit-Position: refs/heads/master@{#324086}

This CL adds methods to extract the content of a log in an external module
and import it to upload in the main application.

BUG=474625

Review URL: https://codereview.chromium.org/1030503003

Cr-Commit-Position: refs/heads/master@{#324085}

Now that Blink handles animated gifs, this code is not needed.

BUG=467197

Review URL: https://codereview.chromium.org/1061203002

Cr-Commit-Position: refs/heads/master@{#324084}