- 04 Dec, 2019 40 commits
-
-
James Cook authored
Move the Wi-Fi configurations to UserSelectableOsType. Change the ModelTypeController to respect the global "OS sync enabled" pref. Refactor the printers ModelTypeController to share code. Note: This means Wi-Fi config sync cannot ship before Split Settings Sync. However, it's much simpler than trying to support Wi-Fi config being *both* a UserSelectableType and a UserSelectableOsType. I've discussed this with the engineer working on Wi-Fi sync and we're both OK with this plan. Bug: 1013466 Test: existing components_unittests and unit_tests Test: Run --enable-features=SplitSettingsSync,SyncWifiConfigurations and verify "Wi-Fi configurations" appears in Chrome OS settings. Verify turning it off and closing settings results in chrome://sync-internals showing that the Wi-Fi type is not syncing. Change-Id: I878fecaf449248ae8747e37aa2e0e897130e63ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947396Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#721541}
-
Joe Downing authored
The code which read this policy was removed from Chrome Remote Desktop in M76 but it looks like we did not officially deprecate the policy at that point. This CL marks it as deprecated and lists the last host version which supports it. Change-Id: I14e1dc3d5fc061703fc94f93ba7b75861b3fa317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949229 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721540}
-
Brian Salomon authored
Bug: 1028116 Change-Id: Iaff6b52cb552ca7339ff895b228034d4904eef75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949201 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#721539}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9ad36f3225d..242a9e0ffe94 git log a9ad36f3225d..242a9e0ffe94 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 danilchap@webrtc.org Fuzz RtpPacketizerAv1 2019-12-04 eshr@google.com Add new_request flag to SendFullIntraRequest 2019-12-04 sprang@webrtc.org Verifies trials are populated when creating a Call. 2019-12-04 elrello@microsoft.com Replace hostCandidate with address and port in RTCPeerConnectionIceErrorEvent 2019-12-04 handellm@webrtc.org VideoRtpReceiver: Enable encoded frame sink. 2019-12-04 ilnik@webrtc.org Implement automatic animation detection in VideoStreamEncoder 2019-12-04 handellm@webrtc.org WebRtcVideoEngine: Enable encoded frame sink. Created with: gclient setdep -r src/third_party/webrtc@242a9e0ffe94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013564,chromium:1013590 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ica4a9da85d7c766fd1a5638e93c88251b41a8c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721538}
-
Dominique Fauteux-Chapleau authored
FinishRequest() is called with UNAUTHORIZED, which lets the user upload/download the file but doesn't record UMA metrics. Bug: 1028133 Change-Id: I66405a78e0d33997f1a12b322ca5a8bb5250ada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947362Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721537}
-
Eugene But authored
This histogram is useful and helped me to find a new bug (crbug.com/1030164). Bug: 1029848 Change-Id: Ibedf95a4b237f3c2876005f89a82b3b6fae1e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949277 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#721536}
-
Geoff Lang authored
BUG=982292 Change-Id: I1c44530f3fb18f1866c85433f6aaa2455deb72df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946704Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721535}
-
Ovidio Henriquez authored
This change adds the stub interface for BluetoothChooserContext to be implemented in future patches. Bug: 589228 Change-Id: I1d4a25effa9676548e16f075a7fc6b792943043f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927391Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#721534}
-
James Vecore authored
The BT devices do not have their device type in the accessibility label in the system tray. A recent change https://crrev.com/c/1925593 added this to the settings ui. This CL adds them to the system tray. A utility function GetBluetoothDeviceLabelForAccessibility is added to the devices service public interface to generate the label. Strings from settings were moved over to the bluetooth_strings.grp to be shared between the tray and settings UI. There are two sets of are very similar device type localization strings which is intentional as they serve two slightly different purposes: display name vs accessibility label. Fixed: 1027608 Change-Id: Ic017d908b856e200694ef74a23eec48e21ab2a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931102Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#721533}
-
Mikel Astiz authored
Similarly to how it's done for keystore keys, the patch now adopts a base64-encoding of the encryption keys, prior to the Nigori key derivation (PBKDF2). The main motivation is that the underlying crypto libraries don't deal well with non-utf8 passphrases/passwords, or they diverge across implementations (Java vs C++). The rest of the code, prior to key derivation, continues to use binary keys. Bug: 1000146 Change-Id: Icaa88f285938f09e5fb8b72c9e11b8f90ab41840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950536 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#721532}
-
Mohammad Refaat authored
geo is used to direct the user to the correct global appstore. Bug: 1030346 Change-Id: I31eaffa69643f17a223808ede5051839a8669aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949791Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#721531}
-
Robert Ogden authored
This was using the previous page's url. Ooops Bug: 1029959 Change-Id: Ibda0079598698cfebc54c0c579f76f31355284e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948045Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Ken MacKay authored
Otherwise we get flaky build failures like: ../../third_party/blink/renderer/platform/bindings/name_client.h:9:10: fatal error: 'third_party/blink/renderer/platform/bindings/buildflags.h' file not found #include "third_party/blink/renderer/platform/bindings/buildflags.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ie9737e7e28a3e836cce94c5ff0eff8449096b651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948053 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721529}
-
Dana Fried authored
Many places in test code call EXPECT_TRUE(VerifyUi()), which only produces a stack trace and does not tell you which of the conditions in VerifyUi() aren't met. Adding logging allows us to look at the test logs and figure out which condition actually failed. Change-Id: If6f81dac0f10aabdf8125571295f2a55343f93ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949452 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721528}
-
Avery Musbach authored
WorkspaceEventHandler::HandleVerticalResizeDoubleClick actually handles both horizontal resize double clicking and vertical resize double clicking. The name and header comment both say it is only for vertical. Bug: None Change-Id: I756a951ae86e0f3cf094fd889a1973c85fe63442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950854Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#721527}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c68502c177c6..82f68bc205dc Created with: gclient setdep -r src-internal@82f68bc205dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I471a365248a611b18f5385c946b88e55171cb353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950844Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721526}
-
Liquan (Max) Gu authored
This CL is regarding the toolbar of the Bottom-sheet Payment Handler UI. With a slow connection, the toolbar looks empty in the early loading stage, because the toolbar doesn't show url, title or the security icon until the Payment Handler UI has received update from the page. As an improvement, this CL populates the toolbar with the initial url as soon as it opens the PH UI. Bug: 999196 Change-Id: I72b3a9fc10976eb6dc1814cc9bda28afa03910b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944613 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721525}
-
Robin Lewis authored
Bug: 1027346 Change-Id: I30fac3fbc2dbfcc38a31c0c950c7fbaed4d3382d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929102Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#721524}
-
Evan Stade authored
The preferred height is used during layout of the PWA window frame (CustomTabBarView), so remove obsolete/misleading comment and restore old layout behavior. Bug: 1026519 Change-Id: I015f9bcc0fb4661f73603b3a46acfae937e2f1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949203 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#721523}
-
Clark DuVall authored
This is a follow-up test for http://crrev.com/c/1947639 Bug: 1030186 Change-Id: I3b82495a86befd4c52419047a0856ad012cc7bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949733Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e9dc4222803..4a213018b475 git log 7e9dc4222803..4a213018b475 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 thomasanderson@chromium.org Always check for GL_ARB_sync Created with: gclient setdep -r src/third_party/skia@4a213018b475 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028799 Tbr: bsalomon@google.com Change-Id: Ibbf65d1c59e41656de59a3cadeacfd63f96c0873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950665Reviewed-by:
-
Fabian Sommer authored
Increase arrow button size Decrease card icon size Increase distance between login button and card icon Use new card icon Bug: 1024254 Change-Id: I34962de9e63725b742914a68c382a7c6416b38e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942343Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Jacobo Aragunde Pérez authored
Identifies and removes usage of static Create() for those classes defined in //third_party/blink/renderer/core/animation. Exceptions have been made in some cases: * Animation::Create is considered non-trivial. * KeyFrameEffect::Create is considered non-trivial. * ScrollTimeline::Create is considered non-trivial. * One of DocumentTimeline::Create is part of Web Animations API IDL and hasn't been touched. Bug: 939691 Change-Id: I05616f8addcd9be0e2dbd3cafcc0bcdf8e163b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949474Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#721519}
-
Michael Crouse authored
This is a reland of 548b6a4e This fixes the failing tests by disabling them on platforms this feature will not support. Original CL that was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1938192 Patchset 1 of this CL is the CL that was submitted and reverted. Bug: 1001194 Change-Id: I62f5619ed7c230c168a4da914a17c998092f1e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949697 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Andy Paicu authored
This is a reland of 6e91b688 There was a clash with https://chromium-review.googlesource.com/c/chromium/src/+/1948892 which renamed a file that this CL included. PS1 contains the original CL. Original change's description: > Added IPH for the mini-infobar notification permission prompt (android) > > As part of the new quieter notification prompt, add IPH for the android > quieter notification permission prompt. To be shown the first time > the setting is enabled. > > This is controlled by using the functions: > * AdaptiveNotificationPermissionUiSelector::ShouldShowPromo > * AdaptiveNotificationPermissionUiSelector::PromoWasShown > > Quick mock of how this is supposed to look: > https://docs.google.com/document/d/1hsp1j08yzIK6M6G7pbsdEihU8CLN7QQ3V2iAxESrqQM/edit?usp=sharing > > Bug: 1029595 > Change-Id: I3c90dda846a70396f1130c2ad6dcfc3622b9b25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944173 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721442} TBR=nyquist@chromium.org,engedy@chromium.org,dtrainor@chromium.org,bcwhite@chromium.org,mdjones@chromium.org,bsazonov@chromium.org,hkamila@chromium.org Bug: 1029595 Change-Id: I33eb37e289c8bbea9f8ff3aba51db229aa523381 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950513 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Mike Dougherty authored
TBR=justincohen@chromium.org Bug: 1030701 Change-Id: I9f7ffcccf5484514d22121defe458ada25758d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950667 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721516}
-
Lei Zhang authored
Change-Id: I37ddc01a0427105b679d6f73708e734311f5502e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947965Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721515}
-
Mark Cogan authored
This CL modernizes the ARQuickLookCoordinator to use the superclass -initWithBaseViewController:browser: initializer, and to remove the spurious injection of BrowserState and WebStateList. It also updates the coordinator's unit test, using the new TestBrowser() constructor. Bug: 1029346 Change-Id: I29f6e14409dc66b34da36126d0ea7e516323ddaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943240 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#721514}
-
Mikhail Khokhlov authored
As an experiment in running the TBMv3 metrics on waterfall, this CL adds a simple console_error metric to the power.desktop benchmark. Note that this metric will only be computed when traces collected from Chrome are in proto format, i.e. currently only on linux-perf-fyi bot. The behavior of the benchmark on all other bots is not affected. Bug: 1012687 Change-Id: I24cc9aff5454c95c48b542e86ffa191073d5c01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950515 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#721513}
-
sczs authored
Bug: 1014652 Change-Id: I0ebc5257346656db6c54c9f7055bf99f1699bd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921552 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#721512}
-
Francois Doray authored
Prior to this CL, the SequenceManager set |PendingTask::delayed_run_time| for immediate tasks when the "add queue time to tasks" option was enabled. This caused the responsiveness watcher to consider an interval as janky only when a long task was running, not when a task was queued for a long time as intended. With this CL, SequenceManager only sets |PendingTask::delayed_run_time| for delayed tasks. The responsiveness watcher is modified to keep recording the same jank as before, to ensure that we can easily notice if there are real jank regressions. In an upcoming CL, we will modify the responsiveness watcher to record a new jank histogram that takes into account queuing time. Bug: 1029137 Change-Id: I8394cb42a8b6d77b01eb38cad1242fc4b0f6c74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940452Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#721511}
-
Markus Handell authored
This CL adds a new class VideoTrackRecorderPassthrough, that is used to handle EncodedVideoFrames coming from a source, handling the request of key frames upon construction and Resume(). The common parts of VideoTrackRecorder are abstracted to a new base class and ToT's VideoTrackRecorder is now VideoTrackRecorderImpl. This CL also adds unit tests for the new class. Change-Id: I4f8c71e4c4e1fba57a3b143a56cf64052b315ff4 Bug: 1013590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893935 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I117c327ee7eac55d032374df71244121fd2d8c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950843Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: Ia128c291169bc77604e2fe091b0caf77117f1045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950517 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#721508}
-
Sangwoo Ko authored
components/infobars/core/infobar is a AnimationDelegate but this can't use AnimationDelegateViews or get widget as it would be layering violation. So it's subclass, InfoBarView sets AnimationDelegateNotifier with AnimationDelegateViews. AnimationDelegateViews will adapt CompositorAnimationRunner for InfoBar and then forward callbacks to InfoBar. There's no intentional behavior changes. Bug: 824026 Change-Id: Id824a6a402682e9ec5a0f36216d92d92cffa5669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933839Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#721507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd5a91ebf34d..bc546858739e git log fd5a91ebf34d..bc546858739e --date=short --first-parent --format='%ad %ae %s' 2019-12-04 vapier@chromium.org apiclient: finish migration to googleapiclient 2019-12-04 lamontjones@chromium.org api: sync protos 2019-12-04 vapier@chromium.org cidb: drop GetActionsForChanges/GetActionsForBuild/GetActionHistory 2019-12-04 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-04 bpastene@chromium.org chrome_chromeos_lkgm: When rolling, first close all old rolls that are open. 2019-12-03 vapier@chromium.org cbuildbot: hwtests: delete CQ-specific logic 2019-12-03 vapier@chromium.org triage_lib: drop unused module 2019-12-03 vapier@chromium.org build_failure_message: FindSuspectedChanges: drop unused helper 2019-12-03 vapier@chromium.org metadata_lib: drop unused RecordCLAction 2019-12-03 vapier@chromium.org unittests: use assertExists/assertNotExists in more places Created with: gclient setdep -r src/third_party/chromite@bc546858739e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I10f82497a4a7663e6fc1aaa074499b9c43ef3544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948800Reviewed-by:
-
Antonio Gomes authored
... to use THREAD_CHECKER instead. Blink does not currently make use of sequences. BUG=787254 R=guidou@chromium.org Change-Id: Idda5453badb39a2c52ea8c5d8282a338d9cb5d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946623 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Marc Treib authored
Making a few things private that should be private, renaming "ids" to "topics", updating comments etc. No functional changes. Bug: 1029698 Change-Id: If95081e1b68277bc0beb1e17b23dde0b4791a010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948438 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721504}
-
Mathieu Binette authored
Context: WinServer2008's end of support on Jan 14th 2020 https://support.microsoft.com/en-us/lifecycle/search?alpha=windows%20server%202008 Changes: - Removed Win2008r2 from the template host file used in tests. It's not currently used in any chromium tests, so no test to update. Follow-up to change in enterprise/cel: https://crrev.com/c/1936508 Bug: 1028769 Change-Id: I86410c88cdcfbe4e87e2600d1f20fde3638dd80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937572Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Auto-Submit: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#721503}
-
Antonio Gomes authored
File was removed (accidentally) in https://crrev.com/c/1745279, instead of getting moved down to Blink. R=jbroman@chromium.org Change-Id: I09da94c97c1dc04613bdf6714d01afa01f798016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950624 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#721502}
-
