GitLab

BUG=401588

Review URL: https://codereview.chromium.org/469993006

Cr-Commit-Position: refs/heads/master@{#291367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291367 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the list redraw partially instead of full-redraw when some contents are changed in the directory. This should improve the performance of redraw.

In addition, as the result of the fix, the cache is not flashed on partial redraw, and the issue 374713 has gone.

BUG=374713
TEST=manaul tested

Review URL: https://codereview.chromium.org/486783006

Cr-Commit-Position: refs/heads/master@{#291366}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291366 0039d316-1c4b-4281-b951-d872f2087c98

It caused a failure on Android bot:

********************************************************************************
New warnings.
Please fix, or perhaps add to /mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M C IJU: TestCase org.chromium.content.browser.PopupZoomerTest defines setUp that doesn't call super.setUp()  At PopupZoomerTest.java
--------------------------------------------------------------------------------



Original patch comments:

> Hide PopupZoomer when the container view or window loses focus
> 
> Currently there is a method which hides all the popups but call to 
> hide PopupZoomer is missing. Added the call to hide PopupZoomer inside 
> hidePopups and hiding the zoomer when the view loses focus or the 
> window loses focus. Also added unit test code.
> 
> BUG=405477
> 
> Review URL: https://codereview.chromium.org/470193005

TBR=r.ghatage@samsung.com

Review URL: https://codereview.chromium.org/497693002

Cr-Commit-Position: refs/heads/master@{#291365}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324170
TEST=None

Review URL: https://codereview.chromium.org/474563004

Cr-Commit-Position: refs/heads/master@{#291363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291363 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291362}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291362 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180746:180753&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/493383002

Cr-Commit-Position: refs/heads/master@{#291361}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371538
TBR=pkasting@chromium.org for include fix in chrome/browser/ui/omnibox/omnibox_edit_model.cc

Review URL: https://codereview.chromium.org/469623004

Cr-Commit-Position: refs/heads/master@{#291360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291360 0039d316-1c4b-4281-b951-d872f2087c98

Currently there is a method which hides all the popups but call to 
hide PopupZoomer is missing. Added the call to hide PopupZoomer inside 
hidePopups and hiding the zoomer when the view loses focus or the 
window loses focus. Also added unit test code.

BUG=405477

Review URL: https://codereview.chromium.org/470193005

Cr-Commit-Position: refs/heads/master@{#291359}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405345
NOTRY=true

Review URL: https://codereview.chromium.org/492393002

Cr-Commit-Position: refs/heads/master@{#291358}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291358 0039d316-1c4b-4281-b951-d872f2087c98

This patch resolves a few issues with GitilesFileSystem.

BUG=404239
NOTRY=True

Review URL: https://codereview.chromium.org/498503002

Cr-Commit-Position: refs/heads/master@{#291357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291357 0039d316-1c4b-4281-b951-d872f2087c98

dragend would never fire on mac because
BrowserPluginEmbedder::SystemDragEnded() clears |guest_dragging_over_|, which stops
BrowserPluginEmbedder::DragSourceEndedAt() to send the dragend
message.
This isn't an issue in aura b/c, we see DrageSourceEndedAt() before
SystemDragEnded().

BUG=401941
Test=On mac, load a <webview> in a chrome app, register a "dragend"
listener to a draggable div. Drag that div, observe "dragend" listener
firing properly.

Review URL: https://codereview.chromium.org/499493002

Cr-Commit-Position: refs/heads/master@{#291356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383635

Review URL: https://codereview.chromium.org/498563002

Cr-Commit-Position: refs/heads/master@{#291355}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291355 0039d316-1c4b-4281-b951-d872f2087c98

I'm changing two things to Connector:
. Removing setting destroyed_flag in NotifyError. This seems wrong
  since Connector hasn't been destroyed. If destoyed_flag_ was
  non-NULL and we set it to true and we're nested, then when the stack
  unravels destroyed_flag_ won't be unset even though Connector may
  not have been destroyed. This would leave Connector in a very bad
  state.
. Makes NotifyError cancel a wait. If there was a wait outstanding or
  a notification was in flight than if we don't cancel the wait we may
  very well end up back in OnHandleReady trying to do something.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/494243002

Cr-Commit-Position: refs/heads/master@{#291354}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291354 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to avoid a pairing request prompt when connecting to a service on
a system that tries to upgrade the connection from general bonding to general
bonding with MITM protection, which according to Android and ChromeOS Bluetooth
experts is the correct behavior.

BUG=403069
TEST=chrome.easyUnlockPrivate.connectToBluetoothServiceInsecurely() should work
     just like chrome.bluetoothSocket.connect(), but not show a pairing request
     prompt when pairing with Android L.
R=tengs@chromium.org, keybuk@chromium.org

Review URL: https://codereview.chromium.org/491753002

Cr-Commit-Position: refs/heads/master@{#291353}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291353 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/468913003

Cr-Commit-Position: refs/heads/master@{#291352}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405904
R=mschilder,juanlang,xiyuan

Review URL: https://codereview.chromium.org/495033002

Cr-Commit-Position: refs/heads/master@{#291351}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291351 0039d316-1c4b-4281-b951-d872f2087c98

Skia no longer require SkPictures to be cloned for playback on
different threads. This removes all compositor code that exists
only to handle the cloning requirement.

BUG=235280

Review URL: https://codereview.chromium.org/362073002

Cr-Commit-Position: refs/heads/master@{#291350}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291350 0039d316-1c4b-4281-b951-d872f2087c98

Originally an IDL argument like "[out] int[] foo" will generate
int* foo[]. It means an array of pointers to integers and what we
want is a pointer to an array of integers. Change the output to
int** foo to be not confusing.

BUG=387547
TEST=Run generator and build chrome.

Review URL: https://codereview.chromium.org/490433002

Cr-Commit-Position: refs/heads/master@{#291349}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291349 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291343}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291343 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=370554

Review URL: https://codereview.chromium.org/499533002

Cr-Commit-Position: refs/heads/master@{#291341}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291341 0039d316-1c4b-4281-b951-d872f2087c98

This is needed by some files in these targets. The GYP build has this dependency.

TBR=jam

Review URL: https://codereview.chromium.org/478853005

Cr-Commit-Position: refs/heads/master@{#291340}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291340 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Create a new AccountTrackerService (patchset #8 of https://codereview.chromium.org/425823002/)

Reason for revert:
Likely causing chrome.browser.signin.OAuth2TokenServiceIntegrationTest failures on Android.

TBR=rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true

Original issue's description:
> Create a new AccountTrackerService PKS based on the existing AccountTracker.
> 
> This CL is one part of the effort to change chrome to use gaiaid instead of
> email address as the unique id for an account.
> 
> BUG=341408
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291263

Review URL: https://codereview.chromium.org/490403002

Cr-Commit-Position: refs/heads/master@{#291335}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=finnur@chromium.org, dtseng@chromium.org

Review URL: https://codereview.chromium.org/493903003

Cr-Commit-Position: refs/heads/master@{#291330}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291330 0039d316-1c4b-4281-b951-d872f2087c98

The test is failing on all platforms with the following error message:
"[FAIL] createGuestViewDOM: uncaught exception: Error in event handler for extensionOptionsInternal.onSizeChanged: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params)
Stack trace: Error: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params)
    at Object.normalizeArgumentsAndValidate (extensions::schemaUtils:113:11)
    at Object.\u003Canonymous> (extensions::binding:326:30)
    at ExtensionOptionsInternal.resize (extensions::extensionOptions:178:21)
    at ExtensionOptionsInternal.onSizeChanged (extensions::extensionOptions:153:10)
    at ExtensionOptionsEvents.handleSizeChangedEvent (extensions::extensionOptionsEvents:66:33)
    at Object.EXTENSION_OPTIONS_EVENTS.sizechanged.customHandler (extensions::extensionOptionsEvents:20:15)
    at info.evt.addListener.instanceId (extensions::extensionOptionsEvents:55:12)
    at EventImpl.dispatchToListener (extensions::event_bindings:397:22)
    at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26)
    at EventImpl.dispatch_ (extensions::event_bindings:379:35)
Error
    at extensions::test:93:22
    at exports.handle (extensions::uncaught_exception_handler:15:3)
    at EventImpl.dispatch_ (extensions::event_bindings:384:9)
    at dispatchArgs (extensions::event_bindings:247:26)
    at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://obocclgnomgjhjnenilbpmgkgfmdhecn/test.html (0)

> Implement smoother autosizing of the extension options overlay
> 
>  - Use element.animate to resize the overlay for embedded extension
>    options. When an <extensionoptions> element is embedded in a WebUI
>    overlay, if its size changes the overlay will smoothly expand to
>    surround the element.
>  - Add an API to <extensionoptions> to defer autosizing until its
>    embedder is ready. This is used to 'pin' the element's size until
>    the overlay is done expanding.
>  - Move the <extensionoptions> off screen until the overlay is done
>    expanding.
>  - Prevent <extensionoptions> from shrinking after the initial sizing.
>    This makes the look of the embedded options page more consistent.
> 
> BUG=386842
> 
> Review URL: https://codereview.chromium.org/480243003

TBR=ericzeng@chromium.org

Review URL: https://codereview.chromium.org/498633002

Cr-Commit-Position: refs/heads/master@{#291328}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291328 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291322}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291322 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that we simply need to initialize the don't-animate flag earlier, as we did in the other tests.
BUG=403824
TBR=sky@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/497583003

Cr-Commit-Position: refs/heads/master@{#291318}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291318 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291317}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291317 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180729:180745&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/474563005

Cr-Commit-Position: refs/heads/master@{#291316}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291316 0039d316-1c4b-4281-b951-d872f2087c98

Updated Arm, Mips, x86_32 and x86_64 syscall defines
to match the latest kernel 3.17 at the time of this commit.

BUG=406123
TEST=sandbox_linux_unittests

Review URL: https://codereview.chromium.org/493603003

Cr-Commit-Position: refs/heads/master@{#291315}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291315 0039d316-1c4b-4281-b951-d872f2087c98

To make porting the QUIC EndToEndTest to Chromium possible with fewer
Chromium-specific parts in shared code, I've made QuicDispatcher expose
and accept a QuicDispatcher::PacketWriterFactory which it uses to create
a new packet writer wrapper for every QuicConnection. I also changed
QuicConnection to accept a QuicConnection::PacketWriterFactory (a second
new type of factory) rather than the writer itself in its constructor,
since the per-connection packet writers need to be created with the
connection already existing.

Merge internal CL: 73064412

Written by Daniel Ziegler <dmziegler@chromium.org>
Original review URL: https://codereview.chromium.org/467963002/

R=rch@chromium.org,wtc@chromium.org
BUG=

Review URL: https://codereview.chromium.org/475113005

Cr-Commit-Position: refs/heads/master@{#291314}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291314 0039d316-1c4b-4281-b951-d872f2087c98

This will make it easier to move tests that use permissions from Chrome's
unit_tests target to extensions_unittests.

BUG=none
TEST=extensions_unittests passes

Review URL: https://codereview.chromium.org/496903002

Cr-Commit-Position: refs/heads/master@{#291313}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291313 0039d316-1c4b-4281-b951-d872f2087c98

Reliability tests have been dead for a while.

Review URL: https://codereview.chromium.org/479703002

Cr-Commit-Position: refs/heads/master@{#291312}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403813
TEST=athena_unittests
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/496793004

Cr-Commit-Position: refs/heads/master@{#291311}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398467
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/499453002

Cr-Commit-Position: refs/heads/master@{#291310}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393969

Review URL: https://codereview.chromium.org/480173004

Cr-Commit-Position: refs/heads/master@{#291309}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/494143003

Cr-Commit-Position: refs/heads/master@{#291308}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291308 0039d316-1c4b-4281-b951-d872f2087c98

Step 1 - factor out current cache and increase its size.

BUG=401758
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/455563002

Cr-Commit-Position: refs/heads/master@{#291307}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291307 0039d316-1c4b-4281-b951-d872f2087c98

This changes CC to trust Blink's inner container layer size and apply
Android top controls size as a delta on top of it. Prior to this patch,
on Android we would clobber what Blink told CC with a from-scratch
computation "physical device size - top controls impl size - keyboard
overdraw size".

This change makes it unnecessary for the renderer to be aware of
keyboard overdraw size, but on the other hand CC now must know about how
top controls size was applied to Blink layout size, to understand the
size coming from Blink. So this patch replaces one float with the other.

This simplifies the logic and is a step towards converging OSK codepaths
between platforms (since ChromeOS didn't use overdraw_bottom_height, but
used visible_viewport_size instead -- this patch unlocks the potential
use of the latter on Android as well).

NOTRY=true
BUG=404315

Review URL: https://codereview.chromium.org/476113004

Cr-Commit-Position: refs/heads/master@{#291306}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291306 0039d316-1c4b-4281-b951-d872f2087c98

As there is no URL being displayed users need to be aware of what host
they are on for security reasons. This is part of the experimental
streamlined hosted apps window frame.

BUG=368372

Review URL: https://codereview.chromium.org/490103003

Cr-Commit-Position: refs/heads/master@{#291305}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291305 0039d316-1c4b-4281-b951-d872f2087c98

This test was enabling a lot of categories that it should not have.
When using impl side painting, we can use the trace events from
blink.ImageFrameGenerator::decode to measure the time. On legacy
compositing, this doesn't exist and we have to fall back to the
"timeline.Decode Image" event still. Left FIXMEs to remove this.

BUG=405244
NOTRY=true

Review URL: https://codereview.chromium.org/480713004

Cr-Commit-Position: refs/heads/master@{#291304}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291304 0039d316-1c4b-4281-b951-d872f2087c98