- 18 Jan, 2007 18 commits
-
-
sullivan authored
- Tests for: <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string * editing/spelling/spelling-expected.checksum: Added. * editing/spelling/spelling-expected.png: Added. * editing/spelling/spelling-expected.txt: Added. * editing/spelling/spelling.html: Added. * editing/execCommand/find-after-replace-expected.checksum: Added. * editing/execCommand/find-after-replace-expected.png: Added. * editing/execCommand/find-after-replace-expected.txt: Added. * editing/execCommand/find-after-replace.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@18953 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt authored
Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before calling hitTest on it. Fixes "flashy" selection in textareas. Reviewed by darin * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): git-svn-id: svn://svn.chromium.org/blink/trunk@18951 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca authored
Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent. * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): * loader/ResourceLoader.h: * loader/mac/ResourceLoaderMac.mm: Removed. * platform/network/ResourceHandleClient.h: (WebCore::): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::willStopBufferingData): * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): git-svn-id: svn://svn.chromium.org/blink/trunk@18950 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin authored
* Scripts/run-webkit-tests: Fix handling of configuration so it does the right thing when no explicit configuration is passed in. The old code assumed that the result of setConfiguration() was the configuration, but it's undefined when no configuration is explicitly passed in. The correct function to use is configuration(), and I also streamlined the code. git-svn-id: svn://svn.chromium.org/blink/trunk@18948 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mjs authored
- fixed <rdar://problem/4887416> REGRESSION (SearchField): Assertion failure in HTMLInputElement::setValueFromRenderer when editing via drag and drop (11846) http://bugs.webkit.org/show_bug.cgi?id=11846 * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid nesting blocks in plaintext mode, since that's not an issue under normal circumstances. * html/HTMLInputElement.h: * manual-tests/drag-move-in-search-field.html: Added. * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd rather truncate it than end up with an illegal value here. git-svn-id: svn://svn.chromium.org/blink/trunk@18944 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann authored
git-svn-id: svn://svn.chromium.org/blink/trunk@18941 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin authored
Reviewed by Darin and Mitz. - Test for http://bugs.webkit.org/show_bug.cgi?id=12305 REGRESSION: Images do not load in video sections on CNN.com homepage * fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added. * fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added. WebCore: Reviewed by Darin and Mitz. - fix http://bugs.webkit.org/show_bug.cgi?id=12305 REGRESSION: Images do not load in video sections on CNN.com homepage <rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305) Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html * html/HTMLAttributeNames.in: Added lowsrc. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc. (WebCore::HTMLImageElement::lowsrc): Added. (WebCore::HTMLImageElement::setLowsrc): Added. * html/HTMLImageElement.h: Added lowsrc and setLowsrc. * html/HTMLImageElement.idl: Added lowsrc. git-svn-id: svn://svn.chromium.org/blink/trunk@18940 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann authored
git-svn-id: svn://svn.chromium.org/blink/trunk@18933 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zack authored
Reviewed by Lars. git-svn-id: svn://svn.chromium.org/blink/trunk@18932 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aliceli1 authored
Reviewed by Harrison. Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste Migration of some editing code from WebHTMView to WebCore::Editor resulted in not calling pasteboardTypesForSelection, which Mail was overriding for the special purpose of adding a type to the pasteboard after WebKit did. This patch adds 2 separate code paths for Tiger and Leopard. On Tiger we give in and call the WebView's pasteboardTypesForSelection. On Leopard we call a delegate after the pasteboard types are set. * bridge/EditorClient.h: * editing/Editor.h: * platform/Pasteboard.h: * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard): (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection): * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): WebKit: Reviewed by Harrison. Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste Migration of some editing code from WebHTMView to WebCore::Editor resulted in not calling pasteboardTypesForSelection, which Mail was overriding for the special purpose of adding a type to the pasteboard after WebKit did. This patch adds 2 separate code paths for Tiger and Leopard. On Tiger we give in and call the WebView's pasteboardTypesForSelection. On Leopard we call a delegate after the pasteboard types are set. * DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]): * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::didSetSelectionTypesForPasteboard): (WebEditorClient::pasteboardTypesForSelection): * WebView/WebEditingDelegate.h: WebKitQt: Added these stubs to keep the Qt build from failing. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::didSetSelectionTypesForPasteboard): * WebCoreSupport/EditorClientQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@18931 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sullivan authored
Reviewed by Darin - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string * page/Frame.h: * page/Frame.cpp: (WebCore::Frame::findString): new startInSelection parameter -- if true, search starts looking in selection; if false, search starts looking after the selection * page/mac/WebCoreFrameBridge.h: * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]): new startInSelection parameter, passed through to Frame::findString() * editing/JSEditor.cpp: pass false for new findString parameter, to match old behavior WebKit: Reviewed by Darin - WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string * Misc/WebKitVersionChecks.h: Added extern "C" so this can be used from .mm files. I don't need this change anymore for this fix, but it's still worth fixing now so it doesn't bite anyone later. * WebView/WebDocumentPrivate.h: Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one method is just like the one WebDocumentSearching method, but with an additional parameter. We hope to eliminate this dependence on protocols someday, but adding another one as SPI seems like it won't make anything worse. * WebView/WebHTMLView.mm: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): now calls through to new method that has one additional parameter, passing NO to match old behavior (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): pass new parameter to bridge * WebView/WebPDFView.h: Declare conformance to WebDocumentIncrementalSearching protocol * WebView/WebPDFView.mm: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): now calls through to new method that has one additional parameter, passing NO to match old behavior (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]): new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection parameter * WebView/WebViewPrivate.h: Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing method but with one additional parameter * WebView/WebView.mm: (-[WebView searchFor:direction:caseSensitive:wrap:]): now calls through to new method that has one additional parameter, passing NO to match old behavior (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection parameter git-svn-id: svn://svn.chromium.org/blink/trunk@18928 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson authored
git-svn-id: svn://svn.chromium.org/blink/trunk@18927 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson authored
Drop Panther Support (?!?) and change the comment explaining some SPI forward decls * Misc/WebDownload.m: git-svn-id: svn://svn.chromium.org/blink/trunk@18926 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bdakin authored
git-svn-id: svn://svn.chromium.org/blink/trunk@18925 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
justing authored
Reviewed by darin <rdar://problem/4920488> REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link) * editing/execCommand/4920488-expected.checksum: Added. * editing/execCommand/4920488-expected.png: Added. * editing/execCommand/4920488-expected.txt: Added. * editing/execCommand/4920488.html: Added. * fast/dom/Range/compareBoundaryPoints-1-expected.txt: Added. * fast/dom/Range/compareBoundaryPoints-1.html: Added. WebCore: Reviewed by darin <rdar://problem/4920488> REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link) * dom/Range.cpp: (WebCore::Range::commonAncestorContainer): Return null if the nodes don't have a common ancestor. As a side effect, the public commonAncestorContainer now sets an exception if the Range starts in one document and ends in another, or starts or ends in a tree that's been removed from the document. The spec doesn't cover this and there is no precedent in other browsers for this case because they don't allow invalid Ranges (you can create one with WebCore by removing a node that contains the start/end of a Range). (WebCore::Range::compareBoundaryPoints): If the the two positions are in nodes that have no common ancestor, return null. This doesn't change the behavior of the public compareBoundaryPoints: it already throws an exception if the two positions are in nodes that don't have a common ancestor. This follows the spec. git-svn-id: svn://svn.chromium.org/blink/trunk@18924 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sullivan authored
- fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word * editing/TextIterator.cpp: (WebCore::WordAwareIterator::WordAwareIterator): We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses kind RUNFINDER, so WordAwareIterator needs to do so also. git-svn-id: svn://svn.chromium.org/blink/trunk@18923 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
adele authored
Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS No test case since you need to open up the menu to fire onChange. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Keep track of m_lastOnChangeIndex even when we're not firing onChange. Since the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare it later. This matches our behavior in Safari 2.0. git-svn-id: svn://svn.chromium.org/blink/trunk@18922 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
adele authored
- Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead of returning early for double and triple clicks. git-svn-id: svn://svn.chromium.org/blink/trunk@18921 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 17 Jan, 2007 22 commits
-
-
eseidel authored
Reviewed by Brady. Update results after SVG container hit testing changes. * svg/custom/pointer-events-text-expected.checksum: * svg/custom/pointer-events-text-expected.png: * svg/custom/pointer-events-text-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@18920 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin authored
* rendering/RenderObject.h: Removed unused nextEditable and previousEditable. * rendering/RenderObject.cpp: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@18919 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin authored
Reviewed by Maciej. - fix http://bugs.webkit.org/show_bug.cgi?id=12278 <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278) * WebCore.exp: Added HitTestResult::imageRect, removed HitTestResult::boundingBox. * rendering/HitTestResult.h: * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect): Added. Returns the content rectangle of the image. * rendering/RenderObject.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::absolutePosition): Made const. (WebCore::RenderObject::contentBox): Added. (WebCore::RenderObject::absoluteContentBox): Added. * rendering/RenderBox.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Made const. * rendering/RenderTableCell.h: * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absolutePosition): Made const. * rendering/RenderView.h: * rendering/RenderView.cpp: (WebCore::RenderView::absolutePosition): Made const. WebKit: Reviewed by Maciej. - fix http://bugs.webkit.org/show_bug.cgi?id=12278 <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278) * Misc/WebElementDictionary.mm: (-[WebElementDictionary _imageRect]): Call HitTestResult::imageRect, not HitTestResult::boundingBox. git-svn-id: svn://svn.chromium.org/blink/trunk@18918 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lars authored
git-svn-id: svn://svn.chromium.org/blink/trunk@18917 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
adele authored
Updating this new layout test so that it actually crashes before the last fix. * fast/css/pseudostyle-anonymous-text.html: git-svn-id: svn://svn.chromium.org/blink/trunk@18916 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
adele authored
Reviewed by Beth. Test for http://bugs.webkit.org/show_bug.cgi?id=10139 <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle * fast/css/pseudostyle-anonymous-text-expected.txt: Added. * fast/css/pseudostyle-anonymous-text.html: Added. WebCore: Reviewed by Beth. Fix for http://bugs.webkit.org/show_bug.cgi?id=10139 <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle Test: fast/css/pseudostyle-anonymous-text.html * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node. git-svn-id: svn://svn.chromium.org/blink/trunk@18915 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lars authored
Make sure DumpRenderTree exits when run-webkit-tests is done. git-svn-id: svn://svn.chromium.org/blink/trunk@18914 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
adele authored
Reviewed by Anders and John. Test for http://bugs.webkit.org/show_bug.cgi?id=11278 <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options * fast/forms/menulist-width-change-expected.checksum: Added. * fast/forms/menulist-width-change-expected.png: Added. * fast/forms/menulist-width-change-expected.txt: Added. * fast/forms/menulist-width-change.html: Added. WebCore: Reviewed by Anders and John. Fix for http://bugs.webkit.org/show_bug.cgi?id=11278 <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options Test: fast/forms/menulist-width-change.html * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc. git-svn-id: svn://svn.chromium.org/blink/trunk@18913 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap authored
http://bugs.webkit.org/show_bug.cgi?id=12268 Give object prototypes their own names JavaScriptCore: * kjs/lookup.h: Append "Prototype" to ClassName in KJS_IMPLEMENT_PROTOTYPE. WebCore: * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo. * bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): * bindings/js/JSHTMLInputElementBase.h: * bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): * bindings/js/JSXMLHttpRequest.h: * bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessor::JSXSLTProcessor): (KJS::XSLTProcessorPrototypeFunction::callAsFunction): (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp): * bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction): (KJS::DOMMediaList::DOMMediaList): (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction): (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction): (KJS::DOMCSSValue::DOMCSSValue): (KJS::DOMCSSValuePrototypeFunction::callAsFunction): * bindings/js/kjs_css.h: * bindings/js/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNodePrototypeFunction::callAsFunction): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction): (KJS::DOMNamedNodeMap::DOMNamedNodeMap): (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction): * bindings/js/kjs_dom.h: * bindings/js/kjs_domnode.h: * bindings/js/kjs_events.cpp: (KJS::DOMEvent::DOMEvent): (KJS::DOMEventPrototypeFunction::callAsFunction): (KJS::Clipboard::Clipboard): (KJS::ClipboardPrototypeFunction::callAsFunction): * bindings/js/kjs_events.h: * bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction): (KJS::): (KJS::JSHTMLDocument::JSHTMLDocument): (KJS::JSHTMLElementPrototypeFunction::callAsFunction): (KJS::JSHTMLElement::JSHTMLElement): (KJS::JSHTMLCollection::JSHTMLCollection): (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction): * bindings/js/kjs_html.h: * bindings/js/kjs_navigator.cpp: * bindings/js/kjs_traversal.cpp: (KJS::DOMNodeFilter::DOMNodeFilter): (KJS::DOMNodeFilterPrototypeFunction::callAsFunction): * bindings/js/kjs_window.cpp: (KJS::Window::clear): Changed Proto to Prototype, and ProtoFunc to PrototypeFunction. LayoutTests: * fast/dom/Window/window-properties-expected.txt: * fast/dom/prototype-chain-expected.txt: * fast/events/event-view-toString-expected.txt: * fast/events/mouseclick-target-and-positioning-expected.txt: * fast/tokenizer/external-script-document-write-expected.checksum: * fast/tokenizer/external-script-document-write-expected.png: * fast/tokenizer/external-script-document-write-expected.txt: Updated the results. git-svn-id: svn://svn.chromium.org/blink/trunk@18912 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lars authored
Fix the Qt build again after the latest Image changes. Also make some of the methods implemented in ImageCG crossplatform. git-svn-id: svn://svn.chromium.org/blink/trunk@18911 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
andersca authored
Move all code in WebNetscapePluginEmbeddedView down to WebBaseNetscapePluginView. * Plugins/WebBaseNetscapePluginView.h: * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView didStart]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView _redeliverStream]): * Plugins/WebNetscapePluginEmbeddedView.h: * Plugins/WebNetscapePluginEmbeddedView.mm: git-svn-id: svn://svn.chromium.org/blink/trunk@18910 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin authored
* platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled): Remove obsolete parameters from this stub. git-svn-id: svn://svn.chromium.org/blink/trunk@18909 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eseidel authored
Reviewed by rwlbuis. Test: svg/custom/inner-svg-hit-test.svg * rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit. git-svn-id: svn://svn.chromium.org/blink/trunk@18907 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lars authored
Don't call receivedResponse twice for file: URLs. Never call back into the ResourceHandleClient once cancel() has been called on the ResourceHandle. Remove the inheritance from Shared<XxxClient> in the client classes. Answer asynchronously to most of the Policy checking methods in FrameLoaderClientQt to avoid some crashes in the loader. Small fixes in DumpRenderTree, so we don't by accident dump twice for the same test. Exclude one more test as it currently causes DumpRenderTree to hang forever. git-svn-id: svn://svn.chromium.org/blink/trunk@18906 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eseidel authored
No review, build fix only. * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern (WebCore::Image::drawPattern): (WebCore::Image::drawTiled): git-svn-id: svn://svn.chromium.org/blink/trunk@18905 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eseidel authored
Reviewed by mitz and rwlbuis. SVGs do not work as background images: http://bugs.webkit.org/show_bug.cgi?id=12096 Tests updated: - fast/images/svg-as-background.svg: now passes - fast/images/svg-as-tiled-background.svg: now passes * platform/graphics/BitmapImage.h: (WebCore::BitmapImage::nativeImageForCurrentFrame): (WebCore::BitmapImage::mayFillWithSolidColor): (WebCore::BitmapImage::solidColor): * platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor): (WebCore::Image::solidColor): (WebCore::Image::nativeImageForCurrentFrame): (WebCore::Image::startAnimation): * platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPatternCombined): (WebCore::caculatePatternScale): (WebCore::Image::drawTiled): * platform/graphics/cg/PDFDocumentImage.cpp: * platform/graphics/cg/PDFDocumentImage.h: * platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame): * platform/graphics/svg/SVGImage.h: git-svn-id: svn://svn.chromium.org/blink/trunk@18904 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mjs authored
<rdar://problem/4887781> Seed: Repro Safari crash in -[WebHTMLRepresentation receivedData:withDataSource:] (music.aol.com) * WebView/WebDataSource.mm: (-[WebDataSource _receivedData:]): Protect self against destruction partway through this method. git-svn-id: svn://svn.chromium.org/blink/trunk@18903 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rwlbuis authored
Add proper condition for rx attribute negative check. git-svn-id: svn://svn.chromium.org/blink/trunk@18902 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lars authored
suppress all debug output coming from qDebug() statements. Like this we can get rid of all the noise coming from the notImplemented() macro when running the layout tests. You can get it back by adding -v to DumpRenderTree's command line. Changed run-webkit-tests slightly, so we by default don't fail anymore when our output differs from what is generated on the Mac. Added a --strict option, so that we can still see this cases and fix them one by one. change all notImplemented() macros to use qDebug instead of fprintf(stder, ...) git-svn-id: svn://svn.chromium.org/blink/trunk@18901 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson authored
Reviewed by Oliver A few enhancements to the HTTP Auth architecture * platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::isProxy): (WebCore::ProtectionSpace::receivesCredentialSecurely): * platform/network/ProtectionSpace.h: git-svn-id: svn://svn.chromium.org/blink/trunk@18900 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aliceli1 authored
Reviewed by harrison. Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard * WebCore.xcodeproj/project.pbxproj: * bridge/EditorClient.h: * editing/Editor.cpp: (WebCore::Editor::copy): (WebCore::Editor::didWriteSelectionToPasteboard): * editing/Editor.h: * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard): WebKit: Reviewed by harrison. Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard * DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:didWriteSelectionToPasteboard:]): * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::didWriteSelectionToPasteboard): * WebKit.xcodeproj/project.pbxproj: * WebView/WebEditingDelegate.h: WebKitQt: Added these stubs to keep the Qt build from failing. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::didWriteSelectionToPasteboard): * WebCoreSupport/EditorClientQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@18899 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
justing authored
Reviewed by harrison <rdar://problem/4747450> Gmail Editor: Caret doesn't always position itself after list marker <rdar://problem/4917055> GMail Editor: A hang can occur when attempting to apply list styling to selected indented text Added: * editing/execCommand/4747450-expected.checksum: Added. * editing/execCommand/4747450-expected.png: Added. * editing/execCommand/4747450-expected.txt: Added. * editing/execCommand/4747450.html: Added. * editing/execCommand/4917055-expected.txt: Added. * editing/execCommand/4917055.html: Added. Fixed: * editing/execCommand/create-list-with-hr-expected.checksum: * editing/execCommand/create-list-with-hr-expected.png: * editing/execCommand/create-list-with-hr-expected.txt: WebCore: Reviewed by harrison <rdar://problem/4747450> Gmail Editor: Caret doesn't always position itself after list marker <rdar://problem/4917055> GMail Editor: A hang can occur when attempting to apply list styling to selected indented text * editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions to compute the end of a run for emitted '\n's, because it's often wrong in that case. git-svn-id: svn://svn.chromium.org/blink/trunk@18895 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-