- 30 Sep, 2020 40 commits
-
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I904540644c257307be39c965f1d775646df30b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438805 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812432}
-
Josiah K authored
Change-Id: Ie6b5eadc25d2ddda95140d6c2730e663a33e34c3 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439699 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812431}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of cb2f5900 Original change's description: > [Instant Start] Avoid pre-native GURL usage > > Remove native dependency of > ReturnToChromeExperimentsUtil.shouldShowStartSurfaceAsTheHomePage() > and PseudoTab.readAllPseudoTabsFromStateFile() so that they can be > called without leading to native initialization. > > Benchmarking results using http://crrev.com/c/2373287: > > 100 samples on Nexus 5X > Median Diff with control p-value > FirstDrawCompletedTime 414.0ms -29.0ms (-7.00%) 0.000000 > SingleTabTitleAvailableTime 287.0ms -31.5ms (-10.98%) 0.000000 > FeedStreamCreatedTime 836.5ms -39.5ms (-4.72%) 0.000030 > FeedContentFirstLoadedTime 1898.5ms -0.5ms (-0.03%) 0.534189 > FeedsLoadingPlaceholderShown 234.0ms -2.0ms (-0.85%) 0.629761 > > 100 samples on Pixel 2 XL > Median Diff with control p-value > FirstDrawCompletedTime 176.0ms -18.0ms (-10.23%) 0.000000 > SingleTabTitleAvailableTime 131.0ms -14.0ms (-10.69%) 0.000000 > FeedStreamCreatedTime 424.0ms -31.0ms (-7.31%) 0.000180 > FeedContentFirstLoadedTime 1137.0ms -18.5ms (-1.63%) 0.075061 > FeedsLoadingPlaceholderShown 107.0ms -1.0ms (-0.93%) 0.718766 > > 100 samples on Pixel 3 XL > Median Diff with control p-value > FirstDrawCompletedTime 155.0ms -13.5ms (-8.71%) 0.000000 > SingleTabTitleAvailableTime 117.0ms -13.0ms (-11.11%) 0.000000 > FeedStreamCreatedTime 356.0ms -35.5ms (-9.97%) 0.000001 > FeedsLoadingPlaceholderShown 94.5ms -2.0ms (-2.12%) 0.007312 > FeedContentFirstLoadedTime 924.0ms -6.5ms (-0.70%) 0.034100 > > Bug: 1041865 > Change-Id: I640aaeb6f2dae64b9152fd94d0cd354a487f5bf5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372900 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809226} Bug: 1041865, 1131139 Change-Id: Ia56003e714389baed68c2af9df37f22b3cef32e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427874Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812430}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95c77a92cd84..af8e9f1e8115 2020-09-30 jalyn@microsoft.com Settings: Don't allow shortcut headers to overlap content 2020-09-30 vidorteg@microsoft.com Changing 'request blocking' to 'network request blocking' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130946 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic369df5f0806df5d713f142ac31339c3acdf89a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812429}
-
Brandon Wylie authored
This reverts commit 44803ec9. Reason for revert: Fixed already Original change's description: > Revert "Migrate remaining usages of ChromeActivityTestRule" > > This reverts commit fd165f29. > > Reason for revert: Failing build on ToT: > new ChromeActivityTestRule<>(ChromeActivity.class); > ^ > reason: cannot infer type-variable(s) T > > Original change's description: > > Migrate remaining usages of ChromeActivityTestRule > > > > Bug: 989569 > > Change-Id: If9f2bf207142253262bca092ca7dad6975893322 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437026 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811949} > > TBR=mthiesse@chromium.org,agrieve@chromium.org > > Change-Id: I5970dcbad4685e2ae423b0bf5bdcd8beb7b00396 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 989569 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441672 > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812334} TBR=mthiesse@chromium.org,agrieve@chromium.org,wylieb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 989569 Change-Id: Ifc9054d915cacdef40394661472aff4653b123a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441673Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Bluetooth operations are invoked on different threads from the ones which bound the SharedRemotes, so passing raw pointers could potentially cause deadlocks. This CL converts to using SharedRemotes directly to fix this issue. Bug: 1130069 Change-Id: I8a17b10f74c3d406138895c31ab5ff74dc12b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440981Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812427}
-
Elly Fong-Jones authored
This change: 1) Makes the behavior change described in this CL's title 2) Adds unit tests to cover that behavior 3) Makes RenderViewContextMenuMac constructable for testing purposes Bug: 853814 Change-Id: I0426f73a9dd828a96905bea8873010ad6e5025ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441657Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812426}
-
Joon Ahn authored
https://screenshot.googleplex.com/APf7nYKZJynGLbr Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ifde623fa4bc35c934b2d053629abcfde722eb4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439435 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#812425}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Starting with the historically most prolific cause of browser crashes from printing (GetPrinterSemanticCapsAndDefaults), work towards having support definitions to enable that query to be moved out-of-process. Start with a mojo definition for the printing::PrinterSemanticCapsAndDefaults::Paper structure, which is required for the larger query. Bug: 809738 Change-Id: Id7d52f131f8587b9edc50c8e1c4f8b6718998965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387409Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812424}
-
Brian Cui authored
This CL disables some tests in order to land the following DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436646 The test failures are caused by a string change in the Console counter title property. Example: "2 errors, 1 warning" will change to "Open Console to view 2 errors, 1 warning" Bug: 1133060 Change-Id: I9a08caca60dc3283ccf50e4669cf83803ee4ab0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441677Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812423}
-
Esmael El-Moslimany authored
Bug: 1131871 Change-Id: Ic88e6fba9226ed273aa028ef8a489c0f6e8e583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441008 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812422}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Id8b7299aa6fa0226ec16fc43d545ceb1e150a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437173Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812421}
-
Xi Han authored
The original CL got reverted because crbug.com/1132734: all the open tab heads are missing on tablet. The issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2392403. Original change's description: In this CL, we remove the check of stack tab switcher in TabUiFeatureUtilities#supportInstantStart(). Thus instant start can be enabled in MVP++. These changes can be verified by: - StartSurfaceTest#testShow_SingleAsHomepage_V2__Instant*. The following changes are made to support stack tab switcher in instant start: 1) Defer the creation of TabList in StackLayoutBase. It allows the StackLayoutBase/StartSurfaceStackLayout to be created pre-native. 2) Add pending observer list in TabModelFilterProvider. Any observer which is added before the TabModelFilterProvider is initialized, will be cached and notified when the initialization is completed. 3) StartSurfaceLayout and StackLayoutBase will create its SceneLayer if hasn't yet before calling updateSceneLayer(). Bug: 1116449, 1076449 Change-Id: Id8bc9153629a575ac6ef3728733d7945cc43b54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436618Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812420}
-
Russell Davis authored
Bug: 1131780 Change-Id: I3556016852284a7c7c2c64c22787747dfb420ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438634Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812419}
-
Ahmed Mehfooz authored
This CL changes the holding space bubble to use an AnchorRect instead of an AnchorView. This is to position it in the corner of the screen in a similar way to the system and media tray. Bug: 1131254 Change-Id: Idde8ff8071b1c01fcb0ba282957ece19c1a50c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439025 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812418}
-
Mike Wittman authored
Updates the ThreadProfiler configuration to consider a build to be a Chrome release if it's official and Chrome branded. The existing code only considered the Chrome branded state which is overly lenient. For what its worth breakpad uses the same conditions for whether it should be enabled. This changes behavior of edge cases as follows: Unofficial Chrome branded builds are now considered to be development/CQ builds and as such the profiler is always enabled for them. Official Chrome branded builds with unknown channel are no longer treated as development/CQ builds, so the profiler is disabled for them rather than always enabled. Bug: 1129939 Change-Id: I52b2120ef98734278ffd211809463c2ded3d3bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432386 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812417}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/810b74c0d7e4..492d4a85a2f0 2020-09-30 oksamyt@google.com Merge "[trace processor] Add Webview-only thread usage to WV power metric" 2020-09-30 taylori@google.com Roll trace processor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I775a1171821778c4b7752c89bad237684aa40ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441013Reviewed-by:
-
Eero Häkkinen authored
This fixes getUserMedia to select the correct camera when cameras support different PTZ controls (such as a zoom-only camera versus a pan-tilt-zoom camera). Spec: https://github.com/w3c/mediacapture-image/pull/261 Bug: 934063 Change-Id: I6162e1d3f26950151f91dca4ab14f4fa09f0964e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428975 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#812415}
-
Darin Fisher authored
This enables us to replace usage of mojo::SharedRemote and the thread pool usage with an ordinary mojo::Remote. This should be a performance improvement as it eliminates a hop through the thread pool. Adds usage of sequence checker to assert thread safety expectations. Change-Id: I93a681a2a6543fed417dcffbd0b43da121caddf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439559Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812414}
-
Matt Swartwout authored
Bug: 169598735 Test: None Change-Id: I86875685f252d46bc2a90a18b9d610594ec80f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436314 Commit-Queue: Matt Swartwout <mwswartwout@google.com> Auto-Submit: Matt Swartwout <mwswartwout@google.com> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#812413}
-
Owen Min authored
Create PolicyMapAndroid so that Java can get raw policy values based on policy names. Bug: 1127469 Change-Id: I2864b3e079d5a99227295db177d8dc54ae534abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432965 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#812412}
-
Anders Hartvoll Ruud authored
The current counting mechanism works if we "isolate" the changes to the counter at appropriate times: - When extracting features in a list. This is necessary to handle cases such as '.a + :is(.b + .c + .d + .e)', where feature extraction of the rightmost compound would yield max=3 (at the top level complex selector) without a reset. - When adding features to nested complex selectors. This is necessary to handle cases such as '.a + :is(.b + .c + .d + .e) + .f'. For .b, max should be 4, but for .a it should be 2. Hence mutations to the count made by nested complex selectors must remain local to that complex selector, and not leak upwards (or sideways, see comment near AutoRestoreMaxDirectAdjacentSelectors for a slightly different example). Bug: 568705 Change-Id: I0695dc944ec0aeee0ffa5d9a8d6ace3e238755b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435088 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812411}
-
Oystein Eftevaag authored
The non-allowlisted proto fields that caused this to flake should be allowed again now. R=ssid@chromium.org BUG=1008387 Change-Id: I829bc29e5e5d7fc9f4856c57f651f84c4bdfd1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436672 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#812410}
-
James Vecore authored
Previously the [Sync] mojo call to Accept was deadlocking. By switching over to a ShareRemote and using a deadicated task runner we can avoid the deadlock. ShareRemote is used to ensure the mojo is bound and run on the same sequence even though the remote is not actually shared. Fixed: 1133515 Change-Id: I44bc38ab8c3ddedcba02357c520d439ed7681c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439775 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Adam Langley authored
This change updates the previous, GATT-based code to use the new authenticator::Platform class. BUG=1002262 Binary-Size: This code ends up in a dynamic feature module, and so doesn't impact the main APK size. Also, the previous change (https://chromium-review.googlesource.com/c/chromium/src/+/2430324) deleted 13KiB of code so the delta isn't as large as it seems. Change-Id: I5ed395492ac440d7fdab6a13edfef7610da505f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436415 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#812408}
-
Zach Trudo authored
Previously DmServerUploader used a raw pointer of a std::vector of RecordHandlers owned by DmServerUplaodService. The vector could have died before the DmServerUploader was complete, this would have caused a runtime error. The vector has been replaced with a SharedVector that will survive until DmServerUploader is complete. Additionally, the SharedVector complicated the delay logic for resending records. This was found to be superfluous anyway, since the StorageQueue will resend on its own cadence. All retry and delay logic has been removed from DmServerUploadService. Bug: chromium:1078512 Change-Id: I60248a93ec1036562deaa9f42f30a0d9f90fbf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419753 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812407}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36477e478d39..e2764fee10f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,jianli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128762,chromium:1132894 Tbr: xidachen@google.com,jianli@google.com Change-Id: I3a6559b097826a769dd469038d669993749dc5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441707Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812406}
-
Nnamdi Theodore Johnson-Kanu authored
Requirements: - https://carbon.googleplex.com/cros-ux/pages/lte-setup/setup-dialog Screenshots: - https://screenshot.googleplex.com/9k9jbPVMqpn6tTY.png - https://screenshot.googleplex.com/BV2mY4zuwCq2drM.png - https://screenshot.googleplex.com/8Nq4yFZXQNtEu6q.png - https://screenshot.googleplex.com/WLvorXWMMzqmE5K.png Bug: Bug: 1093185 Change-Id: I16e7080d1e650a963910607164807292d5be4fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430298 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812405}
-
Jenny Zhang authored
Bug: 1119925 Change-Id: Ifd3b09d96bbe948f41347ef3723d0fa831e0d39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441198Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812404}
-
Christian Biesinger authored
There have been a number of spec changes in parsing aspect-ratio: https://drafts.csswg.org/css-sizing-4/#aspect-ratio https://drafts.csswg.org/css-values-4/#ratio-value In particular: - "auto <ratio>" is now a supported syntax, where the ratio is only used as a fallback if there is no intrinsic ratio - The ratio is now a non-negative number instead of a positive integer - The second component of the ratio is optional Note that I believe the last test in contain-intrinsic-size-valid to be incorrect; by my reading only the computed value should be affected, not the serialization. Note open issues: https://github.com/w3c/csswg-drafts/issues/5557 https://github.com/w3c/csswg-drafts/issues/5084 R=futhark@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668, 1083010, 1086606 Change-Id: Iba3588ed98beacd02f77f3bcc19e387b3add4a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437698Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#812403}
-
Jian Li authored
This reverts commit fbe2ef31. Reason for revert: Caused test failures at https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25664 Original change's description: > [smoothness] Revamp UKM reporting for smoothness. > > Set up a shared memory for the smoothness data, so that the renderer > can keep updating the data (which can happen many times every second), > without incurring cost of thread-hops from the compositor thread to > the main-thread, or IPC costs from the renderer process to the browser > process. > > https://docs.google.com/document/d/1E91V41tssxOhTjujaT7BoJ0A4TNabR7Vgd9k2eg7fMY/edit > > BUG=1115139 > > Change-Id: If4fe22035620faed3875f2026558cb5b03e62723 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393531 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812097} TBR=avi@chromium.org,sadrul@chromium.org,dcheng@chromium.org,rockot@google.com,skobes@chromium.org,bmcquade@chromium.org Change-Id: Ie006129febeaa21a90bafbc2b604dce46e869636 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1115139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441731Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812402}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I041b3ed90f74124b175fd7a1a506d2aea75feff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441334Reviewed-by:
-
Wenbin Zhang authored
Add a trace for the call to add_reserved_diagnostics to help debug. Bug: chromium:1133791 Change-Id: I2a94feda38d6de9f7be7992dacde064e2d1458b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441199 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812400}
-
Josh Nohle authored
A recent uprev of Nearby Connections introduced passing the fast advertisement service UUID into BleMedium::StartScanning(). (See its introduction in cl/332425345.) This can eventually be used to filter incoming Nearby BLE advertisements; the other argument to StartScanning(), service_id, is just a bare string like "NearbySharing", and therefore cannot be a filter. In this CL, we do the following: (1) Within BleMedium, use fast_advertisement_service_uuid as the actual UUID, not service_id. (2) Because BlePeripheral::GetAdvertisementBytes() still uses service_id as its lone parameter, pass the one-to-one map of service_id to fast_advertisement_service_uuid. With that mapping, the BlePeripheral::GetAdvertisementBytes() can understand which UUID to use given an input service_id. Fixed: 1131974 Change-Id: I7b245176930e803ea0524b9d77a794cd6cfbc504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436788 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by: -
Anastasia Helfinstein authored
This is a pure refactor. AX-Relnotes: n/a. Bug: None. Change-Id: Ie49ab8152b5fdd7b876dbf07346015c15717740a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391605Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#812398}
-
Xiaohui Chen authored
Previously ambient mode will trigger lockscreen on screen dimm and then rely on lock screen idle to show screen saver. This works in some cases, but in suspend case the time between screen dim and cpu suspend is too short. Screen saver was not able to enguage. The reason we have the set up is because the screen saver was sharing the same window constainer as the lock screen, it cannot show before lock screen is ready. Now screen saver has its own window container, we changed the flow to show ambient mode immediately when idle. This will prevent cpu suspend because screen saver will take a wake lock if charging. Screen saver will still lock the screen in the back if user reference indicated lockscreen after wake. Bug: b:169442907 Test: unitests and manual tests Change-Id: I1a5df2c58c976bba492c709e0a61dd5a6314d084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435334Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812397}
-
Roman Arora authored
Bug: 1133575 Change-Id: I0664480f31d008136f005f3ab44bd66ca40e0f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441333Reviewed-by:
-
Yue Ru Sun authored
Instead of blink Document generating its own UKM source id and calling the UKM API to associate the source id to the URL, move the source id generation to NavigationRequest and plumb it down through RenderFrameHostImpl to the blink::Document that will be created in the frame (when possible). UKM source is created when navigation successfully commits. Source creation for failed navigations are not in scope for this patch. In case of empty initial Documents and iframes without src, the blink::Document will still generate its own source id. Since they are not associated with any navigation nor represent real-world metrics, we are not interested in them. This moves the creation of Document-type UKM sources and the recording of "DocumentCreated" events from the renderer to the browser process. Bug: 1070793, 961847 Change-Id: I4820f98ec41fcd606dc31160c6d69c446554c742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163851 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812395}
-
Dave Tapuska authored
Remove unnecessary includes of web_float_rect.h Change-Id: I4f3ec23efc55358f3af74eca714410c68eaafcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431554 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812394}
-
Henrique Nakashima authored
Allow disk reads so the test running handleSynchronousStartup() does not trigger strict mode violations. Bug: 1131373 Change-Id: If3e0ccd0fa51c7f6a492bcf7793b40ee88e84d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441649Reviewed-by:
-
