GitLab

In debug builds, the callback parameters are validated. Since this value
is not sent on an alarm that doesn't exist, the validation fails.

The fix here is to make the parameter optional.

BUG=369636

Review URL: https://codereview.chromium.org/267723014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368728
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/261823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267972 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267971 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/257953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369703
TBR=bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/268803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369461

Review URL: https://codereview.chromium.org/260903019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267968 0039d316-1c4b-4281-b951-d872f2087c98

To help make test results more informative, updated AppInfoPermissionsTabTest to
use EXPECT and ASSERT in appropriate places. Future test failures will now halt
or continue correctly depending on the failed check.

Also added other minor cleanups to make the test easier to read/maintain.

BUG=368758

Review URL: https://codereview.chromium.org/265703010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267966 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements open_resource() in non-SFI mode.
1) Introduced a new sync message PpapiHostMsg_OpenResource
and its handlers.
2) Implement async version of OpenManifestEntry. As IPC's
handler is called on renderer's main thread, otherwise it
causes deadlock.

TEST=Run trybots.
BUG=358431

Review URL: https://codereview.chromium.org/249183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267962 0039d316-1c4b-4281-b951-d872f2087c98

From the kitkat-release branch - these are needed to compile hardware.c.

BUG=358029

Review URL: https://codereview.chromium.org/254683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267960 0039d316-1c4b-4281-b951-d872f2087c98

We seem to be reporting the whole memory limit as unreleasable. In
reality the memory limit shouldn't play a role in what we have
allocated, whether it is releasable or not.

BUG=369481
R=reveman

Review URL: https://codereview.chromium.org/266003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267959 0039d316-1c4b-4281-b951-d872f2087c98

We are removing notifications (NotificationService API) from InfoBar
code. And thus we need to migrate its uses to the Observer style.
This is what this patch does.

BUG=354380
TEST=browser_tests --gtest_filter=AutofillInteractiveTest.*
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/269543010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267958 0039d316-1c4b-4281-b951-d872f2087c98

> Support 8bpp screens in X11
> 
> Use Xrender to do the color conversion to 8bpp.
> 
> BUG=368425
> 
> Review URL: https://codereview.chromium.org/264903004

TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/267883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267957 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369703
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/265933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267955 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following CLs:

Fix bugs in intel-gcm-x86-masm.asm and re-enable the Intel AES assembly
code.
https://codereview.chromium.org/254213002

R=agl@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/266673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267954 0039d316-1c4b-4281-b951-d872f2087c98

This fixes \src\chrome\common\extensions\dos\server2\integration_test.py
failure under Windows.  Here, path_utils.py requires path with separator '/', but it's given separator '\\' in Windows and fails.

BUG=369510
NOTRY=true

Review URL: https://codereview.chromium.org/264793013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267952 0039d316-1c4b-4281-b951-d872f2087c98

gles2_cmd_decoder_unittest.cc has gotten too big and additional work is
causing build errors on Win64.

See CL https://codereview.chromium.org/262793002/ for example.

This change splits up gles2_cmd_decoder_unittest.cc into smaller logical
components.

BUG=369596

Review URL: https://codereview.chromium.org/268773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267951 0039d316-1c4b-4281-b951-d872f2087c98

Use Xrender to do the color conversion to 8bpp.

BUG=368425

Review URL: https://codereview.chromium.org/264903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267950 0039d316-1c4b-4281-b951-d872f2087c98

> Merge GeolocationDispatcherHostImpl with GeolocationDispatcherHost. None of the other message filters hide the internal in the cc file, and it just makes reading/modifying this code harder.
> 
> BUG=304341
> R=avi@chromium.org, mvanouwerkerk@chromium.org
> 
> Review URL: https://codereview.chromium.org/262753006

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/265043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267949 0039d316-1c4b-4281-b951-d872f2087c98

Merge GeolocationDispatcherHostImpl with GeolocationDispatcherHost. None of the other message filters hide the internal in the cc file, and it just makes reading/modifying this code harder.

BUG=304341
R=avi@chromium.org, mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/262753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267948 0039d316-1c4b-4281-b951-d872f2087c98

ResourceLoaderBridge was originally created to bridge code in //webkit that
talked to WebURLLoaderImpl (which talked to Blink) with code in
ResourceDispatcher in content which used IPC. Now that WebURLLoaderImpl
is in content/child, we don't need this interface anymore.

As requested by John in -
https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode42

BUG=265753,338338,237249
TEST=content_unittests
R=jam@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/226273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368917
TEST=Test player resumes playback after key added.
R=qinmin@chromium.org

Review URL: https://codereview.chromium.org/265793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267946 0039d316-1c4b-4281-b951-d872f2087c98

Previously GN did not write out any ninja code for deps and datadeps. This patch adds that and also documentation for how deps work for actions.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/265703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267945 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/265133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368713

Review URL: https://codereview.chromium.org/263703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267943 0039d316-1c4b-4281-b951-d872f2087c98

It was used to run the x-webkit-speech layout tests, which
have been removed.

This depends on Blink r173128.

BUG=223198
NOTRY=true

Review URL: https://codereview.chromium.org/268723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267942 0039d316-1c4b-4281-b951-d872f2087c98

Output the extension id as well as whether the experiment is enabled.

Review URL: https://codereview.chromium.org/267653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267939 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/260283002/ had different names.

NOTRY=true

Review URL: https://codereview.chromium.org/261753010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267938 0039d316-1c4b-4281-b951-d872f2087c98

The API has been considered deprecated for some time, and was disabled
in https://src.chromium.org/viewvc/blink?revision=171373&view=revision

BUG=223198
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/260903010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342884
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/269773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354034
TEST=build & unit_tests
R=derat@chromium.org
TBR=derat

Review URL: https://codereview.chromium.org/265813008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267934 0039d316-1c4b-4281-b951-d872f2087c98

Fix the copying of asan runtime. I'll try to come up with a more permanent
solution, but this should get the ASan buildbot going in the meantime.

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/263003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267932 0039d316-1c4b-4281-b951-d872f2087c98

Main CL https://codereview.chromium.org/266793002/

BUG=172527
TBR=mattm@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/269803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267931 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267930 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=18&start=14543
TBR=
BUG=

Review URL: https://codereview.chromium.org/261173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267929 0039d316-1c4b-4281-b951-d872f2087c98

Original commit here: https://codereview.chromium.org/251443006/. Was reverted because it wasn't triggering GC agressively enough, causing timeouts on the GPU bots.

BUG=365747
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/263523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267927 0039d316-1c4b-4281-b951-d872f2087c98

This change flips the default for deferred filters to true in Chrome, and changes
the enable command-line flag to a disable.

(The feature had already been force-enabled in Blink, but
this will allow us to disable it properly from Chrome.)

BUG=368265

Review URL: https://codereview.chromium.org/260383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267926 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds hooks to allow an outgoing message to be re-written just
before it is handed off to C++ for transmission.  I then build a simple
bit-flipping test based upon this to see how the C++ side stands up to
this (under ASAN).

Another small change is to pass the number of iterations from the C++ side so 
that there no longer is a need to keep two constants in sync with each other.

Another small change is to pull some of repeated code dealing with isolated
testing into its own function to avoid duplication.

The test is currently disabled pending the associated bug.  This does not
fix the bug but introduces a realiable repro for it.

BUG=366797

Review URL: https://codereview.chromium.org/250713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:368815
TEST=Tested manually on daisy

Review URL: https://codereview.chromium.org/260873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267924 0039d316-1c4b-4281-b951-d872f2087c98

These traces shouldn't ever be top level:
- "SyncChannel::SendWithTimeout"
- "ChannelProxy::Context::OnDispatchMessage"

One is sending an IPC (contained within RunTask), and one is
recieving an IPC that was forwarded (also contained within
RunTask).

This brings back the 'ipc' label for all ipc related
events, and just adds 'toplevel' to the one IPC trace that
is actually toplevel, "ChannelReader::DispatchInputData".

BUG=None.

Review URL: https://codereview.chromium.org/237113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267923 0039d316-1c4b-4281-b951-d872f2087c98