- 28 Jul, 2020 40 commits
-
-
Wolfgang Beyer authored
Change-Id: I185fd95debae1b80e578fbf061f076cd490938b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316866Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792165}
-
My Nguyen authored
This allows for tracking the opportunity for emoji suggestions. Bug: 1108251 Change-Id: Iffbf3b52f0abcde442e203a63c634e710765c6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318487 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792164}
-
Mathias Bynens authored
Downstream DevTools CL that impacts the expected results: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318257 No-Try: true Bug: chromium:1103854 Change-Id: I9ba181977ca662f53d8bbd35b3f2753eb3be859d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320612 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#792163}
-
Jan Wilken Dörrie authored
This change adds a wstring.mojom to chrome_cleaner, renames string16_embedded_nulls.mojom to wstring_embedded_nulls.mojom and makes WStringEmbeddedNulls an alias for String16EmbeddedNulls. Bug: 911896 Change-Id: I9fbf8cb4e0252eb21f66fc89610438da44bd9df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316357 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792162}
-
Yuki Shiino authored
Bug: 839389, 1108111, 1109761 Change-Id: I67612b91346b98e6503ebb693b45ce1d9f8f0306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320391Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#792161}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/LmieCUDR23kDvDwIcb-H4-WhIUhmeI0M330ACBOQZIYC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200727_RC00.html Bug: b/161847066, b/161687144, b/162047051, b/161959336, b/161405432, b/162183843 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iaf451beb875056c83daeb35fd98a852e8c6abd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320909Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#792160}
-
Avi Drissman authored
5d1c71c83e95 Update buildtools to 9e121212d42b and mini_chromium to 85e41f6b6cb5 6c96d8fb7809 fuchsia: Move crashpad_tests to injected-services 1a64e1cdc658 [fuchsia] Add tests group 13fd1561dc05 [fuchsia] Mark tests group testonly f9549d1ffefe [fuchsia] Avoid underscores in package names ad3ad354d3c9 android: fix executable name test e89ba0d1d66f linux: fix timer test 4ae896bad0af Migrate to OS_MAC and OS_APPLE in Crashpad This spuriously triggers on a test file that matches a regex of security-sensitive filenames; removing presubmit. Bug: 1105907 No-Presubmit: true Change-Id: I2f304b087ddafd851e6364c7b421d59bace9afcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321792 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#792159}
-
Katie D authored
Bug: 1108171 Change-Id: I037f79720373b1d5d948109bbc283aeea2b8807e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313379 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792158}
-
Sara Kato authored
crrev/c/2291552 changed focused node computation to remain unchanged if the adjusted node was invalid. However this meant that nodes with no name that should be focused, did not receive focus. Controls (such as seekbars), don't always have a name, but they should be focusable. This CL adds such a condition, to allow controls to receive focus. AX-Relnotes: n/a. Bug: b:160107299 Test: AccessibilityNodeInfoDataWrapperTest.controlIsFocusable Test: AXTreeSourceArcTest.ControlReceivesFocus Test: manual. Check that settings app does not have regression Test: tast run DUT_IP arc.AccessibilityEvent passes Change-Id: I562d70c319974d900b1d48afcc135e64f1181533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310219 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792157}
-
Shik Chen authored
Recently the spec is updated to require a successful getUserMedia() before running enumerateDevices(). Otherwise the deviceId and label fields would be empty. See https://crbug.com/1101860 for more details. Bug: 1103303, 1101860 Test: tast run <nocturne> camera.CCAUI* Change-Id: I61b4278d20720bf6424dada24a1d4e4b73f8c5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321907Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#792156}
-
François Degros authored
This will allow to mount encrypted ZIPs. Enhanced unit test FileManagerJsTest.VolumeManagerTest to check that the password is correctly passed by VolumeManager to chrome.fileManagerPrivate. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.VolumeManagerTest" Change-Id: Iaddff192feed91e1e42557c89618e2a18d2f1369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303413 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792155}
-
Jan Wilken Dörrie authored
This change extends the PasswordManager.TimeBetweenStoreAndServer histogram and swaps the roles of jdoerrie@ and battre@ as primary and secondary owner. Fixed: 1066050 Change-Id: I27f32491f786cbd4f19548e2a7a895a669e093d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320597 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792154}
-
edchin authored
Bug: 1099646 Change-Id: I2b88eb75acc48c02d58b3febdea380410a74861f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321213 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792153}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of local_frame_view.h by 1.64MB. This CL has no behavior changes. Bug: 242216 Change-Id: I97eb1498e7bb7cd40810e54f05ed99d8fa63faca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320711 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#792152}
-
Minoru Chikamune authored
blink::UserMediaProcessor::OnLocalSourceStopped() is called after ExecutionContext was destroyed. In this case, blink::LocalFrame::GetBrowserInterfaceBroker() will access to LocalFrame::client_, and it will be null already and it will cause a crash. To avoid the crash, this CL checks the Frame::Client() doesn’t return null. Bug: 1105842, 1049056 Change-Id: Idc942b4a59b6d0e220bd58dfeb4a53df0730dca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318502Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#792151}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee995bcb..f31e5f45 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibaf02f3169f30fdebc17ae5f153fcfd57745d908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321449Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792150}
-
Kai Ninomiya authored
And: - Deprecates mapReadAsync, mapWriteAsync, and createBufferMapped. - Updates one other usage of the old mapping API. - Add GPUBufferUsage.QUERY_RESOLVE for compatibility with tests I'm writing. Bug: 1069302 Change-Id: I4710883d6ae1f66d3cd0f8216bc335d1e751472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299538 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#792149}
-
Charlie Harrison authored
Right now the conversions UI just looks at presence / absence of the ConversionManager to determine whether the feature is enabled. This isn't enough since we allow the embedder to disable at run-time. Bug: 1109987 Change-Id: Icf0622e5c21bba2a4995ba0dbde4a8ae5bf76e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321238Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#792148}
-
Xianzhu Wang authored
Most of the code is copied from perf_tests/paint/select-all-words.html Change-Id: I3d231a67f8162ac3145f070df38875de1a72dfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321233 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792147}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1d870649dd5..43f111af3540 2020-07-27 primiano@google.com install-build-deps: clean node_modules when updating node 2020-07-27 dproy@google.com build: Update the nodejs version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Test: Test: manual on mac Change-Id: I009e5610e8fc3793d7832ab5eaf6374e5c64f706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792146}
-
Brian Sheedy authored
Re-enables the Telemetry minidump symbolization tests on CrOS Betty devices, as the failures that caused them to be disabled appear to no longer be an issue. Bug: 1038043 Change-Id: Ibe335c60cb85ed29bd478dbfe6369d7e40d5c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321402Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792145}
-
Avi Drissman authored
If another channel of Chromium is already default, don't ask to become default. Bug: 1109417 Change-Id: I095410b47a64731c7ca7fbafa5f3e3427ec89d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318193Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792144}
-
Ben Schwartz authored
This hides all the server choice fields when "Choose another provider" is not selected. It also adjusts the label and removes the bottom horizontal line, as requested. Bug: 1106095 Change-Id: Ib362f5f2507235dd63c76d1fd857943425bb7f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320131Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#792143}
-
Sicheng Li authored
1. Adds the CustomTabOrientationController in SharedActivityCoordinator 2. Calls the setCanControlOrientaton() in the SharedActivityCoordinator#updateUi() 3. Implements the CustomTabOrientationController#setCanControlOrientaton() 4. Modifies the method of mapping orientation from AndroidX (convertOrientationType()) to chromium as we now take int as parameter instead of String 5. Imports ScreenOrientationLockType class to handle lock type 6. Adds a method as ScreenOrientationProviderImpl#setOverrideDefaultOrientation() to get the default screen orientation lock for TWAs or WebAPKs. Bug: 812797,989606 Change-Id: If07122814a7ca0e68f40fa70d9df24c68e3c5ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276255Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Sicheng Li <scli@google.com> Auto-Submit: Sicheng Li <scli@google.com> Cr-Commit-Position: refs/heads/master@{#792142}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia859e9e047f269cc301f938cfdb14ba1618757b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321968Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792141}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0307e9114c30..b3038f8cb5c5 2020-07-28 johnstiles@google.com Remove layout(key) support for rects and points. 2020-07-27 johnstiles@google.com Update DataEntry struct to properly support move semantics. 2020-07-27 johnstiles@google.com Allow GLSL processor keys to use floats with full precision. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Idd39a70ff7f79e56292c7d166b9f04a000ecc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792140}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/478f7fed94ec..0dde0b31cf31 2020-07-27 kahinds@microsoft.com Convert localized URL-only strings to normal strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10a6cd911f113480c1b096210b181a906cdfacea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792139}
-
Chris Harrelson authored
Tables always paint collapsed borders, even if the rows are seprately composited. While we don't need to invalidate paint for the table (because the row is the DisplayItemClient for the borders), we do need to cause repaint for its painting layer, because the table paints those borders. See also (*), which removed the code that previously had the same effect. There was previously no test for this code. (*) https://chromium-review.googlesource.com/c/chromium/src/+/2317848 Change-Id: I269101d3bf28445c0ec3d1f6bcad1a23cf3e46d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321234 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792138}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9f2af40de2705fb07dc0ef18aba665ea26564b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321826 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#792137}
-
Mike Wittman authored
Supports alignment of pointers without forcing users to employ the casts required to use the existing functions. Enables only for pointers to 1 byte types (e.g. uint8_t/char) to avoid ambiguity about whether alignment is measured in bytes or sizeof of the pointed-to type. Updates code to use the new functions. Change-Id: If196122876c7e753b3faaa116fdf1874d8cf1db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300342 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792136}
-
Siyu An authored
Bug: 1095037 Change-Id: I456518658b6d2f3f1609947269aed5cce58f503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321108Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#792135}
-
Yuke Liao authored
Exclude ui_base_unittest from linux lacros builders due to a compile failure. Bug: 1110072 Change-Id: Ia228c2d6959d4821c2258d68bccb0a34d02bf02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321244Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792134}
-
Hitoshi Yoshida authored
This reverts commit 662e18cb. Reason for revert: This CL seems to be a trigger of a test failure on Mac. Bug: 1110172 Original change's description: > Don't use constrained dialogs for macOS certificate viewer. > > Instead parent the sheet to the specified gfx::NativeWindow directly. > This avoids a host of bugs around the native constrained dialogs > machinery, but does mean the dialog is now window-modal rather than > tab-modal. On Windows, where we also use the native dialog, the sheet is > similarly window-modal and the certificate viewer only ever opens in > response to the user clicking in browser-owned UI or DevTools, so there > shouldn't be an abuse concern. > > See https://crbug.com/1098786#c4 > > Bug: 762915, 1078158, 1098786 > Change-Id: Iafeee58fd04aff9f8b88e8c2f030fe18913f81f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313160 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791907} TBR=ellyjones@chromium.org,davidben@chromium.org Change-Id: I8e29389c8a609daeed12b13d50b3d8d27f8959d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762915 Bug: 1078158 Bug: 1098786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320913Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#792133}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/308078b0ca18..52d2563373fa 2020-07-27 jmadill@chromium.org Disable GPU time tracking in trace tests. 2020-07-27 cclao@google.com Vulkan: Add cache for driver uniform descriptor set 2020-07-27 syoussefi@chromium.org Vulkan: Fix render target's tracking of content defined 2020-07-27 m.maiya@samsung.com Vulkan: Enable VK_KHR_get_memory_requirements2 extension 2020-07-27 cclao@google.com Vulkan: Increase default uniform buffer size to 64K If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Ic92250b699dbe1d32b115681723177412599d520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792132}
-
John Williams authored
Bug: b/161609791, 1107157 Change-Id: I66010e578d8f7541134c5f80bb7b194fdeb9b42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310903Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#792131}
-
Hitoshi Yoshida authored
This reverts commit 7ec7300a. Reason for revert: This CL still breaks interactive_ui_tests. See crbug.com/1110181 for the details. Bug: 1110181 Original change's description: > Reland "Add pixel browser tests for focus rings" > > Original Patch: https://chromium-review.googlesource.com/c/chromium/src/+/1986972 > Revert: https://chromium-review.googlesource.com/c/chromium/src/+/2148472 > > The original patch was reverted for three reasons: > 1. android-pie-x86-rel had slightly different pixel output. I am > addressing this with a fuzzy pixel comparator, and the bot passes in > "Choose Tryjobs". > 2. android-arm64-proguard-rel started failing, and surprisingly it > showed that it was using the linux baseline as the expected output. > This must have happened because I left in the logic for separate > marshmallow baselines but didn't provide a separate marshmallow > baseline. This shouldn't happen again now that I removed the check > for a separate marshmallow baseline. Unfortunately this bot does not > appear in "Choose Tryjobs," but I am confident that at the very least > the bot will not fail again for the same reason. > 3. Focus rings on different macos versions have different colors. I > fixed this in http://crrev.com/786769 and verified that it works by > running tests on the various macos bots available in "Choose Tryjobs" > > This patch also implements the suggestion crbug.com/1091661 and > re-enables the tests disabled in that bug. > > In the original patch, I made a new file called screenshot_test_utils, > but I found another function in browser_test_utils which does the same > thing, so this patch doesn't have screenshot_test_utils anymore. > > Bug: 1038425, 1022122, 1039866, 1091661 > Change-Id: Ic1642179bd3ca659f3b4b1f3a25c86a719518ede > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150765 > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792092} TBR=avi@chromium.org,sky@chromium.org,vmpstr@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I33f8898677410e7674d2f396c5c29e507c52d0a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038425 Bug: 1022122 Bug: 1039866 Bug: 1091661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322006Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#792130}
-
Dominic Farolino authored
As per typical Chromium style, we separate system includes from intra-project includes. This CL fixes that for resource_loader.cc in Blink. Bug: N/A Change-Id: I6a64b76862df1c41b0e4f9be5ebabd3660c86a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321250Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#792129}
-
Matthew Denton authored
Glibc 2.32 (development version) registers rseq on thread startup. Because libraries' ELF constructors may see that rseq is registered, and it is unclear that libraries should have to deal with rseq deregistration, just allow it globally. Otherwise rseq registration status will be out of sync between threads which could cause unexpected issues. Hopefully different parts of Chrome will leverage it for fast per-cpu data. Bug: 1104160 Change-Id: I3f93ee598004910ffde46ee782ba60b6201ae8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298525 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792128}
-
Rakina Zata Amni authored
Finishes the move of WebPreferences to WebContents that started in crrev.com/c/2263635 by moving OnWebkitPreferencesChanged, ComputeWebPreferences, SetSlowWebPreferences to WebContents. AX-Relnotes: n/a Bug: 1085003 Change-Id: I0a9973245f29d0fad785d279eecdc6c239b0f897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266917Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#792127}
-
Mike Dougherty authored
On iOS 14, when set as default browser, Chrome can receive http and https URLs directly from system and third party apps. Extend the metrics to capture this case separately from the default case where the source application is unknown. Bug: 1101058 Change-Id: Ieb269be5d93d00c07e23e25d366037667d986cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315199Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792126}
-