GitLab

The comment for ReadRawData reads:
  // If returning true, data was read from the job.  buf will contain
  // the data, and bytes_read will receive the number of bytes read.
...
  // If returning false, an error occurred or an async IO is now pending.
  // If async IO is pending, the status of the request will be
  // URLRequestStatus::IO_PENDING, and buf must remain available until the
  // operation is completed.  See comments on URLRequest::Read for more info.

I interpret this to mean that an implementer should never set status to IO_PENDING and return true, but that's what the slow download job does:
...
    SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
    DCHECK(!is_done());
    return true;
...

Unfortunately this class is part of the Download UI tests which are already flaky/broken so it's not possible to verify that this change doesn't further break those tests. But the current implementation is clearly broken and should be fixed.

BUG=50399
TEST=ran ui_tests, verified no additional breakage

Review URL: http://codereview.chromium.org/3052016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53876 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3007014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53875 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53874 0039d316-1c4b-4281-b951-d872f2087c98

DOMUIThumbnailSource objects are deleted on the IO thread, while they are used
on the UI thread. The DataSource documentation says that they should not live
on the IO thread, but for almost all DataSources, the only reference held is
the one by ChromeURLDataManager, which lives on the IO thread. Since I had a racy
stack where the object was being used on the UI thread while its destructor was
running on the IO thread, forcing destruction on the UI thread should fix
the crash.

Pretty much everything but changing the templated base class of DataSource to
always DeleteOnUIThread is my usual cleanup.

BUG=34115
TEST=none

Review URL: http://codereview.chromium.org/3061009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53873 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a host of seeking, synchronization and layout test issues but does incur a CPU performance hit while seeking.  In the worst case a seek could take quite some time if the content was high resolution H.264 and we attempted to seek to right before a keyframe.

We'll see how people like the new behaviour and back this change out if needed.

BUG=48984
TEST=layout tests, media_unittests

Review URL: http://codereview.chromium.org/3032030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53872 0039d316-1c4b-4281-b951-d872f2087c98

IDs, but also force IS_UNAPPLIED.

This allows BV to be valid in case the item is marked UNSYNCED and later commits,
but still allows the update application to proceed if it's not.

BUG=49715
TEST=See bug

Review URL: http://codereview.chromium.org/3054021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53871 0039d316-1c4b-4281-b951-d872f2087c98

Add new search engine logos to template url data.  This CL also reorganizes the way logos and search engine type data are stored.  Because the search engine dialog is no longer an experiment running on few locales, move the data and logos into the template_url_prepopulate_data for each search engine.

BUG=42612
TEST=search engine dialog works as expected.

Review URL: http://codereview.chromium.org/3040022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53870 0039d316-1c4b-4281-b951-d872f2087c98

Add new images for M6 theme changes.  This is done separately so that the code changes that use them can be run on the trybots.

TBR=ben
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3013037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2847079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Make sure interactive_ui_tests can build on OS X 10.5 correctly.

Review URL: http://codereview.chromium.org/3046027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=thestig

Review URL: http://codereview.chromium.org/2009004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53864 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=should work exactly the same

Review URL: http://codereview.chromium.org/3069006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53862 0039d316-1c4b-4281-b951-d872f2087c98

Both libxml and its direct dependencies need to define
LIBXML_STATIC when libxml is a static library.  Right
now it is necessary to define this macro only on Windows,
but the macro is intended to be cross-platform.

R=evan
BUG=50048
TEST=Windows build log should not contain "locally defined
symbol XXX imported" linker warings such as:
libxslt.lib(numbers.obj) : warning LNK4049: locally defined symbol _xmlFree imported
Review URL: http://codereview.chromium.org/3063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53861 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3047004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53858 0039d316-1c4b-4281-b951-d872f2087c98

Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs.
Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed.

BUG=48713
TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs.

Review URL: http://codereview.chromium.org/3046025

TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/3058018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53857 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3059005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53856 0039d316-1c4b-4281-b951-d872f2087c98

o3d-webgl: Adjusting Sampler to throw an error if client attempts to use BORDER as uv address mode (not supported in WebGL).
Review URL: http://codereview.chromium.org/3038014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53855 0039d316-1c4b-4281-b951-d872f2087c98

This could be caused by http://trac.webkit.org/changeset/64124/trunk.
Created a bug and assigned to pfeldman to investigate.

TBR=pfeldman
BUG=50416
TESt=unit test passes


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53854 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a small typo; reported in: http://groups.google.com/group/o3d-discuss/browse_thread/thread/db4be6e10594af70?hl=en
Review URL: http://codereview.chromium.org/3045017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53853 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53852 0039d316-1c4b-4281-b951-d872f2087c98

Also, the old method of passing around a pointer was not safe due to
object lifetime issues.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53851 0039d316-1c4b-4281-b951-d872f2087c98

BUG=37201
TEST=net_unittests.exe --gtest_filter=NetUtilTest.IDNToUnicode*
Review URL: http://codereview.chromium.org/3011012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53850 0039d316-1c4b-4281-b951-d872f2087c98

Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs.
Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed.

BUG=48713
TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs.

Review URL: http://codereview.chromium.org/3046025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Verify that the internal PDF plugin is disabled by default.s

Review URL: http://codereview.chromium.org/3052015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3058011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53847 0039d316-1c4b-4281-b951-d872f2087c98

Extension functions should be allowed to make repeat requests to external protocol handling without needing a user gesture (see bug). This allows them to do so (and changes the method name for clarity).

BUG=39178
TEST=NONE

Review URL: http://codereview.chromium.org/2884040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53846 0039d316-1c4b-4281-b951-d872f2087c98

Adds awareness of kAutoFillAuxiliaryProfilesEnabled preference to |OptionsUtil::ResetToDefaults()|, which is used to reset preferences from the "Under the Hood" / "Reset to Defaults" button.

BUG=49873
TEST=AutoFillManagerTest.AuxiliaryProfilesReset

Review URL: http://codereview.chromium.org/3054019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53845 0039d316-1c4b-4281-b951-d872f2087c98

The logic is taken from firefox.

BUG=48346
TEST=unit tests; downloading the same .tar.gz file multiple times (see bug)

Review URL: http://codereview.chromium.org/3018011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53844 0039d316-1c4b-4281-b951-d872f2087c98

during the review of r49350).

BUG=none
TEST=recompiled

Patch from Mihai Parparita <mihaip@chromium.org>.

Review URL: http://codereview.chromium.org/2854060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=Run chrome --lang=he, click the wrench; the button and dropdown should align on the left edge, not the right.
Review URL: http://codereview.chromium.org/3017033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53842 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove pointless GetInsets() override.  Simplify |container_size_| to just be |container_width_|.  Fix indenting/alignment, especially of function parameters.  L"" -> std::wstring().  Don't handle assertion violations (style guide/simplicity).  Reduce indenting via early-return or simpler-path-return.  Streamline code where possible.  Definition order should match declaration order.  EXPECT_STREQ -> EXPECT_EQ.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3076001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53841 0039d316-1c4b-4281-b951-d872f2087c98

This CL includes:
1. Implementation of ui_test_utils_mac.mm
2. Fix for ui_controls_mac.mm
3. Port browser_keyevents_browsertest.cc to Mac and add some new tests for Mac.
4. Partially port browser_focus_uitest.cc to Mac, now can be compiled and run
on Mac but some tests fail.
5. Add two functions into ui_test_utils.h: HideNativeWindow() and
ShowAndFocusNativeWindow(). The latter one shows a window and grabs the input
focus, which is useful for tests depending on fake keyboard/mouse events.

Because browser_keyevents_browsertests.cc and browser_focus_uitest.cc
belong to interactive_ui_tests, which is not available on Mac (see
http://crbug.com/21276), in order to test them on Mac, you may want to
move them into browser_tests locally. But it won't work on build and try
bots, because these tests must be run with screen unlocked.

This CL depends on CL: http://codereview.chromium.org/2973004
and http://codereview.chromium.org/2805075

BUG=22515 Keyboard handling needs unit tests
BUG=48671 interactive_ui_test: BrowserKeyEventsTest.NormalKeyEvents is flaky
BUG=48936 Browser window is opened inactivated when running an InProcessBrowserTest.
TEST=none

Review URL: http://codereview.chromium.org/2986004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47883
TEST=manual (turning network connection off and on)

Review URL: http://codereview.chromium.org/2809056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53839 0039d316-1c4b-4281-b951-d872f2087c98

with a weak pointer to avoid crashing at shutdown.

BUG=50082
TEST=net_unittests

Review URL: http://codereview.chromium.org/3054012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53838 0039d316-1c4b-4281-b951-d872f2087c98

Avoid printing log errors during shutdown of HostResolverImpl when there are still requests outstanding.
BUG=49692
Review URL: http://codereview.chromium.org/3023011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53837 0039d316-1c4b-4281-b951-d872f2087c98

xib changes: Add menu item with shortcut cmd-f10 for now, connect it to -commandDispatch:. Connect app controller's new outlet to the new menu item.

BUG=50307
TEST=No changes by default. If --enable-expose-for-tabs is passed, a new menu item should be visible below "prev tab" in the window menu. It should be active for normal browser windows and fullscreen windows, but not if there are no browser windows around or if the current window is a popup window or a non-browser window (e.g. prefs). Clicking the menu item doesn't do anything yet. cmd-f10 should trigger the menu item, but it shouldn't if the cmdline flag isn't passed.
TEST2=Go to a page that is busy spinning some javascript (e.g. "javascript:while(1);"), give it focus, hit cmd-f10. Menu should blink immediately.

Review URL: http://codereview.chromium.org/3020035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53833 0039d316-1c4b-4281-b951-d872f2087c98

We would like to refine the numbers we started off with in the first experiment (then set to [4, 6, 8, 16] connections -- see http://codereview.chromium.org/2658006). Overall, 16 connections did not compare favorably to either 6 or 8 connections. At this point we'd like to modify and narrow down our range to span 5 to 9 connections.


r=jar
BUG=44491

Review URL: http://codereview.chromium.org/3077001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53832 0039d316-1c4b-4281-b951-d872f2087c98

Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.

r=jar 
BUG=47469



Review URL: http://codereview.chromium.org/3032024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53830 0039d316-1c4b-4281-b951-d872f2087c98