- 15 Jan, 2020 40 commits
-
-
Matthew Denton authored
Bug: 983009 Change-Id: Ie285c4035bfc4c45e27e5f3fd6c34280d9f4c2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001943Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#732131}
-
Sahir Vellani authored
Currently the mouseUpAt function in gesture-util.js does not work, despite being called after mouseDownAt. This behaviour occurs due to SyntheticMouseDriver::UserInputCheck (last_modifiers_ does not match web mouse event modifier. Furthermore, x and y arguments passed in to mouseUpAt would not be used because SyntheticMouseDriver::Release would not take the coordinates. This change fixes the aforementioned issues by adding pointerMove to mouseUpAt and setting click count to 1 in SyntheticMouseDriver when only release is called. Bug: 979408 Change-Id: Ic63637e0533b6f69d703b6954156f58e050897ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904748 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732130}
-
Kush Sinha authored
Extend |ChildAccountReconcilor.ForcedUserExitOnReconcileError| histogram's expiry by 1 year. Bug: 1041518 Change-Id: I7c8519eee57cc1198577cad580451df458cd13d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000621Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#732129}
-
Peter Boström authored
This removes the need to call OnAnchorBoundsChanged from View::OnBoundsChanged overrides. Note that the screen bounds of a View may still change for other reasons (such as the Window moving). Bug: chromium:1016968 Change-Id: Ia59b72da3102842fa81179cc73a9566d09ae300c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874711Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732128}
-
Peter Kotwicz authored
This CL fixes a regression introduced by the "split cache" feature where WebApkIconHasher no longer uses the icon cached via ManifestIconDownloader earlier in the WebAPK install process. The regression is fixed by setting the network_isolation_key on the content::ResourceRequest BUG=1036372 TEST=WebApkIconHasherBrowserTest Change-Id: Ia82ace8d6f2bf70ab5bf8f79c9b2216a03cc8af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998821 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732127}
-
Rune Lillesveen authored
There were a couple of instance where we serialized the AtomicString as an identifier without taking necessary escaping into account. This is fixing serialization for :state(), :lang(), and unrecognized ::-webkit-* pseudo elements. Bug: 1042181 Change-Id: Ic0ca090bb57798f2905e360a0c5728a303dab3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002609Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#732126}
-
Nicolás Peña Moreno authored
Currently we do not dispatch LCP when the paint timestamp is 0 in order to fix crbug.com/1017335. However, this means that update methods are never called when the timestamp is 0, which can occur when the largest image detected so far has not yet finished loading. This CL fixes this by dispatching updates even when the timestamp is 0, but being more careful to not report UMA/UKM when the timestamp is 0. In addition, subframe logic is a special case where navigation offsets may be added, so the case where the timestamp is 0 is handled as a special case. Bug: 1033950 Change-Id: I48832437aab153eb27fdfaeaca3fefd669c4501a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998826Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#732125}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/86f730971751..ffdd58f5c0bf git log 86f730971751..ffdd58f5c0bf --date=short --first-parent --format='%ad %ae %s' 2020-01-15 artyom@fb.com Fixing OVR_multiview and OVR_multiview2 issues Created with: gclient setdep -r src/third_party/angle@ffdd58f5c0bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: Ie16e346b48c0a569abf11b3a3129fa13161261eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732124}
-
Sven Zheng authored
This cl should have no affect for fake server. gtest_filter and passing/total number: -USS/TwoClientPasswordsSyncTest.*E2ETest* (115/120) -TwoClientSearchEnginesSyncTest.*E2ETest* (78/80) -TwoClientSessionsSyncTest.*E2ETest* (20/20) -TwoClientThemesSyncTest.*E2ETest* (40/40) -TwoClientTypedUrlsSyncTest.AddThenDelete_E2ETest (10/10) -TwoClientTypedUrlsSyncTest.DisableEnableSync_E2ETest (10/10) -TwoClientAutofillProfileSyncTest.DISABLED_E2ETest_TwoClientsAddAutofillProfiles (10/10) TEST: Run test 10 times with no retry. Bug: 1010568 Change-Id: Iacdb0480b7518806f7a3ff6c901690f4b19ae18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994907 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732123}
-
Victor Vasiliev authored
This way, the datagrams have a small time-limited buffer that allows them to work nicely with pacing. R=yhirano@chromium.org Bug: 1011392 Change-Id: Iad925e4755d550ef352901145b651eff70e35228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001233Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#732122}
-
Jiaqi Han authored
The GPU process crash when using headless ozone platform, as the GPU process tries to access OverlayManager that is not initialized. Disable overlay for this unittest by setting an empty --enable-hardware-overlays flag for overlay strategies. Bug: b/145926049 Test: cast_shell_browsertests Change-Id: Ia5737bb227023cb9163a688da8553ce24eeedc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003210Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Jiaqi Han <jiaqih@google.com> Cr-Commit-Position: refs/heads/master@{#732121}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6a9868686ae..cc93308cee32 git log e6a9868686ae..cc93308cee32 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 janscheffler@chromium.org Allow editing of cookies in table 2020-01-15 aerotwist@chromium.org Migrates text_editor/ to ESM internally 2020-01-15 aerotwist@chromium.org Migrates security/ to ESM internally 2020-01-15 aerotwist@chromium.org Switches extensions and console_counters to legacy versions in root 2020-01-15 aerotwist@chromium.org Migrates source_frame/ to ESM internally 2020-01-15 aerotwist@chromium.org Migrates search/ to ESM internally 2020-01-15 petermarshall@chromium.org [fix-it] Add more unittests for TextUtils.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@cc93308cee32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6c89be79e6becb58ea04ad4b49fbe55230cc9a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002837Reviewed-by:
-
Henrique Nakashima authored
The method is now unused since downstream code is calling RevenueStats#markRlzNotified(). Bug: 1022108 Change-Id: I859bbbd242aa5d579465453721a957620932e205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997649 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#732119}
-
Toni Barzic authored
Simplifies the AppListController API for toggling app list state by folding OnHomeButtonPressed logic into ToggleAppList (OnHomeButtonPressed contained tablet mode specific logic for showing app list, and defaulted to ToggleAppList in clamshell). Updates AcceleratorController to toggle app list by calling AppListController directly, instead of simulating press on the home button - thus removing direct dependency on HomeButton (which might not be set when feature to remove shelf control buttons in tablet mode is implemented and enabled). Removes logic to update ink drop when home button is pressed from HomeButton - instead makes logic for setting ink drop on app list visibility changes in HomeButtonController work for this case (clicking the home button), too. BUG=1012814 Change-Id: Ib775fdc0beb13114e00a133226e1815eb5bafb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999751 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732118}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I8cc7fde8e56a66f75b0e0adf4db11171340e6412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992509 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#732117}
-
Saman Sami authored
Since |evdev_cursor_| is bound on the evdev thread, we need to make it also gets destroyed on the evdev thread. Bug: 620927,1039834 Change-Id: Idd64f5e7b3ee412dcfd3f0a61fedce7f6f12e53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001064 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#732116}
-
Dan Beam authored
R=dpapad@chromium.org Bug: 1028829 Change-Id: Ifbe52d54e1c578ae2947317fe8022a75bb3300fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995802 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732115}
-
Stephan Hartmann authored
listformatter.h was moved from icuuc to icui18n Bug: 989153 Change-Id: I9fcb56f6d5af7787f34ea99b737e2ed8fe741c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000142Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#732114}
-
Rodney Ding authored
Bug: 775189 Change-Id: I29d8288d707157a09a12b695b2fd47e7cc40c6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994096 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#732113}
-
Roberto Carrillo authored
This reverts commit fe842ad4. Reason for revert: This seems to have introduced a crash in linux-chromeos-dbg. See crbug.com/1042349 Original change's description: > Update and clarify view ownership for app-list views. > > Bug: 648382 > Change-Id: I0d000accee686dd67b2db1e14cea20ff893835c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001399 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732019} TBR=kylixrd@chromium.org,newcomer@chromium.org Change-Id: I0eb8c79817cb992ae915de2af4f2a2e669e0bd3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 648382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003076Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#732112}
-
Thomas Lukaszewicz authored
Added a label color update method to IconLabelBubbleView that is called OnThemeChanged() and also when LocationIconView's Update() method is called. This is necessary as the LocationIconView may switch the foreground color to red in the presence of a security context change, not necessarily only during a theme change event. Bug: 1042090 Change-Id: Ib0004bd519abfbf3ab27102b6304e9a9f75ec4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002855 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#732111}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b24c3d92df5..0c66bcd13a54 git log 2b24c3d92df5..0c66bcd13a54 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 enga@chromium.org Reland "Metal: Add CommandRecordingContext" 2020-01-15 rharrison@chromium.org Switch over to using CheckSpvcSuccess where possible 2020-01-15 rharrison@chromium.org Rolling 2 dependencies 2020-01-15 cwallez@chromium.org Add a proper license to webgpu.h's template. 2020-01-15 rharrison@chromium.org Return errors in ExtractSpirvInfo instead of sending to the device 2020-01-15 cwallez@chromium.org Introduce wgpu::Surface and implement it for HWND, X11 and Metal Created with: gclient setdep -r src/third_party/dawn@0c66bcd13a54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I31b9439f2b75aa9adb098853aeef4fc74effced6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002838Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8e0880b3003..4175d400f36f Created with: gclient setdep -r src-internal@4175d400f36f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1019796,chromium:1040973 Tbr: jbudorick@google.com Change-Id: Id114ffb3a0f5137a3c602afa9fed0eb368dd09a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003111Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732109}
-
Haiyang Pan authored
Bug: 1012776 Change-Id: Ief7d2bb5877b83de53f9c03273b254c42e364310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995876Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#732108}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity use TwaFinishHandler - Moves WebAPK specific logic to TwaFinishHandler - Moves setting of TwaFinishHandler#setShouldAttemptFinishingTask() to SplashController BUG=1041647 Change-Id: I1ec3964e0a28532a7d338e508cf6f2776f3584de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999326Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732107}
-
Vasiliy Telezhnikov authored
In ExternalBeginFrameSource::AddObserver we send OnBeginFrameSourcePausedChanged and missed BeginFrame for new observer. If this observer was first one, ExternalBeginFrameSourceClient::OnNeedsBeginFrames(true) will be called, which can change the paused status. This CL moves call to OnNeedsBeginFrames before adding new observer to the list to avoid calling OnBeginFrameSourcePausedChanged twice. Change-Id: I04ddbf489ceb67244600d113c5dd12ec3b743c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003288Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#732106}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=flackr@chromium.org Bug: 1041419 Change-Id: I7ff5060ebb5b369c81513b25dd9da6bb148a6c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994076 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732105}
-
Alex Newcomer authored
Don't use in-app shelf insets in this case because in-app shelf does not exist in the login screen. Bug: 1035207 Change-Id: I3cf89db8146d69fc8ed9565c1e131bc14e966777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001997Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732104}
-
Kyle Horimoto authored
Also remove hsuregan@ and jordynass@ who no longer work on these areas. Change-Id: I22a543609a84bbef67e72059c1e5ab8a85a0587c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002831 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#732103}
-
Josh Nohle authored
The primary device identifier in CryptAuth v2 DeviceSync is the Instance ID. The (soon-to-be) legacy device identifier is the device's encoded public key, given by RemoteDevice::GetDeviceId(). In v2 DeviceSync, device public keys come end-to-end encrypted and might not be readily available. During the migration to v2 DeviceSync, we need to support both identifiers. Even after v2 DeviceSync is rolled out, we will continue to use the legacy device identifier in multi-device applications like Smart Lock and Instant Tethering--the legacy ID is baked heavily into those code bases. Consequently, the RemoteDevice caches now need to support lookup and storage by both the Instance ID and the legacy device ID. In this CL, the RemoteDevice caches key devices by Instance ID and legacy device ID, RemoteDevice::GetDeviceId(). Concretely, we replace the map from legacy device ID to shared RemoteDevice pointer with a vector of shared RemoteDevice pointers. We search this vector for either a matching Instance ID or legacy device ID. All devices in the cache will have a unique Instance ID, if one exists, and a unique legacy device ID, RemoteDevice::GetDeviceId(), if one exists. Every device is guaranteed to have at least one non-trivial ID. If a device is added with either ID matching an existing device, the existing device is overwritten. Here are a few scenarios that require storage/look-up by multiple IDs: - A v1 DeviceSync device that does not have an Instance ID. - A RemoteDevice cache built in the EasyUnlock sign-in service that does not track Instance ID. - A v2 DeviceSync device that does not have the legacy device id, i.e. public key, decrypted yet. - Multi-device applications, e.g. SmartLock, still track devices by the legacy device ID, so they might try to look up a v2 DeviceSync device-- that has an Instance ID--by legacy device ID. Note: Bypassing presubmit shared_ptr errors. We are working with existing shared_ptrs. The migration from shared_ptr to scoped_refptr is complex, and it is being tracked at https://crbug.com/960538. No-Presubmit: true Bug: 951969 Change-Id: I511c1a314bb98e8129516f38dd7a3f156fddbd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971652 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732102}
-
Xiaoqian Dai authored
Previously ui::MODAL_TYPE_WINDOW type modal child window controls its own visibility, thus when its modal parent window becomes visible, it can still be invisible. This CL makes the modal parent window controls its modal child window's visibility if its modal type is ui::MODAL_TYPE_WINDOW. Bug: 1036067 Change-Id: Icfeb612beec0d76419e9b0606986c8bc5791e12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995463Reviewed-by:
-
Khushal authored
AcceleratedStaticBitmapImages created by WebGL rely on creating a GL texture backing for a shared image to ensure the shared image outlives the StaticBitmapImage. This in turn assumes that even if the client explicitly destroys a shared image mailbox via SharedImageInterface, they can continue to use this mailbox as long as an associated representation is alive. This pattern is not something we want to support. This pattern also means that when a mailbox is stored on SharedImageInterface, we can not safely assume that the metadata associated with it can be cached correctly. This change fixes this by transitioning WebGL to use the same factory method for creating StaticBitmapImages as used by canvas2d. This in turn also does the following: 1) Ensures that the correct texture target is plumbed through with the StaticBitmapImage. 2) Eliminates the needs to plumb an image and a release callback through a bunch of code. Since the image now owns the release callback. 3) Cleans up code in MailboxTextureHolder used to keep the mailbox's texture backing alive. 4) TransferToImageBitmap currently works by marking the resource as lost, which means it can not be recycled. These redundant reallocations are avoided with this change. R=kbr@chromium.org Bug: 1036142 Change-Id: I8824aa8d03a48e35e39744cc30c9d0313dcbed08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996124Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732100}
-
Jimmy Gong authored
- Introduces the dialog for adding a print server in printer settings - This is initially hidden behind the flag: enable-print-server-ui - Added browser tests for this dialog. Screen shots of the new UI: Switch to print server dialog: https://screenshot.googleplex.com/xYyeAukxOgu Add print server dialog: https://screenshot.googleplex.com/e7EQCrHGxan Sample dialog error: https://screenshot.googleplex.com/GnV6Fd4Jyk1 Bug:1015628 Test: browser tests Change-Id: I419f8c8f159af75fc3a9b2cd5c2c6ed2dcf8288f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954669Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#732099}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/63468081e52e..5349f3c9d904 git log 63468081e52e..5349f3c9d904 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 bclayton@google.com Vulkan: Disable SPIR-V preprocessing when debugging 2020-01-15 capn@google.com Produce less debug info in Kokoro builds Created with: gclient setdep -r src/third_party/swiftshader@5349f3c9d904 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I76adbb330f4fd0145392e3419d581ab359eba570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002985Reviewed-by:
-
Richard Knoll authored
There is a race when we wait on the response from FCM to give us the message id of the sent message. If we for some reason get the ACK for that message before the response from FCM, we discard the ACK and timeout. Bug: None Change-Id: I35a1965aa5e1034af1b046099a60656ea61b59cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001302 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732097}
-
Victor Vasiliev authored
This adds callbacks that notifies the client: * when a new datagram can be read, * when a new stream can be opened. Bug: 1040236 Change-Id: I731bbc18951eb28dc8dd594db6a98036172a2e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001195Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#732096}
-
Yury Khmel authored
This reverts commit c02f2451. Reason for revert: System apps are not required for managed users. Original change's description: > arc: Add concept of system default apps. > > These apps exist on system image and available for all users. This also > moves custom Play Store case handled separately before to system app. > > TEST=unit test > BUG=1013730 > > Change-Id: Iaf63d52c38c376b6b07930bc8ec88e5b9de4bb58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865472 > Reviewed-by: Josh Horwich <jhorwich@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706920} TBR=xiyuan@chromium.org,jhorwich@chromium.org,khmel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013730 Change-Id: I106b0bee9f55b655d467094e0a55f7d50679de7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002720Reviewed-by:
Yury Khmel <khmel@chromium.org> Auto-Submit: Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732095}
-
Xiaohui Chen authored
Bug: 994944 Test: CQ Change-Id: Ib8bc6a552258c35c93699f5eb196bfbe7df9f252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001069 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#732094}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. This CL removes a number of tests from /fast/forms related to pop-up picker behavior. These tests are old, and assume *many* details of the internal shadow implementation of the pickers, which are no longer true with the FormControlsRefresh pickers. Those controls are also better-tested with the new suite of tests at [2]. See crbug.com/1034611. To maintain test coverage of the *old* form control popups, these old tests will be moved into the virtual/form-controls-refresh-disabled virtual test suite. [1] http://crrev.com/c/1967608 [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/virtual/controls-refresh/ Bug: 1035582, 1034611 Change-Id: I35238a1923cd2a2a2612ee469957f8c6bd70b5b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997846 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#732093}
-
Francois Doray authored
It is invalid to have a visible browser window with no active WebContents, but https://crbug.com/1032348 shows that it happens. This is a fix that can be merged to M80 to avoid getting crashes on stable. Instrumentation to better understand the problem is added in https://chromium-review.googlesource.com/c/chromium/src/+/2001220 Bug: 1032348 Change-Id: Ia20a35fff65532d8f11110a097b94b72fbcf3dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001139 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#732092}
-
