GitLab

TabSwitchTimeRecorder needs to be notified when a tab is hidden, to
record histograms and keep local state up to date if no frame was
presented since the tab was shown.

This CL ensures that TabSwitchTimeRecorder is notified when the tab
is hidden because of native window occlusion This was broken by
https://chromium-review.googlesource.com/c/chromium/src/+/1680969.

Bug: 995339
Change-Id: I77b6fe6ad438c1c038e3fcce09a0a639d153fa6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760872Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689456}

HashTraits<blink::PropertyHandle>'s IsDeketedValue method was declared
as accepting blink::PropertyHandle. The argument should have been
const blink::PropertyHandle& (as it is in the parent class).
As a result, when trying to use this method, PropertyHandle was copied
resulting in a crash when traced by concurrent markers.

Bug: 986235
Change-Id: I0f29d37453f5c948bfd6e041e2979c9dbe144366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764157Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689455}

This reverts commit 27ca1df7.

Reason for revert: This CL causes an official build failure
https://crbug.com/996658

Original change's description:
> Enable dist fusing for all feature modules.
> 
> Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689075}

TBR=tiborg@chromium.org,benmason@chromium.org

Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689454}

Add a web platform test that performs navigations to a test page with
various targetText parameters and checks if the target page
successfully scrolled as expected. Using a BroadcastChannel is the only
way to communicate whether the target page scrolled, since scroll to
text is specifically restricted from iframes or pages with an opener,
so there's no other way for the test page to track the status of the
child target page.

Bug: 994299
Change-Id: I69243e739c3a7469ac48647508e379f204ccfbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756707
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689453}

Bug: 991553
Change-Id: If5d74661f713101080f75e4baa6a77e981ac0f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742209
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689452}

Bug: 648382
Change-Id: I127a672ac3b53220816737843cb2525859a25b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765030Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689451}

The prompt field in the GetPaymentInformationAction was dropped due to a

std::move. This patch fixes that by setting the status message before
moving.

R=arbesser@google.com

Bug: b/139842776
Change-Id: I7c62a72d0f4856f20baa882081d8ee1d61104c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763683Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#689450}

Change-Id: I2cd3b65e477a99a3e7c2368767958d0f08156a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764156Reviewed-by: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689449}

This CL removes the special treatment applied to counters labels in
order to make the label pluralizable. Given the special format of
ChoiceLabel, some characters (like '<', '#' or '|') make the
application crash.

Those special characters can be escaped with ' but they will then be
displayed in the string, which is undesired.

We can safely remove this pluralizable logic as it is not used by any
scripts (the text shown is extracted from the website).

Bug: b/139643534
Change-Id: I88109b2f374c5c343545603a28aac38a8a190b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763682Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689448}

The same dialog component will be used for multiple purposes, for
the onboarding flow as well as for leak detection. Since these need
different button strings, this CL makes the strings customizable
from the bridge.

Bug: 986317
Change-Id: Icfb80952b0312cd15e6f16bf722abf292b82a523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762230
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689447}

Ran:
$ rm -rf third_party/android_deps/libs/[!O]*
$ tools/android/roll/android_deps/fetch_all.py --update-all

Tbr: Trivial update to documentation
Bug: None
Change-Id: I5a59c721c9b6cbbf4334464f71f8363baa0ac753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765551Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689446}

Stability.iOS.UTE.OSRestartedAfterPreviousSession is stability metric
and should be logged via the macro.

Change-Id: Ia72ba513b2e5d47c040528ad732af1a1a10dde70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763164
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689445}

Add compiler option to turn shadowed variables into errors for cc.
Fix various shadowing errors generated by compiler error.

BUG=794619

Change-Id: I84a6aaceb6552291c4d2122228a894097b4c7da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763297
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689444}

Bug: 986298
Change-Id: I743c86bec5f5424781a050a5d732c269b4e296d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760798
Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689443}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d20e6d40df1f..e9bc22c848cc


Created with:
  gclient setdep -r src-internal@e9bc22c848cc

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I12040d0422fb1927d62e0cde673fcc3cd901aa56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764880Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689442}

This reverts commit 99e62c7f.

Reason for reland: Not actually the culprit for PrintBrowserTests flakiness

Original change's description:
> Revert "Remove print document race condition using synchonous message"
> 
> This reverts commit 2ff72648.
> 
> Reason for revert: Suspected of making various PrintBrowserTests flaky, see crbug.com/996185
> 
> Original change's description:
> > Remove print document race condition using synchonous message
> > 
> > JavaScript window.print() requests have been returning back to the
> > renderer process before the print has actually completed.  When the
> > print preview is disabled it is easier to expose a race condition
> > between serving the print logic and whatever comes next in the
> > JavaScript.
> > 
> > If the script has a popup window to be printed, which has
> > window.close() immediately after the window.print(), then the document
> > to be printed has its destruction racing against being printed - and
> > will typically lose that race, resulting in a lost or empty print job.
> > 
> > Resolve by ensuring that the renderer process does not proceed past
> > window.print() until the DidPrintDocument message is sufficiently
> > completed.  Making this message synchonous achieves this effect.
> > 
> > This means that the renderer process will be blocked for all sites
> > which it serves for slightly longer than it already does. [1]
> > 
> > [1] https://www.chromium.org/developers/design-documents/printing
> > 
> > Bug: 974480
> > Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275
> > Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
> > Reviewed-by: Tao Bai <michaelbai@chromium.org>
> > Reviewed-by: Tom Sepez <tsepez@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Commit-Queue: Alan Screen <awscreen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#688096}
> 
> TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,ctzsm@chromium.org,awscreen@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 974480, 996185
> Change-Id: I3ae34235d1bbdb98619a157a451e94e6b0e1cf48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760795
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689415}

TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,treib@chromium.org,ctzsm@chromium.org,awscreen@chromium.org

Change-Id: Ifc9ba8829440672fa83fdd1aa2ed45d4ede71e4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974480, 996185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764196Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689441}

Related to:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1685369
https://chromium-review.googlesource.com/c/chromium/src/+/1762699

Bug: 995940
Change-Id: I3cc34fad155fbe96fcedc1ca7166d5b3adceb90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764800Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689440}

DriveServiceInterface and its subclasses should use CoreAccountId
instead of std::string to denote account_id because they get this
account_id from identity_manager. This should not be a std::string as
that could lead to confusion in using this as gaia_id or email.

Bug: 959157
Change-Id: I6cb20917504f4aeca6fae095df1f018811b17e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736668Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689439}

Fake cronet needs to keep the FakeCronetProvider class name so it can
be specified in the test resource files.

Bug: 669707
Change-Id: I3137bbb1eb78a7c56f4b0865b2a107b34cd43fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763230Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Benjamin Kirchman <kirchman@google.com>
Cr-Commit-Position: refs/heads/master@{#689438}

TBR=khushalsagar@chromium.org

Bug: 995142, 900706
Change-Id: Ibd84ef39365710816ec301b8865de83816805e08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760797Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689437}

Now that UserMediaClient is GC'ed (see [1]), this
CL moves UserMediaProcessor to be managed by Oilpan.

[1] crrev.com/c/1757492

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Icfe0579b32c98283f1a340cb86dd7c95f8de3b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758604
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689436}

Leak dialog has a cancel button with label "Close", but functions
should have "Cancel" in the names since it is really a cancel button
in dialog delegate.

Change-Id: I77f43a4833582f83cc017d91c402bd93164bf958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758241Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Rafał Godlewski <rgod@google.com>
Cr-Commit-Position: refs/heads/master@{#689435}

This isn't a security bug but a race condition. The `data:` frame is
inaccessable from the `javascript:` frame (as the former has an opaque
origin). The test passes if the second frame loads first (as the first
frame will still be at the initial `about:blank`), and fails if the
first frame loads first.

This patch loads `about:blank` in the first frame. Problem solved.

Bug: 993238
Change-Id: Ibd10bcf3756816fc967f64c1c78d2290cc0898b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765469
Commit-Queue: Mike West <mkwst@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689434}

This is CL changes the ownership model of UserMediaClient, making it
GC-able by Oilpan

It also:
- Removes the associated WeakPtrFactory declaration in user_media_client.h
  changing the uses of WTF::Unretained by WrapWeakPersistent.
- Removes the body of ~UserMediaClient, since the object is now GC-ed.
- Rework the callbacks passed to LocalFrame and UserMediaProcessor, to
  overcome the limitation that Callbacks can not be bound to a weak
  reference, if they return non-value.

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I2cc51660b6007fdc929d50f5508659aac83e3697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757492
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689433}

The mojo interface will be used to communicate the new lifecycle state
of the worker. This will be useful for filtering out frozen state for
dedicated workers in the client matching APIs.

BUG=968417,907125

Change-Id: Ic9f32a83ea6fd8e88dd59c63b8e2966d86ca6bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756623Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689432}

This CL merges blink::features::kOffMainThreadDedicatedWorkerScriptFetch to
blink::features::kPlzDedicatedWorker.

PlzDedicatedWorker depends on OffMainThreadDedicatedWorkerScriptFetch.
Initially, we planned to enable OffMainThreadDedicatedWorkerScriptFetch first
and then PlzDedicatedWorker. However, it turned out that
OffMainThreadDedicatedWorkerScriptFetch breaks some tests and PlzDedicatedWorker
fixes them. Therefore, we decided to enable both of them at once. As a result,
we no longer have to keep both the flags.

Bug: 835717, 906991
Change-Id: I9821abd350d88949279456499376406002a28840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763525
Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689431}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d65c05cb1aa9..d20e6d40df1f


Created with:
  gclient setdep -r src-internal@d20e6d40df1f

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ic6248aaa448b186343dc53ec92e98ae5755d9813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764359Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689430}

Using wpt-import in Chromium 812bd585.
With Chromium commits locally applied on WPT:
1194775a "Add ability to block same-origin access via document-access feature policy"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I420d3478f3ec40b7ee8688753d7e8a54717e3ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765330Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689429}

After [1], we're stripping `Sec-Fetch-*` headers from non-secure
transport. This is lovely! Except insofar as it also strips the headers
from secure redirect targets. Which is a problem, as it gives attackers
the option of laundering their requests through HTTP to strip the
headers.

This patch removes the secure transport restriction while we figure out
a cleaner way of removing the headers on a per-hop basis.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1647354

Bug: 995745, 971938, 964053
Change-Id: Icec4e685902b7be2983bb81b7289ac9b45467782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762079
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689428}

https://webrtc.googlesource.com/src.git/+log/224c69d52748..a2dae38ee772

git log 224c69d52748..a2dae38ee772 --date=short --no-merges --format='%ad %ae %s'
2019-08-22 nisse@webrtc.org Revert "Reland "Delete mac_utils.h and mac_utils.cc""
2019-08-22 chxg@google.com Add helper classes to send and receive abs-capture-time extensions.
2019-08-22 jonasolsson@webrtc.org Remove unused framerate parameter from simulcast bitrate allocator.
2019-08-22 nisse@webrtc.org Reland "Delete mac_utils.h and mac_utils.cc"

Created with:
  gclient setdep -r src/third_party/webrtc@a2dae38ee772

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:None
Change-Id: Id66c3da8c217369c5cc2d4fc0a8f8afacb4e2c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764939Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689427}

If a subframe does audio capture, it should be handled the same as if
audo capture was done from the top level frame.

Bug: 989379
Change-Id: I31f751c7c96aa202ced4d78d8f396f3e36bd3425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760295
Commit-Queue: Lowell Manners <lowell@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689426}

Bug: 986317
Change-Id: I9476047656d127450faecbb0e927999d61c2ad0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764138Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Rafał Godlewski <rgod@google.com>
Cr-Commit-Position: refs/heads/master@{#689425}

+ Adding comments.
+ Removing ColdStateTabSwitcher test (exactly the same than
  ColdStateConfigureSigninPromoView).
+ Renaming WarmStateConfigureSigninPromoViewWithoutImage into
  WarmStateConfigureSigninPromoView.
+ Adding ColdStateConfigureSigninPromoViewFromSettings (to test the
  close button).
+ Cleaning up the code.

Related to:
+ crrev.com/c/1764151
+ crrev.com/c/1718370

Change-Id: I4581537ad8bbad38c83faba8cbaa977faa6dea36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760793
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689424}

In order to continue with the launch process for this feature, we need
it to be enabled by default on tip-of-tree.

Bug: 659750
Change-Id: Ia55037944bde87793a6f1eb4fd6b83a5b2b362d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764433
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689423}

Moving away from Apple's default colors to Chrome's specific ones.

Bug: 976671
Change-Id: Iba1e410f8453d3abd26851febc17f56ed4122baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763757
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689422}

Tracing suggests WTF::Partitions::FastFree is slow. On my workstation
deallocating 260 segments takes more than 100us. This CL stops using
SharedBuffer and introduces WebSocketMessageChunkAccumulator which pools
segments. A WebSocketMessageChunkAccumulator will free segments which
were not used in the last 100ms.

This improves [1] in my environment.

Without the change: 390MB/s
With the change   : 416MB/s

With --websocket-renderer-receive-quota-max=128000
     --websocket-read-buffer-size=32000, the result is

Without the change: 494MB/s
With the change   : 563MB/s

1: third_party/blink/perf_tests/websocket/receive-arraybuffer-1MBx100.html

Bug: 865001
Change-Id: Id87134e766b662816249b4a08e24cf844bb4a88f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725351
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689421}

It's been over a year since modal permission prompts have been enabled
by default. The usage is now very low so it's time to removed them.
https://uma.googleplex.com/histograms?sid=19aaae5bcd78f725505eebc7e91172ce
Usage in stable less than 0.0003%

Bug: 935900
Change-Id: Ifecfacec485fc1a18fccbf7d219209d3727946b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757939Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689420}

http/tests/devtools/elements/styles-3/styles-computed-trace.js
http/tests/devtools/elements/styles-3/styles-add-new-rule-colon.js
http/tests/devtools/elements/styles-2/force-pseudo-state.js

TBR=luoe@chromium.org

Bug: 994008, 994034, 994027
Change-Id: I47a3cb1c8c6d3355d28e54a56b05a2eca6207f6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760796Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689419}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ccbb1967..152e05a4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I65d5f4cd6a8c638f6156ba89068eb0d910549a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765329Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689418}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60d1f774d1f3..d65c05cb1aa9


Created with:
  gclient setdep -r src-internal@d65c05cb1aa9

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I9597cb99247abe3362cf18c31285fd663cde351f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764937Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689417}