- 12 Apr, 2019 40 commits
-
-
Natalie Chouinard authored
leveldb_proto databases will soon be migrated from unique LevelDB instances to a single shared underlying database. Because of this, we need to migrate to the new API to construct and initialize the database. Bug: 941796 Change-Id: Ic0462828c5dc1c026ffb08c2cec236f023b4478b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559699Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#650515}
-
Chris Harrelson authored
A synthetic mask layer is not needed if there is no content under it which draws. This patch implements that optimization, and also adds a new optimization to CompositedLayerMapping to set DrawsContent to false for layers which have empty size. The patch also removes one unused method from cc::Layer. Bug: 947715 Change-Id: I7625fc251a3dc04ce5319edc56a9dc5fccf27564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566029 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650514}
-
Roman Aleksandrov authored
Add empty alt to the extension's image because the name of the extension is presented. Add backButton alt to be consistent with other Settings pages. Cover all the issues by tests. Bug: 879146 Change-Id: I74d4c8683fac4b9051eb43706b260fe0e030a5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554769 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#650513}
-
Eric Aleshire authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Bug: 922813 Change-Id: I9d881648b15a3e1bd69eed3ccfa20d7aee7d3dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562756 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#650512}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81fd86c1ca03..e62bf561638c git log 81fd86c1ca03..e62bf561638c --date=short --no-merges --format='%ad %ae %s' 2019-04-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-12 herb@google.com Convert the CPU mask case to use prepareForDrawing Created with: gclient setdep -r src/third_party/skia@e62bf561638c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I04f871f0c96b528474a8b1d4cca342c1d954b0cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650511}
-
Theresa authored
Suppress unused resource lint warning so that compilation without the Feed enable doesn't fail. BUG=951074 Change-Id: Iac74b2bd29cc54c976d7112101a5ab814a10898e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566286 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#650510}
-
about://flagsCharlene Yan authored
Bug: 951078 Change-Id: Id66be9ff30e334f53338fa9848fa73db3ea318ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560373 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#650509}
-
Erik Luo authored
- Prompt's '>' icon is dimmed when pressing 'Enter' would not evaluate (instead insert newline) - Icon moves from ConsoleView to ConsolePrompt - Drive-by: removes obsolete styles related to pins Screenshot: https://imgur.com/a/GNrOadJ Bug: none Change-Id: Ia22c905154b78495138a0eaf954a2bc88de9a9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548578Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#650508}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/644a8b5800a7..7017b6e58088 git log 644a8b5800a7..7017b6e58088 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 ravisadineni@chromium.org Adjust tester for power user belonging to debugfs-access group. Created with: gclient setdep -r src/third_party/chromite@7017b6e58088 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I97e35ec2c65082eecfcc6cbde3dcccbbb66721ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565776Reviewed-by:
-
Jonathan Metzman authored
Only build seed corpora where it is necessary, in order to reduce build sizes. Bug: 952412 Change-Id: I6e529226d4ba51fd547c1869525a9f094fdcd998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566454Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#650506}
-
Ian Kilpatrick authored
This adds a pre-OOF-layout cache check. Essentially if we know the size of the OOF container hasn't changed size, and the OOF descendant isn't dirty, we can safely re-use the layout result. If we hit this cache check we don't need to perform the work required to size and position the OOF object again. This comes with one hiccup. We need a way to properly determine what the old offset was without resorting to running the full logic within LayoutDescendant. This adds a mutable field on the NGLayoutResult to perform this. An alternate I considered was making the NGOutOfFlowLayoutPart know about the previous layout result, and children within them. But to perform this efficiently we would need to keep a pointer to the current child so that we wouldn't scan all the children. Bug: 635619 Change-Id: I4dd4fb526b273b982e4e94a2a280f388c16719cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553646Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#650505}
-
Sammie Quon authored
These were part of [1], but made the diff difficult to read so moved them to a separate cl. Also renamed StartAnimationObserver to EnterAnimationObserver as it makes more sense in the context. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1564881 Test: added tests Bug: 914147 Change-Id: Iaf878bf2255d3c5ac585d52fc32cdf9f15cf8029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566361 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#650504}
-
Khushal Sagar authored
The fact that we initialize EGL bindings in tests but don't clear them on teardown was making tests unhappy. R=piman@chromium.org BUG: 899985 Change-Id: Id5e103974379f1fca18d9ec67768f9fc72f65061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566280 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#650503}
-
Junbo Ke authored
Bug: b/120908346 Test: Manual test on device Change-Id: Iaf3b38a615f8679a87fd5982fff1fe6e4fa7e8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565618Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#650502}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 375cda34. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If03c7481381b4f8461d5b9e1cbdbaac20da8b84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566360Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650501}
-
Jonathan Metzman authored
archive_seed_corpus is false by default. If it is true then seed corpora won't get built. This will be used to reduce build sizes on most fuzzer build bots since they don't all need seed corpora. Bug: 952412 Change-Id: I67b925756763e6221e88a3d47961f20c5a831054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566418 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
Yue Li authored
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome Bug: 950144 Test: Manual Test Change-Id: I9fc6ae5e228e8f2c5697345cbd90445ae045fc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566412 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#650499}
-
David Dorwin authored
* Make WebVR-specific statements explicit * Simplify logic for calling SetVibrationActuatorInfo() * Coalesce newly_connected evaluation at the beginning * Fix incorrectly named web_gamepad in SampleGamepads() Change-Id: I656890f835089cb4bb7a176136119ba9b65a1c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564878 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#650498}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=none Change-Id: Ifff24ff52a6b4bf295b2a31b51bbe6fe27547d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566284 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#650497}
-
John Abd-El-Malek authored
Fix URLLoaderInterceptor not intercepting non-network schemes for navigations when the network service is enabled. Bug: b/120908346 Change-Id: Ib1cbc7be93a417e662c9dafcd337637fab1483e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566021 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#650496}
-
Tanya Gupta authored
Switched STTS to use this new channel. Bug: 938944 Change-Id: I6ccccc058884050821e38490326f6b9c092d05c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560377 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#650495}
-
Matthew Mourgos authored
shortcuts on the shelf. Bug: 951964 Change-Id: I858d99304c09846581947a0ec17d6ff6ae497585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564549Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#650494}
-
Kurt Catti-Schmidt authored
Some unit tests are leaking SAFEARRAY allocations. This change converts raw SAFEARRAY* usage to use the recently added ScopedSafearray class instead. Bug: 942116 Change-Id: I66e6d1ecd8b7c71864c0e698bc2bbc94390e0d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559754Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#650493}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c85037d35b5..1e064014eb2b git log 6c85037d35b5..1e064014eb2b --date=short --no-merges --format='%ad %ae %s' 2019-04-12 benjaminwagner@google.com Fix 'not all control paths return a value' and add to extra_warnings 2019-04-12 jmadill@chromium.org Update test result output from ANGLE dEQP gtests. Created with: gclient setdep -r src/third_party/angle@1e064014eb2b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ia89e65a18b2fe6e0b04ebe406ee333324ac896d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566278Reviewed-by:
-
siyua authored
Rename to OmniboxPageActionIconContainerView to differentiate from ToolbarPageActionIconContainerView. This CL only includes some name changes, so everything should be covered by existing tests already. Bug: 932818 Change-Id: I93902f9559bce2701735dc6df7f8029c1f8ab279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540312 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#650491}
-
Xianzhu Wang authored
Using the parameter, we can e.g. let the function go through the fast path using GeometryMapper. Change-Id: I8741e177e0691c11618160076da92725b756c366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564861Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650490}
-
Erik Chen authored
This reverts commit e8f29ced. Reason for revert: Undoing this change rather than leaving the iOS configs in a half-migrated state. Original change's description: > Create mb_config entries for public iOS master/builders. > > This CL adds matching GN configs for all the public iOS master/builders. The > feature is not yet enabled, since the implementation of mb.py has a hack that > skips reading the config files for public iOS master/builders. > > This CL makes two slight adjustments to the GN args: > 1) All gn configs that use goma now set > 'strip_absolute_paths_from_debug_symbols=true'. This matches every other > platform. This breaks lldb-debugging, but that's not relevant for bot builds, > and increases goma cache hit rates. > 2) The WebRTC FYI ios-simulator device now uses code-signing. This matches > every other ios-simulator builder. > > Bug: 951182 > Change-Id: I7d6ce92f15b7751ade796156fda31f4235208b46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562451 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649704} TBR=thakis@chromium.org,dpranke@chromium.org,erikchen@chromium.org,justincohen@chromium.org,oprypin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951182 Change-Id: Ie0970b742d7219e557d28a7a1a8f017865afc5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566491Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#650489}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0c227e21d110..bff933affcff git log 0c227e21d110..bff933affcff --date=short --no-merges --format='%ad %ae %s' 2019-04-12 enga@chromium.org Clear glColorMask at the start of a RenderPass for LoadOp::Clear attachments Created with: gclient setdep -r src/third_party/dawn@bff933affcff The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Ifa3db8bc6fe02334de3c1c24fc609a2031cf83a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566276Reviewed-by:
-
Yuchen Liu authored
For audio only stream, we should let it play even video backgroud play is disabled. Bug: internal b/129859403 Test: Move audio only page to background, stream is still playing. Change-Id: If82d6c0cbc21b71d3da3c8dd70e344b08bdb55f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552164 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#650487}
-
Tarun Bansal authored
Change-Id: If8307e56a7efee27c5496d07c5984344d10b440c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566457Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#650486}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35c44ec01176..cd92a27aa122 Created with: gclient setdep -r src-internal@cd92a27aa122 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Ice9dd342d21702fe4a8bdd63794479e1a49a116e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566451Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650485}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/82eb22e297f5..09591b87bdf1 git log 82eb22e297f5..09591b87bdf1 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 capn@google.com Pass descriptor sets to SPIR-V compilation Created with: gclient setdep -r src/third_party/swiftshader@09591b87bdf1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5c65b61756895a9f25e11fcb649e2fa22fee5eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566452Reviewed-by:
-
Eric Aleshire authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Bug: 922813 Change-Id: Id28a27a97677091b68b3b2579f3019e613e0c5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558155 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This CL does the following changes for inline images (images with data URIs): * Trim the |name| to a max 100 chars. * Do not apply the Timing-Allow-Origin check: assume it passes. Bug: 879270 Change-Id: I58b67cb96bea11a78d0bb60af609db8459917df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555006Reviewed-by:
-
Mike Reed authored
More clear, and simplifies future skia api changes. Change-Id: I2f8172e4292bdf63c1e06843ee080ace3baa29e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566113Reviewed-by:
Ben Wagner <bungeman@google.com> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#650481}
-
Johannes Henkel authored
Change-Id: I5ace88b383d1ba94a75e8990fde5bfeb0a357f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566026Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#650480}
-
Jacob Dufault authored
Change-Id: Ic56f86eee47d27077c07cf781dcae80f983020aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562516 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#650479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb85b8b3f306..81fd86c1ca03 git log bb85b8b3f306..81fd86c1ca03 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 herb@google.com Revert "Convert the CPU path case to use prepareForDrawing" 2019-04-12 michaelludwig@google.com Remove debug quadType() checks 2019-04-12 michaelludwig@google.com Support domain clamping and transform matrices in YUVToRGB effects 2019-04-12 herb@google.com Convert the CPU path case to use prepareForDrawing 2019-04-12 benjaminwagner@google.com Factor common SSH logic into a new flavor. Created with: gclient setdep -r src/third_party/skia@81fd86c1ca03 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935563,chromium:935503,chromium:8959 TBR=egdaniel@chromium.org Change-Id: I2ae6457e8e3ad9fdb6bb42957b323e0dc727b334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566275Reviewed-by:
-
David Bokan authored
Reland Note: Original CL actually fixed the test on Mac which caused it to mis-match the failing expectation. The test remained broken on other platforms because it didn't account for scroll animations. This CL fixes the test and updates the expectation to passing, original CL in PS#1. The IsOffscreen computation was comparing the FrameView's GetScrollableArea()->VisibleContentRect, which is be the content rect in the _root scroller_, with the object's VisibleRectInDocument, which is in document coordinates. This breaks when a non-default root scroller is active. I've rewritten this method to be cleaner. I've kept the separate mapping up to the local frame first using VisualRectInDocument rather than mapping directly from local to root frame since VisualRectInDocument has some specific logic in subclasses that uses a different local rect depending on the LayoutObject type; I couldn't find an equivalent way of getting an equivalent rect but in local coordinates and several tests depend on this (e.g. how line boxes are collected in a LayoutInline). TBR=eae@chromium.org Bug: 949406 Change-Id: Iec0f5a27bd242c537db231cfb44b39d535fc579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565724 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650477}
-
Yutaka Hirano authored
As a preliminary step to have a platform provided underlying sink, this CL defines UnderlyingSinkBase. UnderlyingSinkBase is much simpler than UnderlyingSource because we don't need extra logic that was needed for lifetime issues. Bug: None Change-Id: Ibcb5ccd364627df553cdd2be1c9dc1c1fa45a685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564278 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#650476}
-
