GitLab

On iPad PKAddPassesViewController alloc/init returns nil. This CL fixes
a crash, which caused by presenting nil view controller.

The functional behavior remains the same as for old pass kit
implementaiton (the error is silentry ignored). This issues is tracked
in a separate bug (crbug.com/794301).

Bug: 787943
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id3826fa13d5c327795d411b3ec7b9c5d343031c1
Reviewed-on: https://chromium-review.googlesource.com/823239Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523804}

https://pdfium.googlesource.com/pdfium.git/+log/f85c43bc7374..14768f3264a4

$ git log f85c43bc7..14768f326 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 thestig Get rid of CXML_AttrMap.
2017-12-13 thestig Fix some nits in CXML_Element.
2017-12-13 thestig Use size_t in CXML_Element and callers.
2017-12-13 thestig Simplify CXML_Element::GetTagName().
2017-12-13 thestig Inline CXML_Element private methods.
2017-12-13 thestig Remove dead CXML_Element code.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3cb26439c453ee16b04ffad2d5ec2b9562f07d55
Reviewed-on: https://chromium-review.googlesource.com/824427
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523803}

(since he's no longer doing reviews)

Bug: 
Change-Id: I0ff731864705a88006b159f26781856402cd737e
Reviewed-on: https://chromium-review.googlesource.com/825002Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523802}

This was deprecated method from CRWWebDelegate which is not used
anymore.

Bug: 674991
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie06ae35173b03681a49625272aa0ec8c2a38265f
Reviewed-on: https://chromium-review.googlesource.com/820934Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523801}

https://chromium.googlesource.com/angle/angle.git/+log/87cc90dfaaf7..e30edd6fcb96

$ git log 87cc90dfa..e30edd6fc --date=short --no-merges --format='%ad %ae %s'
2017-12-13 jiajia.qin Update deqp31 test expectations

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I71693941eae5c70e6249998869504a195100d6ca
Reviewed-on: https://chromium-review.googlesource.com/824428Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523800}

Last usage of this constructor was removed by https://crrev.com/i/459854.

Bug: 746519
Change-Id: Id798024deec1915c9c101b46d84287c530469629
Reviewed-on: https://chromium-review.googlesource.com/824762Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523799}

blink-dev i2s thread with 3 LGTMs:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AgonJunvfIE

Bug: 772566
Change-Id: I09178ae913a513de7dc646b1dd43cdffafe1b3c5
Reviewed-on: https://chromium-review.googlesource.com/823252Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523798}

When the toolbar is translated for the search provider logo on the NTP,
the background needs to be transparent to prevent it from covering part
of the RecyclerView's scroll bar.

BUG=791766

Change-Id: I9651c16dccc153d1bdad15925a51fae9acbeb591
Reviewed-on: https://chromium-review.googlesource.com/823575Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523797}

Bug: 771918
Change-Id: I97aa23f789d70dcc611fae05cb10b4e9b18009ed
Reviewed-on: https://chromium-review.googlesource.com/820310Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523796}

The use of -rootViewController is fine here because it
is used for safe area sizing rather than presentation.
This is necessary because the view is not in the
hierarchy at the time the sizing is done.
We should find a way to completely remove
rootViewController, which may involve moving
when the sizing is done in this case.


Bug: 791784
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id69b668a9b08c85b0e0ff66a3dd90ac56f580ecd
Reviewed-on: https://chromium-review.googlesource.com/824432
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523795}

https://webrtc.googlesource.com/src.git/+log/6c8e6666cebe..1aa285974b6b

$ git log 6c8e6666c..1aa285974 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtcBUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I019bc2d27e51e2d48adde5eae9637b9aea48d163
Reviewed-on: https://chromium-review.googlesource.com/824642Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523794}

Animating or using an ever increasing number of instances of variable
fonts can make the font_data_table_ in CSSFontFaceSource grow without
bounds. Set a limit, and remove least recently used entries from the
table. In my experiments this reduces the tab memory leakage for the URL
from issue 778352 to a third and should help keep the tab running a lot
longer.

Bug: 778352
Change-Id: I9a812afdffb318be977def0b2c0301321603ab15
Reviewed-on: https://chromium-review.googlesource.com/824172
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523793}

Following bot results are included.
2470 2471 2472 2473 2476 2477 2478 2481 2482

Deflake is not included until bots become more stable.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I09c19bf6da0c1b905a828af50c379d3a3d523c37
Reviewed-on: https://chromium-review.googlesource.com/824007
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523792}

When the flag is enabled, the pull-to-refresh in-product help bubble is
shown at the top of the screen rather than anchored to the bottom
toolbar.

ArrowBubbleDrawable was modified to support not drawing an arrow.

BUG=793403

Change-Id: I86d753a1eb7a193576f4523de6dd5f01a1a4c145
Reviewed-on: https://chromium-review.googlesource.com/817882
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523791}

Define the bridge interface to connect the machine USB devices to the
Android USB host API.
Implement the API using /device/usb.

The permission request for the USB devices is currently stubbed and
fails closed. So until the Permission UI and settings are submitted, the
API basically rejects all the requests.

Bug: 24572867
Test: Manual, run with ARC++ app using android.hardware.usb to use USB
devices.

Change-Id: Ibce0a45e4359a97ee06d8d49981169bd5f18176f
Reviewed-on: https://chromium-review.googlesource.com/731284Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523790}

Since loading pages hides ToolbarButtons, this CL makes sure hidden buttons are updated correctly
after the expanding/contracting animations.

Bug: 794246
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I633e18bd0899fd6d9586e4136719ea39279c35bc
Reviewed-on: https://chromium-review.googlesource.com/823228Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523789}

Input throttling with surface synchronization didn't always work well.

Occasionally a huge number of input events from Ash would be processed
between the time a resize request is first initiated and the time the
surface synchronization event began. This caused a lot of unnecessary
jank. Traces showed that the browser UI process was busy doing a lot of input
processing work but the resize in the renderer consumed very little
time so there was definitely an opportunity to improve input throttling.

This CL takes a different (simpler/better) approach. As soon as a
synchronization event is detected in DelegatedFrameHost (we know we
will produce a UI CompositorFrame that will synchronize with the
renderer), we throttle input events until a browser UI commit
(OnChildResizing guarantees an upcoming commit).

Bug: 672962
Change-Id: I75c8328bb846eff2817a805e63a6367ebb0714a2
Reviewed-on: https://chromium-review.googlesource.com/822658
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523788}

With 'textLength' and 'lengthAdjust' with the value 'spacingAndGlyphs',
each SVGTextFragment is subject to an additional scale factor that
stretches the glyphs along the x- or y-axis.
This scale factor was not (any longer) taken into account by
SVGInlineTextBox::OffsetForPositionInFragment, which resulted in the
incorrect offset being calculcated.
Apply the (inverse) length_adjust_scale from SVGTextFragment before
querying the font for an offset.

Remove the |include_partial_glyphs| argument from
SVGInlineTextBox::OffsetForPositionInFragment since it's always true,
and also use 'float' rather LayoutUnit for the position.
Remove the dead |horizontal_glyph_stretch_| member variable from TextRun
since it's no longer used (since the simple shaper path was removed.)

Bug: 793075
Change-Id: Ia7d369d914f5afd87d198b7b21077e180fc8bc59
Reviewed-on: https://chromium-review.googlesource.com/824162
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523787}

iossim no longer automatically launches the Simulator, that must be
done manually. Also, macOS 10.12 is required for Xcode 9.

TBR=rohitrao

Bug: none.
Change-Id: Icab37c48a6b79fbbe3e5a99b89a67058e215ca98
Reviewed-on: https://chromium-review.googlesource.com/824562
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523786}

This reverts commit fe22ec61.

Reason for revert: Revert didn't fix the issue; original CL was innocent.

Original change's description:
> Revert "mus: Support display mirroring for mus without viz"
> 
> This reverts commit e5c68a86.
> 
> Reason for revert: Suspected for breaking several tests in ash_unittests-mus on  Linux Chromium OS ASan LSan
> E.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187/steps/ash_unittests-mus
> 
> Original change's description:
> > mus: Support display mirroring for mus without viz
> > 
> > Append mirrors to the list of displays in DisplaySynchronizer.
> > (creates normal ws::Displays for ash to handle mirror content)
> > 
> > Add & call aura::WindowTreeHostObserver::OnAcceleratedWidgetOverridden.
> > (lets MirrorWindowController handle mus's async initialization)
> > 
> > Support WindowTree::ProcessSetDisplayRoot use with existing displays.
> > Remove WindowManagerState::DeleteWindowManagerDisplayRoot NOTREACHED.
> > (now hit when re-using a display and switching mirror->extended)
> > 
> > Allow ash/window_manager.cc to include ash/host/ash_window_tree_host.h
> > 
> > Bug: 770243
> > Change-Id: I21ada68097cff001bb98b9a8a22482d59d0ac1c8
> > Reviewed-on: https://chromium-review.googlesource.com/806238
> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: kylechar <kylechar@chromium.org>
> > Commit-Queue: Michael Wasserman <msw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#523618}
> 
> TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org,kylechar@chromium.org
> 
> Change-Id: I87b3b57193b38c955f3089f039a5c479c869c50c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 770243
> Reviewed-on: https://chromium-review.googlesource.com/824042
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523730}

TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org,kylechar@chromium.org,cfroussios@chromium.org

Change-Id: I66c2dbea1a2c5294f5210ad227cab87bf45f30ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 770243
Reviewed-on: https://chromium-review.googlesource.com/824782Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523785}

Both gesture_detector.cc and scale_gesture_detector.cc have
a local constant kSlopEpison with the same value. Since
I could find no suitable shared place for it, I moved them
into a tighter scope. That way they will not clash in jumbo
builds where several cc files share the same translation
unit.

Bug: 773275
Change-Id: I22c6a452532fbe0b2be3fddb29388a2d65aa901a
Reviewed-on: https://chromium-review.googlesource.com/824241Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#523784}

In CSS Color 4, HSL and HSLA were synonymized, along with allowing
whitespace to separate the values instead of commas, introducing a
backslash as a new way to separate the alpha parameter, allowing
percent values for the alpha parameter, and allowing the hue to be
specified as an angle. This updates our parsing behavior to reflect
these changes, and enables now-passing WPT tests. This also updates
our implementation of converting HSLA to RGBA, fixing a few bugs in
the process. The new spec is at
https://drafts.csswg.org/css-color/#the-hsl-notation.

Bug: 786139
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I634b5323365cc19f64a4b1732bbaf33268cb3389
Reviewed-on: https://chromium-review.googlesource.com/812125Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Chris Nardi <hichris123@gmail.com>
Cr-Commit-Position: refs/heads/master@{#523783}

Bug: 598854
Change-Id: I4a8aef73b405d4e4f1c557a9eaad2c3fb02c8f24
Reviewed-on: https://chromium-review.googlesource.com/823943Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523782}

DirectoryOwnersExtractor.find_owners_file is made more generic to
accommodate the new usage in ImportNotifier:
* It does not skip "empty" OWNERS (those without emails) any more, which
  allows "# WPT-NOTIFY" to be added to OWNERS files with comments only
  (e.g. "# TEAM", "# COMPONENT" lines; there are a bunch in wpt).
* It may now return LayoutTests/external/OWNERS. This is to make sure
  owners can always be found for WPT files so that ImportNotifier can
  generate and log bugs for all failures (but we will never turn on
  WPT-NOTIFY there).
* It can now take four variants of paths: (absolute, relative) X (file,
  directory), to make it easier to use.

Previous heuristics like skipping empty OWNERS are moved to list_owners
instead, which is only used for generating a list of owners in commit
messages and may eventually be removed.

Also improve the setup of the unit test of this module.

Bug: 765334
Change-Id: I01bd1fa85d2602299eaf1e0d8e0872b04b93a008
Reviewed-on: https://chromium-review.googlesource.com/822834
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523781}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/0bde3157d7...9596033e36

Picked up changes:
9596033 Skip elements with zero area when finding article element
38037b3 Update docs after GoB/gerrit migration

Bug: 749769,791975
Change-Id: Id545cf658982204297fcbbcd0c8716fd4f272c28
Reviewed-on: https://chromium-review.googlesource.com/823287Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523780}

CHECK should not be used in tests. This test uses a net::MockCachingHostResolver, so the HostCache
argument that was being checked should never be null.

Change-Id: Ibaa7051c404037089fb010a0ed11ee8775c70277
Reviewed-on: https://chromium-review.googlesource.com/823962Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523779}

Not required codes and comments related to sockets annotations are
removed from several classes. The changes include:
 - Default network traffic annotation values are removed and test tags
   are added instead if required.
 - Code to store annotations in sockets is removed.
 - Comments regarding annotations storage is removed.

Bug: 656607
Change-Id: I716dd482a6e868ba3b634437c434950db6073332
Reviewed-on: https://chromium-review.googlesource.com/823965
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523778}

This CL adds StrictModeContext.allowSlowCalls() to avoid crashes when
non-Chrome code calls StrictMode.noteSlowCall(). Use sparingly (e.g.,
to avoid crashes on older versions of the library if a new version
no longer calls noteSlowCall).

Bug: 793841
Change-Id: I24a03b8c241499c00a871a564cff0a5b0b58a87a
Reviewed-on: https://chromium-review.googlesource.com/824273Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523777}

https://pdfium.googlesource.com/pdfium.git/+log/94ed4456bfe6..f85c43bc7374

$ git log 94ed4456b..f85c43bc7 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 weili Update build instructions on Windows

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I53dde22be2fba99aee9435ce1861394011cc6d56
Reviewed-on: https://chromium-review.googlesource.com/824424
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523776}

Bug: 613650
Change-Id: I8674c107d619895ff7c752b4cf4397b7553b310e
Reviewed-on: https://chromium-review.googlesource.com/820158
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523775}

There is one ItemView class in notification_view_md.h so if that
header is in the same translation unit as notification_view.cc
then the local ItemView class will fail to compile. That happens
in jumbo builds.

Bug: 773275
Change-Id: I2911c4cbcc73df186d9520d4182a186a76d2ce34
Reviewed-on: https://chromium-review.googlesource.com/824364
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523774}

The previous fix for this (see linked bug) was tested via the `open`
command in Terminal. Turns out that the system sends a slightly
different AppleEvent in the case of a link being clicked (in, say,
Notes.app) than via `open`. Something about the "click a link"
version doesn't take well to being forwarded the way we were doing it.

This change extracts the URL from the received event and sends a fresh
event with that URL instead.

Bug: 777863
Change-Id: Ie8c0dc6187806756fda898440849b6830ab9d345
Reviewed-on: https://chromium-review.googlesource.com/822892Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523773}

Bug: 
Change-Id: Id24aa72e0e4647e15b5c1bb6a5386a800f75f1c0
Reviewed-on: https://chromium-review.googlesource.com/822735
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523772}

https://webrtc.googlesource.com/src.git/+log/844ce8bb3ac1..6c8e6666cebe

$ git log 844ce8bb3..6c8e6666c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id9ceff06a55e16562bc0ce42a91003edc1589f0f
Reviewed-on: https://chromium-review.googlesource.com/824422Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523771}

- This omission was purely an oversight when the flag was added in
crrev.com/782561

Bug: 595685
Change-Id: I52d852b924047f76defed5ac08009afc8e7023c1
Reviewed-on: https://chromium-review.googlesource.com/824262Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523770}

These procs supercede SkPixelSerializer and SkImageDeserializer.
See https://docs.google.com/document/d/1VcqNM_dukn3egke_m7YeMUf_kwHY37fDdftZtp7H0oc/edit#heading=h.9jbrzffapovp

One change in behavior is that Skia never serializes raw/decoded images.
- If there is no serialproc for images, skia stores png (or some other std loseless format)
- If there is a serialproc, then skia stores whatever it returns.

The chrome functions in skia_utils_base that serialize/deserialize flattenables now perform the following:
- serialize: force any images to be re-encoded (as png), so no native encoded data is transmitted
- deserialize: nothing fancy to do, since all (png) encodes should be fine

Bug: 
Change-Id: I4d3d45efafc5c07dad0b55a4a4fffe6095674a49
Reviewed-on: https://chromium-review.googlesource.com/814220
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523769}

visibility is used for logos to mark whether the default logo or a
Doodle is visible, and to fade between them. Apparently, visibility:
visible in a child overrides visibility: hidden in a parent. Adding
opacity as well prevents the logo from being visible.

Bug: 792914
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iddc9f4fa2cb9dec45b979fa332e830f4958db79c
Reviewed-on: https://chromium-review.googlesource.com/817122
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523768}

https://skia.googlesource.com/skia.git/+log/e3b013047d00..526c39f41f62

$ git log e3b013047..526c39f41 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 495162b9b..87cc90dfa (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: If3095487b53991883419f4e72f8384d80f8f5b52
Reviewed-on: https://chromium-review.googlesource.com/823827Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523767}

If we're block fragmented (e.g. multicol), the start border/padding
may end up in a fragmentainer preceding the one with the end border/padding, so
we cannot require the fragment block size to be at least as large as the total
sum of block border+padding in that case.

Added a unit test to prove it (it used to DCHECK-fail).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib51982617d0d5ef7d0abbe9b5430ef12fc3ebb59
Reviewed-on: https://chromium-review.googlesource.com/822940
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523766}

The audio element has more space so we can maximize the touch radius for
the timeline.

BUG=784363

Change-Id: Ief8f127e6cf1dc9cb08869891dc46f575d6c6d79
Reviewed-on: https://chromium-review.googlesource.com/824164Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523765}