GitLab

This CL includes a new Mojo service for controlling the
ContainedShell, as well as a feature flag for enabling it.

Bug: 902571
Change-Id: I645643270a5e595a0cadb6f781f400d700ae3bed
Reviewed-on: https://chromium-review.googlesource.com/c/1323718
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612304}

Bug: 889992
Change-Id: I9a8d8f787507c7e461b8a02ad5b130389a9f876c
Reviewed-on: https://chromium-review.googlesource.com/c/1351489Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612303}

At least on Windows, the screen reader will not read non-menu-item
Views in a menu. Currently, extensions hidden in the app menu and
the zoom plus and minus buttons are not read. This patch tags them as
kMenuItem, which fixes the bug.

Bug: 835738
Change-Id: I507c9595f6aa02d8768330f18a8b725ef1b440e4
Reviewed-on: https://chromium-review.googlesource.com/c/1354482Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612302}

Original change's description:
> MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the
> BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only
> External Clear Key CDM to store the license in the file system, if it is
> available.
>
> The original CL was flaky due to Mac's only saving file timestamps to
> second granularity. As a result it was possible for the newly created license
> to be saved with a timestamp prior to the current actual time, and deleting
> "old" licenses would include it in the deletion. Change is to wait for some
> time on Macs only to ensure that the "new" license has a later timestamp.

This reverts commit b6bfa2b7.

BUG=808690
TEST=new browser_tests pass

Change-Id: Iad919ec23bf157a9bc4af3e6d54af2b28fdc217e
Reviewed-on: https://chromium-review.googlesource.com/c/1354498Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612301}

(This doesn't apply to U2F register responses because there's no flags
byte there.)

Bug: 896980
Change-Id: I02c63d4bc63db4a8e2e7256a428d8349c34f5443
Reviewed-on: https://chromium-review.googlesource.com/c/1355242
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#612300}

Change-Id: Icb4017f98f8edea6692d84ef82872a2182e3d29c
Reviewed-on: https://chromium-review.googlesource.com/c/1355325Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612299}

Follow-up CL fixing a leak identified post check-in.

Bug: 902041
Change-Id: I733cc6037f5c29f0decabae72d51a6470de17f91
Reviewed-on: https://chromium-review.googlesource.com/c/1355332Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612298}

Updating android_deps is a bit more involved & will be in a
separate CL.

Bug: 877304
Change-Id: Ic297766125ffd638b8190033736d301ce650a86e
Reviewed-on: https://chromium-review.googlesource.com/c/1350879
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612297}

R=mmoroz@chromium.org,ochang@chromium.org

Bug: 909950
Change-Id: I00c7a8dcab631a8e4f7334847733c4a10a1376f0
Reviewed-on: https://chromium-review.googlesource.com/c/1354684Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612296}

https://chromium.googlesource.com/angle/angle.git/+log/a1442ecdf514..471358f39a6a


git log a1442ecdf514..471358f39a6a --date=short --no-merges --format='%ad %ae %s'
2018-11-29 syoussefi@chromium.org Vulkan: fix pipeline stages of memory barriers
2018-11-29 matavenrath@nvidia.com Optimize State::syncDirtyObjects


Created with:
  gclient setdep -r src/third_party/angle@471358f39a6a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Iad8707cc33c68cf716b17b6f184389220509bba7
Reviewed-on: https://chromium-review.googlesource.com/c/1355241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612295}

This is necessary in order to fix http://crbug.com/894906, where all
tests disabled on Nexus 5 were accidentally disabled on Nexus 5X
"Nexus 5X" contains the string "Nexus 5", and we were targeting the
disables based on substring matching.

I erred on the side of being redundant: if there was both a "Nexus 5"
disable and an "Android" disable, I added a corresponding "Nexus 5X"
disable. My idea here was that, if at some later point the "All" bug
got fixed and the test got reenabled, I didn't want the person doing
that to be confused why the story was failing on Nexus 5X still.
Associating the logic bug with the disable explicitly reduces that
confusion.

Bug: 894906
Change-Id: I601304a979c7b7c6451d1571f8ffce61a60f4ecd
Reviewed-on: https://chromium-review.googlesource.com/c/1355482Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612294}

This change further changes direct calls to Time::Now or the default
base::Clock instance to an OfflineClock module for ease of testing
within production files and their related tests in:

components/offline_pages/core/background/

Bug: 906903
Change-Id: Iee19708b9297e3e3b3944c457b163d5555914948
Reviewed-on: https://chromium-review.googlesource.com/c/1352045Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612293}

```-----------------------------------------------
Date:   Tue Nov 13 01:34:33 2018 +0000

Deprecate FLAGS_quic_reloadable_flag_quic_fix_path_degrading_alarm.

Merge internal change: 221188379

https://chromium-review.googlesource.com/c/1351736/
```

-----------------------------------------------
Date:   Tue Nov 13 15:59:56 2018 +0000

Deprecate FLAGS_quic_reloadable_flag_quic_fix_reset_zombie_streams.

Merge internal change: 221267071

https://chromium-review.googlesource.com/c/1351737/


--------------------------------------------------
Date:   Tue Nov 13 16:00:26 2018 +0000

Fix the bug where v44 packets are rejected by a connection close.

Fix the bug where v44 packets are rejected by a connection close
framed by a framer with an incorrect version. Protected by default
true flag FLAGS_quic_reloadable_flag_quic_fix_reject_by_session_type.

This bug happens when the rejection packet is framed before the framer
version is set, rejections from unsupported session type is an example
of this bug. This bug was discovered while we trying to disable UDP
proxying traffic.

Merge internal change: 221267139

https://chromium-review.googlesource.com/c/1351725/

Bug: 116200989

--------------------------------------------------
Date:   Tue Nov 13 20:36:06 2018 +0000

Send version negotiations n response to 1200 byte packets.

Only send QUIC version negotiation packets in response to packets
which are at least 1200 bytes. Protected by
FLAGS_quic_reloadable_flag_quic_limit_version_negotiation

Merge internal change: 221314259

https://chromium-review.googlesource.com/c/1351726/

Bug: 119156969

--------------------------------------------------
Date:   Tue Nov 13 20:44:37 2018 +0000

Move #include .../quic_mem_slice_storage.h from .h to .cc file.

The included class is only used in the .cc file.

Merge internal change: 221315750

https://chromium-review.googlesource.com/c/1351738/


--------------------------------------------------
Date:   Tue Nov 13 21:50:51 2018 +0000

Deprecate FLAGS_quic_reloadable_flag_quic_deprecate_post_process_after_data.

Merge internal change: 221327286

https://chromium-review.googlesource.com/c/1351739/


--------------------------------------------------
Date:   Wed Nov 14 19:36:56 2018 +0000

Remove an incorrect expectation in the unit test.

On a network with sufficiently large RTT, it's possible to be 120ms
into PROBE_RTT and still occasionally receive samples from packets
sent before the connection has entered PROBE_RTT phase.

Merge internal change: 221481262

https://chromium-review.googlesource.com/c/1351740/

Bug: 119213623

--------------------------------------------------
Date:   Wed Nov 14 20:45:59 2018 +0000

Ensure BBR pacing starts above 1.25xBW Estimate.

Ensure the pacing rate in QUIC BBR doesn't decrease below 1.25 *
BandwidthEstimate() when in STARTUP and rate based startup is enabled.
Protected by existing not-enabled flag
FLAGS_quic_reloadable_flag_quic_bbr_startup_rate_reduction.

Merge internal change: 221492597

https://chromium-review.googlesource.com/c/1351728/

Bug: 68184215

--------------------------------------------------
Date:   Thu Nov 15 17:06:50 2018 +0000

Remove redundant const: kMaximumStreamIdSupported.

Merge internal change: 221633247

https://chromium-review.googlesource.com/c/1352329/


--------------------------------------------------
Date:   Thu Nov 15 18:25:07 2018 +0000

Route OnDataAvailable() for QuicSpdyStream and its subclasses to OnBodyAvailable().

When data is available in sequencer, QuicSpdyStream::OnDataAvailable()
will be invoked and it will be able to do the decoding job. Once the
decoded data is ready, OnBodyAvailable() will be invoked and pure body
data can be passed to upper layer.

For now OnDataAvailable() simply calls OnBodyAvailable().

This prepares for HTTP/3 implementation where HTTP body will be
encoded in data frames.

no hehavior change.

Merge internal change: 221646112

https://chromium-review.googlesource.com/c/1352337/


--------------------------------------------------
Date:   Thu Nov 15 19:38:01 2018 +0000

Stop caching ephemeral key shares in QUIC.

We don't do this for TLS, so might as well stop doing it in QUIC too.
Protected by --gfe2_restart_flag_quic_no_ephemeral_key_source.

Merge internal change: 221660656

https://chromium-review.googlesource.com/c/1352342/


--------------------------------------------------
Date:   Fri Nov 16 00:38:54 2018 +0000

Add a max_retransmission_count to QuartcStream.

This is used (along with MaybeSetTtl) for go/quartc-data-channels to
provide the partial reliability parameters needed in WebRTC data
channels.

This is a more flexible variant of cancel_on_loss mode, which causes a
stream to immediately cancel itself if the stream tries to retransmit
any lost frames.  It allows the caller to specify a fixed maximum
number of retransmissions for the stream, after which the stream will
cancel itself.

Up to max_retransmission_count stream frames are allowed to be
retransmitted.  If a max_retransmission_count + 1st frame would be
retransmitted, the stream cancels itself.  Setting the value to zero
is equivalent to setting cancel_on_loss.

In theory, it might be preferable to retransmit *each* stream frame up
to max_retransmission_count times, rather than allowing that number of
retransmissions for the whole stream.  However, this requires complex
bookkeeping and isn't required for WebRTC data channels.  WebRTC data
channels use the semantics of SCTP, which disallows fragmentation of
unreliable messages (see
https://tools.ietf.org/html/draft-ietf-sigtran-usctp-01#section-4.2).
For data channels, we can refuse unreliable messages that don't fit in
one packet.

Merge internal change: 221712381

https://chromium-review.googlesource.com/c/1352346/


--------------------------------------------------
Date:   Fri Nov 16 01:26:34 2018 +0000

Add missing using declaration or qualification for names in the
testing namespace.

Merge internal change: 221719195

https://chromium-review.googlesource.com/c/1352348/


--------------------------------------------------
Date:   Fri Nov 16 14:56:35 2018 +0000

Add QpackInstructionDecoder; convert QpackDecoder to use it.

Add general purpose instruction decoder QpackInstructionDecoder
and use it in QpackDecoder.

The next steps are:
* convert QpackEncoderStreamReceiver to use QpackInstructionDecoder;
* implement QpackDecoderStreamReceiver using QpackInstructionDecoder;
* implement QpackInstructionEncoder;
* convert QpackEncoder to use QpackInstructionEncoder;
* convert QpackEncoderStreamSender to use QpackInstructionEncoder;
* implement QpackDecoderStreamSender using QpackInstructionEncoder.

Merge internal change: 221787819

https://chromium-review.googlesource.com/c/1352478/

Bug: 112770235

--------------------------------------------------
Date:   Fri Nov 16 16:48:54 2018 +0000

Fix a TSAN bug in QuicDispatcherTest.NoVersionNegotiationWithSmallPacket

Merge internal change: 221800371

https://chromium-review.googlesource.com/c/1351104/

Bug: 119623391

--------------------------------------------------
Date:   Fri Nov 16 18:54:34 2018 +0000

Add a fuzz mode to GfeQuicConfig.

Add a fuzz mode to GfeQuicConfig which allows skipping handshake in
GfeQuicServerStream with the presence of connection option'FUZZ' in
handshake message. Not flag protected as the new behavior is protected
by a new field in QuicConfigProto which should only be used in fuzzing
test.

Merge internal change: 221818256

https://chromium-review.googlesource.com/c/1351105/

Bug: 69366971

--------------------------------------------------
Date:   Fri Nov 16 22:46:09 2018 +0000

Temporary fix to make SendMessage API safer

Make quic message frame copy message to prevent dangerous use case
described in b/118998735. We agreed that long term solution would be
new API with MemSlice. This is temporary fix to make existing API
safer to use. One use case which Quartc is interested is calling
SendMessage from OnCanWrite notification, which is currently called
under flusher.

In QUIC SendMessage API implementation copy message to prevent
dangerous use case when SendMessage delays flushing and keeps
reference to input QuicStringPiece until flusher gets out of scope.

No changes in functionality.

Merge internal change: 221856121

https://chromium-review.googlesource.com/c/1351107/

Bug: 118998735

--------------------------------------------------
Date:   Sat Nov 17 01:23:43 2018 +0000

Use QpackInstructionDecoder in QpackEncoderStreamReceiver.

* Rip out complicated state machine from QpackEncoderStreamReceiver
and use shiny new complicated state machine of QpackInstructionDecoder.
* Rename index to varint (enum members, class members, accessors) to
reflect that integer can mean things other than an index, for example,
stream ID or maximum size.
* Do early returns in ProgressiveDecoder::OnInstructionDecoded(), also
use DCHECK_EQ instead of DCHECK(a==b) for pointers (this is generally
preferred unless there is no ostream<< override).

Merge internal change: 221877696

https://chromium-review.googlesource.com/c/1352691/

Bug: 112770235

--------------------------------------------------
Date:   Mon Nov 19 00:53:47 2018 +0000

Add QuicStreamSequencer::StreamInterface class

Add a new QuicStreamSequencer::StreamInterface class which the
sequencer uses to communicate with the Stream instead of talking
directly to the stream. This will permit the sequencer to be used with
"pending" unidirectional streams while they wait for initial data to
arrive. It also allows the sequencer tests to be simplified.

Merge internal change: 222005123

https://chromium-review.googlesource.com/c/1352674/


--------------------------------------------------
Date:   Mon Nov 19 15:31:51 2018 +0000

Add move constructors for QuicStreamSequencer

Add move constructors (and tests) to QuicStreamSequencer,
QuicStreamSequencerBuffer and QuicFlowController.  This will allow a
QuicStream to be constructed from buffered stream frames.

Merge internal change: 222073117

https://chromium-review.googlesource.com/c/1352534/


--------------------------------------------------
Date:   Mon Nov 19 17:46:54 2018 +0000

Fix QpackEncoder bug.

Fix bug in QpackEncoder that if last header is encoded by index and
|max_encoded_bytes| equals the number of bytes necessary for encoding,
then DoVarintDone() must be executed in order to increment
|header_list_iterator_| so that HasNext() correctly returns false.

This will soon be obsoleted by QpackInstructionEncoder, but we wanted
to land the regression test in before that change to make sure this
bug is not replicated by QpackInstructionEncoder.

Prototype code not used in production yet.

Merge internal change: 222091323

https://chromium-review.googlesource.com/c/1352675/


--------------------------------------------------
Date:   Mon Nov 19 19:05:54 2018 +0000


Implement support for SendMessage in quartc session

Quic now support simple unreliable SentMessage API. Currently it does
not support re-transmissions and does not break large messages
(assumes that message fits in quic frame), but for audio this is
exactly what we need right now.

If connection is congestion controlled, SentMessage returns error and
we need to queue messages and re-send on OnCanWrite.

This CL adds support for SendMessage quartc session.

n/a (Quartc only)

Merge internal change: 222104840

https://chromium-review.googlesource.com/c/1352676/

R=rch@chromium.org

Change-Id: Id232dc5e538c0081b3b8222966eb05a400a2284b
Reviewed-on: https://chromium-review.googlesource.com/c/1354264
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612292}

Bug: 909724
Change-Id: I24c3341ca5245d599ce43cba8b17c164e38e3618
Reviewed-on: https://chromium-review.googlesource.com/c/1354414
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612291}

TBR=rockot@google.com

Bug: 910205
Change-Id: I01cc1a4d38bd4108f6d609f7fdbea9d1c9de4446
Reviewed-on: https://chromium-review.googlesource.com/c/1355519Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612290}

Enables WebKit based side swipe, and only enables Chrome side swipe when the
page swiped page is to or from an NTP.

This reverts commit 1baa2855.

Change-Id: If29fd2c98bf475bfe9251e3eae18b24cb9c9c773
Reviewed-on: https://chromium-review.googlesource.com/c/1352958Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612289}

https://chromium.googlesource.com/catapult.git/+log/eee0f6ad0df5..b88aa2d8ba8e


git log eee0f6ad0df5..b88aa2d8ba8e --date=short --no-merges --format='%ad %ae %s'
2018-11-29 charliea@chromium.org Fix typos in expectations_unittest for Nexus 6P tests


Created with:
  gclient setdep -r src/third_party/catapult@b88aa2d8ba8e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iee75e2f3ddff78c8d29f79b3a459545b74ecfd0f
Reviewed-on: https://chromium-review.googlesource.com/c/1355559Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612288}

This ensures that the request must go through the proxy to pass.

Bug: 901896
Change-Id: I4c54d438ab2689b082eefc544b1c64f3866bb2c9
Reviewed-on: https://chromium-review.googlesource.com/c/1354324Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612287}

This patch adds the plumbing and integration for using the feature
highlight api to show in product help for duet instead of the
previous pointer bubble.

The new IPH follows the same triggering rules and brings focus to
the search accelerator. Tapping outside the highlight or on the
search accelerator will dismiss the IPH, otherwise it will dismiss
after 6 seconds.

A complementary internal patch will add the actual feature highlight
functionality.

Bug: 907617
Change-Id: I8e12f87954aae146b592618333620c1eb76995b0
Reviewed-on: https://chromium-review.googlesource.com/c/1347569Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612286}

Previously, if an article was already in the prefetch database, its priority
was left unchanged when a new list of suggestions is received. Now its priority
is updated to conform to the list order given by the suggestion source.

Bug: 841516
Change-Id: I38ed8ae9f5024095af14496e7274afa09c2ceff1
Reviewed-on: https://chromium-review.googlesource.com/c/1345238
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612285}

Just a few spelling mistakes and incorrect parameter names.

TBR=xiyuan@chromium.org

Bug: none
Change-Id: Iee5c1170aa96626ebc46d75c224f024479eee7b2
Reviewed-on: https://chromium-review.googlesource.com/c/1355428Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612284}

Tbr: sdefresne@chromium.org
Bug: 910216
Change-Id: I6cdfe95d6c9202d14fc681fecded9ff2ce2bbdb2
Reviewed-on: https://chromium-review.googlesource.com/c/1355599Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612283}

The script now passes the argument through to the test suite. This allows the
default value of 3 to be overridden.

Bug: 910027
Change-Id: If9bd23756262a84443c097aeafa011e05e84f876
Reviewed-on: https://chromium-review.googlesource.com/c/1354274
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612282}

We want to eventually switch most libFuzzer builds to component builds
in order to save the space. The Chrome OS one is a good build to test
component builds with since it isn't running already.

Bug: 701825
Change-Id: I43bf889e20ef54c51a5bbce1e9976ff1636fe3fb
Reviewed-on: https://chromium-review.googlesource.com/c/1355329Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612281}

Makes explicit when the custom keyboard views are paused.
Nils last suggestions on reset.
Removes the accessory view from non web urls.
Organizes code in the the form activity handler.
Stops using |lastSuggestions| to gate view controller updates,
|[pause / continue]CustomViewController| is used instead.

Bug: 845472
Change-Id: I751015f9bd2b7b085c15a10fd41fd949dc1fa672
Reviewed-on: https://chromium-review.googlesource.com/c/1355179Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612280}

Use enumeration statistic type and no index fields.

Bug: 1182320
Change-Id: If45573cd4572fd9ed634710a026ac898e001a0cf
Reviewed-on: https://chromium-review.googlesource.com/c/1354329Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612279}

BUG=b:118408409
TEST=try

Change-Id: Id4eab57052f4221d5150e68294f54a22821f22df
Reviewed-on: https://chromium-review.googlesource.com/c/1354400Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612278}

Bug: 907282
Change-Id: I239dfb4ed667e6584bd598f7221003271ee7185b
Reviewed-on: https://chromium-review.googlesource.com/c/1347270Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612277}

This reverts commit 4fd1b68c.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Sheriff] Disable document-user-activation.html on Linux.
> 
> It's flaky.
> 
> Tbr: tkent@chromium.org
> Bug: 910211
> Change-Id: I66a8cf70781d906fd97fda1a22f9d5050b273613
> Reviewed-on: https://chromium-review.googlesource.com/c/1355487
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612255}

TBR=sebsg@chromium.org

Change-Id: I9f41384c2a4b9dce100eecf1603f33a9f7ca6bbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910211
Reviewed-on: https://chromium-review.googlesource.com/c/1355431Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612276}

https://dawn.googlesource.com/dawn.git/+log/813bfbd06112..df72914a60d5


git log 813bfbd06112..df72914a60d5 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 cwallez@chromium.org Result: Add default template for Result<T, E>


Created with:
  gclient setdep -r src/third_party/dawn@df72914a60d5

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I5f9f01249f952b88c7cb97f491920306183d7a21
Reviewed-on: https://chromium-review.googlesource.com/c/1355361Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612275}

AddFirstRunTab, WelcomePages, and WelcomePagesWithPolicy are disabled
due to they failed constantly on Mac. After repeated tests, they seem
working fine so re-enable them now.

BUG=691707

Change-Id: I34e5a191094a488111151a0bccf949b30f26fad7
Reviewed-on: https://chromium-review.googlesource.com/c/1353989Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612274}

It's flaky there are well. Disabled the test altogether for now.

Tbr: jonross@chromium.org
Bug: 910213
Change-Id: Ifbd34680ae3896a5cd9ff99a4791ccc2f8e12289
Reviewed-on: https://chromium-review.googlesource.com/c/1355494Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612273}

Bug: 910211
Change-Id: I32512c338b59e5474a89b32172e2089f96467598
TBR: sebsg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1355491Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612272}

Bug: 903948
Change-Id: Ida8e955b212f26c9938a43cb196d9f90aac3404b
Reviewed-on: https://chromium-review.googlesource.com/c/1351098
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612271}

This patch makes CommitFailedNavigation not use
LoadNavigationErrorPage, which is left for loading
renderer-initiated error pages. That allows us
to simplify LoadNavigationErrorPage and unify all three
renderer-initiated calls.

Bug: 855189
Change-Id: Ic56fe7b63376e0c4d92d4fb38b87e9d20aae85a5
Reviewed-on: https://chromium-review.googlesource.com/c/1338919Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612270}

This is a reland of 93ee1837

This includes a fix to //ash:ash_unittests which was throwing
a linker error which resulted in the original being reverted.

Original change's description:
> [Media Session] [1/4] Move MediaMetadata to service
>
> This CL moves the MediaMetadata and MediaImage mojo types
> from Blink to the Media Session service along with their
> mapped types in content.
>
> This is the first of four parts.
>
> BUG=875004
>
> Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74
> Reviewed-on: https://chromium-review.googlesource.com/c/1227401
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605481}

Bug: 875004
Change-Id: Id04143a89594a523f323ac16a54d93f1f2447367
Reviewed-on: https://chromium-review.googlesource.com/c/1318802Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612269}

This prevents removing runtime apps on package change event.
This fixes the issue when running Andorod Instant apps are closed
on package update. They appear in ARC as runtime app.

TEST=Manually, unit_test
BUG=b/119671931

Change-Id: Ife214bafb11a7b86c2b8fa86eea9824f1bc6e6d6
Reviewed-on: https://chromium-review.googlesource.com/c/1354686
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612268}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I984e218d26ca92c1f531fbec9267a0de56ea0c57
Reviewed-on: https://chromium-review.googlesource.com/c/1352422Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612267}

Bug: chromedriver:1997
Change-Id: Ic231f01e68cc141877d501b5aee6926bc48ac1ee
Reviewed-on: https://chromium-review.googlesource.com/c/1355172Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612266}

Otherwise they're hitting an old Mac version and can't find xcode

Change-Id: Ie959d5fa958001822cace2160fb6c45516b8f602
Reviewed-on: https://chromium-review.googlesource.com/c/1355131Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612265}