GitLab

This patch makes editing/selection/vertical-*.html to use w3c test harness
rather than pixel match for ease of maintain.

This is the first patch of three patches of rewriting vertical-*.html.
Due by Windows command prompt limitation, we can't upload once.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1463673003

Cr-Commit-Position: refs/heads/master@{#361252}

BUG=528489

Review URL: https://codereview.chromium.org/1474593002

Cr-Commit-Position: refs/heads/master@{#361251}

Cr-Commit-Position: refs/heads/master@{#361250}

The type of shared memory used is controlled by an A/B experiment. If the
experiment isn't present, use Mach primitives.

BUG=466437

Review URL: https://codereview.chromium.org/1453383002

Cr-Commit-Position: refs/heads/master@{#361249}

Revert of Disable kEnableGpuMemoryBufferCompositorResources on Mac (patchset #1 id:1 of https://codereview.chromium.org/1435133003/ )

Reason for revert:
This is no longer needed now that 48 has branched and https://codereview.chromium.org/1463853002/ is landed.

Original issue's description:
> Disable kEnableGpuMemoryBufferCompositorResources on Mac
>
> This caused an uptick in crashes due to GpuMemoryBuffers failing to
> allocate.
>
> BUG=554541
> TBR=reveman
>
> Committed: https://crrev.com/c5b6a85810bd669a3916587ac4d70ac566351258
> Cr-Commit-Position: refs/heads/master@{#359396}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554541

Review URL: https://codereview.chromium.org/1470213002

Cr-Commit-Position: refs/heads/master@{#361248}

Mus+ash changes to GpuProcessTransportFactory for Chrome rendering under a
mojo shell checked the command line directly to enable mojo shell mode
because IsRunningInMojoShell wasn't available. Since it is now, use it.

Review URL: https://codereview.chromium.org/1464663003

Cr-Commit-Position: refs/heads/master@{#361247}

Revert of Enable compositor-thread property trees (patchset #1 id:1 of https://codereview.chromium.org/1449143004/ )

Reason for revert:
This is causing overscroll on Mac to fail. Just using the flag --disable-compositor-property-trees fails to make this go away -- I had to do a manual revert
BUG=559550

Original issue's description:
> Enable compositor-thread property trees
>
> This enables compositor-thread property trees for all clients of cc.
> It also replaces the existing --enable-compositor-property-trees flag
> with a --disable-compositor-property-trees flag.
>
> BUG=481585
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/f626d0b9d0fb2bfde430cf63c5111df7da1fba6f
> Cr-Commit-Position: refs/heads/master@{#360635}

TBR=enne@chromium.org,jaydasika@chromium.org,piman@chromium.org,ajuma@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481585
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1469733006

Cr-Commit-Position: refs/heads/master@{#361246}

security_interstitials::ControllerClient needs to be subclassed by a
standalone class, instead of being part of the SecurityInterstitialPage.

Eventually, future classes like security_interstitials::ClockError will
take ControllerClients as inputs. Until all of the blocking pages have
been updated to take ControllerClients, the functionality needs to
remain available from within the SecurityInterstitialPage, so I've put
in some temporary wrapper methods.

BUG=488673
TBR=cschuet@chromium.org

Review URL: https://codereview.chromium.org/1467063002

Cr-Commit-Position: refs/heads/master@{#361245}

Mark this test failing on Linux/NVIDIA because it's too flaky to retry.

BUG=544989
TBR=zmo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1471963003

Cr-Commit-Position: refs/heads/master@{#361244}

Replacement for https://codereview.chromium.org/1416793005/

BUG=484261

Review URL: https://codereview.chromium.org/1456943003

Cr-Commit-Position: refs/heads/master@{#361243}

This way the WM can correctly see the set of properties during creation and we don't need a bunch of round trips for setting individual properties.

BUG=548424
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1474543002

Cr-Commit-Position: refs/heads/master@{#361242}

This will hopefully illuminate some of the problems inherent with the low resolution clock on windows.

If filtering by high resolution proves to be an effective way to de-noise UMA, we can come up with next steps and potentially migrate more histograms to use this model (or allow post-processing filtering).

For now, we will only bucket FirstContentfulPaint, as we think it's our best metric to date.

BUG=394757

Review URL: https://codereview.chromium.org/1473443002

Cr-Commit-Position: refs/heads/master@{#361241}

This is a little complex, for reasons that are explained in the code
comments. Also, this refactors ChromotingUtil to make it easier to tint
arbitrary Drawables.

Review URL: https://codereview.chromium.org/1461893002

Cr-Commit-Position: refs/heads/master@{#361240}

BUG=560603
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/1473533003

Cr-Commit-Position: refs/heads/master@{#361239}

Continuing https://codereview.chromium.org/1412083002 but:
Removed emojis from generated_resources.grd and update the code.
Now we are keeping Emojis in the code rather than resource files.

BUG=498288
TEST=Follow these steps (taken from bug report):
1. Open multiple Chrome windows (optionally with multiple tabs)
2. Play sound clip (e.g via youtube) on a given tab
3. Drop down the Window menu
4. It is also possible to mute the tab and see what will happen but
chrome://flags/#enable-tab-audio-muting should be enable.

Review URL: https://codereview.chromium.org/1432803002

Cr-Commit-Position: refs/heads/master@{#361238}

Check active tree state separately, on each PrepareToDrawOnThread.

The source of the flakiness that the
test previously made assumptions about the timing of draws (when the active
tree's draw properties get updated) vs commits.

BUG=546867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1472723002

Cr-Commit-Position: refs/heads/master@{#361237}

Also tweak the newline at the end of the stamp file to be
compatible with update.sh. This way, if either downloads
clang the other will consider it up-to-date.

BUG=494442
NOTRY=true

Review URL: https://codereview.chromium.org/1468243002

Cr-Commit-Position: refs/heads/master@{#361236}

Missing braces when adding code inside an "if" block,
resulting in lots of attributes being marked as editable
when they shouldn't be, breaking VoiceOver.

Regression happened in:
https://crrev.com/6185ca046850b24b92a5dffd9ab7d1ecc3048001
https://codereview.chromium.org/1435113003/

BUG=559210,473220

Review URL: https://codereview.chromium.org/1473483002

Cr-Commit-Position: refs/heads/master@{#361235}

They are not used yet, but will be soon.

BUG=548424
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1471693004

Cr-Commit-Position: refs/heads/master@{#361234}

BUG=560550

Review URL: https://codereview.chromium.org/1471153002

Cr-Commit-Position: refs/heads/master@{#361233}

The breakability of the object doesn't matter here. The space shortage that
prevented an object from fitting in one column may very well be the lowest
space shortage that we'll ever find. So always record it, to avoid
over-stretching columns.

BUG=559133
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1465193002

Cr-Commit-Position: refs/heads/master@{#361232}

Adds translation one-box triggering when the user selects
using long-press.  This currently requires server-side
auto-detection of the source language, but it should not
over-trigger due to a feature of the one-box (suppressed
when the source and target text ends up matching).

Adds a separate flag to control disabling this feature,
currently default-enabled.

BUG=413717

Review URL: https://codereview.chromium.org/1463583004

Cr-Commit-Position: refs/heads/master@{#361231}

Stacks that are truncated due to the Win32StackFrameUnwinder being
unable to unwind are being reported with an extra frame.

BUG=555770

Review URL: https://codereview.chromium.org/1469983002

Cr-Commit-Position: refs/heads/master@{#361230}

We have a large set of histograms that were set up private
before our feature launched, that should now be public.
This adds those existing histograms.
Removing the private ones will be done soon in the private
repository.

BUG=545055

Review URL: https://codereview.chromium.org/1441013004

Cr-Commit-Position: refs/heads/master@{#361229}

This implements proper handling of lost context by exosphere. It
also improves support for software compositing by not crashing.
True software compositing support will be added by follow up
patches.

BUG=549781
TEST=exo_unittests --gtest_filter=BufferTest.IsLost

Review URL: https://codereview.chromium.org/1467943002

Cr-Commit-Position: refs/heads/master@{#361228}

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's no single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=

Review URL: https://codereview.chromium.org/1471523002

Cr-Commit-Position: refs/heads/master@{#361227}

This adds the mock classes and a initial tests for the
ReaderModeManager.

BUG=

Review URL: https://codereview.chromium.org/1469973002

Cr-Commit-Position: refs/heads/master@{#361226}

Revert of Makes window manager include ui pak file (patchset #1 id:1 of https://codereview.chromium.org/1466483003/ )

Reason for revert:
I'm reverting this and will instead include it in the wm.

Original issue's description:
> Makes window manager include ui pak file
>
> We'll need this for cursors and shadows.
>
> BUG=548426
> TEST=none
> R=erg@chromium.org
>
> Committed: https://crrev.com/35b0cd220fd2a788c16055b756e8483936b0e384
> Cr-Commit-Position: refs/heads/master@{#361162}

TBR=erg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548426

Review URL: https://codereview.chromium.org/1472753003

Cr-Commit-Position: refs/heads/master@{#361225}

These tests have never worked on perf bots, and are currently disabled. See
https://code.google.com/p/chromium/issues/detail?id=530405#c10 for more details.

BUG=530405
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1463503003

Cr-Commit-Position: refs/heads/master@{#361224}

Revert of Start calling show/hide onStart/onStop in DocumentActivity (patchset #1 id:1 of https://codereview.chromium.org/1455343002/ )

Reason for revert:
BUG=559197

This was causing an early tab.show call which made the test think the activity is in the foreground.

Reverting my CL for now. Will have to figure out a proper way to hide/show to reland.

Original issue's description:
> Start calling show/hide onStart/onStop in DocumentActivity
>
> This logic in documents diverge from CHromeActivity behavior for
> archaic reasons (crbug.com/451672). Making documents show/hide
> in the same time as all other ChromeActivities with this change.
> Verified that the previous bug that caused the bheavior divergence
> no longer exists after this CL.
>
> BUG=546182
>
> Committed: https://crrev.com/e548d4580bbd915716a855f9195b6f5f2d63d2a1
> Cr-Commit-Position: refs/heads/master@{#360581}

TBR=dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=546182

Review URL: https://codereview.chromium.org/1464313003

Cr-Commit-Position: refs/heads/master@{#361223}

R=michaelpg@chromium.org,apacible@chromium.org
TBR=isherman@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1468623004

Cr-Commit-Position: refs/heads/master@{#361222}

The internal Attribute and AttributeCollection need not know anything
about the web-exposed Attr.

Since Attr::qualifiedName() is not just a trivial getter, calling that
outside of the loop is probably a good idea anyway.

Review URL: https://codereview.chromium.org/1467143004

Cr-Commit-Position: refs/heads/master@{#361221}

BUG=internal b/21639416

Review URL: https://codereview.chromium.org/1473003002

Cr-Commit-Position: refs/heads/master@{#361220}

This problem was already fixed in r360646, but was broken again due
incorrect merge in r361205.

TBR=kelvinp@chromium.org

Review URL: https://codereview.chromium.org/1468283002

Cr-Commit-Position: refs/heads/master@{#361219}

If the frame that called the chrome.webstore.install method to begin an
inline install gets deleted before the user accepts from the dialog, we
don't want the install to continue because a navigation could make it
look like the install request was coming from some unrelated site.

One downside of this approach is that the dialog stays around even after
the frame is deleted, and hitting either accept or cancel buttons both
just cancel the install. It would be better if the dialog is
automatically cancelled, but doing that would involve a lot more
refactoring. The approach in this CL was easier and is probably worth
getting out, and we can improve on it in the future.

BUG=550047

Review URL: https://codereview.chromium.org/1403293008

Cr-Commit-Position: refs/heads/master@{#361218}

One layout test needs rebaselining with the next Skia roll:
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/79661/layout-test-results/results.html

BUG=559240
NOTRY=true
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1468053003 .

Cr-Commit-Position: refs/heads/master@{#361217}

This fixes a bunch of positioning and cropped selection bugs.

BUG=548087

Review URL: https://codereview.chromium.org/1461783003

Cr-Commit-Position: refs/heads/master@{#361216}

Force full invalidation after layoutScope.setNeedsLayout() in PaintLayerScrollableArea::finalizeScrollDimensions()

This is a partial revert of https://codereview.chromium.org/799093002
which caused the bug.

This is a temporary measure to workaround crbug.com/560418
for crbug.com/535161.

BUG=535161,560418

Review URL: https://codereview.chromium.org/1471453002

Cr-Commit-Position: refs/heads/master@{#361215}

WKWebView sets the title to blank when the web process dies; ignore that
update so that the navigation item won't end up with a blank title.

BUG=558178

Review URL: https://codereview.chromium.org/1461413004

Cr-Commit-Position: refs/heads/master@{#361214}

Add info to the network part of the timeline flamechart.

BUG=528489

Review URL: https://codereview.chromium.org/1463393003

Cr-Commit-Position: refs/heads/master@{#361213}