- 15 May, 2018 40 commits
-
-
Charlie Harrison authored
These metrics are unmonitored, and the predictor is being replaced by a new system. Bug: 831006 Change-Id: I2f3260637581960b059319e92f434091426252bb Reviewed-on: https://chromium-review.googlesource.com/1057461Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558670}
-
Joel Hockey authored
Add a new ContentScanner class for crostini that shows an empty directory and spinner whilst starting and mounting the crostini container. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5dd83c7db3783fff2d0298234d16bb00478ba3d8 Reviewed-on: https://chromium-review.googlesource.com/1059427 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558669}
-
Chris Pickel authored
This reverts commit fc95501f. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 557680 as the culprit for introducing flakiness in the tests as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmM5NTUwMWZiMjllM2U3NDg3ZmZmOThjMTdlNmFhYmExMDQ2YjMzMAw Original change's description: > Create BrowserThread::IO thread before browser main loop to start > ServiceManager. > > We need a thread to post/execute tasks when starting the > ServiceManager. This thread needs to be created before the browser > main loop is initialized, and will be registered as the > BrowserThread::IO thread which is currently used by ServiceManager > connections. > > The creation of such a thread is moved to service_manager::main via > MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no > thread created before calling fork() on posix, we also move the setup > of sandbox before creating the IO thread. > > Bug: 740677, 729596 > Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1 > Reviewed-on: https://chromium-review.googlesource.com/969098 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557680} TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 740677, 729596 Change-Id: Ia548067acbf640010f4c8fbed29a0012a274af05 Reviewed-on: https://chromium-review.googlesource.com/1059167Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#558668}
-
Kent Tamura authored
Thew new test is added to SmokeTests in order that Android build bots run it. Bug: 838898 Change-Id: I18f8320550a82fb5fddc0c98f0b8f0417f1e4d80 Reviewed-on: https://chromium-review.googlesource.com/1056947Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558667}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/558cf7d7..df9ba269 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I356073fdce19d4bd2454a3c84969bdc7726b64d7 Reviewed-on: https://chromium-review.googlesource.com/1058917Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558666}
-
Joel Hockey authored
Set NavigationListModel.linuxFilesItems async from FileManager to allow directoryTree redraw which is required to show the item when FilesApp first launches. Remove specialized SFTPMountItem class and combine Recent and Linux Files to use NavigationModelFakeItem and DirectoryTree/FakeItem. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie840c8826368df5c63b608dcc5be59601f6452cb Reviewed-on: https://chromium-review.googlesource.com/1059368 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Currently CompleteSweep() is forced in the epilogue of Scavenger. If the Scavenger is scheduled close after a BlinkGC then completing sweeping can introduce large pause. Blink GC should synchronize with V8 Mark-Compact GC and should be independent from Scavenger. Change-Id: I8ae10c1d914a1182f3848d20252123795cd931a9 Reviewed-on: https://chromium-review.googlesource.com/1059148 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558664}
-
Colin Blundell authored
On ChromeOS, IdentityManager has its primary account info set by UserSessionManager (see crbug.com/814787). At this point in the flow, the email address that UserSessionManager knows about is the sanitized email address. Hence, that is what gets set with IdentityManager. However, this email address can be updated in AccountTrackerService later on in response to the user info being fetched (see details in crbug.com/842041); in particular, if the user entered a non-sanitized version when creating their gmail account (e.g., f.o.o@gmail.com vs. foo@gmail.com), it will get updated to the user-entered version (note that the accountID used by AccountTrackerService to track the account is not changed; it is only the email address that is updated). This behavior is causing an IdentityManager DCHECK to go off, as it sees that its view of the primary account's email address doesn't match that of SigninManagerBase. This CL inserts a hack so that IdentityManager updates its email address in these cases. crbug.com/842670 tracks the need for a long-term solution for this problem. This CL also adds a unittest that fails before this change. Note: On other platforms, the email address passed to SigninManager's signin flow is already the user's originally-specified version. To test, sign in on a ChromeOS debug build with an email address that was created in non-canonical form (e.g., when the gmail account was originally created, the user added some periods in the email address). Verify that no DCHECK goes off. TBR=msarda@chromium.org Bug: 842041 Change-Id: Ic4097e2091640fc44d242a7aba5062a3a85b367c Reviewed-on: https://chromium-review.googlesource.com/1057233 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#558663}
-
https://webrtc.googlesource.com/src.git/+log/8a150d9c2134..5702736f7e46 $ git log 8a150d9c2..5702736f7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:755660 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0593ca5d9f2ccf1eb7f7df04b2df6faa21eeb94 Reviewed-on: https://chromium-review.googlesource.com/1059014 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558662}
-
Noel Gordon authored
NOT_IN_GUEST_MODE is the default guest mode for a TestCase. Remove it in TestCase calls by adding an explicit, one-arg TestCase constructor (which is therefore NOT_IN_GUEST_MODE by default). No change in behavior, no new tests. Bug: 843030 Change-Id: Ib46f5f047c74c426d56ceacb1f6ab8334ccd88a7 Reviewed-on: https://chromium-review.googlesource.com/1059101Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558661}
-
Noel Gordon authored
Bug: 843030 Change-Id: Idf992fd81fa8647b13458ded9f47a83b8bc5a222 Reviewed-on: https://chromium-review.googlesource.com/1059099Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c185e5a2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17648 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: I797f4b7b0cab5d35567f22fcdfa443e7299ae48f Reviewed-on: https://chromium-review.googlesource.com/1058915 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558659}
-
Joel Hockey authored
Add fileManagerPrivate.isCrostiniEnabled and fileManagerPrivate.mountCrostiniContainer. Add paper-progress polymer lib to test.html. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If90e8005100286229219a9771b488722b0f14275 Reviewed-on: https://chromium-review.googlesource.com/1059098Reviewed-by:
-
Boris Sazonov authored
A follow-up to https://crrev.com/c/1047870. This CL removes initPreference, onBindViewToPreference and onClickPreference helper methods from ManagedPreferenceDelegate interface, adding corresponding static methods to ManagedPreferencesUtils instead. It also moves null checks into these methods, making ManagedPreferenceDelegate param @Nullable. Bug: None Change-Id: I53e3669962c21e68a00b83dcde38b229d0b44364 Reviewed-on: https://chromium-review.googlesource.com/1057472Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558657}
-
https://webrtc.googlesource.com/src.git/+log/739351d4760f..8a150d9c2134 $ git log 739351d47..8a150d9c2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I743dfb844b5bcb91958897af64d58704f36d8d80 Reviewed-on: https://chromium-review.googlesource.com/1059012Reviewed-by:
-
Guido Urdaneta authored
With this patch, the network state of elements playing inactive streams is NETWORK_IDLE and the state of elements playing active streams is NETWORK_LOADING. Before this CL, the network state was always NETWORK_LOADING, which prevented media elements from being garbage collected, which was a source of JavaScript memory leaks and made it easy to reach limits in the number of active low-level audio streams. Drive-by: Fix the case of addition of stopped tracks to a stream. Bug: 771550 Change-Id: Id0d8e27fc30c9850e5ad43d7a3887c03a9415a18 Reviewed-on: https://chromium-review.googlesource.com/1057808 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558655}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia6931b2d1840af16c0752c7af744b9b94c5777d2 Reviewed-on: https://chromium-review.googlesource.com/1059013 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558654}
-
Noel Gordon authored
std::tuple<> is not a good passenger to have on the great browser test renaming ship. Throw it overboard, and replace with TestCase: a struct to cargo all our test options into the future. Current options are the GuestMode and |test_name| so no change in test behavior here. Bug: 843030 Change-Id: I85636ae502aa1b46f434884eeafaa0b2c2dcadd2 Reviewed-on: https://chromium-review.googlesource.com/1057747Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558653}
-
Hayato Ito authored
We don't need to have virtual/incremental-shadow-dom test suites because IncrementalShadowDOM became experimental (or stable, which would be done later). Bug: 776656 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I80a10d95aa5ba0135305ca8245efd1625dc9b729 Reviewed-on: https://chromium-review.googlesource.com/1059091Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558652}
-
Chris Pickel authored
This reverts commit b54641a0. Reason for revert: Findit has detected a flake at test All/PasswordManagerBrowserTestWithViewsFeature.NoFormElementTest/1. Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I4dd593c829c25e8f45ad816f6a3ddd3b941d76af Regression range: None Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzM4NDY3L2Jyb3dzZXJfdGVzdHMvUVd4c0wxQmhjM04zYjNKa1RXRnVZV2RsY2tKeWIzZHpaWEpVWlhOMFYybDBhRlpwWlhkelJtVmhkSFZ5WlM1T2IwWnZjbTFGYkdWdFpXNTBWR1Z6ZEM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Original change's description: > Change some password browser tests to produce user input. > > This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually. > The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. > > Bug: 842643 > Change-Id: I4dd593c829c25e8f45ad816f6a3ddd3b941d76af > Reviewed-on: https://chromium-review.googlesource.com/1054675 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558296} TBR=battre@chromium.org,vasilii@chromium.org Change-Id: I3f54c76a4e3bb797f894750b16e1cdd6970e0d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842643 Reviewed-on: https://chromium-review.googlesource.com/1059168Reviewed-by:
-
Marton Hunyady authored
kErrorCodeNoUpdate introduced in http://crrev.com/c/1055857 kRollbackNotPossible introduced in http://crrev.com/c/1047610 BUG=840432 Change-Id: Id6a7697b6db70a01503e10196997c800a3522a5a Reviewed-on: https://chromium-review.googlesource.com/1047866Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#558650}
-
Ricky Liang authored
The original CL broke the component build due to a typo in the export macro. It should have been CAPTURE_EXPORT instead of MEDIA_EXPORT in camera_3a_controller.h, and the functions in camera_metadata_utils.h should be exported as well. Original change's description -------------------------------------------------- media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice This CL implements the TakePhoto() API for the Chrome OS camera HAL VideoCaptureDevice, including the following features: - Full size still capture - Auto-focus, auto-exposure, and auto-white-balancing stabilization BUG=chromium:832772 TEST=Run capture_unittests on DUT TEST=Make sure TakePhoto() API works on https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html TBR=wuchengli@chromium.org,emircan@chromium.org Change-Id: Ia44506b30315df2aaff9047ff725fff95d3ba118 Reviewed-on: https://chromium-review.googlesource.com/1058881 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558649}
-
Hans Wennborg authored
Apparently lambdas are non-literal types before C++17, and Clang errors about this after r332286. TBR=thakis Bug: 843046 Change-Id: I9ec058e9e4e74e418d36d1875f7e51bf0d1165c1 Reviewed-on: https://chromium-review.googlesource.com/1059111Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558648}
-
Matt Falkenhagen authored
Pass the network factory instead of the URLLoaderFactoryGetter, as they only need the network factory. Change-Id: Ie421f779d18edec9217bc8f3a5fe4946b75719d6 Reviewed-on: https://chromium-review.googlesource.com/1058746 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558647}
-
Gustav Sennton authored
To ensure support library methods calls are only called on webview / support library versions where they're supported we use feature flags. This CL adds feature flags for APIs related to WebMessages (postmessages). Bug: 813118 Change-Id: Ic0d06df79da079a0d9c87ce09cd9fc720d6a244c Reviewed-on: https://chromium-review.googlesource.com/1041931 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558646}
-
Mike Frysinger authored
Bug: None Change-Id: Ib1079c2c37ba772ac3c9a73927c24ecf0cf19d98 Reviewed-on: https://chromium-review.googlesource.com/1058699Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#558645}
-
Yoshifumi Inoue authored
This patch gets rid of unused declaration |Element::RecalcOwnStyleForReattach()| for improving code health. Change-Id: I9c9b1331a59614d8bdf8f1ced03e4e8348db0da0 Reviewed-on: https://chromium-review.googlesource.com/1058877 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558644}
-
Philip Jägenstedt authored
These tests are already doing fairly well on Chrome: https://wpt.fyi/css/css-masking However, there's also at least one Chrome-only failure: https://wpt.fyi/css/css-masking/parsing/clip-path-invalid.html Note that some of the tests are still problematic: https://wpt.fyi/css/css-masking/clip-path https://github.com/w3c/web-platform-tests/issues/7543#issuecomment-388744004 No-Try: true Change-Id: I036e08fd44b12291f8fcce386b67b7d5897365da Reviewed-on: https://chromium-review.googlesource.com/1057090Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#558643}
-
Hans Wennborg authored
Bug: 843032 Change-Id: I0aabddd2f0ae520fcd46a5c6532289547da7cde3 Reviewed-on: https://chromium-review.googlesource.com/1058796Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Alan Cutter authored
This is a small code clean up to use ranged based for loops instead of manual iterator logic. This reduces the line wrapping and makes the type of the iterated values more obvious in some cases. Bug: 809816 Change-Id: I4f6e856a4dcd052d3d7ec5befd5792b9c1f09602 Reviewed-on: https://chromium-review.googlesource.com/1058987Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#558641}
-
Vasilii Sukhanov authored
Currently the function always generates capital letters regardless of the parameters. Change-Id: I7b1f11743c3ba2463e7fd5268d29400d3c71792b Reviewed-on: https://chromium-review.googlesource.com/1056533Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#558640}
-
Matt Falkenhagen authored
This ships updateViaCache which controls whether the browser cache is used for service worker update checks. Importantly, this changes the default behavior, since the default value of updateViaCache is 'imports', which skips the browser cache for the main service worker script and uses it only for import scripts. However, actually checking import script contents for updates is not yet implemented, so effectively the default is 'none': https://crbug.com/648295. Thanks to Emma Haruka Iwao (yuryu@) for doing the bulk of the implementation work. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RwjXGTAbuuA/7Q3NPlJ4BAAJ Bug: 675540 Change-Id: Ifdbaaa76b028e07ac26b9db28d9c59c7b8bd055f Reviewed-on: https://chromium-review.googlesource.com/1056756 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#558639}
-
Hiroki Nakagawa authored
Worklets don't support dynamic import (see the issue) Bug: 782538 Change-Id: Iea9b4352122e78d1ff671ae09a9947f6a7f1ef3b TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1058883Reviewed-by:
-
Christopher Lam authored
This CL fixes an issue with JS externs generation for Interface types in mojo. This was blocking https://chromium-review.googlesource.com/c/chromium/src/+/1053381. Bug: 632206 Change-Id: I164bc3d9e9b0fd43f438dfefeaa2bc6e731fd1e7 Reviewed-on: https://chromium-review.googlesource.com/1053332Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#558637}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=oshima@chromium.org Change-Id: Icb169f38374388d9acada35cb4ced2bdc4cc7509 Reviewed-on: https://chromium-review.googlesource.com/1058696Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558636}
-
Marc Treib authored
TBRing trivial call site update in avatar_button_error_controller.cc TBR=msarda Bug: 839834 Change-Id: I3f01a7fd80d4699101e6d7002e85b9829d0aa881 Reviewed-on: https://chromium-review.googlesource.com/1057672 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558635}
-
Hitoshi Yoshida authored
To merge common processes into one place, this CL make CodeGeneratorV8 inheritances to use CodeGeneratorBase.render_templates(), which was renamed from render_template(). This CL also make normalize_and_sort_includes() to use set() type to avoid include duplicates. Bug: 830255 Change-Id: I7e723153930ae55cab04d5a5fdb38b51c3494434 Reviewed-on: https://chromium-review.googlesource.com/1058743Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/08d96f1cadb1..473b4ae489e8 $ git log 08d96f1ca..473b4ae48 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 thestig Lower the limit of image dimensions for fax codecs. 2018-05-15 thestig Read data in bigger chunks in fax codec code. 2018-05-15 thestig Clean up CBC_ASCIIEncoder. 2018-05-15 thestig Return earlier in CPDF_TextPage::ProcessInsertObject() when possible. Created with: roll-dep src/third_party/pdfium BUG=chromium:834633,chromium:834633 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I67c2cecc2867cf1ea9506e502702c67a3b1f5843 Reviewed-on: https://chromium-review.googlesource.com/1058927Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558633}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7e9e7b065a98..c8e4e795ed75 $ git log 7e9e7b065..c8e4e795e --date=short --no-merges --format='%ad %ae %s' 2018-05-14 bpastene Revert "[chromite] Capture job_name and git timing for ts_mon in cbuildbot runs." Created with: roll-dep src/third_party/chromite BUG=chromium:829289 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifcc9ffe22c45cf58facf0522b1e9604c3638b9b9 Reviewed-on: https://chromium-review.googlesource.com/1058980Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558632}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60f2c3c7. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17636 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=markdittmer No-Export: true Change-Id: I0dc71858072594d862992196ba0d94f72b057f43 Reviewed-on: https://chromium-review.googlesource.com/1058911 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
