GitLab

This CL adds MockCertVerifierRuleAndroid#setResult() which enables
individual tests to customize the certificate verification result.

BUG=997796

Change-Id: I9efd46db72523049fd72754103dafaff33e75021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869763Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707558}

Bug: 1014959
Change-Id: I72f36884a3bc36e7d39a93314ec3c4e770ddd10a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869371
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707557}

Bug: b/141992733
Change-Id: Ifff0300df4c36ae8eed67541bda35a5fb0187013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869832Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707556}

Bug: 1015974
Change-Id: I643d415f8dca086461c54a4080286f27ef0929c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869028
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707555}

Although unlikely, it's possible that AutocompleteMatch::
InlineTailPrefix() could access past the end of its classification.
Check for this and avoid it. Also adds unit test.

Bug: 1013103
Change-Id: Iccb23643c06ca952567a99bfa7cbe7cdeb335d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869117Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707554}

Change-Id: Idb32f317aadba2d4480bd5d01034ac3e45f86d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869720
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707553}

This change adds a "TouchToFill.UserActions" histogram and enum and adds
corresponding logging logic. This histogram records how users interact
with the Touch To Fill sheet and logs whether they select a credential,
dismiss the sheet explicitly or select the "Manage Passwords" option.

Bug: 1013134
Change-Id: Ic8dc3da3b6ae8339ad299373760e20c9453c5925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868954Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707552}

Screenshot on Android 8
https://screenshot.googleplex.com/UVZOQ5FA2nh.png

Bug: 993920
Change-Id: Id5036c2183ec28ef029e2fb8e19a35b83d7c5755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848370
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707551}

Change-Id: I2412e00ef5686d9b551bdae4a7dc8e1f4a696876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869718Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707550}

This CL creates the Media History database and the accopmanying tables
that will be used to store information relating to media engagement.

Design doc: https://docs.google.com/document/d/1RAq_RY-R87Dlrkbjnq5ghs7Joax2JIKBHuFBHMlqFdc

Bug: 997813
Change-Id: I3848d172a8cda7b42ead4aa6f409435d6fc83412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857044
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707549}

media/video-currentTime.html is flaky on Mac 10.13.
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29

TBR=srirama.m@samsung.com

Bug: 1015975
Change-Id: I437a177d43f614653c26ab4369d15d62c7021cc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869683Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707548}

This change adds aria-label and aria-describedby to inputs.

This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1648916 which has been split into small changes.

Bug: 963183
Change-Id: Ia9c29f1aeb4d95b2535d755d0b7772bbaff161cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817413Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707547}

Using wpt-import in Chromium 65bb2a31.
With Chromium commits locally applied on WPT:
6386d9d8 "Update service_worker_unregister_and_register()"
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
ba49a3d6 "autofocus: Change the timing of 'flush autofocus candidates'"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I9084a620d63de61da10b37a73219905a0be1bff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869287Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707546}

SitePerProcessBrowserTestWithSadFrameTabReload.ReloadHiddenTabWithCrashedSubframe
is flaky on Linux.
https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel

TBR=jyasskin@chromium.org

Bug: 1015971
Change-Id: Ib5c06204dfce22f0ccd2622cbfacba4d90613c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869762Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707545}

Background attachment doesn't apply to color backgrounds. We should
always treat them as default attachment.

The added condition is like how we check if there is effective
fixed-attachment background elsewhere using

The changed code is special because we check background-attachment
of individual fill layer.

FillLayer: :AnyLayerHasFixedAttachmentImage().
Change-Id: I877bf7e3cb1a9e23f463d53b64acb507720d37e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868839Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707544}

Change-Id: Id181aa4fe87701830b5e843bc693ef8eb4041b63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866552
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707543}

This CL refers to these two images:
https://storage.cloud.google.com/chromium-translation-screenshots/4cac9b5f4f523d130b9c666ea7978a6ccd2c29d1
https://storage.cloud.google.com/chromium-translation-screenshots/9459e00d739be97acb35e43a6d3b4d1b34dece2d

Bug: 1013374
Change-Id: I3c77c4a949c3daf0c00ea48f2f537fc263ca96f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869830Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707542}

This is a reland of 0908b290

Original change's description:
> Fix calculation of inner padding of OOBE dialog depending on outer margins
> 
> Bug: 1007294
> Change-Id: I99b7b3cc46e12c0fb060f76e086f5f31bd4cb812
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865216
> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
> Auto-Submit: Denis Kuznetsov <antrim@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707055}

Bug: 1007294
Change-Id: Iba03d0ed0f931ed50ced79b30dea18735fb127f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868990Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707541}

I made a fuzzer for this because this code is kind of complex.

Also, the user's clipboard can contain pretty arbitrary data, so we
want to validate we can handle all inputs with no problems.

Change-Id: Ifaa25d47d5cdc247bf7f73425011bab8deadd135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869075Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707540}

This works around the fact that the 10.14 config is not complete and
doesn't work for [ Mac ] expectations.

Also refactors our test_suites.pyl entries to deduplicate our giant
list of command line flags and tighten down on unnecessary flags on
some systems.

Bug: 984818   # WebGL CTS tracking issue
Bug: 1014785  # Worked-around expectations bug
Change-Id: I215a01a349262cecdf54bcbc6f6c8137b4426f5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867990Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707539}

Regression from:
https://chromium-review.googlesource.com/c/chromium/src/+/1842222

Bug: 1014915
TBR=khorimoto@chromium.org

Change-Id: I8b26ffc6015d1ed6e7fce8391c935f5f7ae83b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865753Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707538}

Note: this will also be used by D3D11VideoDecoder in the future.

The old way of just checking D3D11Device->CheckFormatSupport lies about
whether the processor / enumerator really can support those profiles.
This cl makes a new checker which can create an enumerator and then
check the formats that way.

Change-Id: I9f25e633c161095410909afa3ba88ca4f2e09000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864349
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707537}

Things that will be logged under normal mode:
PADDING_FRAME: The number of padding bytes.
NEW_CONNECTION_ID_FRAME: the new connection id, and its sequencer_number.
NEW_TOKEN_FRAME: The address validation token received.
RETIRE_CONNECTION_ID_FRAME: the sequencer number.
MESSAGE_FRAME: the frame length.

Change-Id: Id66fbe17dd9a35437fe1d5162b57d5a0b995134a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832717Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707536}

Bug: 978490
Change-Id: I0169f66399a9f02dcca8cce5e0e6aaefde1d67a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869448
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707535}

https://chromium.googlesource.com/catapult.git/+log/c98b1ee7e410..a5c8651cfccb

git log c98b1ee7e410..a5c8651cfccb --date=short --no-merges --format='%ad %ae %s'
2019-10-18 crouleau@chromium.org [Telemetry] Move abridged benchmark flag to story_filter.py.

Created with:
  gclient setdep -r src/third_party/catapult@a5c8651cfccb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:985103
Change-Id: I298ecddffd757cdedbcf0a09879d7848dfec853a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869446Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707534}

BUG=b:136128691
TEST=arc.Boot

Change-Id: Ife8a4f5eabd790e1f73c7b08e4ade4272a3100ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867410Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707533}

We implement 0-RTT by having Connect() return early at the socket level
and then, at the request level, if the request should not be sent over
0-RTT, we additionally wait for ConfirmHandshake() to fully finish the
handshake.

The existing logic around LoadTimingInfo picks up the Connect() time,
but not the ConfirmHandshake() time. That means servers that enable
0-RTT will see POST requests decrease their connectEnd time, despite the
actual request still being sent after a 1-RTT handshake. This doesn't
make sense so, if ConfirmHandshake() was called and returned
asynchronously, adjust LoadTimingInfo accordingly.

See also https://github.com/w3c/resource-timing/issues/199.

Bug: 926299
Change-Id: Icd7fb3661aec72e2a6de183a4aa9efbe06097fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869529Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707532}

Previously, there was a delay while the new destination was retrieved
where the previous destination's icon showed with the new text. This
looked odd, so update the icon immediately on selection.

Bug: None
Change-Id: Ifda42525c82726b84fa9277839deaa197169bc57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859590Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707531}

This change adds accessible text to columns in the coverage tool
that were not previously screen reader accessible. It adds accessible text
for the Total bytes column to prevent the numbers from being read separately
due to the spaces. It adds a label to the Unused Bytes column to prevent
screen readers from interpreting the column as 1 large percentage
instead of separate bytes value and percentage values.
And it  adds accessible text to describe the bars
in the last column. Text reads
"X% of file unused. Y% of file used."

Before: https://imgur.com/qpAwxVF

After: https://imgur.com/GTqrstQ

Bug: 963183
Change-Id: I2b69cc32e935f94d2138f7964f449a4f0472182a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710753Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707530}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ia6a87c8a2e8d520357a4c6b8213df894fed94a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869734Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707529}

WakeOnWifiConnectObserver seems like a good candidate to be converted
to a KeyedService, but its lifetime doesn't match up with Profile
lifetime very well (particularly due to being destroyed early in some
cases).

It's not necessary to listen for profile destruction because normal
profiles aren't destroyed until browser shutdown, by which time
WakeOnWifiManager is gone. OTR profiles aren't observed since they
are never added to the ProfileManager.

Bug: 268984
Change-Id: Ie669931e04661363b4080c329e708beeb00ba53c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867124
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707528}

Change-Id: Ie68765ef6dcf9293f40d901ec9a066d0a530bb9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868934
Commit-Queue: Xinan Cheng <xinan@google.com>
Auto-Submit: Xinan Cheng <xinan@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707527}

Change-Id: I4162b02c2f733f5353985402b3c77d4d9e6f4451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869754Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707526}

This fixes a bug where opcode count was incremented (+=)
rather than set when opcodes were serialized into backing memory.

In turn this allow todoing the use of a uint32_t for low level policy
|options_| internal storage.

policy_engine_opcodes.h:243
// TODO(cpu): Making |options_| a uint32_t would avoid casting, but causes
// test failures.  Somewhere code is relying on the size of this struct.
// http://crbug.com/420296

It turns out that the test failure occurred not because of a structure
being the wrong size. Instead when policy_low_level.cc
LowLevelPolicy::Done() was called twice (because a rule was
changed or added) the memory to which rules were stored was not
zeroed before filling the memory.
This meant while most memory was rewritten with
new values the count of opcodes was instead incremented.

It's not entirely clear to me why this did not break before as
this resulted in an incorrect opcode count for any case where
::Done() was called twice but my hypothesis is:

a) ::Done() was not called twice in production nor in most tests.
b) The memory allocated for policies is much larger than required
so no sanitizers would locate a OOB read or write.
c) The alignment of the structures with a uint16_t for |options_|
caused the rule engine, when attempting to read twice as many
rules as required, to interpret the 'next' rule as a
OP_ALWAYS_FALSE and so return something sensible in these
cases. This changed when the size of the value, and packing,
stretched the size of the PolicyOpcode structure, so that when
reading past the end of the rules an invalid opcode type of
0x10 would be read (the next entry's count) which resulted
in the test failing.

Bug: 420296
Change-Id: I806a70d66fba9d4cd831df64658ded2c9545be9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867476
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707525}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f4ca326d0db..8fbf366d1dac


Created with:
  gclient setdep -r src-internal@8fbf366d1dac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I3f90062158616e8ea0b02e9a7c494ebf06cbdd70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869436Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707524}

This trybot runs webkit layout tests with NGFragmentItem runtime flag
set.

R=bpastene@chromium.org, jbudorick@chromium.org

Bug: 1011768
Change-Id: I6480b284d3119e07d636388fc6fb2f4b631da5d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850255
Commit-Queue: Anushruth  <anushruth@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707523}

... So that cookies accessed don't have to be marked as being OK for 3p
access once we require explicit marking for such (SameSite=none).

(The Android change also looks at HttpOnly cookies, which it didn't before,
 but that's probably OK since if you can set an HttpOnly cookie you can set
 a non-HttpOnly one).

Bug: 1015171

Change-Id: I2fcace302c272b0f08f09214ebfe72b9aee14203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853109Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707522}

This change adds tests to ensure autofill and autocomplete state
are plumbed correctly to the accessibility tree.

This change also consolidates when and where we fire these
notifications.

Change-Id: I1888b71445cf4c5db356dae090dc69f58362f077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845916Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707521}

Reverted CL is in PS1.
New CL is in the latest PS.

Reason for revert: The commit tried to access the scroll_element_id
of a scrollbar layer that was destroyed causing a use-after-free. The
bot that caught this (WebKit Linux ASAN) doesn't run during the DryRun.

[Original CL that got reverted]: https://crrev.com/c/1854534

CL description:
This CL stabilizes a test that fails due to defererencing a freed raw
pointer in cc::ScrollbarController. The fix is to get rid of that raw
pointer entirely and instead, retrieve the ScrollbarLayerImplBase on
demand using the CapturedScrollbarMetadata.

Bug: 1002828, 987115, 1014930
Change-Id: Ica9128f616f6ad83f72f7e94659a9bc81bc3d1c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865529
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707520}

With the NetworkService, InterceptDownloadIfApplicable is always called
on the UI thread.

Remove some overrides that are unnecessary, and unconditionally intercept
downloads --- rather than missing some, and cancelling them in
DetermineDownloadTarget.

Bug: none
Change-Id: Ia85f420d7d7aca3d14823e1d38d597e07bbf3f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866551Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707519}