- 11 Jul, 2014 40 commits
-
-
avi@chromium.org authored
BUG=371151 TEST=everything still works Review URL: https://codereview.chromium.org/367113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282545 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
This CL makes the ownership of the pp::Buffer_Dev clear: 1) If the PpbBuffer owns the pp::Buffer_Dev, it always calls allocator_->Release() during the destructor so that the buffer is returned to the allocator_ and can be reused. 2) If TakeBufferDev() is called. PpbBuffer doesn't own the pp::Buffer_Dev any more. The caller of TakeBufferDev() needs to make sure allocator->Release() is called sometime later to return the buffer to allocator_. BUG=392497 TEST=Tested with random stream switch video. Review URL: https://codereview.chromium.org/374353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282544 0039d316-1c4b-4281-b951-d872f2087c98
-
shuchen@chromium.org authored
BUG=391674 TEST=Verified on pixel device. Review URL: https://codereview.chromium.org/375363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282543 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282542 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
Use gfx::DeviceDisplayInfo::GetPhysicalDisplayWidth/Height() when avaialble as this is a more accurate value for display size as window decorations etc. have not been subtracted. BUG=365877 Review URL: https://codereview.chromium.org/374303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282541 0039d316-1c4b-4281-b951-d872f2087c98
-
falken@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177867:177877&mode=html TBR=yutak@chromium.org,junov@chromium.org BUG= Review URL: https://codereview.chromium.org/387623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282540 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
Original CL: https://codereview.chromium.org/336923002/ BUG=384650 Review URL: https://codereview.chromium.org/382053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282536 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
This change simplifies the URLLoader interface, eliminating the URLLoaderClient interface. The URLResponse now includes the DataPipeConsumerHandle for the response body stream as well as information about a possible redirect response. One nice thing about this change is that you can now pass around the URLResponsePtr without also having to pass around the DataPipeConsumerHandle for the response body stream. This didn't enable me to eliminate ResponseDetails as I think that structure should include not only the URLResponse but also the URLLoader used to generate the response. (That enables the LaunchInstance to get destroyed immediately after delegating the response to the handler app as it no longer needs to stick around to keep the URLLoader alive.) The recipient of the URLLoader might be interested in calling the new QueryStatus method to find out more information about the URL load (e.g., Blink wants to know the encoded size of a response body, which may not be available at the time when response headers are received). Review URL: https://codereview.chromium.org/373373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282535 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
If the server sends down no changes, then the update is cancelled. Previously, this left stale temporary files in the profile. BUG=none Review URL: https://codereview.chromium.org/381243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282534 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
* Rename "max state" value to "num states" so it sounds less like it's the largest valid state * Shorten/simplify code * Reduce indenting * No else after return * Use scoping objects where possible * Return directly out of switches where possible * Don't handle DCHECK failure * Omit NOTREACHED messages (not necessary in tracking down bugs) * "const" goes on same line as last function arg * Order "disabled/hovered/normal/pressed" cases the same way every time * Fix spelling errors * Eliminate unnecessary {}s BUG=none TEST=none Review URL: https://codereview.chromium.org/377423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282533 0039d316-1c4b-4281-b951-d872f2087c98
-
matthewyuan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282532 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
Added CustomLauncherPageContents, which is copied from AppWindowContents and modified to provide launcher pages instead. This correctly dispatches messages to the extensions system. The extension inside the launcher page is now "activated" which ensures that it is styled as a platform app and given the correct APIs by the extension dispatcher. BUG=391137 BUG=391202 Review URL: https://codereview.chromium.org/365013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282530 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
Fix the HTML5 drag and drop demos at http://www.w3schools.com/html/tryit.asp?filename=tryhtml5_draganddrop and http://html5demos.com/drag on Linux and CrOS This CL makes the behavior of OSExchangeData::Provider::SetString() match that of Windows on Linux and CrOS This CL also changes the string which is dragged out of the omnibox on Linux and CrOS to match the string which is dragged out from the omnibox on Windows. On Linux and CrOS, with this CL, the dragged out string for URLs no longer includes 'http://' if 'http://' is not visible in the omnibox. For instance, if the user has navigated to 'www.random.org', the dragged out string is 'http://www.random.org' without this CL and 'www.random.org' with this CL. BUG=355390 TEST=OSExchangeDataTest.URLAndString Review URL: https://codereview.chromium.org/208313009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282529 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
to be a removable drive. Particularly this is the case for some USB sticks. We are fixing this by changing the device listing to list all drives that are either removable or attached via USB. We have already done a similar change for Chrome OS due to some SD card readers listing themselves as non-removable. Chrome OS lists all SD or USB drives. However, we do not have a reliable way to detect SD cards on Windows and Mac so we will continue to use the removable flag. BUG=392943 Review URL: https://codereview.chromium.org/382023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282528 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=370746 Review URL: https://codereview.chromium.org/384973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282527 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
Part of getting OpenSSL working on OS X, the networking_private_crypto.cc implementation is renamed to networking_private_crypto_nss.cc and a stubbed out version networking_private_crypto_openssl.cc. BUG=393023 Review URL: https://codereview.chromium.org/387753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282526 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This error seems to pop up when adb is not currently running. It isn't clear to me why we get that instead of NoSuchProcess, but in any case, this should allow us to continue instead of aborting like in: http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1022/steps/device_status_check/logs/stdio BUG=388885 Review URL: https://codereview.chromium.org/385733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282525 0039d316-1c4b-4281-b951-d872f2087c98
-
kouhei@chromium.org authored
This should fix a document leak from r270279. BUG=392121 Review URL: https://codereview.chromium.org/380533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282524 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
BUG=387985 TEST=components_unittests Review URL: https://codereview.chromium.org/382663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282523 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
The condition should find entry change but '!' is missing so far. BUG=392055 TEST=manually Review URL: https://codereview.chromium.org/383463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282522 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=391943 TBR=nduca@chromium.org Review URL: https://codereview.chromium.org/389443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282521 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=393024 Review URL: https://codereview.chromium.org/384983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282516 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282513 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
r=wtc Review URL: https://codereview.chromium.org/380403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282511 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
For some applications where we need to keep multiple copies of the audio bus around (particularly in STL containers), a scoped_ptr to an audio bus isn't enough. For those rare situations, we're adding a RefCounted version of the AudioBus. R=dalecurtis@chromium.org BUG=None. Review URL: https://codereview.chromium.org/388563005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282510 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=bruening@chromium.org BUG=392585 Review URL: https://codereview.chromium.org/386863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282509 0039d316-1c4b-4281-b951-d872f2087c98
-
lcwu@chromium.org authored
BUG=336640 Review URL: https://codereview.chromium.org/223143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282508 0039d316-1c4b-4281-b951-d872f2087c98
-
yhirano@chromium.org authored
In order to update forbidden header names in Blink side, I remove a subtest from a browsertest. I will restore the subtest once the Blink side CL[1] is landed. 1: https://codereview.chromium.org/378183003/ BUG=373120 Review URL: https://codereview.chromium.org/385523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282507 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
This is done by setting results_are_the_same_on_every_page property on TimelineBasedMeasurement to False. BUG=393049 Review URL: https://codereview.chromium.org/387783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282506 0039d316-1c4b-4281-b951-d872f2087c98
-
ppi@chromium.org authored
This patch uses the existing browser_navigation_start field in FrameMsg_Navigate to set the navigation start time for browser navigations in new tabs. For browser navigations that result in cross-site swap, the value is later overriden with the end of the beforeunload event of the current document. BUG=376004 Review URL: https://codereview.chromium.org/339573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282505 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
The navigation transition needs to apply some styles during the transition, so we need to expose this call to java. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Review URL: https://codereview.chromium.org/375073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282504 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=391943 TBR=nduca@chromium.org Review URL: https://codereview.chromium.org/387753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282502 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
Creating a canvas can fail, so be robust to this. BUG=392587 Review URL: https://codereview.chromium.org/386803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282500 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
The default cookie option excludes http only cookies. And thus causing some streams not being able to play. android bug 66050 Review URL: https://codereview.chromium.org/386723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282499 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
android_tools/sdk/tools/proguard/bin/proguard.sh was removed with SDK tools update. https://gerrit.chromium.org/gerrit/#/c/70802/ updates SDK tools and we want to roll to start using it. BUG=393019 Review URL: https://codereview.chromium.org/377353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282498 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
It still takes time to componentize autocomplete input and search features. However, we have componentized some important parts already. The added code will be replaced by the real autocomplete code in the future, but meanwhile, this is good enough. Feature: - the logic to check if the input looks like URL / host names - canonicalize the input to form the actual URL (http://...) - use TemplateURLService to create the search result page URL if it looks like a query. BUG=387207 R=oshima@chromium.org, hashimoto@chromium.org TBR=pkasting@chromium.org, jar@chromium.org TEST=manually Review URL: https://codereview.chromium.org/382683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282497 0039d316-1c4b-4281-b951-d872f2087c98
-
imcheng@chromium.org authored
Inputs: - directory to libffmpegsumo.so. - network simulation parameters given as a proto. BUG=none Review URL: https://codereview.chromium.org/362123005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282496 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
Having the same name for a grd is bad because the post processor flattens the file so one of them gets overriten with the other. NOTRY=true TBR=blundell BUG=372175 Review URL: https://codereview.chromium.org/381353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282495 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=392874 Review URL: https://codereview.chromium.org/382963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282494 0039d316-1c4b-4281-b951-d872f2087c98
-
dyen@chromium.org authored
It looks like this crash came from the following CL: https://codereview.chromium.org/338523007 R=sehr@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 Review URL: https://codereview.chromium.org/383803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282493 0039d316-1c4b-4281-b951-d872f2087c98
-