- 06 Dec, 2018 40 commits
-
-
Karolina Soltys authored
Follow-up to patch 1353921. Bug: 891670 Change-Id: Ibae12547f3550debeda11cc400b6cb1b6eabfca9 Reviewed-on: https://chromium-review.googlesource.com/c/1363206Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#614308}
-
Mirta Dvornicic authored
webrtc::VideoEncoderFactory::CodecInfo properties are being moved to webrtc::VideoEncoder::EncoderInfo, see: https://crbug.com/webrtc/10065. Bug: webrtc:10065 Change-Id: Ib74503c5390f4f3c148a8039005a28870733a974 Reviewed-on: https://chromium-review.googlesource.com/c/1358061 Commit-Queue: Mirta Dvornicic <mirtad@google.com> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#614307}
-
Hans Wennborg authored
It fails with tip-of-tree Clang because the diagnositics have changed slightly. Disable for now and possible re-enable with updated expectations after the next Clang roll. TBR=thakis Bug: 912021 Change-Id: Ib0d83178ea5c38fa2d19ada720e8526437c916fd Reviewed-on: https://chromium-review.googlesource.com/c/1365434Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#614306}
-
Kunihiko Sakamoto authored
This fixes a bug that viewport width was evaluated to zero when evaluating media queries from Link: rel=preload headers, if "width=device-width" was specified in <meta name="viewport">. viewport_description->max_width has type = kDeviceWidth and value = 0 in such case, so device width must be resolved before overriding viewport dimensions. Note: HTMLPreloadScanner is already doing this, in HandleMetaViewport(). Bug: 590188 Change-Id: Iffb0e031e0316bd41aaf52014609d5e7d0b32284 Reviewed-on: https://chromium-review.googlesource.com/c/1360209 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#614305}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baf62bde47d2..ed9aa80dbd6e Created with: gclient setdep -r src-internal@ed9aa80dbd6e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iff2613e7527e25d3f2621fb252220a890fc26b8e Reviewed-on: https://chromium-review.googlesource.com/c/1365411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614304}
-
Jérôme Lebel authored
This is a reland of 1d497322 This patch also includes implementation for: RLZTrackerDelegateImpl::ShouldUpdateExistingAccessPointRlz() Original change's description: > cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz > > In addition to fixing the DCHECK, this CL contains a speculative fix > for flaky test (crbug.com/907379). The guess for the flakiness is > (not able to repro the failure locally though): > > |RecordProductEvent| may fail to acquire the |ScopedRlzValueStoreLock| > when recording the CAI event, because the lock is being taken by > |UpdateExistingAccessPointRlz|. In tests, the delay for > |ScheduleDelayedInit| is set to zero, so it's possible for this race > condition to happen. But in production, the delay is non-zero. > > I don't think we're losing test coverage by disabling > |UpdateExistingAccessPointRlz| here because the call is a no-op in > tests, and another test (RlzLibTest.UpdateExistingAccessPointRlz) is > testing its implementation. > > Bug: 906293, 907379 > Change-Id: I208919f22edc09fc1a739a1efe1909a71e5a2730 > Reviewed-on: https://chromium-review.googlesource.com/c/1353990 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613172} Bug: 906293, 907379, 911439 Change-Id: Ic1d9f85bc3714f890d2dc7fcc1d070d0711baec0 Reviewed-on: https://chromium-review.googlesource.com/c/1360692 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614303}
-
Kent Tamura authored
mojo_layouttest_test.mojom is renamed to mojo_web_test_helper_test.mojom. It keeps _test suffix indicating it affects only tests. Bug: 843412 Change-Id: Iddfdfcbfd87228fb9ee8abd2777f4838c4b66801 Reviewed-on: https://chromium-review.googlesource.com/c/1362717Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#614302}
-
Philip Jägenstedt authored
This is like the `./wpt run --no-manifest-update` in upstream wpt: https://github.com/web-platform-tests/wpt/blob/81607985fc9485cbf9f3d0a8ae74359f885eb36b/tools/wptrunner/wptrunner/wptcommandline.py#L52-L53 Because updating the manifest is pretty slow, this reduces the time to run a few tests over and over in development when the manifest is not changing. On a Linux workstation, the time to run a single test (dom/historical.html) went from ~14s to ~7s. Bug: 905406 Change-Id: I50e4b8bdd9d3bedbf1e31bc34a2338317a30aaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1361874 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#614301}
-
Clemens Arbesser authored
Also in this CL: - refactoring of parts of the backend to remove redundant and potentially error-prone code - modified unit tests for web_controller to test for UTF-8 compliance of SetFieldValue() Change-Id: Ib7dd2429159a527ec81f325622e8bf6f97c5e5ab Reviewed-on: https://chromium-review.googlesource.com/c/1360691 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#614300}
-
Javier Ernesto Flores Robles authored
Only add the loading indicator if the model hasn't been created Bug: 912085 Change-Id: I0d557013eeb63cf882793460a342e22485fa48d5 Reviewed-on: https://chromium-review.googlesource.com/c/1363179Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#614299}
-
Yutaka Hirano authored
In order to WebDataConsumerHandle deprecation easy, move content::FtpDirectoryListingResponseDelegate to blink. Bug: 910489 Change-Id: I878df1c90c28de1c3f44d9ed48e518207fa831c5 Reviewed-on: https://chromium-review.googlesource.com/c/1358315 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8f1b7a66a5e3..d300548fcc28 git log 8f1b7a66a5e3..d300548fcc28 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 enga@chromium.org Add ANGLE_multi_draw entrypoints to proc table Created with: gclient setdep -r src/third_party/angle@d300548fcc28 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890539 TBR=ynovikov@chromium.org Change-Id: Id92afc679acf0f0e00f46fba3d8806da8987f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/1365175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614297}
-
Kent Tamura authored
The behavior of ListedElement::checkValidity() with kCheckValidityDispatchNoEvent was very simple. This CL introduces IsNotCandidateOrValid() for that behavior, and removes CheckValidityEventBehavior argument of checkValidity(). Change-Id: Ieff28ada30cc47d8617e73306d874cdfa9dee43c Reviewed-on: https://chromium-review.googlesource.com/c/1364990 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614296}
-
Makoto Shimazu authored
Currently NetS13nServiceWorker is enabled by default, and we don't have tests excercising non-S13nServiceWorker path. This flips the test to enable S13nServiceWorker to disabling S13nServiceWorker forcefully. Bug: 715640 Change-Id: I8ba3401989dcd9da46e24cd7dc0500f66a200741 Reviewed-on: https://chromium-review.googlesource.com/c/1365050 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#614295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3dc3d8f696a7..baf62bde47d2 Created with: gclient setdep -r src-internal@baf62bde47d2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I405f390d1485db257fc26dca9ad21eede7227b0f Reviewed-on: https://chromium-review.googlesource.com/c/1365173Reviewed-by:
-
Reka Norman authored
This CL adds a fake page handler to the app management page which is used when accessing chrome://apps?fakeBackend=true. Bug: 906508 Change-Id: Ib92a66a45b312efd14b5fb038d7cc506944dd716 Reviewed-on: https://chromium-review.googlesource.com/c/1360034 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#614293}
-
Mohamed Amir Yosef authored
This CL introduced the ResumableTaskRunner: https://chromium-review.googlesource.com/c/chromium/src/+/1353946 In the class comment where we describe how to make use of the class, one of the lines was not updated with the rest during the last iterations of the review, leaving the example code incorrect. This CL just ensures that we are using consistent variable naming throughout the example. Bug: 909682 Change-Id: I67666306888909e867f624dddb85d003e24604e6 Reviewed-on: https://chromium-review.googlesource.com/c/1363284 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#614292}
-
Fumitoshi Ukai authored
Bug: 901708, 901706 Change-Id: I7eaaf7434a465be2020d7e81ebf08e8d5ca93ba6 Reviewed-on: https://chromium-review.googlesource.com/c/1360452Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#614291}
-
Rakina Zata Amni authored
This reverts commit dcfa9938. Reason for revert: Caused flaky tests: crbug.com/912431 Original change's description: > Add console message in MixedContentChecker::HandleCertificateError > > Print console message when subresources are loaded over broken HTTPS. > Screenshot: https://drive.google.com/file/d/1Sn_2c162NmvCoIXFuFVB68z-MhzphcNT/view?usp=sharing > > Bug: 587168 > Change-Id: I997a8da26f0fe015cc0103b96dcbaa7d40525eb8 > Reviewed-on: https://chromium-review.googlesource.com/c/1306779 > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614212} TBR=sky@chromium.org,meacer@chromium.org,yhirano@chromium.org,japhet@chromium.org,mkwst@chromium.org,livvielin@chromium.org Change-Id: I9142c895af7dd1c6a4c9ea7500ee0eca2ce9d118 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 587168, 912431 Reviewed-on: https://chromium-review.googlesource.com/c/1364974Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#614290}
-
Mario Sanchez Prada authored
Replace usage of SigninManager's API with calls to APIs from the IdentityManager and PrimaryAccountMutator. Bug: 890813 Change-Id: I1a70a47e41aa132f0d5e4a1de12bd7c5d5eb31ce Reviewed-on: https://chromium-review.googlesource.com/c/1259009Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#614289}
-
David Jean authored
Fixed dynamic types for separating labels. Bug: 912030,912028 Change-Id: I1acbfed7fe6569c8af712c45a04b8f86dbbbf0af Reviewed-on: https://chromium-review.googlesource.com/c/1363180 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#614288}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib51caf6f12f66fcb6b8d98ce42033e316e3f87dd Reviewed-on: https://chromium-review.googlesource.com/c/1365390Reviewed-by:
-
dpapad authored
This is in preparation of turning on no-var, and prefer-const ESLint checks for all of chrome/browser/resources/ Bug: 792774 Change-Id: Id1bfd8720970876275499854d4fccce1c911d0b2 Reviewed-on: https://chromium-review.googlesource.com/c/1364053Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#614286}
-
Yuichiro Hanada authored
It should use WMHelper::HasInstance() to check there is WMHelper instance, but WMHelper::GetInstance() was used instead. Bug: 911857 Change-Id: I46249edd757eff5364863365983be6bef905505c Reviewed-on: https://chromium-review.googlesource.com/c/1365093Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#614285}
-
Hiroki Nakagawa authored
Change-Id: Ieb3f3b689f266d0d6c88824accd31a752dd66cbe Bug: 911415 Reviewed-on: https://chromium-review.googlesource.com/c/1360036 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL just moves content_security_policy.mojom from public/platform/ to public/mojom/csp/ for cleanup. This is useful for onion-soupifying shared workers without an additional dependency in BUILD.gn. Change-Id: I1292c6f18613be38c44e592fc1fe8a35fe070966 Bug: 911415 Reviewed-on: https://chromium-review.googlesource.com/c/1362703Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL introduces FetchContext::fetch_client_settings_object_ and makes - FetchContext::GetSecurityOrigin() - FetchContext::GetFetchClientSettingsObject() non-virtual, to make it clearer that FetchContext's SecurityOrigin is always the SecurityOrigin of FetchContext's FetchClientSettingsObject. Bug: 880027 Change-Id: I7ea1cc0edd4d7096b3a0c009c24fcb140d275430 Reviewed-on: https://chromium-review.googlesource.com/c/1352042 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#614282}
-
Noel Gordon authored
The fix for bug 911609 obsoleted a comment about the affected JS code. Let's update the comment too. No-try: true Bug: 873539, 911609 Change-Id: I2477ce8082724bd9ca3f2ab70cd169d6579b22e4 Reviewed-on: https://chromium-review.googlesource.com/c/1364971 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#614281}
-
Hiroki Nakagawa authored
Bug: 835717 Change-Id: Icde42b1dd837ca6110933b5cffc53864b7778a0d Reviewed-on: https://chromium-review.googlesource.com/c/1364811Reviewed-by:
-
Hiroshige Hayashizaki authored
In classic_pending_script.cc, [1] uses GetElement()->GetDocument().Fetcher()->Context() which corresponds to the element document, while before [1] it was GetElement()->GetDocument().ContextDocument() which corresponds to the context document. This CL reverts this change and uses the context document, and adds a regression test derived from a clusterfuzz test case. [1] https://chromium-review.googlesource.com/1351873 Bug: 912046, 880027 Change-Id: I92ca9723c3fdd1c5d9c304e4e196aeb77c75ee88 Reviewed-on: https://chromium-review.googlesource.com/c/1364050Reviewed-by:
-
Christopher Cameron authored
Strictly cut-and-paste patch, should have no functional changes. At present, we don't instantiate a WebContentsViewCocoa in the PWA process (rather, we just create a vanilla NSView in WebContentsNSViewBridge's constructor). To add support for drag-drop in PWAs we'll use a WebContentsViewCocoa in the PWA process, and then mojo-ify the boundaries needed for drag-drop support. Bug: 898608 Change-Id: I90da19a0508872db8f39123d0e55d4bd24afe696 Reviewed-on: https://chromium-review.googlesource.com/c/1363966 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614278}
-
Matt Falkenhagen authored
The existing test was asserting the opposite of the standard, which is to use the response URL. See https://github.com/whatwg/fetch/pull/146. This CL does the following: - Tests that a CSS stylesheet fetched via respondWith(fetch(responseUrl) uses responseUrl as its base URL. - Tests that a CSS stylesheet fetched via respondWith(new Response()) uses the response URL (which is the request URL) as its base URL. - Changes the test to not test cross-origin stylesheets. That is more complex than needed for this test, and there is talk of making subresource requests from opaque stylesheets skip the service worker, which would render the test ineffective for testing base URL. - Changes the test to use waitUntil() in the message event to try to ensure the service worker stays alive between the message and fetch events. Bug: 911974 Change-Id: I167dfe86986ec718a50d512f862f1eb49889608b Reviewed-on: https://chromium-review.googlesource.com/c/1362776 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#614277}
-
Noel Gordon authored
- remove task_contoller_unittest.html - add BUILD rules to auto-generate and compile this unittest - define, install, and use mockChrome in the unittest code - use setupFileManagerPrivate() in all test cases - testExecuteEntryTask had its own local version but the test could also jsut use the common one: make it so. - make all test cases use the createTaskController helper - update JsDoc: a {FileSelectionHandler} is now required - remove the crostini create helper function - remove crostini.init call: no test cases depend on the crostini volume manager fake. - make createTaskController call createCrostiniForTest() when new-ing the {TaskController}. - make MockFileSelectionHandler @constructor, and @extends {FileSelectionHandler} interface, so createTaskController construction is both simple and type-safe. - add decriptive comments for each test case fixture - fix all Closure compiler errors, and auto-format JS code No change in test behavior, no new tests. Bug: 912410 Change-Id: I7a685533632860ce785b9aaca2e84b7c69579979 Reviewed-on: https://chromium-review.googlesource.com/c/1364270 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#614276}
-
Sam McNally authored
Bug: 911609 Change-Id: I69434c3516bc8867eb0a67e2c6df4699887d8ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1364970Reviewed-by:
-
John Abd-El-Malek authored
WriteOrQueue may delete the memory if it's written synchronously (in HandleWriteResult). It looks like on Mac this occurs, while other platforms are always sync, which is why it crashes there. Bug: 884598 Change-Id: Ia45fb3915531cb5b4efadb5e6cf4d0ce82955f29 Reviewed-on: https://chromium-review.googlesource.com/c/1364390Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#614274}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/41fdb78fbbd8..c7cc237f9582 git log 41fdb78fbbd8..c7cc237f9582 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 nduca@google.com Update contributing guide for guidance when git-cl upload fails Created with: gclient setdep -r src/third_party/catapult@c7cc237f9582 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I68591156f328dcb0fb90db3d63008e6c7e3fd72c Reviewed-on: https://chromium-review.googlesource.com/c/1364771Reviewed-by:
-
John Abd-El-Malek authored
Stop calling StoragePartition::GetRequestContext in ChannelID browser code when the network service is enabled. This will always early exit because ChannelID doesn't work with network service. Bug: 837753 Change-Id: Icdd08121e6da55f5a8b6ad1f4cbe2797ca92e8df Reviewed-on: https://chromium-review.googlesource.com/c/1363846Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#614272}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bbdb8efacb83..d138913917ce git log bbdb8efacb83..d138913917ce --date=short --no-merges --format='%ad %ae %s' 2018-12-06 dgarrett@google.com master-postsubmit: Use MasterSlaveLKGMSyncStage. Created with: gclient setdep -r src/third_party/chromite@d138913917ce The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5d0fc5d23e1ab180c4f5193d71219e2280674d25 Reviewed-on: https://chromium-review.googlesource.com/c/1364770Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c84ccb1ff157..6d59568196c0 git log c84ccb1ff157..6d59568196c0 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 reed@google.com change private alloc methods to also take fonts 2018-12-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@6d59568196c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: If986fdbf77b39cbadf18315c0b531e3ccc578742 Reviewed-on: https://chromium-review.googlesource.com/c/1364179Reviewed-by:
-
weidongg@chromium.org authored
Remove the flag and also fixed several test failures in AppListViewFocusTest. Bug: 911003 Change-Id: I361c216d9935dc35add1ab14dd1bcec8bfe45f11 Reviewed-on: https://chromium-review.googlesource.com/c/1358044 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614269}
-
