Commits · afba4e4b79cfdb85a6c13a46971a97ef95ebf719 · eriksson monteiro / tangled

02 Dec, 2018 31 commits

pdf: enable eslint checks for no-var and prefer-const · afba4e4b

dstockwell authored Dec 02, 2018

Most of this change was automated by running `eslint --fix` but a
few cases were resolved manually (in particular global definitions
and typedefs).

Bug: 792774
Change-Id: Iea4e373a088d7d276975bf946a738bc9d81772c3
Reviewed-on: https://chromium-review.googlesource.com/c/1355302
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612985}

afba4e4b

Roll src-internal dfda24364504..ae58624a3a9b (3 commits) · a87dcc51

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfda24364504..ae58624a3a9b

Created with:
gclient setdep -r src-internal@ae58624a3a9b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: Ib268a116f56f6afa15dfa54a65a0e2e0389c416b
Reviewed-on: https://chromium-review.googlesource.com/c/1357897Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612984}

a87dcc51

Roll src-internal 1354d1a0ca50..dfda24364504 (1 commits) · c2329fc5

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1354d1a0ca50..dfda24364504

Created with:
gclient setdep -r src-internal@dfda24364504

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: Idcc3f324ca52f1b4446ffe785a34e86a01ffbc6f
Reviewed-on: https://chromium-review.googlesource.com/c/1357896Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612983}

c2329fc5

Revert "Reland "Avoid recycling sync tabs if commit pending"" · f40e8ac5

Findit authored Dec 02, 2018

This reverts commit a61d2bb4.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612980 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTYxZDJiYjQzMDRkZjgyOGRhNjBhZjA3ZjBiMDVmMzNlNDlmZDE4Zgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/9304

Sample Failed Step: sync_integration_tests

Sample Flaky Test: SingleClientSessionsSyncTest.NavigateThenCloseTabThenOpenTab

Original change's description:
> Reland "Avoid recycling sync tabs if commit pending"
> 
> This is a reland of 62414cfc
> 
> Test improved to avoid flakes.
> 
> Original change's description:
> > Avoid recycling sync tabs if commit pending
> >
> > When a tab is closed, it's possible that the corresponding history
> > hasn't been committed yet, and hence there is a risk that synced history
> > is lost if the entity is recycled (for another tab that is opened).
> >
> > In this patch, and behind a feature toggle, this issue is prevented by
> > *not* freeing tab nodes while the sync entity is unsynced. Old tabs are
> > excluded from this (to avoid problems with expired history) and a max
> > cap is also introduced to the number of tabs in this state, in order to
> > avoid memory regressions.
> >
> > Bug: 882489
> > Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1356541
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612971}
> 
> TBR=treib@chromium.org
> 
> Bug: 882489
> Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f
> Reviewed-on: https://chromium-review.googlesource.com/c/1357086
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612980}

Change-Id: I69bf304dc196b29f2b6ccf5f15ff8dd77ca7d610
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882489, 910947
Reviewed-on: https://chromium-review.googlesource.com/c/1357826
Cr-Commit-Position: refs/heads/master@{#612982}

f40e8ac5

Roll src-internal d33123b9f809..1354d1a0ca50 (2 commits) · fb0e572f

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d33123b9f809..1354d1a0ca50

Created with:
gclient setdep -r src-internal@1354d1a0ca50

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I58962cea7d1ca7bd32a27ca09b215b6e1514760e
Reviewed-on: https://chromium-review.googlesource.com/c/1357895Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612981}

fb0e572f

Reland "Avoid recycling sync tabs if commit pending" · a61d2bb4

Mikel Astiz authored Dec 02, 2018

This is a reland of 62414cfc

Test improved to avoid flakes.

Original change's description:
> Avoid recycling sync tabs if commit pending
>
> When a tab is closed, it's possible that the corresponding history
> hasn't been committed yet, and hence there is a risk that synced history
> is lost if the entity is recycled (for another tab that is opened).
>
> In this patch, and behind a feature toggle, this issue is prevented by
> *not* freeing tab nodes while the sync entity is unsynced. Old tabs are
> excluded from this (to avoid problems with expired history) and a max
> cap is also introduced to the number of tabs in this state, in order to
> avoid memory regressions.
>
> Bug: 882489
> Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b
> Reviewed-on: https://chromium-review.googlesource.com/c/1356541
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612971}

TBR=treib@chromium.org

Bug: 882489
Change-Id: Ib3f3ff9e4d620512435d9b22ba7b2c338f92203f
Reviewed-on: https://chromium-review.googlesource.com/c/1357086Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612980}

a61d2bb4

Roll src-internal affb25a9e181..d33123b9f809 (1 commits) · 3a9cafd9

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/affb25a9e181..d33123b9f809

Created with:
gclient setdep -r src-internal@d33123b9f809

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I46761826d6c9bf0a748dad070bc253b35ea5bebb
Reviewed-on: https://chromium-review.googlesource.com/c/1357894Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612979}

3a9cafd9

Roll src-internal 565bc6695ef2..affb25a9e181 (2 commits) · c59e0fdd

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/565bc6695ef2..affb25a9e181

Created with:
gclient setdep -r src-internal@affb25a9e181

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I0e3bdea97fa4e1e7267c0dcfe4c253918e29f54e
Reviewed-on: https://chromium-review.googlesource.com/c/1357893Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612978}

c59e0fdd

Roll src/third_party/webrtc 0cc11b4b947e..21d8b181f663 (47 commits) · a4fc9569

chromium-autoroll authored Dec 02, 2018

https://webrtc.googlesource.com/src.git/+log/0cc11b4b947e..21d8b181f663

git log 0cc11b4b947e..21d8b181f663 --date=short --no-merges --format='%ad %ae %s'
2018-12-02 kwiberg@webrtc.org Remove some unused forward declarations
2018-12-01 zstein@webrtc.org Add transaction id to candidate pair event log parser and encoder.
2018-12-01 zstein@webrtc.org Log DTLS writable changes to RtcEventLog
2018-12-01 benwright@webrtc.org Add BufferedFrameDecryptor to cleanly deal with receiving encrypted frames.
2018-12-01 qingsi@webrtc.org Revert "Fix output period in RtcEventLogImpl"
2018-11-30 magjed@webrtc.org Android: Add constant for native EGL NO_CONTEXT
2018-11-30 zstein@webrtc.org Reland "Add transaction id to CandidatePairEvents."
2018-11-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 173a384b..3546854f (612554:612694)
2018-11-30 ouj@fb.com Parse `ice_unwritable_timeout` and `ice_unwritable_min_checks` from RTCConfiguration into IceConfig
2018-11-30 steveanton@webrtc.org Add integration test for new GetStats() with many tracks
2018-11-30 eladalon@webrtc.org Fix output period in RtcEventLogImpl
2018-11-30 sprang@webrtc.org Remove deprecated VideoEncoder metadata methods
2018-11-30 mirtad@webrtc.org Add metadata from VideoEncoderFactory::CodecInfo to VideoEncoder::EncoderInfo
2018-11-30 nisse@webrtc.org Move implementation of LoopbackMediaTransport to .cc file
2018-11-30 srte@webrtc.org Fixes DCHECK bug in LinkCapacityEstimator.
2018-11-30 srte@webrtc.org Friendlier error messages from data unit classes.
2018-11-30 sprang@webrtc.org Revert "Add transaction id to CandidatePairEvents."
2018-11-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 77dd2659..173a384b (612445:612554)
2018-11-30 braveyao@webrtc.org desktop_capture: apply scale to cursor relative positon on Mac only
2018-11-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6514607..77dd2659 (612330:612445)
2018-11-29 zstein@webrtc.org Add transaction id to CandidatePairEvents.
2018-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a7ee900..d6514607 (612216:612330)
2018-11-29 srte@webrtc.org Extracts LinkCapacityEstimator from AimdRateControl.
2018-11-29 sprang@webrtc.org Cap probing bitrate to max total allocated bitrate
2018-11-29 crodbro@webrtc.org Unittests for loss based bandwidth estimation.
2018-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f85d2e4d..0a7ee900 (612092:612216)
2018-11-29 phoglund@webrtc.org Revert "Various VP9 high fps fixes"
2018-11-29 phoglund@webrtc.org Try UWP with msvc.
2018-11-29 sprang@webrtc.org Make simulcast screenshare default-on
2018-11-29 nisse@webrtc.org Delete method EncodedFrame::GetBitstream, part 2
2018-11-29 nisse@webrtc.org Move size() method to EncodedImage base class
2018-11-29 phoglund@webrtc.org Disable goma for uwp bots.
2018-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f5059a4..f85d2e4d (611832:612092)
2018-11-29 phoglund@webrtc.org Add Win UWP bots.
2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 28d61688..2f5059a4 (611644:611832)
2018-11-28 steveanton@webrtc.org [Unified Plan] Fix old GetStats() not associating track id
2018-11-28 zstein@webrtc.org Log DTLS state changes to RtcEventLog
2018-11-28 hta@webrtc.org Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 yvesg@webrtc.org [Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 oprypin@webrtc.org Add new names of perf bots that will be migrated to LUCI
2018-11-28 ssilkin@webrtc.org Keep bitrate constraints.
2018-11-28 artit@webrtc.org Reland "Run robolectric tests for Android on several Android API versions"
2018-11-28 nisse@webrtc.org Add video support to LoopbackMediaTransport
2018-11-28 nisse@webrtc.org Delete ssrc book-keeping in NetEq
2018-11-28 andersc@webrtc.org React to changes in either width or height in iOS Metal renderer.
2018-11-28 sakal@webrtc.org Add missing files to AAR.
2018-11-28 nisse@webrtc.org Delete method EncodedFrame::GetBitstream, part 1

Created with:
gclient setdep -r src/third_party/webrtc@21d8b181f663

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:909784,chromium:None,chromium:None,chromium:none,chromium:None,chromium:690537,chromium:None,chromium:None,chromium:906988,chromium:907849,chromium:908001
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia2a0ebb98aeece46ef99b2c5f9e622f088ba3822
Reviewed-on: https://chromium-review.googlesource.com/c/1357892Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612977}

a4fc9569

Revert "Avoid recycling sync tabs if commit pending" · 949ec112

Findit authored Dec 02, 2018

This reverts commit 62414cfc.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 612971 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjI0MTRjZmNkZThiNzA0NTk5ODQ3ZDZhY2M3MzFkMjU0NDc5NjU1Zgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/31315

Sample Failed Step: sync_integration_tests on (none) GPU on Mac on Mac-10.11

Sample Flaky Test: SingleClientSessionsSyncTest.NavigateThenCloseTabThenOpenTab

Original change's description:
> Avoid recycling sync tabs if commit pending
> 
> When a tab is closed, it's possible that the corresponding history
> hasn't been committed yet, and hence there is a risk that synced history
> is lost if the entity is recycled (for another tab that is opened).
> 
> In this patch, and behind a feature toggle, this issue is prevented by
> *not* freeing tab nodes while the sync entity is unsynced. Old tabs are
> excluded from this (to avoid problems with expired history) and a max
> cap is also introduced to the number of tabs in this state, in order to
> avoid memory regressions.
> 
> Bug: 882489
> Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b
> Reviewed-on: https://chromium-review.googlesource.com/c/1356541
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612971}

Change-Id: I7735b817751abcbd18bded6a731115333ee50b26
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882489, 910947
Reviewed-on: https://chromium-review.googlesource.com/c/1357999
Cr-Commit-Position: refs/heads/master@{#612976}

949ec112

Roll src-internal baba3f8b15c5..565bc6695ef2 (2 commits) · 3556685a

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baba3f8b15c5..565bc6695ef2

Created with:
gclient setdep -r src-internal@565bc6695ef2

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I0ad2a56fea1a565c23057f43eea4627b1b43e6b2
Reviewed-on: https://chromium-review.googlesource.com/c/1357891Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612975}

3556685a

Roll src-internal b6d4fb5081ba..baba3f8b15c5 (3 commits) · bac1fec7

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6d4fb5081ba..baba3f8b15c5

Created with:
gclient setdep -r src-internal@baba3f8b15c5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I1c4d1798c941dfaa21a2c690ca7937ec2d48c8fa
Reviewed-on: https://chromium-review.googlesource.com/c/1357890Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612974}

bac1fec7

Roll src/third_party/chromite d5cded1697ed..58dc4bf4fc2b (1 commits) · 8fe1c2fc

chromium-autoroll authored Dec 02, 2018

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5cded1697ed..58dc4bf4fc2b

git log d5cded1697ed..58dc4bf4fc2b --date=short --no-merges --format='%ad %ae %s'
2018-12-02 garryxiao@chromium.org group_baseline: add group suzy-q

Created with:
gclient setdep -r src/third_party/chromite@58dc4bf4fc2b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=chrome-os-gardeners@chromium.org

Change-Id: I352aa8e5d7c44279b132955585f0573eb160e920
Reviewed-on: https://chromium-review.googlesource.com/c/1357889Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612973}

8fe1c2fc

Roll src-internal c8b231e26255..b6d4fb5081ba (2 commits) · 567511c8

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8b231e26255..b6d4fb5081ba

Created with:
gclient setdep -r src-internal@b6d4fb5081ba

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: Ifbec2721c4c1559eb9f3acaca9ae3264593e780b
Reviewed-on: https://chromium-review.googlesource.com/c/1357888Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612972}

567511c8

Avoid recycling sync tabs if commit pending · 62414cfc

Mikel Astiz authored Dec 02, 2018

When a tab is closed, it's possible that the corresponding history
hasn't been committed yet, and hence there is a risk that synced history
is lost if the entity is recycled (for another tab that is opened).

In this patch, and behind a feature toggle, this issue is prevented by
*not* freeing tab nodes while the sync entity is unsynced. Old tabs are
excluded from this (to avoid problems with expired history) and a max
cap is also introduced to the number of tabs in this state, in order to
avoid memory regressions.

Bug: 882489
Change-Id: I6dd796642f9553f2713a0814731897a4ffb13f0b
Reviewed-on: https://chromium-review.googlesource.com/c/1356541
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612971}

62414cfc

Roll src-internal 86ff2e751864..c8b231e26255 (2 commits) · 4c5dd75b

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86ff2e751864..c8b231e26255

Created with:
gclient setdep -r src-internal@c8b231e26255

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I991cebf66786d1f49a828e90fb54b4c402de9068
Reviewed-on: https://chromium-review.googlesource.com/c/1357886Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612970}

4c5dd75b

Roll AFDO from 72.0.3626.0_rc-r1 to 73.0.3628.0_rc-r1 · 850eb03b

chromium-autoroll authored Dec 02, 2018

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=gbiv@chromium.org

Change-Id: I72fdde7e958faeebc986bbfe0b9107bdf1240bb0
Reviewed-on: https://chromium-review.googlesource.com/c/1357920Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612969}

850eb03b

Roll src-internal 2ec7409514ed..86ff2e751864 (4 commits) · 3efcf5f5

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ec7409514ed..86ff2e751864

Created with:
gclient setdep -r src-internal@86ff2e751864

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I39c6c6338c435945d321ea0c431f08068debf630
Reviewed-on: https://chromium-review.googlesource.com/c/1357884Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612968}

3efcf5f5

Roll src-internal 248876f7b6b1..2ec7409514ed (1 commits) · 21c20248

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/248876f7b6b1..2ec7409514ed

Created with:
gclient setdep -r src-internal@2ec7409514ed

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I6745961f09d6d366b59d52eaa8b519de70d2551a
Reviewed-on: https://chromium-review.googlesource.com/c/1357882Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612967}

21c20248

Roll Fuchsia SDK from 912a4908d4c4 to 59b243456fcd · 5367e555

chromium-autoroll authored Dec 02, 2018

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Icbb5afb6b21e64e5717717b68182e4480f45be5e
Reviewed-on: https://chromium-review.googlesource.com/c/1357880Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612966}

5367e555

Roll src-internal 4bc9893eed87..248876f7b6b1 (2 commits) · 907af718

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bc9893eed87..248876f7b6b1

Created with:
gclient setdep -r src-internal@248876f7b6b1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I0d0cd5441f42a6df4e3f136594cf29a2000e29b4
Reviewed-on: https://chromium-review.googlesource.com/c/1357881Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612965}

907af718

sqlite: Update process for changes in README.chromium. · a71e1021

Victor Costan authored Dec 02, 2018

This CL aligns the process for changing SQLite with the new process for
upgrading SQLite.

Change-Id: I0bfd95855606642de569844145b1d4b0117341c4
Reviewed-on: https://chromium-review.googlesource.com/c/1349458
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612964}

a71e1021

Updating trunk VERSION from 3628.0 to 3629.0 · b2e129e8

chrome-release-bot authored Dec 02, 2018

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Id31f83702db71aece936782e49233448184a486a
Reviewed-on: https://chromium-review.googlesource.com/c/1357899Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612963}

b2e129e8

Roll src-internal 62c2383b006d..4bc9893eed87 (3 commits) · 60e2ab10

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62c2383b006d..4bc9893eed87

Created with:
gclient setdep -r src-internal@4bc9893eed87

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I03ea70135d7783831b51d552de1bea3b8c0dd422
Reviewed-on: https://chromium-review.googlesource.com/c/1357879Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612962}

60e2ab10

Roll src-internal 480454475db7..62c2383b006d (2 commits) · 17c0c5f2

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/480454475db7..62c2383b006d

Created with:
gclient setdep -r src-internal@62c2383b006d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I9dac876007d538d04e65a967ef80e1093e5aabb2
Reviewed-on: https://chromium-review.googlesource.com/c/1357738Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612961}

17c0c5f2

sqlite: Remove source code for old release 3.25.2. · 27abebbd

Victor Costan authored Dec 02, 2018

Bug: 892852
Change-Id: I6c43809d5a74ffd4648442fe30f3c505999e219b
Reviewed-on: https://chromium-review.googlesource.com/c/1354315Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612960}

27abebbd

android: Enable sampling crashpad dumps for WebView · 14d509ec

Joshua Peraza authored Dec 02, 2018

Both the browser and child processes determine whether they will
produce crash dumps at initialization. When crash dumping is disabled
for the browser, no signal handler is installed. Child processes with
crash dumping disabled will still install a signal handler so the
browser and any observers can be notified of the crash, but the child
process will send a byte along with its message to the CrashHandlerHost
noting whether a dump should be produced.

Change-Id: I7acde16b604ecdcad124cb95677e127fc099e0e8
Reviewed-on: https://chromium-review.googlesource.com/c/1298651
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612959}

14d509ec

Roll src-internal 6c2434aa5b5b..480454475db7 (2 commits) · cfc449cd

chromium-internal-autoroll authored Dec 02, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c2434aa5b5b..480454475db7

Created with:
gclient setdep -r src-internal@480454475db7

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I688074ec0e7222741b9cc4594f90ab922f30aa96
Reviewed-on: https://chromium-review.googlesource.com/c/1357735Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612958}

cfc449cd

Roll src/third_party/chromite ac9b0ff799ae..d5cded1697ed (1 commits) · 4df0d221

chromium-autoroll authored Dec 02, 2018

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac9b0ff799ae..d5cded1697ed

git log ac9b0ff799ae..d5cded1697ed --date=short --no-merges --format='%ad %ae %s'
2018-12-01 dburger@chromium.org Stop generating URLs per their "waterfall"

Created with:
gclient setdep -r src/third_party/chromite@d5cded1697ed

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=chrome-os-gardeners@chromium.org

Change-Id: I6359f71ce3227c39d931cc1df614cc734b0d3372
Reviewed-on: https://chromium-review.googlesource.com/c/1357736Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612957}

4df0d221

Quit the loop immediately upon animation complete · d62d5106

Mitsuru Oshima authored Dec 02, 2018

The task posed in the complete callback can be executed
under load if it waits for idle. Explicitly exit upon
animation complete instead.

Bug: None
Test: Test no longer fails under load
Change-Id: Ibef010506fd7a888615b7d2d304d0a04c826d00d
Reviewed-on: https://chromium-review.googlesource.com/c/1357668Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612956}

d62d5106

Add tools for dumping WebView embedder apps · 59582aea

Joshua Peraza authored Dec 02, 2018

Adds DumpWithoutCrashingForClient() which enables generating a dump on
behalf of the embedding app (represented by AwDebugCrashReporterClient)

This also includes refactoring of native code in minidump_uploader
to expose MimeifyReport() and WriteBodyToFile(), to be used by
AwDebug::DumpWithoutCrashing() in the followup CL.

Change-Id: If528bf060b6acaa51d0facaf1f1adf784c1852e6
Reviewed-on: https://chromium-review.googlesource.com/c/1269099
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612955}

59582aea

01 Dec, 2018 9 commits

Add check for search_result_ pointer to prevent browser crash · 59f9c856

Matthew Mourgos authored Dec 01, 2018


Fixes browser crash after search result answer card search

Bug: 910388
Change-Id: I7ab881d2cf4da2920439be73da2977a7c436b6af
Reviewed-on: https://chromium-review.googlesource.com/c/1356715Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612954}

59f9c856

Roll src-internal b296c5011167..6c2434aa5b5b (2 commits) · 41e4b43a

chromium-internal-autoroll authored Dec 01, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b296c5011167..6c2434aa5b5b

Created with:
gclient setdep -r src-internal@6c2434aa5b5b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I8806fa299af37a0e55d3b0c0ec2169c783a26354
Reviewed-on: https://chromium-review.googlesource.com/c/1357839Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612953}

41e4b43a

Roll src-internal 9cee82d2dd3b..b296c5011167 (2 commits) · a8c9f5d3

chromium-internal-autoroll authored Dec 01, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9cee82d2dd3b..b296c5011167

Created with:
gclient setdep -r src-internal@b296c5011167

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: Ia5686062e709bd637fa0ac87efbfa76f54fff6ea
Reviewed-on: https://chromium-review.googlesource.com/c/1357734Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612952}

a8c9f5d3

Plumb flag and settings for BlinkGenPropertyTrees finch trial · 63481331

Philip Rogers authored Dec 01, 2018

This patch plumbs a flag and settings for a BlinkGenPropertyTrees
finch trial. Because we have dependencies on the existing command line
flag (--enable-blink-gen-property-trees), the command line flag has not
been removed in this patch but will be removed in a followup.

Bug: 836884
Change-Id: I73d4c01964b953397d1857a9ee130502792b3d4a
Reviewed-on: https://chromium-review.googlesource.com/c/1355852Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612951}

63481331

Reland "Package Crashpad's handler into various APKs" · ab224140

Joshua Peraza authored Dec 01, 2018

This is a reland of dbca191e

Original change's description:
> Package Crashpad's handler into various APKs
>
> For Chromecast, Content Shell, and non-monochrome Clank/Webview:
>
> The Crashpad handler is a standalone executable, packaged like a
> loadable module and named libcrashpad_handler.so in order to not be
> ignored by Android's APK installer.
>
> For Monochrome:
>
> The Crashpad handler is linked into libmonochrome.so. At crash-time
> /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java
> which loads libmonochrome.so and runs the native HandlerMain().
>
> This strategy is not used for non-monochrome APKs (i.e. pre-N) because
> on L, Android's loader is not yet capable of loading native libraries
> from the APK. This is normally performed by the Chromium linker which
> can't be used by CrashpadMain.java because /system/bin/app_process
> doesn't initialize the process like a normal Android application
> (specifically, no ContextImpl has been created, so any calls to e.g.
> appContext.getApplicationInfo() will segfault).
>
> Binary-Size: MonochromePublic.apk increases in size by 100 KB.
> ChromeModernPublic.apk increases in size by 203KB (587 KB
> increase in install size because libcrashpad_handler.so is extracted
> from the APK). Possible mitigations for this increase are TODO:
>
> For J, K: We could link the handler directly into libchrome.so and let
> that be our handler executable. This would de-dup portions of libbase
> that are currently linked into both libchrome.so and
> libcrashpad_handler.so.
>
> For L, M: It might be possible to get the chromium linker (or Bionic's
> linker on M) to dlopen libchrome.so from the APK for a trampoline
> libcrashpad_handler.so to de-dup libbase.
>
> Bug: crashpad:30
> Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65
> Reviewed-on: https://chromium-review.googlesource.com/1150774
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594853}

TBR=agieve@chromium.org,torne@chromium.org

Binary-Size: See above.
Bug: crashpad:30
Change-Id: I2b866be642670188d9e8b674fac940b05497b806
Reviewed-on: https://chromium-review.googlesource.com/c/1252007
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612950}

ab224140

Reland "Migrate chrome services to ServiceBinding" · c15f3499

Ken Rockot authored Dec 01, 2018

This is a reland of e13e5485 with a
fix for official Chrome OS compile, which was broken by this and
doesn't have CQ coverage. :}

Original change's description:
> Migrate chrome services to ServiceBinding
>
> Migrates most remaining chrome & chrome OS services from ServiceContext
> to ServiceBinding.
>
> Bug: 891780
> Change-Id: Ib67772b549a58a4b2549840e90f719daa3370215
> Reviewed-on: https://chromium-review.googlesource.com/c/1356312
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612911}

TBR=jam@chromium.org

Bug: 891780
Change-Id: Ibde6312ca6710a981ebbd43473e8289dae479781
Reviewed-on: https://chromium-review.googlesource.com/c/1357670Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#612949}

c15f3499

Roll src-internal 7246cb4fac87..9cee82d2dd3b (1 commits) · 3bccf520

chromium-internal-autoroll authored Dec 01, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7246cb4fac87..9cee82d2dd3b

Created with:
gclient setdep -r src-internal@9cee82d2dd3b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: I372f028df3ef1f84cd57270e05d306666605edbb
Reviewed-on: https://chromium-review.googlesource.com/c/1357733Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612948}

3bccf520

Roll src/third_party/chromite b05d24c8ae07..ac9b0ff799ae (5 commits) · 791aeaed

chromium-autoroll authored Dec 01, 2018

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b05d24c8ae07..ac9b0ff799ae

git log b05d24c8ae07..ac9b0ff799ae --date=short --no-merges --format='%ad %ae %s'
2018-12-01 achuith@chromium.org device: Move Device to separate lib.
2018-12-01 lamontjones@chromium.org Drop unit parameter from osutils.GetImageDiskPartitionInfo
2018-12-01 lamontjones@chromium.org Allow partition name in MountImagePartition.
2018-12-01 chrome-bot@chromium.org Update config settings by config-updater.
2018-12-01 derat@chromium.org chromeos_config: Remove chrome-informational from ASan/UBSan

Created with:
gclient setdep -r src/third_party/chromite@ac9b0ff799ae

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=chrome-os-gardeners@chromium.org

Change-Id: I8cb20460a312dabe20cd37dae915cf261ad85e64
Reviewed-on: https://chromium-review.googlesource.com/c/1357731Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612947}

791aeaed

Roll src-internal ae97faeec26e..7246cb4fac87 (10 commits) · a02ce97e

chromium-internal-autoroll authored Dec 01, 2018

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae97faeec26e..7246cb4fac87

Created with:
gclient setdep -r src-internal@7246cb4fac87

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=mmoss@chromium.org

Change-Id: Ia30a104ca5de576a589d6ae35ae4bac463a3b8f2
Reviewed-on: https://chromium-review.googlesource.com/c/1357732Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612946}

a02ce97e