- 03 Oct, 2019 29 commits
-
-
Hiroshige Hayashizaki authored
Fix a typo introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1788876 (Upstream: https://github.com/web-platform-tests/wpt/pull/18904) Change-Id: I9ac2d8048c14c42e18d44f643b8dfcfac47c5fd9 Bug: 1001422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834886Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#702278}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bf575c5e4e06..bb31bb3faa36 git log bf575c5e4e06..bb31bb3faa36 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 rmhasan@google.com [Typ] Make typ raise an exception when attempting to overwrite an artifact Created with: gclient setdep -r src/third_party/catapult@bb31bb3faa36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:982208 Change-Id: Idc1cc7f0ed79f1aa02ea94ccc2991a183c7f4c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702277}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including fetch_api.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes. Bug: 1001360 Change-Id: I61ec74c570b02881c7419facc4be95b9410b79b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835871Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#702276}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64a01fd9a557..f686d5021cb1 Created with: gclient setdep -r src-internal@f686d5021cb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I216ad3f66978f37ac9ecd30d954b10275b16afa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836272Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702275}
-
Moe Ahmadi authored
Adds a new option to chrome://omnibox-on-focus-suggestions that enables remote and local zero-prefix suggestions in both Omnibox and Realbox. Removes obsolete options that enable remote suggestions only. Bug: 996516 Change-Id: I54bab6628e6c3322d17abef987c10122d9cf4ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836871Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#702274}
-
Brian Sheedy authored
Makes BrowserMinidumpTest.testGetStackTrace() always expect Crashpad stack symbolization output. Previously, there were issues on Telemetry's end that prevented Crashpad dumps from being found, which prevented any output showing up in getStackTrace's Crashpad section. Now that the issues have been fixed, we should always expect output. Bug: 949321 Change-Id: Iec729238abbb57b7adfb57bfc76e03cda3cbfa8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830359 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#702273}
-
Kyle Horimoto authored
Before this CL, settings would sometimes erroneously show an "out of range" error even when the network was not out of range. This CL fixes this issue. Bug: 1009365 Change-Id: If5ef684bf8d643c1078dcb1fc06438c483f34b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834903 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702272}
-
Sophie Chang authored
target defined in proto Bug: 1001194 Change-Id: Iccceb795ed89d571c07129f9a6b12a9721dd3b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835013 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#702271}
-
Eugene But authored
Bug: None Change-Id: I22b245cdc9117556e77c482495a9a43825723cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834646 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702270}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f417d3ad5009..0a33d2b80fc8 git log f417d3ad5009..0a33d2b80fc8 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0a33d2b80fc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I604085657c2eafd160b7b12a697cc843a5c338c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836274Reviewed-by:
-
Doug Arnett authored
Initially this is a prototype grade patch to test async script deferral with DeferAllScript sync script deferral. It uses the Suspend/Resume api on the ScriptRunner to hold off async script execution until the force deferred sync scripts are executed. Bug: 965277 Change-Id: I62763aa8929e5756e63030789024ed936409e402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785137Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#702268}
-
Maggie Cai authored
This CL adds ARC intent filters updated observer for a single package. Currently the ARC intent filter is always updated as a whole, and we do not know which package has the update. This CL splits up the conditions for start up and package updates. On start up we send all the ARC intent filters while for package updates, we only send the update for that package. We are still sending exactly the same number of updates as before, the only difference is that now we specify what package is being updated and only send through the change for that package. If all packages are updated, an base::nullopt will be sent through. BUG=853604 Change-Id: Ia973168486e04eb337d99379a69d6eb8d9c72ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824045 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#702267}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ad1e2151d99..b06d185a495b git log 3ad1e2151d99..b06d185a495b --date=short --no-merges --format='%ad %ae %s' 2019-10-02 zakerinasab@google.com Support memory tracker layer from Gapid in Perfetto Created with: gclient setdep -r src/third_party/perfetto@b06d185a495b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3c3003301b9c1ec1df6e80d037ba7ce9f968a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836273Reviewed-by:
-
Andrey Kosyakov authored
Change-Id: I3b52e61ad7b9030ad75582699d60dc5ca831e588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836664 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#702265}
-
Fabrice de Gans-Riberi authored
* Handle the |enable_remote_debugging| parameter in chromium.cast.ApplicationConfig to enable per-app remote debugging in CastRunner. * Set the CastRunner debugging port to 9222. * Remove a buildflag to enable remote debugging Context-wide. * Add a test to check remote debugging is properly enabled per-App. Bug: 997895 Change-Id: I19aced4e90790e77cc3f55b1118fbf459ae19b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773707 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#702264}
-
Danan S authored
This fixes an AppService triggered ARC++ crash in M78 which appears to be resolved in M79, but going forward it's a guard against things that might cause the crash to occur again in the future. Bug: 1010600 Change-Id: I80fa47a2686b29c073b45c269b965fe8e6d2ece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836606Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702263}
-
Alex Danilo authored
When a file operation error occurs, the progress panel that was providing visual feedback is changed to an error panel. Since file operations that take less than 2 seconds don't show the progress panels, the side-effect is the error panel won't display until the 2 second timeout happens. Call the attachPanel() method immediately when an error status is sent and add a check in the display panel custom element to ignore attachPanel() calls when the panel is already attached. Test needed. Bug: 1009853 Change-Id: I0829c3747240d35d81607385dab17e57273aa84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833022 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702262}
-
Matt Falkenhagen authored
* Improved formatting and linking. * Removed "Goal" which seems redundant now. * Edited guidelines around enums and enum classes. Change-Id: I11d922cbe310d93b9648aa0ff64fb7f99c1d1b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824730Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#702261}
-
Ana Salazar Maldonado authored
Apps.AppListPageSwitcherSource metric should only record the switches on the AppList and not inside the folder. Bug: 956342 Change-Id: I6929858b8348228514ab215de52b8277c939b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830089Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702260}
-
Matt Amert authored
WebMouseWheelEvent currently uses two bools to represent the units of the delta; one for precise pixel units and one for page units. However, it is undefined for them to both be true, and adding new units would not be trivial; as such, it should instead be represented as an enum. ScrollGranularity already includes this information, and so is used as the enum. However, since some of the other units (e.g. line) were previously not supported, a DCHECK has been added to the mouse wheel event queue to check that we aren't getting units we weren't expecting. This refactoring work is done on behalf of the CL http://crrev.com/c/1776898, which will be adding percentage units to ScrollGranularity. Bug: 1008132 Change-Id: I3972a375edfceefd29bbb05254c810d60706e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812330Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Matt Amert <Matthew.Amert@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702259}
-
Meilin Wang authored
|STOPPED| state has been removed and we only have |READY|/|NOT_READY| Assistant states for now. So we need to delete the outdated comments in order to keep consistent with the code update and avoid confusion. BUG=None. TEST=manually. Change-Id: I31a07ee77b8cbdb0e24813b9bfb73f1e8f931a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836004 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#702258}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/73fb657586a5..c1e818f42172 git log 73fb657586a5..c1e818f42172 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 sanikak@chromium.org auto_updater: Moving common AU constants into a new file Created with: gclient setdep -r src/third_party/chromite@c1e818f42172 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0929765220e2b74d546f17cda5c66d0bfd01049c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836652Reviewed-by:
-
Simeon Anfinrud authored
Merge-With: libassistant-internal/109915 Merge-With: libassistant-internal/109885 Bug: Internal b/130382048 Test: gn check libassistant build with two listed patches Change-Id: Id30a100aad39caa8b149b81bf90da81db877b104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817418 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702256}
-
Sergey Ulanov authored
After crrev.com/701889 feature flags were not passed properly from runners to WebEngine. As results some features were unintentionally disabled. This cl updates WebContentRunner::BuildCreateContextParams() to pass the feature flags to the web context. Change-Id: I82add02bc56d30a65b6a97919d36597317654902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836670 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702255}
-
Manu Cornet authored
This is a tentative fix for the linked bug. Bug: 1010699 Change-Id: I95e24169ada31291d9a1be1598c0887d39f11e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836597 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702254}
-
Jeffrey Yasskin authored
This reverts commit 7eaf8829. Reason for revert: The new DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateMultipleFolders test fails on the linux-chromeos-dbg builder. See the bug for details. Original change's description: > Fix unnecessary blink of new created folders > > When creating new folders from the directory tree, the new entry was > sometimes added in the wrong spot due to the way labels were compared. > The folders were then immediately reordered, causing the new folder to > lose its renaming state with the corresponding input box. > > Issue fixed using the util.compareName function. > > Test: browser_tests --gtest_filter="*FilesApp*dirCreateMultipleFolders" > Bug: 1004717 > Change-Id: If2bc4d559a7a74811204d198a2aa8579ee3a6889 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827110 > Commit-Queue: Jeremie Boulic <jboulic@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701473} TBR=noel@chromium.org,lucmult@chromium.org,jboulic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004717 Change-Id: Idddeca60b18f9081aa36c2a577df2aeafb451672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836655Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702253}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d46e2fb1e341..fd092e853e7b git log d46e2fb1e341..fd092e853e7b --date=short --no-merges --format='%ad %ae %s' 2019-10-02 ianelliott@google.com Vulkan: Point end2end failure at correct bug 2019-10-02 ianelliott@google.com Vulkan: Expect additional GLES 3.0 KHR tests to pass Created with: gclient setdep -r src/third_party/angle@fd092e853e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I262b3c592f25a8cb3669064fce7f6450e0d64021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836489Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 990561 Change-Id: Ie745f8a50c28cb19cdaf31c95b188b1db762d5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761892 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Deletes all remaining Cast APIs from the Cast Runner codebase. Bug: 953958 Change-Id: Ia715e9c972735f11d29978925a2199356e4d1d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793791 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702250}
-
- 02 Oct, 2019 11 commits
-
-
Peter Boström authored
Replaces kHighlightPathKey uses in FindBarButton, ProfileMenuViewBase and BubbleFrameView. Bug: chromium:1007546 Change-Id: Iec2a07ed28913d68bf8e835e9603ca4247eadaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835263Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702249}
-
yilkal authored
This CL records the maximum number of frames present in web contents. The records will help us better predict the cost of improving SupervisedUserNavigationThrottle to filter at the iframe level. The will help us predict the following two information: 1. By how much will the requests for the kids management servers to classify urls will increase as a result of iframe filtering. 2. By how much will we delay the overall page load time? Bug: 850328 Change-Id: I01cf33305a67aa01e3ab416d1659e027156bedef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769663 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Gavin Williams authored
-Current dropdown behavior can show different text than what's actually selected. Bug: 1009772 Change-Id: I8480e054ef33855cd1c2764d3f8591b57139725e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832793 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
LayoutScrollbar* were for custom scrollbars, which was not obvious from their names. LayoutScrollbarPart is renamed to LayoutCustomScrollbarPart keeping the Layout prefix because it's a LayoutObject and all LayoutObject classes have the Layout prefix. Move CustomScrollbarTheme (renamed from LayoutScrollarTheme) from layout to paint, and combine ScrollbarPainter into it. Change-Id: Ia65cc7824ed9bdc16372976225a1acbcef59601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835999 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702246}
-
Tao Bai authored
- Added TestMetricsWebContentsObserverEmbedder for sharing between component and chrome browser - Moved chrome browser unrelated tests to components. - Keep extension related tests in Chrome. - Clean up some unused include header file. Bug: 995880 Change-Id: I31f211c83c4faaafa7016a5f9890f242668e5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832034Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#702245}
-
Brian Sheedy authored
Switches tracing_perftests to use PerfResultReporter instead of PrintResult and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I719e754be1cba67cdec15034e7a614494723a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836006Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#702244}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6154fb127e5c..f417d3ad5009 git log 6154fb127e5c..f417d3ad5009 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 ehmaldonado@chromium.org depot_tools: Run git_cache_test and git_dates_test on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@f417d3ad5009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1009809 Change-Id: I5be987be591a1a86c70ad81214c451d3765ecc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836481Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/867f72058a4f..0da52f2d92c3 git log 867f72058a4f..0da52f2d92c3 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 bryan.bernhart@intel.com D3D12: Move resource allocators from device into manager. Created with: gclient setdep -r src/third_party/dawn@0da52f2d92c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7282a3ddb89a18c05a92d57b48d24952b3f9f24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836571Reviewed-by:
-
Wez authored
Previously user-mode remote debugging was available for all Frames in a Context created with a |remote_debugging_port| specified in their CreateContextParams. User-mode debugging is now enabled only for Frames created via CreateFrameWithParams() with the |enable_remote_debugging| option set, in a Context with a |remote_debugging_port| set. Remote debugging support in WebEngine is refactored such that: - DevTools is managed by a WebEngineDevToolsController implementation, which is created and owned by the WebEngineBrowserMainParts. - WebEngineDevToolsController has "hook" APIs which must be called to inform it when a Context is created, when WebContents are created, torn down, etc, and an API that returns a list based on the debuggable WebContents to DevTools. - WebEngineBrowserMainParts supplies the controller to the ContextImpl, which arranges for the WebContents "hooks" to be invoked, and uses it to implement the GetRemoteDebuggingPort() API. - WebEngineDevToolsController has three implementations, depending on the command-line parameters passed by WebEngineBrowserMainParts: - User-mode: DevTools is enabled as soon as a Frame is first created with the remote-debugging option set in its CreateFrameParams. Pending GetRemoteDebuggingPort() calls will be notified at that time. - Debug-mode: DevTools is enabled as soon as the Context is initialized and will stay enabled for the lifetime of the browser process. When the first Frame's main document finishes loading[1], all DevToolsPerContextListeners registered at Context creation will be notified. - No-op: DevTools is never enabled. - WebEngineDevToolsManagerDelegate is moved to be an implementation detail of the WebEngineContentBrowserClient. The integration tests are also updated to verify the new behaviour. [1] Debug-mode clients expect to be notified that DevTools is ready, only when at least one Frame has finished loading its main document. Bug: 995057 Change-Id: I8b4e825c77882bb54f2e568a95e383e3eaedfb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774018 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: -
Jarryd authored
This change adds a BrowserContextKeyedService so that we can pass the storage code (which lives in the content layer) a callback after profile creation. The callback will be used to trigger warnings about storage pressure, and thus needs to live in the chrome layer to make use of UI. The logic for storage pressure notifications will come in follow-up, dependent CLs. Bug: 997258 Change-Id: I840da583873b79cc6754a023d09920317890b780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761161 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb5d5accb146..64a01fd9a557 Created with: gclient setdep -r src-internal@64a01fd9a557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:1007434,chromium:None Change-Id: I78a872380175c5ca225aec00fa959be8d8f0739c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836157Reviewed-by:
-
