- 18 Apr, 2013 37 commits
-
-
nkostylev@chromium.org authored
Created method for obtaining signin profile. Signin profile used instead of "DefaultProfile" during login phase. BUG=225116 R=nkostylev@chromium.org TBR=brettw Review URL: https://codereview.chromium.org/13633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194774 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
On certain Android builds, ANativeWindow_fromSurface will fail during startup, and we we don't handle this failure. BUG=230359 NOTRY=true No try, since it's Android only. Review URL: https://chromiumcodereview.appspot.com/14017019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194773 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
Fix an oversight where the current command line's program was being used instead of getting the program from PathService. BUG= Review URL: https://chromiumcodereview.appspot.com/14011005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194772 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=224531 Review URL: https://chromiumcodereview.appspot.com/13888010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194771 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Instead of hardcoding GL_TEXTURE_2D BUG=230300 Review URL: https://chromiumcodereview.appspot.com/13870013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194770 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch introduces new awesome scrollbars as well as restyles the file list, including: checkbox to the right side, removing the pinning checkbox, auto-sizing of the columns. TEST=Run with --file-manager-new-ui. Legacy version should also not be broken. BUG=226912 Review URL: https://codereview.chromium.org/14096016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194769 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
Previously the NTP apps page would not show if the app launcher was installed. Now it will show regardless. This patch also restores apps to chrome://apps when the app launcher is installed. BUG=225371 Review URL: https://chromiumcodereview.appspot.com/13926002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194768 0039d316-1c4b-4281-b951-d872f2087c98
-
ramankk@chromium.org authored
Autofill:Autocheckout: In addition to "Enable Experimental Form filling" flag, support second method of enabling Autocheckout: using finch experiment. Autocheckout will be enabled if either of the conditions is true. Will remove "Enable experimental form filling" flag, once finch experiment is setup completely. BUG=230026 Review URL: https://chromiumcodereview.appspot.com/13811045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194767 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
This change removes SyncSessionJob entirely. The first step towards this goal was to refactor all functions that depended on SyncSessionJob. All these functions have either been inlined or modified to take different parameters instead. DoSyncSessionJob was split into two separate functions, one for configure jobs and one for nudge jobs, which removes the need for SyncSessionJob's "purpose" member. The SyncScheduler's pending_configure_job_ has been replaced with a ConfigParams member, since that was the only part of the job still being referenced. The pending_nudge_job_ has been replaced with scheduled_nudge_time_ (which is similar to the old scheduled_start_ member of SyncSessionJob) and a new object called a NudgeTracker. The NudgeTracker inherits the SyncSessionJob's responsibilities with respect to coalescing nudge sources. The plan is to extend this class to support more sophisticated nudge coalescing in the future. For now it tries to emulate the old SyncSessionJob behaviour as closely as possible. Some of the refactoring does change behaviour. In particular, the decision-making logic has been updated to fix issues 179515 and 155296. BUG=175024,179515,155296 Review URL: https://chromiumcodereview.appspot.com/13743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194766 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
Some audio hardware is presented as separate input and output devices even though they are really the same physical hardware and share the same "clock domain" at the lowest levels of the driver. A common of example of this is the "built-in" audio hardware: "Built-in Line Input" "Built-in Output" We would like to use an "aggregate" device for these situations, since CoreAudio will make the most efficient use of the shared "clock domain" so we get the lowest latency and use fewer threads. BUG=none TEST=extensive manual testing with built-in Mac hardware http://chromium.googlecode.com/svn/trunk/samples/audio/visualizer-live.html Review URL: https://chromiumcodereview.appspot.com/13403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194765 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
Because of typo, gallery wasn't showing up. This patch fixes the typo and also converts every instance of toggleFullscreen to toggleFullScreen for consistency. TEST=Enter Files.app, go to gallery, fire the slide show. BUG=232087 Review URL: https://codereview.chromium.org/14316003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194764 0039d316-1c4b-4281-b951-d872f2087c98
-
harrym@chromium.org authored
corruption of work area insets. BUG=230937 Review URL: https://chromiumcodereview.appspot.com/13994014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194763 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/13991009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194762 0039d316-1c4b-4281-b951-d872f2087c98
-
kuan@chromium.org authored
BUG=229897 TEST=verify per bug rpt Review URL: https://chromiumcodereview.appspot.com/13974003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194761 0039d316-1c4b-4281-b951-d872f2087c98
-
keybuk@chromium.org authored
Provides an implementation for adapter control, device discovery, pairing, connection, disconnection and unpairing using the BlueZ 5.x backend on Chrome OS. Uses Fake* classes for testing instead of Mocks. TBR=youngki@chromium.org BUG=220951 TEST=device_unittests Review URL: https://chromiumcodereview.appspot.com/13927010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194760 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
> Re-enable ExtensionCrashRecoveryTest.ReloadTabsWithBackgroundPage on Windows. > > The culprit change was reverted. > > BUG=232340 > TBR=yoz@chromium.org > > Review URL: https://codereview.chromium.org/14111007 TBR=tkent@chromium.org Review URL: https://codereview.chromium.org/13898005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194759 0039d316-1c4b-4281-b951-d872f2087c98
-
rfevang@chromium.org authored
This change removes the print menu entry from the action box, and moves the bookmark entry so it becomes the first entry in the list. Also moved responsibility for populating the menu model into the controller class, instead of having it split between the model and the controller. BUG=226803 Review URL: https://chromiumcodereview.appspot.com/13983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194758 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/13935005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194757 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Pass settings from connector setup page using "UserSettings" object that includes "connectNewPrinters" flag and list of "PrinterSettings". BUG=230187 R=gene Review URL: https://chromiumcodereview.appspot.com/14215009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194754 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
BUG=195849 Review URL: https://chromiumcodereview.appspot.com/13556004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194753 0039d316-1c4b-4281-b951-d872f2087c98
-
steveblock@chromium.org authored
Also fix SVN URL in test_expectations*.py to use src.chromium.org after blink fork. Also fix test_expectations_history_unittest.py to use correct time zone. Commit time stamps are in UTC, so we need to specify date ranges in UTC, rather than local time, to ensure consistent behaviour in all locations. BUG=230264 Review URL: https://codereview.chromium.org/14316009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194752 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
The culprit change was reverted. BUG=232340 TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/14111007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194751 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
R=danakj BUG= Review URL: https://codereview.chromium.org/14195014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194750 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
To fix layering leakage issue. BUG=none TEST=existing tests Review URL: https://codereview.chromium.org/14237003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194748 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
Currently we have some layering leakages under webkit/ because we have several FS modules (e.g. media modules) that should not be known by WebKit/FileAPI (or content) layer. Also some module implementors are forced to add extra glue interfaces just to across layering boundaries from webkit. This patch changes to: - Add CanHandleType method to each MountPointProvider - Make FileSystemContext's ctor take additional MountPointProviders and MountPoints, so that FS module implementors can implement their own provider outside webkit/ and plug it into FileAPI layer. This is the 1st cut of a couple of planned changes. Brief change plan (internal): https://docs.google.com/a/google.com/document/d/1XEtX0OO_RIA_c0KuKvd9yqK5l3XtsTulwXs3c-mAQ1o/view BUG=175936 TEST=content_unittests:.*File.* TEST=content_unittests:.*MountPointProvider.* Review URL: https://codereview.chromium.org/14096022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194747 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
- Manage all callbacks passed to LoadIfNeeded in the pending queue, not in method argument. This eliminates the need of |refreshing_| variable, and simplify the logic when to wait and when to start loading. - Unify the place where loaded_ is set and OnInitialFeedLoaded() is called. - Unify directory changestamp checking logic into one place. Previously we had it twice. - Get local_changestamp exactly once in every path. Previously we had it twice in some cases, and zero in some case (see the BUG). BUG=231220 Review URL: https://codereview.chromium.org/13933016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194746 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
Chromium does not use the frame flattening code on any platform, though it used to use it for frameset flattening on Android, but that is no longer the case. As there is no intention of ever using it, it should be removed. This change basically removed the code related to the WebCore setting. Committed on behalf of Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>. TBR=darin@chromium.org BUG=231898 Review URL: https://codereview.chromium.org/14293008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194745 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
Also enable three passed java tests. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14230010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194743 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
Review URL: https://codereview.chromium.org/14046039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194742 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
This fixes "Hisilicon" GPUs, which is an instance of a Vivante's GPU design. This involves enabling virtual contexts, since they don't support share-groups, and further adds a work-around for switching surfaces. Without the work- around the view surface "inherits" the size of the last bound surface (which for Chrome tends to be a 1x1 pbuffer) resulting in a black screen. The following steps "repair" the view surface every time it is made current: - Make it current. - Bind the default frame-buffer. - Make it not current. - Destroy/recreate it from the native handle. - Make it current again. NOTE: The "Recreate" function is added to surface because the Destroy/Initialize may be intercepted or modified by wrapper surface classes. Recreate is similar to resize, which after being forwarded by a wrapper can call Destroy/Initialize on the 'real' surface. BUG=179250, 229643 NOTRY=true No try, since it's Android only and already tested. Review URL: https://chromiumcodereview.appspot.com/13140006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194737 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/13926019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194736 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
Previously, the target element (the file list) was hard coded. Instead, we should be able to specify the target element. BUG=none TEST=none; just a test util change. the existing tests should pass as before Review URL: https://codereview.chromium.org/13891013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194735 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
DriveSystemService exposes only the JobListInterface of DriveScheduler. BUG=128079 Review URL: https://codereview.chromium.org/14118006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194734 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
remaining interactive autofill work. R=estade@chromium.org BUG=none TEST=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13870019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194733 0039d316-1c4b-4281-b951-d872f2087c98
-
nileshagrawal@chromium.org authored
BUG=232997 R=yfriedman@chromium.org Review URL: https://codereview.chromium.org/14199005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194732 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
and update the mouseover help. BUG=116601 Review URL: https://codereview.chromium.org/13725016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194731 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The test verifies that the autocomplete list is shown properly. BUG=179976 TEST=none Review URL: https://codereview.chromium.org/14312009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194730 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Apr, 2013 3 commits
-
-
apatrick@chromium.org authored
Review URL: https://codereview.chromium.org/14111003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194729 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=232851 Review URL: https://codereview.chromium.org/14225020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194728 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=232950 TEST=see bug Review URL: https://codereview.chromium.org/14093019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194725 0039d316-1c4b-4281-b951-d872f2087c98
-