- 04 Aug, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9969655224d7ca76d5ad35880312095065108d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336905 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794715}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..7176f54720e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I37fed8d5dffc78513fc5d4dd762b1ede9c358cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794714}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/95d85af7aa56..dd5382a4449c $ git log 95d85af7a..dd5382a44 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 renjietang Change return type of QuicSession::stream_map_size() 2020-08-03 danzh Refactor QuicConnection::UpdatePacketContent() 2020-08-03 danzh N/a add new interface to quic::CertificatePrivateKey. Not protected. 2020-08-03 fayang Neuter CRYPTO data in HANDSHAKE level when discarding handshake keys. Protected by gfe2_reloadable_flag_quic_fix_neuter_handshake_data. 2020-08-03 renjietang Prevent QUIC subclasses from accessing stream_map_.size(). 2020-08-03 fayang In QUIC, when creator is consuming data in fast path, close connection if stream data is sent in the wrong encryption level. Protected by gfe2_reloadable_flag_quic_check_encryption_level_in_fast_path. 2020-08-03 renjietang Deprecate gfe2_reloadable_flag_quic_fix_gquic_stream_type 2020-08-03 fayang Deprecate gfe2_reloadable_flag_quic_stop_sending_duplicate_max_streams. 2020-08-03 fayang Deprecate gfe2_reloadable_flag_quic_fix_undecryptable_packets. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=renjietang@chromium.org Change-Id: Ifde4e2cc1c02d63f50055b2c11631d6a7e9b5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336016Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794713}
-
Fred Mello authored
https://docs.google.com/document/d/1dlgqV5__s8Jyl-YmmmMhRaOp8NwVQ8_Y_O44cKR14ak Bug: 1112872 Change-Id: I542c37f03d3f33cce0765a06223c322fbfaee493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336297 Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#794712}
-
Ahmed Mehfooz authored
Bug: 1111484 Change-Id: I05a1629833f26b03092d61b0db419e26dcbb4345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331516 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#794711}
-
Avi Drissman authored
Do comparisons on int-casted enums; it's easier to work out what's going wrong if you don't have to convert from hex. Use explicit capturing in the lambda; it's clearer than the implicit reference capture. This does not change the functionality of the test. It still fails on Big Sur but it's more clear how it fails. Bug: 1101426 Change-Id: I3a636129b62589b5cbccb5779c1e23920fc9da1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337106 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794710}
-
Changwan Ryu authored
For Android L and M, we use a complicated mechanism to activate keyboard such that we can use IME thread to block on synchronous IME requests. This mechanism has been regressed by some change in AndroidX. When the content view is coming back from a recycler view based window, the IME gets activated, but the logic in the old window seems to dismiss the IME after some delay. There are about 20% users who are using L and M, but as no one is maintaining the framework code, it is extremely challenging to debug Android L and M framework code to understand this further at this point, so landing a workaround to delay IME activation, which seems to fix the problem. Note that this only applies to the specific scenario of 1) Window focus loss 2) (Optional) view focus loss 3) View focus gain 4) Window focus gain to minimize the impact. Bug: 1108237 Change-Id: I3da5a17b69e49fd16e773e8dfa8535ac474de818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335822Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794709}
-
Jonathan Mengedoht authored
Implements the behaviour for .well-known/change-password urls, analogous to the WellKnownChangePasswordNavigationThrottle Bug: 927473 Change-Id: Ib3eed87306ed6b3b5bc1f49f4aa8b91369c614dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317952 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#794708}
-
Hiroshige Hayashizaki authored
This CL also removes ScriptState::Scope and isolate null checks that look unnecessary. Bug: 1111134 Change-Id: I89ae40f566ca68acbc0ee9a70b6f479214c063e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331758 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794707}
-
Lan Wei authored
We will add a new input source type to simulate the mouse wheel scroll to the Webdriver Action API, https://github.com/w3c/webdriver/pull/1522. In this CL, we are adding the wheel input source in the ChromeDriver's ExecutePerformActions function, which implements the Webdriver Action API in Chrome and we will use Devtool's input protocol, Input.dispatchMouseEvent with a type of "mouseWheel". I added some waiting time to wait for the action to be executed to fix the failure on Mac 14 test. TBR=johnchen@chromium.org Bug: 1040611 Change-Id: I348c71bacc32b403ba995c1c736b6bfb230b65aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337255Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#794706}
-
Joel Hockey authored
Currently we are only allowing users to open files with a Windows app if the file is within 'Windows files'. This is changed to allow any files in dirs which are already shared. Note: We do not automatically share files when they are opened with a Windows app as we do for crostini since Windows apps require the entire dir to be shared in order to allow file dances. Bug: b/162771563 Change-Id: Ib2dc963c33629be896638ae3b0b8776295115745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336333 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794705}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a50dc7ad. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" 14e278af "Revert "Reland "Use border box or layout overflow rect for layout shift tracking""" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I33da7c014ca2debe63945a37e1e5d2f0adbd7f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337153Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794704}
-
Mike Wittman authored
The last executable offset calculation was assuming that the ELF image's relocation offset is always equal to its base address. This is not true for non-relocatable images, or those with load-bias. Expose and use elf_reader.cc's GetRelocationOffset() to fix this. Bug: 1105170, 1101023 Change-Id: I0d1e49ccf665173b8f0836e9df9eb545f864ba31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305590 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794703}
-
Brian Malcolm authored
By making TypeCheckingPolicyHandler, SchemaValidatingPolicyHandler, and SimpleJsonStringSchemaValidatingPolicyHandler all derive from the same class we can allow SimpleDeprecatingPolicyHandler to work with all of them. BUG=chromium:1112810 Change-Id: I67a75965c123989e227efc7a9fad47bd4b7f405e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337118 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794702}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4fdf56254f58..a0c3f906bc6f 2020-08-04 tandrii@google.com Roll lucicfg tool to @ 61acc468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112433 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3f2dca7a6fb4d49ca2221e6face82cbfdfbbf9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794701}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596542250-9615b306cb5f76d5a757426ea1c30fa3bd674a0e.profdata to chrome-win32-master-1596549454-7f993c1fb49036aa3a3eb3f7c44ae7cd093767bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I05a29c0816f9f22cbd6aafa40a7ea88e4b15a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794700}
-
Daniel McArdle authored
The wav_audio_handler_fuzzer constructed an input that causes ParseWavData to get stuck in an infinite loop. On this input, ParseWavData's |offset| variable kept overflowing into a smaller value before the loop condition (offset < total_length) could become false. This CL hides the pointer arithmetic inside a base::BigEndianReader and byteswaps integers that were actually little-endian to recover the correct values. Bug: 1112100 Change-Id: Ia4a6c987888d748db4962e4e38fb8ceb0e290e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335563 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794699}
-
Yuke Liao authored
linux-lacros-compile-rel mirrors linux-lacros-builde-rel, which is defined under chromiumos instead of linux. Bug: 1104318 Change-Id: Iebaa73683f811c737695275b6f21f273f86cdf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335029Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#794698}
-
Fred Mello authored
https://docs.google.com/document/d/1dx_0f2sILQWO0hsDI9gROEJ_MNqNXhk99mx9utfHR9M Bug: 1112872 Change-Id: I7608dfa677fd50e5f0f99a1ad8f40a12e7a93924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337098Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#794697}
-
Xiaocheng Hu authored
Design doc: https://bit.ly/39qATQ4 This patch adds a new @font-face descriptor to override spacing between characters when the font is used. For simplicity, this patch only implements the parsing of the descriptor, but doesn't affect any rendering. A follow up patch (crrev.com/c/2318510) will apply it in text shaping. Note: Though we don't have a stable spec at the moment, we land it behind a flag to make testing and discussion easier. Bug: 1098355 Change-Id: I7921aad0d03e0b7da0c2fca77c99324ab7449e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335823Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794696}
-
Rebekah Potter authored
This reverts commit 853e0dd9. Reason for revert: Change seems to have caused consistent unit_tests failures on the TSAN bot, see https://bugs.chromium.org/p/chromium/issues/detail?id=1112825 Original change's description: > service worker: Use mojo version of GetUserDataForAllRegistrations > > This CL starts using mojo version of > GetUserDataForAllRegistrations{,ByKeyPrefix}(). > > The type of the return value of these methods is also changed from > map<registration_id, value> to array<ServiceWorkerUserData>, > and ServiceWorkerUserData now has registration_id. > These changes are required to handle a situation where a > registration_id is associated with multiple values. Some features like > payments could associate multiple values for a registration_id. > > Bug: 1055677 > Change-Id: I29e9ae7c1722316b2ac2f163cfc5b50fe7590d54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331376 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794447} TBR=falken@chromium.org,kinuko@chromium.org,bashi@chromium.org,nhiroki@chromium.org Change-Id: If41653b493ad11a6af679ee000a207be5b65f73b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677, 1112825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337273 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794695}
-
John Lee authored
Bug: 686905 Change-Id: I6f9a55492b7f6cd02be0fda7e9c4110fed2cb4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333289 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794694}
-
Rune Lillesveen authored
EnsureStyleResolver used to do this partially, which made us not crash before [1] landed. [1] https://crrev.com/0e37e8a49d3cfb0f81fa8a9e8ec147c50914e926 Bug: 1109639, 1104634 Change-Id: Ia4d8246b954251d0d3e566cf29081dd8157a5fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336081Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#794693}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/74cc8ea2b8df..a3e03e1086d5 2020-08-04 dpranke@google.com Fix a Python3-compatibility issue for write_icd_json.py. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1112479 Tbr: swiftshader-team+autoroll@google.com Change-Id: I511d932a4bc5e9d6f059e8bd85709bf44b7baf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794692}
-
Tommy Li authored
This CL is the most basic implementation possible of requesting zero-prefix suggestions (ZeroSuggestProvider) when the user deletes the permanent text in the omnibox. In other words, when the flag is on, and the user enters user_input_in_progress mode by deleting everything, this will request ZeroSuggestions. This doesn't implement the oft=2 mode yet, so there's no distinction between on-clobber and on-focus requests. Bug: 1106096 Change-Id: I2f0f3353605f82b378cc2d73499b8f03ceb83f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335509Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794691}
-
Dirk Pranke authored
I'm now consistently only using 'dpranke@google.com', so there shouldn't be any need for the other address. Change-Id: I7576a8bf318cc9455862ea8ef48960e0e6abf641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336508Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#794690}
-
Nicolás Peña Moreno authored
This changes the opacity 0 paints that are ignored by the LCP algorithm. Before, paints that would later be composited were not ignored, which resulted in an inaccurate metric due to detecting LCP too early. After this change, even will-change opacity paints are ignored, which could result in elements not becoming candidates because they are never repainted. In the special case where documentElement changes its opacity, we consider the largest content that becomes visible as a valid LCP candidate. In other words this CL does the following 3 changes: 1) Ignores all LCP signals under style.opacity: 0, as before styles with 'will-change: opacity' were not ignored. 2) Saves off the LCP for ignored LCP signals if they are under non-nested style.opacity = 0. 3.) If the document opacity style changes from opacity: 0 to non-zero, we record the saved off LCP signal. Bug: 1092473 Change-Id: I2a970a34fdb1db6c7c746060c286077553b816a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316788 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794689}
-
Jan Wilken Dörrie authored
This change removes the last references to base::string16 from chrome/chrome_cleaner. All existing instances of base::string16 have been replaced by std::wstring. Bug: 911896 Change-Id: I94235148f23f63642023cf787498f0145d221a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332718Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794688}
-
Tommy Martino authored
This CL adds a new file, text_fragment_utils, which will provide logic for handling text fragments (the URL specifiers which power the scroll-to-text feature). It invokes those utils at the last possible moment of navigation. I've implemented the basic guard logic that checks the preconditions for completing such a navigation; actually performing the scroll to text will be added in a follow-up CL. Bug: 1099268 Change-Id: I522119abe28cc0bd323bdf230a1ca8951c157835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333044Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#794687}
-
Clark DuVall authored
This reverts commit 02b24a76. Reason for revert: Reintroduces the perf regression: https://pinpoint-dot-chromeperf.appspot.com/job/16e0ecee920000 Original change's description: > Move getPacProcessor() to GlueApiHelperForR > > Follow up after feedback on http://crrev.com/c/2328302. > > Bug: 1111909 > Change-Id: If3107a6bc513d2aad898e8bc87c8436392ee057d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335385 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794655} TBR=torne@chromium.org,ntfschr@chromium.org,cduvall@chromium.org Change-Id: I8451360f542ba1b546975c5fd84f84d81b0c502a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335768Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794686}
-
Dan Harrington authored
And threaded access to xsurface FeedActionsHandler Bug: 1044139 Change-Id: I0857f876776f285728ad938f9f41e92ebea50988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335478Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#794685}
-
rbpotter authored
Bug: 1110756 Change-Id: Id0200e0adaefddcd53be7659514cc64a234653c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333061Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794684}
-
Martin Kreichgauer authored
|nserr| is implicitly autoreleased and therefore shouldn't be captured in a scoped_nsobject. Bug: 1109968 Change-Id: I0af640b396983adbe5dbd425f3ad08fcc61513a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337120 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794683}
-
James Vecore authored
Adds the policy for allowing/disallowing Nearby Share via policy. A new policy handler type is introduced to map a policy value of false to pref value of false, but when the policy is true, the pref is not changed. This allows the policy to force off a feature when disallowed, but the user must still manually enable the feature if the policy allows it. This avoids having to introduce another "allowed" pref. For now, Nearby Share will only be supported on CrOS. However, full desktop browser support is planned and this policy will be reused. The policy is currently set to launch in M87 for CrOS so it is left with no supported_on set yet. Change-Id: Ibfcc4ececf49de646ef7c72872db9c6f14c68e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316887 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#794682}
-
Henrique Nakashima authored
Heavily based on tools/binary_size/libsupersize/upload_html_viewer.py. Bug: 1111056 Change-Id: I71dfe9850e60a0f194ffe42896e79335f273c6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333453 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#794681}
-
Jeroen Dhollander authored
Logging the actual HTML makes debugging easier, but it is very big. So I've decided to only show it on the most verbose VLOG level (3). Tests: manually deployed. Bug: N/A Change-Id: I08571942cd21774ab2254bb6d907a67bc5e84698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336281 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794680}
-
Miguel Casas authored
Certain platforms and codecs suffer from horrible artifacts (Intel BYT, H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of error in the tracking of the VASurfaces lifetime in the driver: every time we get a new resource from the pool to decode onto, this is imported into libva as a VASurface: this works fine almost everywhere but doesn't play well in these old platforms (see CreateSurface() body). This CL adds a map that keeps the ref-counted VASurfaces alive and indexed by the unique GpuMemoryBufferId until the VA Context is destroyed. In so doing, we're basically observing the "contract" of va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all contexts using these surfaces have been destroyed". [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 Bug: b:142019786 b:143323596 Change-Id: I78cc08cd882fda51ff036c88a7050adb577e53ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295947 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#794679}
-
Julian Mentasti-Meza authored
iOS14 devices will now use Apple's createPDFWithConfiguration to generate single page PDFs. CreateFullPagePdf will now render the PDFs asynchronously to behave like createPDFWithConfiguration. Unittests have been updated accordingly. Bug: 1103777 Change-Id: I6774f78c69e79d560e4d6f52ad08a7a054a88ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324104 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#794678}
-
minch authored
https://crrev.com/c/2325274 adds 'feedback' item to power menu in the login screen. https://crrev.com/c//2297746 makes the menu content view will only be set if |menu_widget_| is nullptr. Menu items will be added or removed to the content view on needed, which will cause the FocusManager can not get the next focusable item view correctly. This cl resets the |menu_widget_| on login status changes to make sure the content view will be reset too while menu items change to fix the issue. Bug: 1112655 Change-Id: Ie748866a0a4edd0ab4ab194908002822ec748bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337116 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794677}
-
Fred Mello authored
https://docs.google.com/document/d/1fDi6x6aaIdPR0KpGvKV3wGcXyICQNA_EAA6Piyy2i5U Bug: 1112872 Change-Id: Ibbecdfea97ad4de2cb2673821922cb50b85aef48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337257 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#794676}
-