GitLab

        Reviewed by Adam Barth.

        Add ability to get frame from v8 context to chromium WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=57516

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrame::frameForV8Context):

git-svn-id: svn://svn.chromium.org/blink/trunk@83007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/mac/HTMLConverter.mm: Fix #if back the way Alexey seems
to have intended it.



git-svn-id: svn://svn.chromium.org/blink/trunk@83006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/mac/HTMLConverter.mm: Move declarations of new functions
inside the appropriate #if.



git-svn-id: svn://svn.chromium.org/blink/trunk@83005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        [Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
        https://bugs.webkit.org/show_bug.cgi?id=57893
        <rdar://problem/9130486>

        * UIProcess/API/mac/PageClientImpl.h: Added executeSavedCommandBySelector.
        * UIProcess/API/mac/PageClientImpl.mm: Renamed internal Objective-C classes to use
        the WebKit2 Objective-C class prefix, WK, rather than the WebKit1 Objective-C class
        prefix, Web. Removed some unneeded explicit WebKit namespace prefixes.
        (-[WKEditCommandObjC initWithWebEditCommandProxy:]): Removed unneeded WebKit
        namespace prefix.
        (-[WKEditCommandObjC command]): Ditto.
        (-[WKEditorUndoTargetObjC undoEditing:]): Updated for new class name.
        (-[WKEditorUndoTargetObjC redoEditing:]): Ditto.
        (WebKit::PageClientImpl::PageClientImpl): Ditto.
        (WebKit::PageClientImpl::registerEditCommand): Ditto.
        (WebKit::PageClientImpl::executeSavedCommandBySelector): Added.

        * UIProcess/API/mac/WKView.mm: Renamed internal Objective-C categories to use the
        WebKit2 Objective-C prefix, WK, rather than the WebKit1 Objective-C prefix, Web,
        or no prefix at all. Tweaked use of extern "C" a little.
        (-[WKView doCommandBySelector:]): Tweaked the comment.
        (-[WKView _executeSavedCommandBySelector:]): Added. For use when command is not handled
        by WebCore.
        (-[WKResponderChainSink initWithResponderChain:]): Added. Based on the
        WebResponderChainSink class in WebKit1.
        (-[WKResponderChainSink detach]): Added.
        (-[WKResponderChainSink didReceiveUnhandledCommand]): Added.
        (-[WKResponderChainSink noResponderFor:]): Added.
        (-[WKResponderChainSink doCommandBySelector:]): Added.
        (-[WKResponderChainSink tryToPerform:with:]): Added.

        * UIProcess/API/mac/WKViewInternal.h: Added declaration of _executeSavedCommandBySelector:
        method. Also removed unneeded includes.

        * UIProcess/PageClient.h: Added executeSavedCommandBySelector.
        * UIProcess/WebPageProxy.h: Added executeSavedCommandBySelector.
        * UIProcess/WebPageProxy.messages.in: Added ExecuteSavedCommandBySelector.

        * UIProcess/mac/WebFullScreenManagerProxyMac.mm: Updated includes.

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::executeSavedCommandBySelector): Added.

        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::executeKeypressCommandsInternal): Send the synchronous
        ExecuteSavedCommandBySelector message when a command is not handled by WebCore.


git-svn-id: svn://svn.chromium.org/blink/trunk@83004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

       Unreviewed, temporarily mark two tests as more generally failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        Correctly set color when using skia's fillRoundedRect.
        https://bugs.webkit.org/show_bug.cgi?id=57907

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):

git-svn-id: svn://svn.chromium.org/blink/trunk@83002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Silly with statement, from the future!

        * Scripts/webkitpy/common/system/executive.py:


git-svn-id: svn://svn.chromium.org/blink/trunk@83001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Move attributedStringFromRange down to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=57905



git-svn-id: svn://svn.chromium.org/blink/trunk@83000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        Don't use Exception.message because it's deprecated
        https://bugs.webkit.org/show_bug.cgi?id=57892

        Suppress the warning for now.  When we move to Python 3, we might need
        to something more dramatic.

        * Scripts/webkitpy/common/system/executive.py:


git-svn-id: svn://svn.chromium.org/blink/trunk@82999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ojan Vafai.

        Add builders.js to dashboard file list
        https://bugs.webkit.org/show_bug.cgi?id=57899

        Add file added by http://crrev.com/80538 to dashboard file list.

        * TestResultServer/handlers/dashboardhandler.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@82998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        Some plug-in content is displayed upside down in Unity plug-in
        https://bugs.webkit.org/show_bug.cgi?id=57895
        <rdar://problem/9212003>

        Create the flipped geometry layer in the web process instead of the plug-in process,
        which matches what we do in WebKit1.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformPostInitialize):
        * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
        (WebKit::PluginProxy::pluginLayer):


git-svn-id: svn://svn.chromium.org/blink/trunk@82997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        [chromium] Don't have 'using namespace' declarations in header files
        https://bugs.webkit.org/show_bug.cgi?id=57882

        * src/EventListenerWrapper.cpp:
        * src/EventListenerWrapper.h:
        * src/VideoFrameChromiumImpl.h:
        * src/WebDOMEventListener.cpp:
        * src/WebDOMEventListenerPrivate.cpp:
        * src/WebDOMEventListenerPrivate.h:
        (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):

git-svn-id: svn://svn.chromium.org/blink/trunk@82996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Rename variables in border drawing code for readability
        https://bugs.webkit.org/show_bug.cgi?id=57894

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawLineForBoxSide):
        (WebCore::RenderObject::drawBoxSideFromPath):
        (WebCore::RenderObject::drawArcForBoxSide):

git-svn-id: svn://svn.chromium.org/blink/trunk@82995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57886

Reviewed by Darin Adler.

This reduces the need to do (often expensive) platform surface invalidation.
We already do this during layout but style recalculation may trigger
invalidation as well.
    
* dom/Document.cpp:
(WebCore::Document::recalcStyle):



git-svn-id: svn://svn.chromium.org/blink/trunk@82992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        HTML5 Player Has no Fullscreen Mode
        https://bugs.webkit.org/show_bug.cgi?id=57795

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::supportsFullscreen): Call the new ChromeClient API
            supportsFullScreenForElement() before the old supportsFullScreenForNode() API.

git-svn-id: svn://svn.chromium.org/blink/trunk@82991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

slaves.
https://bugs.webkit.org/show_bug.cgi?id=56564

Skip fast/preloader/scan-body-from-head-script.html on Leopard to get the bots green.

* platform/mac-leopard/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@82990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@82989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Build fix for YarrParser.h
        https://bugs.webkit.org/show_bug.cgi?id=57822

        * yarr/YarrParser.h:
        (JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):

git-svn-id: svn://svn.chromium.org/blink/trunk@82988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't skip react-to-vsprops-changes.py for all production builds,
only those initiated via JavaScriptCore.make.

* JavaScriptCore.vcproj/JavaScriptCore.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:



git-svn-id: svn://svn.chromium.org/blink/trunk@82987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        REGRESSION (r82849): 85,000+ JSC-related leaks seen on SnowLeopard Intel Leaks
        https://bugs.webkit.org/show_bug.cgi?id=57857

        Whoops, accidentally removed a deref().

        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::deref):

git-svn-id: svn://svn.chromium.org/blink/trunk@82986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: fix data url's status and timing the network panel.
        https://bugs.webkit.org/show_bug.cgi?id=53066

        Added data url support for status of network resources.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.isDataURL):

git-svn-id: svn://svn.chromium.org/blink/trunk@82985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add per-configuration vsprops files.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Removed inheritance from common.vsprops.
Set production environment variable before calling make.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@82983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Assertion failure when navigating quickly between file URLs
        https://bugs.webkit.org/show_bug.cgi?id=57884
        <rdar://problem/9080559>

        Remove bogus assertion. The pending provisional sandbox extension can be
        non-null if the current provisional load fails because we're about to load a new
        page that also has a sandbox extension.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):


git-svn-id: svn://svn.chromium.org/blink/trunk@82982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        [V8] Keep dirty primitive CSS values alive.
        https://bugs.webkit.org/show_bug.cgi?id=57810

        * bindings/v8/V8GCController.cpp:
        (WebCore::GrouperVisitor::visitDOMWrapper):

2011-04-04  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        [V8] Keep dirty primitive CSS values alive.
        https://bugs.webkit.org/show_bug.cgi?id=57810

        * platform/chromium/test_expectations.txt: Mark
        fast/dom/StyleSheet/gc-inline-style-cssvalues.html as passing.


git-svn-id: svn://svn.chromium.org/blink/trunk@82981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Grant the web process access to ~/Library/Preferences/com.apple.universalaccess.plist
        https://bugs.webkit.org/show_bug.cgi?id=57879

        The web process needs access to the unviersal access preferences to determine if full keyboard
        access is enabled. I've filed <rdar://problem/9237619> which tracks reading this preference in the UI
        process and sending it over to the web process whenever it changes.

        * WebProcess/com.apple.WebProcess.sb:


git-svn-id: svn://svn.chromium.org/blink/trunk@82980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57880
        
Update Windows expected results (with pixel tests) to greenify the bots.

* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@82979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        webkit-patch should print git's stderr when git svn dcommit fail
        http://webkit.org/b/57861

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@82978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57881

Update the Windows-specific results to get the bots green.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
onformchange and onforminput were removed in r82925.



git-svn-id: svn://svn.chromium.org/blink/trunk@82977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Levin.

        Added MediaTypeFile enum value to WebContextMenuData::MediaType.
        https://bugs.webkit.org/show_bug.cgi?id=57566

        * public/WebContextMenuData.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@82976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, removing the chromium-win results causes this test to
        start passing on chromium win and linux.

        * platform/chromium-win/fast/images/svg-as-tiled-background-expected.checksum: Removed.
        * platform/chromium-win/fast/images/svg-as-tiled-background-expected.png: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@82975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser.

        Add parentheses around && within || to avoid clang warning.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):

git-svn-id: svn://svn.chromium.org/blink/trunk@82974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Add two more entries to the sandbox profile
        https://bugs.webkit.org/show_bug.cgi?id=57875

        Allow read-access to /Library/Dictionaries since WebCore::nextBreakablePosition
        ends up calling into ICU which accesses the dictionary.

        Allow Mach access to com.apple.networkd since it's used by CFNetwork.

        * WebProcess/com.apple.WebProcess.sb:


git-svn-id: svn://svn.chromium.org/blink/trunk@82973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        Add --baseline-search-path to NRWT
        https://bugs.webkit.org/show_bug.cgi?id=56233

        Add NRWT option to specify additional directories to look for baselines
        (will be used by hardware GPU bots which will have local per-bot
        expectations for some tests)

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@82972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gavin Barraclough.

        Make caches window show more info about non-jsobject GC values
        https://bugs.webkit.org/show_bug.cgi?id=57874

        Add ClassInfo to the various internal JS types that currently
        don't have any, and make the text for caches window show the
        classname for non-JSObject instances.

        * runtime/Executable.cpp:
        * runtime/Executable.h:
        (JSC::ExecutableBase::createStructure):
        (JSC::NativeExecutable::createStructure):
        (JSC::NativeExecutable::NativeExecutable):
        (JSC::EvalExecutable::createStructure):
        (JSC::ProgramExecutable::createStructure):
        (JSC::FunctionExecutable::createStructure):
        * runtime/Heap.cpp:
        (JSC::TypeCounter::typeName):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/ScopeChain.cpp:
        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::createStructure):
        * runtime/StructureChain.cpp:
        * runtime/StructureChain.h:
        (JSC::StructureChain::createStructure):

git-svn-id: svn://svn.chromium.org/blink/trunk@82971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Oliver Hunt.

        Invalidate callbacks if the WebPageProxy is no longer valid
        https://bugs.webkit.org/show_bug.cgi?id=57873
        <rdar://problem/9059717>

        Audit all function calls that take callbacks and make sure to invalidate the callbacks
        if the web page is no longer valid.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::runJavaScriptInMainFrame):
        (WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
        (WebKit::WebPageProxy::getSourceForFrame):
        (WebKit::WebPageProxy::getContentsAsString):
        (WebKit::WebPageProxy::getSelectionOrContentsAsString):
        (WebKit::WebPageProxy::getMainResourceDataOfFrame):
        (WebKit::WebPageProxy::getResourceDataFromFrame):
        (WebKit::WebPageProxy::getWebArchiveOfFrame):
        (WebKit::WebPageProxy::forceRepaint):
        (WebKit::WebPageProxy::computePagesForPrinting):
        (WebKit::WebPageProxy::drawRectToPDF):
        (WebKit::WebPageProxy::drawPagesToPDF):


git-svn-id: svn://svn.chromium.org/blink/trunk@82970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adele Peterson.

        Add a fast path for simple color backgrounds
        https://bugs.webkit.org/show_bug.cgi?id=57773

        Add a fast path for drawing simple color backgrounds. It's
        faster to fill a path or rect than it is to set up a clip,
        and then paint the rect.

        No visible behavior change so no new tests.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):

git-svn-id: svn://svn.chromium.org/blink/trunk@82969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed EFL build fix for r82962.

        * CMakeListsEfl.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@82968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
files, rather than pointing to the directory that contains them. This is more convenient for
people browsing build.webkit.org, but confused Leaks Viewer.

Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
list don't work

Reviewed by Joseph Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.

git-svn-id: svn://svn.chromium.org/blink/trunk@82967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This includes machines without the necessary graphics hardware, and machines without
WebKitQuartzCoreAdditions (like the Windows 7 Release (WebKit2 Tests) bots).

Fixes <http://webkit.org/b/57870> REGRESSION (r82960): Lots of tests crashing in
DrawingAreaImpl::enterAcceleratedCompositingMode on Windows 7 Release (WebKit2 Tests)

Reviewed by Anders Carlsson.

* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. On platforms other than
Windows, this always returns true.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Only enable accelerated compositing-related
preferences if the machine supports accelerated compositing.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Added. Creates a view, asks it
if it can draw, and returns the result.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added supportsAcceleratedCompositing.

* WebProcess/WebPage/win/LayerTreeHostWin.cpp: Added.
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. Calls through to
LayerTreeHostCAWin in configurations that support that class. Otherwise just returns false.

* win/WebKit2.vcproj: Added LayerTreeHostWin.cpp. Let VS reorder some other files.

git-svn-id: svn://svn.chromium.org/blink/trunk@82966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Jian Li.

        [chromium] send-sliced-dragged-file.html started to crash on chromium bots
        https://bugs.webkit.org/show_bug.cgi?id=57539

        * platform/chromium/test_expectations.txt: Removed passing test
          as it has been fixed in the chromium network stack as of chromium r80114
          and it was introduced in r79905 so no need to change the chromium deps
          since it is before the regression.

git-svn-id: svn://svn.chromium.org/blink/trunk@82965 bbb929c8-8fbe-4397-9dbb-9b2b20218538