GitLab

Extensions used to be able to override the bookmark star view in order
to provide a custom bookmark manager (this was used for the Stars
extension). The extension has been deprecated and removed, and the API
never launched. Clean up the remnants.

When an extension overrode the bookmark shortcuts, the accelerators were
given normal priority, whereas other extension accelerators are given
high priority (in order to override the default shortcut in Chrome).
Now, this can be simplified to have all extension shortcuts be high
priority. Replace the GetAcceleratorPriority() logic with a constant,
and update call sites appropriately.

Bug: 894447
Change-Id: I7a87f323f4c91f8d13bed60c4f845dbe7de45ecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120291
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754756}

* Eliminate a meaningless call
* Factor a delegate into a utils file and use it in two tests
* Prep ChromeViewsTestBase for working with AshTestViewsDelegate

Bug: none
Change-Id: Ib42188446c0a77400d29ab6a648f42a24d64b12b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126095
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754755}

This isn't all that useful relative to just having the profile.

Fixed: 1053032
Change-Id: I320f4fc68782c37fb0e6fc5d1e14966226346f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125240
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754754}

There were already some stubs for the 'page' property, but it couldn't
be used for anything. Move it behind a runtime flag and implement it.
Also add legacy layout engine support. Will add to LayoutNG once it
supports printing.

Bug: 1053768
Change-Id: I2b7eff133c925a67ef36db4b6fa259cf934abf75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126708Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754753}

https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/c8aaddeaf3ea..63f96a1f9b5e

$ git log c8aaddeaf..63f96a1f9 --date=short --no-merges --format='%ad %ae %s'
2020-03-29 ltrudeau const correctness in itx_1d
2020-03-28 ltrudeau const correctness msac
2020-03-27 ltrudeau const correctness in obu.c
2020-03-26 janne-vlc meson/x86: add option to disable AVX-512 asm
2020-03-26 ltrudeau const correctness in picture.c
2020-03-25 ltrudeau Extract sub_h4 out of inner loop
2020-03-15 martin arm64: ipred: Add NEON implementation of ipred for 16 bpc
2020-03-22 martin checkasm: ipred: Test and benchmark FILTER_PRED separately for 10 and 12 bpc
2020-03-16 martin arm: ipred: Prepare for 16 bpc
2020-03-16 martin arm: ipred: Remove stray leftover instructions
2020-03-24 martin arm64: ipred: Integrate aggregation into the first pass of cfl_ac
2020-03-23 martin arm64: ipred: Use rounded shifts instead of a separate addition
2020-03-23 martin arm64: ipred: Do shifts on only half the register width when possible
2019-11-13 martin arm64: ipred: Avoid data dependencies with consecutive dup instructions
2019-11-13 martin arm64: ipred: Remove a superfluous postincrement
2020-03-25 rsbultje x86: add AVX2 SIMD for ipred.cfl_ac[444]
2020-03-25 rsbultje checkasm: add proper restrictions for h/w_pad in ipred.cfl_ac[444/422]
2020-03-25 rsbultje x86: add SSSE3 SIMD for generate_grain_uv_{422,444}
2020-03-24 rsbultje x86: add AVX2 SIMD for generate_grain_uv_{422,444}
2020-03-24 ltrudeau Clean up dav1d_ref_create
2020-03-24 ltrudeau const correctness in thread_task
2020-03-24 ltrudeau Make insert_border src pointer const
2020-03-24 hugo crossfiles: android: Remove misleading comment
2020-03-24 hugo crossfiles: android armv7: Target API 16
2020-03-24 hugo crossfiles: android: Remove hardcoded c_args
2020-03-23 hugo ci: Add android jobs with artifacts on tags
2020-03-20 hugo ci: Add android configs
2020-03-23 hugo package: Add android crossfiles
2020-03-22 me Add crosscompile config files for 32, 64-bit Windows and 32-bit Linux
2020-03-22 martin Add a cast to avoid MSVC warning
2020-03-21 janne-vlc meson/android: undefine _FILE_OFFSET_BITS if fseeko is not available
2020-03-20 rsbultje Merge fix_mv{_int,}_precision() into get_gmv_2d()
2020-02-01 rsbultje Use union refmvs_pair { mv mv[2]; uint64_t n; } for MV pairs
2020-03-19 rsbultje Rewrite refmvs.c
2020-03-09 jamrial lib: restructure the internal implementation of the decode API
2020-03-21 janne-vlc android/arm: do not use fseeko in library code
2020-03-11 jamrial headers: partially revert a recent change to Dav1dLogger doxy
2020-03-07 code CI: Only deploy documentation for master branch
2020-03-08 sledru Fix a typo, only need two l!
2020-03-07 jamrial headers: add missing doxy to some Dav1dSettings fields
2020-03-07 jamrial headers: split some public fields into separate lines and document them
2020-03-07 code CLI: Remove additional space
2020-03-07 code CLI: Remove avx512 from help text
2020-03-07 thresh CI: add examples job build
2020-03-06 thresh examples: fail when SDL is not found
2020-03-06 thresh CI: Add documentation CI job
2020-03-06 thresh CI: Deduplicate and template jobs
2020-03-06 thresh doc: search for dot as it's needed to build doxygen documentation
2020-03-06 jbeich examples: chase cacc8e350c40
2020-03-05 jb Update NEWS for 0.6.0

Created with:
  roll-dep src/third_party/dav1d/libdav1d

TBR=tguilbert

Change-Id: I1a8213fdc15174348316ed6beb1824beb957b989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128588
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754752}

In r604873 support for revoking USB permission in real time was added
but broke this tab indicator behavior by closing the mojo::Receiver for
the UsbDeviceClient interface on device disconnection without updating
the tab indicator state.

This change fixes that behavior by having WebUsbServiceImpl track the
open state of each UsbDevice pipe it creates and updating the tab
indicator state if one of them is forcibly closed while the device is
open.

This change allows connection state tracking in UsbTabHelper to be
simplified.

Additional unit tests for this behavior have been added.

Bug: 1064467
Change-Id: I9747d48428fc3daaf921b6763060ba16007004ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122461Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754751}

This reverts commit 65c5d4c4.

Reason for revert: Flakes are caused by some unrelated crash lingering somewhere in DWriteFontLookupTableBuilder

Original change's description:
> Disable NativeMessagingLaunchApiTest.InvalidConnectId on Win dbg.
> 
> TBR=dbertoni@chromium.org
> BUG:1065344
> 
> Change-Id: Ib760d8263dc8cdd75c750a07770244a5e3ff779b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124311
> Reviewed-by: Tim Schumann <tschumann@chromium.org>
> Commit-Queue: Tim Schumann <tschumann@chromium.org>
> Auto-Submit: Tim Schumann <tschumann@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753973}

TBR=tschumann@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I96f1a1cc871ac98c469f2a0a47fc7b4698ebdc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128029Reviewed-by: Sergei Datsenko <dats@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754750}

Web animation API calls can manipulate timing properties. The values
from API calls override their corresponding CSS properties values.
Specifically, calls to effect.updateTiming(timing_options) override any
property that is included in timing_options. Replacing the animation
effect, overrides all timing properties.

Next step: Fix handling of overridden keyframes.

Bug: 1058731
Change-Id: I351ebf535511c11da0d515bf2e24b6435247d892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120734
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754749}

Relnotes: N/A
Bug: 996871
Change-Id: I8232084777882e247676e4e3350d94d11a711418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122613Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#754748}

Been unused for years.

Change-Id: Icc6c9a668016da2d82ae6f377a9499554bb3341e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127887Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754747}

This fixes a bunch of "use of non-const ref" lint errors in a nicer way
than just changing everything to pointers, since it's a reasonable API.

NOPRESUBMIT=true

Bug: none
Change-Id: I894724ffb05db2e450f76db9d0b788c14c833a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126253
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754746}

This moves it to LocationBarLayoutTest because that is where
the soft input mode logic currently resides.

Ran the test 100 times locally and swarmed across 10 devices w/o
issue.

BUG=1027549

Change-Id: Ib124b9887e7f48b57eab3e0135ff1abbf30badd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128237Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754745}

Build Chromium on macOS with CUPS IPP. Use a runtime switch to allow
for dynamic switching between the original CUPS backend, which uses PPD
attributes, and the new backend. The original backend will remain the
default one until the new one is verfied through experiments and/or
automated testing.

Bug: 226176
Change-Id: I88147e12ec8bb75a2c17add32fbccf7496d2f669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067548Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754744}

Bug: none
Change-Id: Iba3eefb58c629927ee4b429989a151386d393798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106656
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754743}

These are no longer useful since this features is on by default.

Fixed: 1053019
Change-Id: Ibb579ecd5dacf6bc168c95e50dd47362c3c4cc66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125430
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754742}

Terminal events of transferController operations (drag-end, touch-end)
should also remove pointer-active from the html element.

Bug: 1062902
Change-Id: I5da0d327b170bf6128ef5b554a692ba9490cdd58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127166Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754741}

Also, pennymac has not worked on Chromium for a while now.

Change-Id: Ibc2131dc81939a94b26fcd802a749740105a065b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127893Reviewed-by: James Forshaw <forshaw@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754740}

https://chromium.googlesource.com/angle/angle.git/+log/7939e367fa53..1288aa12369e

git log 7939e367fa53..1288aa12369e --date=short --first-parent --format='%ad %ae %s'
2020-03-30 geofflang@chromium.org Update the active texture cache before changing the texture binding.
2020-03-30 sugoi@google.com Add support for NV_read_depth, NV_read_stencil and NV_depth_buffer_float2 extensions

Created with:
  gclient setdep -r src/third_party/angle@1288aa12369e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I23aa84412132c62756bbe768f5b7d8f19c9767c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128850Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754739}

The base/derived class stuff was hiding a bug where the test wasn't
testing what it was supposed to be testing because the FeatureList was
being init'd too late.

This CL cleans all that up and adds a bunch of comments for why, while
making everything a bit easier to understand.

Bug: 1023485
Change-Id: I31b0cab43af4a3032073c69200702b004f8178b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126469
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754738}

This CL removes some icon processing logic that we do differently for
sync initiated installs as they are unnecessary and contains the source
of a DCHECK failure.

We were DCHECK failing sync installation for sites that included icons
with no size specified because we were storing this as size 0. During
sync installation we would include this size 0 as part of the icons to
generate. This produced an invalid icon that failed the DCHECK in
ConvertWebAppToExtension() and caused the app sync install to fail
entirely.

Bug: 1062921
Change-Id: I273276b63ba762d522b86423cc6aaf67740a871b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120081
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754737}

https://skia.googlesource.com/skia.git/+log/6e2af5c326c4..14ba58ff012f

git log 6e2af5c326c4..14ba58ff012f --date=short --first-parent --format='%ad %ae %s'
2020-03-30 bungeman@google.com Add GrTAllocator::push_back(T&&)
2020-03-30 michaelludwig@google.com Declare SkString in GrContext
2020-03-30 reed@google.com remove unused SkLightingShader
2020-03-30 brianosman@google.com Stop including SkCanvas.h from GrTypesPriv.h
2020-03-30 jvanverth@google.com Fix d3d debug clang build

Created with:
  gclient setdep -r src/third_party/skia@14ba58ff012f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: michaelludwig@google.com
Change-Id: Ib36fbffd37623c9662091d5eb3e280d20d50d4e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754736}

Bug: 1065554
Change-Id: I4425e1d43a506ebe6dabacb5c29a6bd8c35c84a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127434
Commit-Queue: Sam Bowen <sgbowen@google.com>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754735}

Bug: 1057952
Change-Id: Ie8b3684340609c5bcde1b54a51c110fe8a5f74b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128834Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754734}

We WONTFIXed the bug already. We don't need this flag anymore.

Bug: 1033184
Change-Id: I0fe90e0a18ee995343ba233a74df78c15eba7aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128787Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754733}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df70c8152767..06101933267d

git log df70c8152767..06101933267d --date=short --first-parent --format='%ad %ae %s'
2020-03-30 dalecurtis@chromium.org Don't delete dormant branches, even if empty.

Created with:
  gclient setdep -r src/third_party/depot_tools@06101933267d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I3fa939f2b0cd9748dde11923ab1646030c3970a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128859Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754732}

Bug: 1046170
Change-Id: I44db23d4b31309a8535bd18c0880b192d05679fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088010
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754731}

Subframes which have their initial load aborted (e.g. due to a
document.write() call) never have the subresource filter activated on
the browser side. We now skip over these frames when ascending the frame
tree so that they inherit the appropriate activation from the frame's
parent. We do not handle the case of a main frame with an aborted load.
This will be fixed by crbug.com/1055558. Frames with aborted non-initial
loads keep their previous activation.

In addition, activated_frame_hosts_ is renamed to frame_host_filter_map_
to reflect the inclusion of nullptr for frame hosts that should inherit
the activation of its parent (which might not be activated). Some tests
are modified to watch for a title change that occurs after all scripts
are loaded. This allows those scripts' functions to be used safely.

The subresource filter was enabled on the frames with an aborted initial
load themselves by crrev.com/c/2064474.

Bug: 1052362
Change-Id: I9121be0f9154e346ca2602c30475b68e4da9f560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081523
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754730}

This CL enables the WebNavigationApiTest.Failures, which was flaky on
various platforms. After tracing the source of flakiness, it boiled down
to internals of Blink and behavior difference when there is a
subresource that is still being loaded. If the JS "cancel()" method is
called and such a subresource is still in the process of loading, the
load is cancelled and the DidFailLoad callback for the document does
not get dispatched due to how internal state has changed. In the
success cases, the subresource is not in loading state, which allows
the expected dispatch of DidFailLoad callback for the document.

As such, a simple fix for the flakiness is to remove the image tag
from the document, allowing it to be deterministic in the cancellation
behavior.

Bug: 477840, 746407, 868880
Change-Id: I8a23575a9c31f0670315fd6ef55b65874e9f1700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128571Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754729}

The intent of the code in the CacheManager() method was to avoid
creating a CrossSequenceCacheStorageManager wrapper object if shutdown
had been initiated.  This was due to the fact the wrapper cannot handle
a nullptr manager once its created.  If shutdown started after the
wrapper was created then everything should be fine since the wrapper's
task to the target sequence should run first.

The code, however, had two bugs:

1. It used a simple atomic boolean instead of a real lock.  This allowed
   a race where shutdown could be initiated on a different thread after
   the shutdown check, but before the wrapper is created.
2. It also gated access to the real CacheStorageManager on the target
   sequence after shutdown.  This broke the design invariant that the
   wrapper's task posted to the target sequence would always see a
   non-nullptr manager.

The fuchsia platform just happened to trigger issue (2) here.  With this
change we can now enable using the sequence on the fuchsia platform.

Bug: 960012
Change-Id: I09e154b3974d5808e73f2be3b8347c47c0d3051a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127766
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754728}

Bug: 1065780
Change-Id: I5206620c1b7ee0047a753b5beacd3797e42517df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126570Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754727}

This CL add UMA metrics to record events of smart dim component, and
adds corresponding items to enums.xml and histograms.xml.

Bug: 1049888
Test: tested on DUT
Change-Id: I6d8dcfbffbf0741b63974d6e3dabcc75b9df675b
Cq-Depend: chromium:2116168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119462Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754726}

https://webrtc.googlesource.com/src.git/+log/1d0faee9aa1a..fa068336f9e0

git log 1d0faee9aa1a..fa068336f9e0 --date=short --first-parent --format='%ad %ae %s'
2020-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a0d7df33..4d555ede (754491:754603)

Created with:
  gclient setdep -r src/third_party/webrtc@fa068336f9e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4186ca89bc0c2c4e75204adc98d15f0575cfe3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128857Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#754725}

This code is for web tests only so does not need to live inside
content shell.

We still read the kRunWebTests switch in ShellMainDelegate, which is
actually a content shell switch (it modifies content shell to inject
web test code).

This puts code to set command lines that was previously running in
every process into just the browser process, and relies on the allow-
lists of switches for each process to pass the appropriate flags.

This uncovered 2 interesting points along the way:

The kRegisterFontFiles switch is only for windows. It is used as a
global variable in the browser process to set the list of font files,
and then to open a hole in the renderer sandbox to read those files.
Then it is passed to the renderer which reads those files. I've made
this more clear with code, ifdefs and comments.

Web tests were setting --disable-gpu-rasterization in the gpu process
unconditionally, since every process sets command line flags but the
--force-gpu-rasterization is not passed to the gpu process. This doesn't
seem to have an impact on results except for on mac. By removing this
--disable-gpu-rasterization from the gpu process, when gpu raster is
being used in virtual/gpu-rasterization/ tests, the results change.
This CL rebaselines them.

R=nasko@chromium.org

Bug: 866140
Change-Id: Ia49983517ff0b9c91b1ae7549a47fd16a45d3497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116535
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754724}

NOPRESUBMIT=true

Bug: none
Change-Id: I0380b4c1d1b9b427923f142ac617e7cd9c78e856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126252
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754723}

Replace new statements and base::WrapUnique() usage with
std::make_unique(). Fix a new nits along the way.

Change-Id: Id5df2a4169623f002ac13ff7142713afab866c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125683
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754722}

This CL adds common test utility code generating and serializing
combinations of Trust Token API parameters
(https://github.com/wicg/trust-token-api). This is so that the same code
can parameterize
1. the integration tests in trust_token_parameters_browsertest.cc, which
verify that JS parameters' values are correctly reflected in the network
stack, and
2. the iframe attribute parsing unittests in the child CL, which confirm
that the JSON-encoded 'trusttoken' iframe attribute is parsed into the
correct internal representation of the parameters' values.

It also refactors a test currently written using URLLoaderInterceptor to
use URLLoaderMonitor, which is much simpler.

Bug: 1062396
Change-Id: I3a109e2d0aacf3914f67aa7ac34ad3c7c363eccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115778Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754721}

Add a test that launches BookmarkFolderSelectActivity from
BookmarkEditActivity, changes the folder, then confirms the bookmark
edit UI adjusts accordingly.

BUG=1065043

Change-Id: I50a1c494b431b70090a2faebf13bd90517d11645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128241
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754720}

During submit, if the frame is not activated yet, a copy of reporter at
Begin_Impl stage will be created and reported. This reporter is the
Begin_Impl portion of the existing reporter which is in Begin_main or
Commit stage.

So in the case of:
BI_1 BM_1 S_1 P_1 BI_2 C_1 A_1 S_2 P_2

In addition to:
BI_1 -> BM_1 -> C_1 A_1 S_2 P_2

This set will also be reported:
BI_1 -> S_1 -> P_1

Bug: chromium:1059282
Change-Id: I581088a41cd8ee1247fa18e28e4a24f5d4870103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095350
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754719}

Currently GNArgsFromDir expects gn arg to have exactly one space around
assignment operator (target_os = "android"). It removes both spaces so
that later the code could to a check in the form
('target_os="android"' in vals['gn_args']). If an arg doesn't have
spaces or have extra (target_os ="android"), the logic works
incorrectly.

This CL fixes GNArgsFromDir to break name/value line on '=' and strip
spaces around both name and value.

BUG=1066289

Change-Id: I958b2cb400415f33f6b5310da0f127df715bd059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127742
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754718}

I incorrectly assumed that any ET_GESTURE_SWIPE would be preceded by an
ET_GESTURE_SCROLL_BEGIN. Sometimes this is not the case, and this caused a
DCHECK.

This change handles swipes that weren't preceded by a scroll event.

Bug: None
Change-Id: I535e43a10e6f6162080af4ba4b85a8fefc8e2cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128091Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754717}