- 26 Oct, 2018 40 commits
-
-
David Bienvenu authored
Use static initializer for condition_ member var instead of win api call. Bug: 891924 Change-Id: I61860a13f286389cf955a74d8e4b3e5c3d30bbb9 Reviewed-on: https://chromium-review.googlesource.com/c/1299916Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603069}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/954de5bd..cce05b09 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd81927f8c1bc3605be07c330d3e10aa8988c6ab Reviewed-on: https://chromium-review.googlesource.com/c/1301560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603068}
-
Xi Han authored
In this CL, the entire ResouceBundle is initialized in the ChromeFeatureListCreator. This prevents loading parts of the data pack earlier and then add it to the ResouceBundle when the full browser starts. Bug: 846846,729596 Change-Id: Ia254252288ead936bde8cb65b12cf2fecbfc106f Reviewed-on: https://chromium-review.googlesource.com/c/1292516 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#603067}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95dfa5223ac6..a5d543ce21cd git log 95dfa5223ac6..a5d543ce21cd --date=short --no-merges --format='%ad %ae %s' 2018-10-26 mbonadei@webrtc.org Set minSdkVersion to 16 for AppRTCMobile_stubbed_video_io_test_apk. Created with: gclient setdep -r src/third_party/webrtc@a5d543ce21cd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaa9936e687006c3a5db37a4da4f93e51ee1998ac Reviewed-on: https://chromium-review.googlesource.com/c/1301535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603066}
-
Maks Orlovich authored
Only true is ever passed here now, so this is latent. Change-Id: I1afd9c466aca857a99ac2cf932185aa899a228cc Reviewed-on: https://chromium-review.googlesource.com/c/1300036Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#603065}
-
Gaurav Dhol authored
base/process/memory_win.cc(35,2): error: Unsupported platform Bug: 893460 Change-Id: I207473a8d4dc7c4d5fc01dae10fde51db0bdfab2 Reviewed-on: https://chromium-review.googlesource.com/c/1298832 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#603064}
-
Asanka Herath authored
R=mmenke@chromium.org Bug: 884310 Change-Id: I0f14c7dfcb2a6c54e52ac4f18328095e4af78db2 Reviewed-on: https://chromium-review.googlesource.com/c/1300778Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#603063}
-
Zakhar Voit authored
This is a reland of 75d0995f I've fixed the start-up crashes with DCHECK enabled (see diff from PATCHSET-1 to PATCHSET-3). Original change's description: > Updated AllowedUILocales to handle preferred languages. > > Updated AllowedUILocales to limit not only the ui locales but also the > available preferred languages. Renamed AllowedUILocales to AllowedLanguages to > better indicate that. > > Bug: 579660 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3 > Reviewed-on: https://chromium-review.googlesource.com/c/1256570 > Commit-Queue: Zakhar Voit <voit@google.com> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597559} Bug: 579660, 695042 Change-Id: I5d499843fb500fa9d2852559dedc08adfd012da0 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1280270 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603062}
-
Ross McIlroy authored
The V8 context shouldn't be accessed when generating context independent code. Convert some string equality operations which require a context to the StringEquals function which does not. BUG=chromium:898076 Change-Id: Ia9a01b27fa9fcfc0c19268a3c862f2174eda7e1d Reviewed-on: https://chromium-review.googlesource.com/c/1301459Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603061}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0607ea1bb336..f75bf6c00916 Created with: gclient setdep -r src-internal@f75bf6c00916 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id2397e8ea045abc3ce9f73236197d8de37b33111 Reviewed-on: https://chromium-review.googlesource.com/c/1301534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603060}
-
Alex Clarke authored
We don't need task timing on the UI thread, so this patch arranges for time only to be sampled if we have an observer that needs it. Bug: 897751 Change-Id: I5915efdb903813a574ca05cee316cb30fa75b39c Reviewed-on: https://chromium-review.googlesource.com/c/1297425 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603059}
-
yoshiki iguchi authored
This reverts commit 3767b2ad. Reason for revert: This CL is innocent. I fixed the issue separately: crrev.com/c/1297853. Original change's description: > Revert "Show notification counter even on lock screen" > > This reverts commit 155c0b00. > > Reason for revert: This breaks the lock screen notification. > > Original change's description: > > Show notification counter even on lock screen > > > > - Unblock notifications in SessionStateNotificationBlocker > > - Hide the message center by seeing the session sate (previously, it > > saw the count of notifications) > > - Change height below scroll, by checking the visibility of message > > center (previously, it checked only the height) > > > > Bug: 893945 > > Test: manual > > > > Change-Id: I39d30d0949d0f44078193ab7e4859f66eeebf880 > > Reviewed-on: https://chromium-review.googlesource.com/c/1282426 > > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601824} > > TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org > > Change-Id: I5b2ded9c9f3212ab3cd085a3ea0721e69b6fae45 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 893945 > Reviewed-on: https://chromium-review.googlesource.com/c/1296330 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601930} TBR=yoshiki@chromium.org,yamaguchi@chromium.org,tetsui@chromium.org Bug: 893945 Change-Id: Iaee3fc6e7dcb996be1406897b07f571991a7e3db Reviewed-on: https://chromium-review.googlesource.com/c/1301037 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603058}
-
Christian Dullweber authored
Rebuild leveldb for LocalStorage when deleting all cookies. This will remove traces of deleted data from disk. This change adds a RewriteDB() method to leveldb.mojom and adds handling of error cases, where the database service becomes unusable and closes the mojo connection. TBR: michaelbai@chromium.org Bug: 823071 Change-Id: I639ce21d7578d19e45ea9b7329b6ccbdfab8b527 Reviewed-on: https://chromium-review.googlesource.com/c/1162172 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#603057}
-
Guido Urdaneta authored
It is easy to produce explicit universal cases for discrete sets of boolean values since there are only to possible values. This CL adds an specialization so that the common case of a set with {true,false} is considered universal. This helps simplify some of the constraints processing code for audio, which contains many boolean properties. Bug: 731170 Change-Id: Ie7cd41a161f9de93fbc13273d44d2cccaa217522 Reviewed-on: https://chromium-review.googlesource.com/c/1299004Reviewed-by:Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#603056}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb69b988..954de5bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I24da46138da7edfac9d4e51784e0327c58190ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1301555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603055}
-
Adam Rice authored
https://chromium-review.googlesource.com/c/1262055 introduced CHECK statements to BodyStreamBuffer::CloseAndLockAndDisturb to verify that the stream is not garbage collected during execution of the function. None of the CHECK statements have been hit, so we can reasonably conclude that this is not happening in practice. These CHECKs should not be included in a stable release, so remove them. BUG=882599 Change-Id: I6c132ffd81c6642df7f4d9628b76f108f24bc2ed Reviewed-on: https://chromium-review.googlesource.com/c/1296571Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#603054}
-
Adam Rice authored
Copy the the original values of selected DOM constructors, methods and getters to the binding object during global object initialisation. Then access them via the binding object in the V8 extras transferable streams implementation. This protects the implementation from modifications to the global object. Constructors copied: MessageChannel DOMException Methods copied: EventTarget.prototype.addEventListener MessagePort.prototype.postMessage MessagePort.prototype.close MessagePort.prototype.start Accessors copied: MessageChannel.prototype.port1 MessageChannel.prototype.port2 MessageEvent.prototype.data DOMException.prototype.message DOMException.prototype.name BUG=897046 Change-Id: I72e40951e5c45f51c957dfa277044a210b054675 Reviewed-on: https://chromium-review.googlesource.com/c/1291191 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#603053}
-
Joshua Bell authored
Now that base::BindLambdaForTesting() can be used, tasks posted to the Indexed DB task runner in tests don't need to explicitly bring along ambient state. Also, use an explicit RunLoop's Run()/Quit() instead of RunAllTasksUntilIdle() where possible, and 'auto' for readability. Change-Id: Iede419cda01c166e8fe2047c901f528f687f940d Reviewed-on: https://chromium-review.googlesource.com/c/1298416 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#603052}
-
Koji Ishii authored
fast/writing-mode/border-image-vertical-lr.html produces different results because, in legacy, block direction borders applied to inline boxes affect positioning of the line box in vertical-lr writing-mode, when they should not. This patch rebaselines it, and also adds a minimized test to check such borders do not affect line box positioning. Gecko, and WebKit fail the test. Edge passes this test, though it paints the border at the incorrect position. Testing the border positoin is not ref-testable and that it is not included. Bug: 636993 Change-Id: I2568d19dac7f7ea886a46d45620bc22feb172c53 Reviewed-on: https://chromium-review.googlesource.com/c/1301698Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603051}
-
Sami Kyostila authored
TBR=gab@chromium.org Bug: 891670 Change-Id: I66e545c6bdbf04333cbd9178f8af9f8b2419e543 Reviewed-on: https://chromium-review.googlesource.com/c/1301456Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603050}
-
Fredrik Söderquist authored
All of the 'blink::*' directives should be unnecessary (now that the code is within Blink.) Remove the testing::StrictMock 'using' too, and just "expand" it at its single usage point. Change-Id: I3171d05f41364fa134c2ee781e93178d831d4eab Reviewed-on: https://chromium-review.googlesource.com/c/1301458 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603049}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4fa2f815257c..0d828e8bb275 git log 4fa2f815257c..0d828e8bb275 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 primiano@google.com Merge "trace_processor: Fix MacOS build (attempt two)" 2018-10-26 primiano@google.com Merge "Export symbols of ScatteredStreamWriter::Delegate" Created with: gclient setdep -r src/third_party/perfetto@0d828e8bb275 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib0dcb40563381f7c584d852130548d697c5a5d83 Reviewed-on: https://chromium-review.googlesource.com/c/1301533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603048}
-
Hitoshi Yoshida authored
Generally we use type names of each member as accessor names in generated union implementations. But for annotated types, the difference from its inner type is the conversion from V8 values to native values. i.e. NativeValueTraits. It means that their C++ accessors for each member work as same with their inner types' ones. And it is annoying to use annotated type's names for other objectives like IsLongClamp() and SetStringTreatNullAsEmptyString("foo"). So this CL makes the generator to use inner type names in IDLUnion member accessors. It means we do not have to consider if a member has extended attributes or not, when we access the members. Bug: 894469 Change-Id: I80a6ea2366405a7ae344d740e1611cea20b88d9e Reviewed-on: https://chromium-review.googlesource.com/c/1280382 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f6d8fb43536..0607ea1bb336 Created with: gclient setdep -r src-internal@0607ea1bb336 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia9831c1abcd61ddcaf3e05cb216c8f78181a2a70 Reviewed-on: https://chromium-review.googlesource.com/c/1301236Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603046}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: If241906ba3024ff6f4aa6ef7a5ff06dc682a130b Reviewed-on: https://chromium-review.googlesource.com/c/1293255Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#603045}
-
Mario Sanchez Prada authored
Reimplement callbacks GoogleSigninSucceeded and GoogleSignedOut as OnPrimaryAccountSet and OnPrimaryAccountCleared, from IdentityManager. Bug: 887461 Change-Id: I6a0f5758b8c07f21a8b06b4993a9f58528ee7c7e Reviewed-on: https://chromium-review.googlesource.com/c/1261637 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603044}
-
Christian Dullweber authored
The style guide says that static functions shouldn't be in the global namespace. TBR: dschuyler@chromium.org, dtrainor@chromium.org Change-Id: I48230748abf496eb312ad0901bf88cbbf9307bcc Reviewed-on: https://chromium-review.googlesource.com/c/1299233 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603043}
-
Yi Su authored
Generate a searchable URL when a <form> is submitted. When the Js file is injected, it will add listeners to all the submit element(i.e. <button> and <input type="submit"> in all <form>s. This CL doesn't add listeners on <form>s' "submit" events. Most of the code in this CL is based on code from Blink: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/exported/web_searchable_form_data.cc Bug: 433824 Change-Id: Ib56808281265e5605d48148d4504eee0e51d1743 Reviewed-on: https://chromium-review.googlesource.com/c/1293914 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#603042}
-
Greg Thompson authored
ExternalProtocolHandler::GetBlockState queries for a value in a dict pref. Previously, it was using DictionaryPrefUpdate to get the dict. This causes the pref file to be written out in its dtor. This CL switches to ordinary read-only ops to avoid spurious pref file writes. BUG=none R=benwells@chromium.org Change-Id: I9a42441cdee70e7bd9b0f67afefb67d411bef2dd Reviewed-on: https://chromium-review.googlesource.com/c/1298715Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#603041}
-
Ivan Sandrk authored
Test follow-up to crrev.com/c/1234334 [Locked Fullscreen] Fix regression in locked fullscreen mode Bug: 883104 Change-Id: I31c28083b04513c640090a55659612b8b5c4ae8c Reviewed-on: https://chromium-review.googlesource.com/c/1280248 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603040}
-
Fredrik Söderquist authored
The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the 'using' and specify the namespace instead. TBR=pwnall@chromium.org Bug: 717812 Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686 Reviewed-on: https://chromium-review.googlesource.com/c/1301434 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603039}
-
Hitoshi Yoshida authored
To work with IDL types with extended attributes (aka. annotated types), this CL defines IdlAnnotatedType class. https://heycam.github.io/webidl/#idl-annotated-types Bug: 894469 Change-Id: I2b59a391ada7657057f79685bad89f56a32a9349 Reviewed-on: https://chromium-review.googlesource.com/c/1296929 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603038}
-
Dominik Röttsches authored
Contains 2346cb3742fe0f8cfafe8c36a4bd5 and other commits that help with forming clusters for emoji sequences. Add a test to Blink layout tests ensuring that male/female sign sequences are no longer broken up if the primary font contains male/female sign characters. Bug: 708604 Change-Id: I34d22a48ec8e4a9a627b12c68efefaabdcd015c7 Reviewed-on: https://chromium-review.googlesource.com/c/1264519 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603037}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I5c64c32974787491071b8cef410626c5568ad713 Reviewed-on: https://chromium-review.googlesource.com/c/1301136Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#603036}
-
Adam Rice authored
These operations will be used for transferable streams. The operations are implemented in JavaScript and exposed to C++ on the ReadableStreamOperations object. See design doc at https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit The new operations are not used outside of tests so far. The implementation currently has the serious issue that if the page modifies the MessagePort or MessageChannel interfaces, it will use the modified versions instead of the originals. Because the operations are still unused this CL by itself it safe. It will be fixed in a followup CL. BUG=894838 Change-Id: Iff40cd9fdd5de39dfce8fbb2b845c1fbd5cbcab0 Reviewed-on: https://chromium-review.googlesource.com/c/1282516Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#603035}
-
Koji Ishii authored
Following bot results are included. 11098 11096 11095 11092 11090 11089 11086 11082 11079 11078 11075 11069 11068 11101 3 lines were removed and 11 lines were deflaked by consecutive results since 11075. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I57badc35cbed219bdb41bbea45887b3b2fa82258 Reviewed-on: https://chromium-review.googlesource.com/c/1297852 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#603034}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14d9c293..bb69b988 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d4e5eb7e498ce7bc254ea9afb674e923bdbd1ca Reviewed-on: https://chromium-review.googlesource.com/c/1301118Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603033}
-
Henrik Grunell authored
TBR=pdr@chromium.org Bug: 899087 Change-Id: Ib988d2211c232c60605e8b24946d564577c59f86 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1301513Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb9e116dc8cf..4f6d8fb43536 Created with: gclient setdep -r src-internal@4f6d8fb43536 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8651beac0fcea32de4e6b79852a7de315a619e82 Reviewed-on: https://chromium-review.googlesource.com/c/1301235Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603031}
-
Simon Que authored
Bug: 835732 Change-Id: I551fb49ec4e3790d090985a7a79dbcd1630f63fa Reviewed-on: https://chromium-review.googlesource.com/c/1297213Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#603030}
-