- 10 May, 2018 40 commits
-
-
Eugene But authored
WaitForCondition is a wrapper around deprecated base::test::ios::WaitUntilCondition, which uses DCHECK. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a85ff395e2cb8edae9b56d4db7998d9c64ae475 Reviewed-on: https://chromium-review.googlesource.com/1053184 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557451}
-
Raymes Khoury authored
This fixes 2 nullptr dereferences. The first arises because we don't sanity check the permission type received in the PermissionService. We don't expect to receive protected media requests on non-android platforms so a check is added for that. The second is because the default implementation of ResetPermission in PermissionContextBase won't work for content settings types which don't have a registered ContentSettingsType. We add a check for that case before resetting the permission. Bug: 839194, 839221 Change-Id: I0dbb9930a7cc5e459b99e8f937791846fd0db83b Reviewed-on: https://chromium-review.googlesource.com/1045962Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#557450}
-
Yoichi Osato authored
This patch changes NGTextFragmentPainter to use NGPhysicalTextFragment::LocalRect instead of computing it itself for consistency. Bug: 837521 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52395834bd0c141873aa792f9f1805ee1a1fdad1 Reviewed-on: https://chromium-review.googlesource.com/1051427Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#557449}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5623aeebe84f..7c3ff1311a45 $ git log 5623aeebe..7c3ff1311 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 tikuta Introduce GIT_TRACE_PERFORMANCE Created with: roll-dep src/third_party/depot_tools BUG=chromium:840592 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1f3b5cde09b19cb3a7137f4245f9074482fd50af Reviewed-on: https://chromium-review.googlesource.com/1053157Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557448}
-
Takumi Fujimoto authored
- Add CastDialogModel struct that contains dialog header and sink info. - Add CastDialogView class that implements the dialog UI. - Add CastDialogController interface, through which the dialog will communicate with Media Router. The interface will be implemented by MediaRouterViewsUI. The code paths to open and send data to the dialog will be added in a later CL (WIP): crrev.com/c/1010410/6..8 Screenshots (colors/dimensions TBD): https://drive.google.com/open?id=1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf https://drive.google.com/open?id=1dRGkINNrk8etvx8_SSZko13uu3MQRfER Bug: 826089 Change-Id: I7f965383d427d347bf8063ed1cb16296a0044aa2 Reviewed-on: https://chromium-review.googlesource.com/1020231 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557447}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 784464, 841513 Change-Id: Ia592f2c0145d9117e6c59d14c6b1685d104429c0 Reviewed-on: https://chromium-review.googlesource.com/1053161Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#557446}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1fcac0556947..563f26415461 $ git log 1fcac0556..563f26415 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ifb767af53ec83f0ecd8c2ec2b3f4e88661438a9b Reviewed-on: https://chromium-review.googlesource.com/1053547 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557445}
-
Cathy Li authored
Change-Id: I987af5542f66c58a89013b2ceffdf7a31d8fd33c Reviewed-on: https://chromium-review.googlesource.com/1053348Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#557444}
-
https://webrtc.googlesource.com/src.git/+log/e1f222e5c5a4..e53ac0463daa $ git log e1f222e5c..e53ac0463 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia28749f2a57e087706cd0e59d69c07e41c8566f6 Reviewed-on: https://chromium-review.googlesource.com/1053550 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557443}
-
Tetsui Ohkubo authored
This CL adds ChromeOS.SystemTray.ToggleExpanded metrics to UnifiedSystemTray. The value records if the system tray bubble is expanded or collapsed by the button, or by touch gesture. TEST=manual(chrome://histograms) BUG=none Change-Id: I55eb917297a00eecd4d07d74e5d346bc5db111fc Reviewed-on: https://chromium-review.googlesource.com/1049465Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#557442}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I633c319df06580406337b56d8c86da04dd5f01bd Reviewed-on: https://chromium-review.googlesource.com/1053567Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557441}
-
Yuri Wiitala authored
The LoopbackStream is an audio::InputStream that provides the result of looping-back and mixing-together all current and future audio output streams belonging to the same "group." An example of this would be for tab capture, where all output streams from one tab are recorded and then re-mixed into a single capture stream. Bug: 824019 Change-Id: I3374182798452bbf9d8688e318dc0546d3630f5e Reviewed-on: https://chromium-review.googlesource.com/1041661 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557440}
-
codeimpl authored
std::make_unique<Type>(...) and base::WrapUnique<new Type(...)) are equivalent but std::make_unique should be preferred, because it is harder to use unsafely than base::WrapUnique in background_sync. Ref: https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Prefer-MakeUnique-to-WrapUnique Bug: None Change-Id: Ibc1f9455206ffb469f63a7e2529a71e678b54757 Reviewed-on: https://chromium-review.googlesource.com/1034050Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#557439}
-
Ben Wells authored
This metric will allow us to know how many people are running the setup flow and what the results of the flow are. Bug: 703927 Change-Id: I1d4fef03f0c88714b4e2f648cc43540ff0e510a6 Reviewed-on: https://chromium-review.googlesource.com/1051133 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Chong Zhang authored
Perf Dashboard has some issues handling large test results (see bug). This patch tentatively changed the benchmark to only upload _diff charts (which is consider most useful) to get the graph running, and we should revert the benchmark back after the issue has been fixed. Bug: 840524 Change-Id: I4e87da8405bf102f16c76ccad28107b3c9b87be7 Reviewed-on: https://chromium-review.googlesource.com/1052674Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557437}
-
Jinsuk Kim authored
The call order of |super.onConfigurationChanged| doesn't seem to matter. This CL deletes the interface method from ContentViewCore.InternalAccessDelegate and let the embedders call it directly. Bug: 598880 Change-Id: If0ef9eeb583036846130accbbdd0e71b19ac48b6 Reviewed-on: https://chromium-review.googlesource.com/1053327Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#557436}
-
Tetsui Ohkubo authored
As described in the design doc, old SystemTray class is going to be replaced by UnifiedSystemTray class. Model variables of SystemTrayItems will be decoupled into SystemTrayModel, and tray icons will be implemented in UnifiedSystemTray by obseving the models. This CL adds power icon to UnifiedSystemTray button. In order to do this, this CL changes * PowerTrayView to observe PowerStatus directly. * Move PowerTrayView declaration to tray_power.h. * TrayItemView to support null owner(). * Embed PowerTrayView in UnifiedSystemTray. Screenshot: http://screen/Wi1PioeB47D Design doc: go/cros-qs-restyling TEST=manual BUG=836134 Change-Id: I5719cf004b258b2498743afd9c775085aae0e068 Reviewed-on: https://chromium-review.googlesource.com/1049472Reviewed-by:
-
Noel Gordon authored
Break test changeTracks into three separate tests, rather than do it all in one test. And hopefully, improve test speed and robustness by eliminating the interrupted play() -> pause() problem, which was due due to not waiting for the play button aria-label state change. changeTracks Clicks on the "next" button and tests that the "next" track plays. Move what was formerly in this test, to the new tests. changeTracksPlayList Expands the track list by clicking on the the play-list button and clicks track 0. Test that the expected audio track (0) plays. changeTracksPlayListIcon Expands the track list by clicking on the the play-list button and clicks the track 1 'Play' icon. Test that the expected audio track (1) plays. Add more comments to the togglePlayState and changeVolumeLevel tests and comments describing the new tests. Test: browser_tests --gtest_filter=AudioPlayerBrowserTest.ChangeTr* Bug: 835626 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibfb771ab7b276fbb64e2f40c5d17221a95244d15 Reviewed-on: https://chromium-review.googlesource.com/1051306Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557434}
-
Ran Ji authored
This cl made two changes: 1. If a url is opened from WebAPK through window.open(), and that url is within the current WebAPK scope. Open it in CCT instead of using WebAPK 2. If a CCT is opened by a WebAPK, and the CCT redirects to a url within the WebAPK scope, stay in the CCT instead of using WebAPK to open the url. Bug: 831806, 771418 Change-Id: Ibf522b3b49599ec8bbb76f515f3b96b07707b56d Reviewed-on: https://chromium-review.googlesource.com/1008735 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557433}
-
Aleks Totic authored
Unfortunatelly, handling scrollbars in NG is delayed to next milestone. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I50ba6eb28ed040da2cbb8857c1b3eb84c3a609a3 Reviewed-on: https://chromium-review.googlesource.com/1053298Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557432}
-
Tsuyoshi Horo authored
We are trying to show SignedExchange related information in DevTools. https://bit.ly/2HXVbCU After this CL, the certificate request of signed exchange is displayed. This CL depends on https://crrev.com/c/1029750 Bug: 830505 Change-Id: Ia431b5bb889fa5f89754f11eb2e54dbf91d0e4fe Reviewed-on: https://chromium-review.googlesource.com/1029755 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557431}
-
Joel Hockey authored
Implement fileManagerPrivate.mountCrostiniContainer to call Crostini Restart. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a6326e0faa92c48cd1014ce426b1a19f0b35d0d Reviewed-on: https://chromium-review.googlesource.com/1049988 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Scott Chen authored
When a controlled-radio-button is controlled by policy, it should not be selectable. While clicks are correctly blocked, users can still erroneously select it with keyboard navigation. This is fixed by changing the "controlled_" attribute to the standard "disabled" attribute. Bug: 841582 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I40f25379f9fc82b51d93f17587ef8c7d2c864e09 Reviewed-on: https://chromium-review.googlesource.com/1053267 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557429}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/96caad126bb2..0aae1c1fc30a $ git log 96caad126..0aae1c1fc --date=short --no-merges --format='%ad %ae %s' 2018-05-09 chrome-bot Update config settings by config-updater. 2018-05-07 bingxue Add ap-hal to usergroup_baseline Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I407203cf1018d3edafd470a8d40e6f06958c52f4 Reviewed-on: https://chromium-review.googlesource.com/1053307Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557428}
-
Dan Beam authored
- Add FindShortcutBehavior for handling Ctrl/Cmd+f keyboard shortcut - Use new behavior in <settings-ui> and <settings-add-languages-dialog> The functional results of this change: - Ctrl/Cmd+f focuses settings-specific search box (+ prevents default) - Ctrl/Cmf+f does nothing when a <dialog> (i.e. side bar) is showing Note: when navigating to a subpage, focus seems to be lost (both with keyboard and with mouse), so Ctrl/Cmd+f doesn't trigger settings-specific search in these cases. Bug: 819770 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8e8263827b107aaf256900750ea14409b736f597 Reviewed-on: https://chromium-review.googlesource.com/956901 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
-
Eric Karl authored
The DCHECK here was from an earlier version of the CL and doesn't apply to the final logic. Note that |frame_presentation_callback|, called right after the DCHECK, assumes that frame.timer exists. TBR=penghuang@chromium.org,piman@chromium.org Bug: 840638 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib8403cb69b2c23dbd851f58c7b207e269dd5b7fe Reviewed-on: https://chromium-review.googlesource.com/1053092 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557426}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b61d387fa2d4..5623aeebe84f $ git log b61d387fa..5623aeebe --date=short --no-merges --format='%ad %ae %s' 2018-05-10 tikuta Introduce GIT_TRACE for chromium/src in bot_update step 2018-05-09 ehmaldonado Reland "bot_update: Fetch references to be synced." Created with: roll-dep src/third_party/depot_tools BUG=chromium:840592,chromium:840445 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2a95cb0bcdd74c11d84eebcef752726ed13ddc4c Reviewed-on: https://chromium-review.googlesource.com/1053411 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Noel Gordon authored
Bug: 833834 Change-Id: Ifdcb79fc61a08ded239b56793ec106b744e0693c Reviewed-on: https://chromium-review.googlesource.com/1053329Reviewed-by:
-
Matt Falkenhagen authored
Before this CL, provider hosts for documents that were still undergoing navigation (i.e., hosts for "reserved clients"), were not owned by SWContextCore. Instead they were owned by ServiceWorkerNavigationHandle* and added to SWContextCore after navigation commit and the renderer ACKs back an OnProviderCreated IPC. This CL makes SWContextCore own such provider hosts. This means that users of SWContextCore will start needing to be aware of reserved vs ready clients. There are some motivations: - Sometimes we need to do operations on reserved clients. For example, the linked bug happens because a new registration can't find reserved clients. - SWContextCore already implicitly knows about reserved clients, since GetProviderByClientUUID can return them. This is a bit of a confusing inconsistency. - The spec has evolved to make "reserved clients" a concept, so it's generally useful to have them clearly defined to more clearly match the spec algorithms. This CL isn't expected to have a behavior change but clears the way to fixing the linked bug. Bug: 841070 Change-Id: I31ba40029e1b7247f41d69abcf4fa6ef97300a0d Reviewed-on: https://chromium-review.googlesource.com/1051145Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557423}
-
Hirokazu Honda authored
In VDA unittest, the video frame size is given as input, and the unittest checks that the visible size does not change. To enable resolution changing videos, set the frame size dynamically when a resolution change happens (i.e. ProvidePictureBuffers()). BUG=chromium:834170 TEST= on kevin $ ./video_decode_accelerator_unittest --test_video_data=switch_720p_1080p_240frames.h264:1920:1080:240:240:24:24:1 --ozone-platform=gbm $ ./video_decode_accelerator_unittest --test_video_data=resolution_change_500frames-vp8.ivf:640:360:500:500:30:30:11 --ozone-platform=gbm $ ./video_decode_accelerator_unittest --test_video_data=resolution_change_500frames-vp9.ivf:640:360:500:500:30:30:12 --ozone-platform=gbm Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I803afb16bc3a706ea9f806ac1f1372c24f80c341 Reviewed-on: https://chromium-review.googlesource.com/1027690 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#557422}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef4f7b4dc1e4..1fcac0556947 $ git log ef4f7b4dc..1fcac0556 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 bsalomon Fix extra texture creation in GrResourceProvider::createTexture() with SRGB data. 2018-05-09 bungeman Remove SkPaint::Flags::kDevKernFlag. 2018-05-09 skcms-skia-autoroll Roll skia/third_party/skcms 78ee9e8..5b9549a (1 commits) 2018-05-09 bsalomon Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float" 2018-05-09 csmartdalton Support C++11 range-for loops in SkTInternalLList 2018-05-09 bsalomon Don't use GrRRectBlurEffect for large rects when highp is not full float 2018-05-09 skcms-skia-autoroll Roll skia/third_party/skcms f771d23..78ee9e8 (1 commits) 2018-05-09 mtklein SkColorSpace::Make(const skcms_ICCProfile&) 2018-05-09 fmalita [skottie] Simplify AttachOpacity 2018-05-09 mtklein strip down SkICC.cpp 2018-05-09 angle-skia-autoroll Roll third_party/externals/angle2/ e95a7f077..7348fc5b9 (3 commits) Created with: roll-dep src/third_party/skia BUG=chromium:b/78866720 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ifdd6995afff69edb4c71b17ed9d4adf6a90e452d Reviewed-on: https://chromium-review.googlesource.com/1053389 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/7e28208d2676..ad18d2fba9dd $ git log 7e28208d2..ad18d2fba --date=short --no-merges --format='%ad %ae %s' 2018-05-09 npm Use enum class instead of int in CJBig2_Context 2018-05-09 thestig Add proper const/non-const versions of CPDF_Array methods. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3e4eea1c0a38d7b3b25f092c09eadf4c0281bfb8 Reviewed-on: https://chromium-review.googlesource.com/1053403 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557420}
-
Tsuyoshi Horo authored
We are trying to show SignedExchange related information in DevTools. https://bit.ly/2HXVbCU After this CL, the Type column in network tab will be "signed-exchange" for signed exchange responses. This CL depends on https://crrev.com/c/1027554 Bug: 830505 Change-Id: I2d7bb005dc24377e105e64e7b7ac439eaea2e88b Reviewed-on: https://chromium-review.googlesource.com/1029750 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
On active user switching, a dialog is shown to confirm the user wants to stop screen sharing sessions. It was implemented in SystemTray, but the logic is not directly related to SystemTray. Also, it doesn't work with UnifiedSystemTray (--enable-features=SystemTrayUnified) which will replace old SystemTray class. This CL splits the dialog management to ScreenSwitchCheckController which will be owned by ash::Shell. Previously it was in chrome/browser/. https://crrev.com/c/665938 TEST=CanSwitchUserTest BUG=837507 Change-Id: I50d27f079e627a212209e1a10a6c23590623624b Reviewed-on: https://chromium-review.googlesource.com/1032453Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#557418}
-
Daniel Park authored
Tracks presses for clear tab experiment Only tracks the event (no IPH shown) Bug: 836445 Change-Id: I2db14cd4a1ca93f8d500912effc2aea13c584184 Reviewed-on: https://chromium-review.googlesource.com/1028718Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#557417}
-
Dirk Pranke authored
The Gerrit plugin will now automatically populate the list of tryservers from LUCI, meaning that we no longer need to manually configure things and don't need to generate a config file from the MB entries. Accordingly, this CL removes the `gerrit-buildbucket-config` code from MB. Bug: 813196 Change-Id: I1c4ba1099a11822c2c741eb21dc61e4f5a163369 Reviewed-on: https://chromium-review.googlesource.com/1053377Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557416}
-
spqchan authored
10.9 is no longer supported. Bug: 840451 Change-Id: I4b4c6901148244b449adfe26f759d2740cc17667 Reviewed-on: https://chromium-review.googlesource.com/1048131Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557415}
-
Peter Boström authored
* Increases horizontal margins for bookmarks bar but removes additional margin for the detached bar. * Uses 8dp margins for toolbar view for all non-touch layouts to align with the bookmarks bar. * Uses corner-radius metric directly for ink-drops, matching toolbar buttons. * Insets bookmark buttons by 2dp for older layouts as they use 24dp ink-drops. Bug: chromium:822072, chromium:836251 Change-Id: If7ba788678732be29921e4ef5d90e8e80815efd7 Reviewed-on: https://chromium-review.googlesource.com/1043255 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Egor Pasko authored
Remove the test PlatformAppNavigationRedirectorBrowserTest .PrerenderedClickInTabIntercepted. The test relies on PrerenderManager::PRERENDER_MODE_ENABLED, which is currently overridden by Finch in all cases, and will soon be removed. The mode PRERENDER_MODE_NOSTATE_PREFETCH is the only one remaining that creates an extra renderer. But it does not have the functionality to replace navigation (only feeds the HTTP cache and kills itself - http://goo.gl/EJjTCM). Since no prerender can be swapped-in instead of an app launch, testing this case seems unnecessary. The test also relies on 'webkitprerenderstop' to notify about renderer going away. At the time of this happening there is nothing to swap in, so the test was probably trying to click on a link too late to test anything meaningful. Bug: 839030 Change-Id: I7e7045081b8c8fe65ace1957b5454f5f0a76270c Reviewed-on: https://chromium-review.googlesource.com/1042387Reviewed-by: -
James Wallace-Lee authored
There are two definitions of ClassRegisterImpl, one downstream. This CL supresses the presubmit warning that there are multiple defintions of the class. Bug: 841499 Change-Id: Ifba28a0bb605901d5c7524d5c8ffc71c667d894b Reviewed-on: https://chromium-review.googlesource.com/1053360Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557412}
-
