- 26 May, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5479f2a80cf..19ffa683a1c0 2020-05-26 bryct@amazon.com Add make-continuous-headless target (headless option) to Makefile. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I3452e577521df2677295741eab1393ea6e1231c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771785}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ea04b09d5a4..4b342721d088 2020-05-26 tvanderlippe@chromium.org Use acorn-loose from front_end/third_party 2020-05-26 tvanderlippe@chromium.org Update http-proxy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia22346907ba9eaa1d38c38358abfcc704ef59dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771784}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590479866-bd3b364dec503175394de5d27879ac865b50ea38.profdata to chrome-win32-master-1590494094-4933e9898781e7babab5bec8654610960e408cf7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2827716810487cf98bf8d1354e65055d6eff85bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771783}
-
Mohamed Amir Yosef authored
This CL is making use of the recent modification to the combobox that now supports: 1- Showing icons in the dropdown menu. 2- Showing different text in the combobox from the dropdown menu. 3- Showing a secondary text (2nd line) in the dropdown menu. Mocks: https://screenshot.googleplex.com/12SDSKY7RUm Screenshot: Open: https://screenshot.googleplex.com/JQ886fwsNDs Account selected: https://screenshot.googleplex.com/rdi2vPbiPV7 Device selected: https://screenshot.googleplex.com/qvxGgLXfiz9 Bug: 1044038 Change-Id: I0a3dcc5df6f68771d338190a40f6d9a162c825a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207223 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771782}
-
Finnur Thorarinsson authored
Ensure calls to MediaPlayer#seekTo are guarded by appropriate SDK level checks, to avoid lint errors. This slipped in while the linter was down due to an error somewhere. TBR: wnwen@chromium.org Bug: 1081243, 895776, 656015 Change-Id: I38143673afa986b310573595435dd2237d8a620b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214947 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771781}
-
Jochen Eisinger authored
Bug: 873178, 927509 Change-Id: I3bdacf95a6c653a9eeabadafe0a7b11a525a6aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215810Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771780}
-
Andrei Salavei authored
Cancel component policy data update job when it was delayed (due to fetch error) and new fetch request with the same parameters come. Bug: 731109 Change-Id: Icc2f27cdcf475afec1369b787bfd56a9936c4356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214527 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771779}
-
Nicolás Peña Moreno authored
It looks like actions.send() does not wait for the events to get processed in order to resolve the promise, which means eventCounts may not be populated by the time we begin testing it. Hence, in this CL we perform a polling-based approach. Sample failure: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=8e7df6aa16ccbffabef2b11c5f2d9aaa02d396c1&as=layout-test-results%5Cexternal%5Cwpt%5Cevent-timing%5Cmouseover-actual.txt Bug: 1074048 Change-Id: I58629d66ad146fd435fc95fb875f21a96f5470a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212497Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#771778}
-
Alice Wang authored
This CL adds BookmarkTestRule and refactors bookmark signin promo tests with it. Prior to the CL, the bookmark manager is only opened but destroyed outside the test environment. The BookmarkTestRule helps to destroy the bookmark manager before the mock signin environment's teardown. Bug: 1080553 Change-Id: I940886577b9b330023c72b6ec2dbae81b1d726a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193112 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771777}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590479866-02719b24a518e7640038fc4f4eebb5b489becebf.profdata to chrome-mac-master-1590494094-23904e540b881376a708d1584e8efd523290bbdf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I92d36f9b33f5450d9680b70b169458958754d640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771776}
-
nancylingwang@google.com authored
BUG=1068884 Change-Id: I7fd646bc3a714c6d06554d886c7a802771497559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203041 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771775}
-
Rune Lillesveen authored
Bug: 1085772 Change-Id: I00c14ac5b874d3cd3d4df41c6bd8be43c320b970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215843Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771774}
-
Nicolás Peña Moreno authored
The WPT.FYI results [1] show that several tests which pass on our bots are actually timing out there. I dug into this and it seems to be due to improper usage of swap promises. In the testcase I looked, a mouseover event occurs, triggering the swap promise. Then a long mousedown occurs. While it is being processed, the GPU completes the frame and resolves the swap promise. However, the main thread is busy at the moment while its handling the mousedown, so it does not yet know about this. In the current logic, there is still a pending swap promise, hence no new swap promise is queued when mousedown handlers have finished executing. This means that both the mouseover and mousedown events use the same swap promise, one which had a paint timestamp which is way before the mousedown handlers have even finished. This means that the |duration| for the mousedown entry is also much less, and hence no entry is dispatched for this event and the tests timeout. The fix is to queue a swap promise when none are queued, or when a new paint lifecycle occurs. This way we queue at most one promise per frame when we're actively painting content, and have at most one queued promise when the renderer is not painting. This fixes the tests, at least per my manual running of /.wpt run, which reproduces the timeouts seen in wpt.fyi. [1 ]https://wpt.fyi/results/event-timing?label=experimental&label=master&aligned Bug: 543598 Change-Id: I298abb1e13adb0b17f1b2d493cb18b43c407c863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174880Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#771773}
-
Robbie Gibson authored
When cookies are blocked, access to other storage methods should also be blocked Bug: 1075534 Change-Id: Id6487617b55735cace97fe0e3e9401f6f1007eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202802 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#771772}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2bc8f192..2e7c4b66 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ec8e142448df791ab25a199d72a65d859fda201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215697Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771771}
-
Maksim Sisov authored
That source file is platform agnostic and used by X11 and Ozone/X11/Wayland. Remove unneseccary includes. Test: compile test ozone/wayland only Change-Id: I9d314988f1dff2ae16043619c947a068229de9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216073 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#771770}
-
Wolfgang Beyer authored
Update test expectations to allow DevTools CL [1] to land. [2] updates the tests and restores the expectations. [1] https://crrev.com/c/2213439 [2] https://crrev.com/c/2213534 Bug: chromium:1011811 Change-Id: I392f6046f2381444825b3bd3152799bdc02f5e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214952Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771769}
-
Eric Seckler authored
And add a bunch of missing includes elsewhere that were breaking the build afterwards. Change-Id: Ice45b155083b9b37281c7d28e6787a97dd4c5ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210981Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#771768}
-
Roman Sorokin authored
* Removed enterprise enrollment element from the login elements * Removed Gaia password changed, Supervision transition, Active Directory password change screens from the oobe screens. * Removed oobe-screen.{html,js} files as obsolete Change-Id: I59c1bbc88b0233aba5c3f64e9d25cce053c538b8 Bug: 1084940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167271Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771767}
-
Illia Klimov authored
That patch shows "Automatically blocked" subtitle for embargoed origins in Category Setting page. Bug: 1033593 Change-Id: I1adafc28ab010f0d584216d803e0cc3aab0f2958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206801 Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771766}
-
Jan Krcal authored
This CL cleans-up a kill switch for code successfully launched in M81. Bug: 1022293 Change-Id: If05412a2e700fdc8132f36c00b6b0a92d42281c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215803 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#771765}
-
Illia Klimov authored
After refactoring ContentSettingsUsagesState was moved from components/content_settings/core/browser/ into components/content_settings/browser To finish migration add ContentSettingsUsagesState under `content_settings` namespace. This patch adds TODO comment. Bug: 1086363 Change-Id: I1c746b3de8678f3ca88992552a76d16fb28e4bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213533 Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771764}
-
Pawel Baran authored
Change-Id: I4f8789fa41616716c4b8a98244e766daedce1bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207154Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Paweł Barań <pbaran@opera.com> Cr-Commit-Position: refs/heads/master@{#771763}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 206c7752. With Chromium commits locally applied on WPT: 9c36a269 "Reduce cross frame messages in feature-policy-nested-subframe-policy.https.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I7977fdbcbdff5cfa868f0b3cbd634c034c61e6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215904Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771762}
-
Benoit Lize authored
Bug: 1078350 Change-Id: I8866933980ec089e7c4835eff850ca1838e9ec2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215822Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771761}
-
Alex Ilin authored
This reverts commit bad70cb2. Reason for revert: SyntheticInputTest.SlowSmoothScrollWheel is still flaky on Android. https://crbug.com/1086450 Original change's description: > [synthesized scroll] Fix wheel-event precision on android. > > Update API to set fractional wheel deltas on android, and remove the > code that explicitly used to remove precision. > > BUG=1085890 > > Change-Id: Ifd18df07637b2fa28288de62bf538f65f7a4d0a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213406 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771639} TBR=sadrul@chromium.org,yfriedman@chromium.org,bokan@chromium.org,nzolghadr@chromium.org Change-Id: Ib671a1db643144448de054fc93b43a2ad87e4805 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085890, 1086450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215824Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771760}
-
nancylingwang@google.com authored
Modify AppNotifications to handle the multiple apps for one notification case, because for one web app notification, there could be multiple web apps affected. BUG=1068884 Change-Id: I2257bee69b92411ee0b690bc2f8ea966ce488f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181246 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771759}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7ff01bb15d40..0638b6b9527b 2020-05-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 2cf9621d6d6f to 2b0eafb1de5b (1 revision) 2020-05-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b0264b87ffb5 to 9cb2571a184c (2 revisions) 2020-05-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cc5cda0f997d to 79dcb2a5abbd (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I2d5dedeb5e70697a8268056ba63969e869fb7490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771758}
-
Mohamed Amir Yosef authored
... to animate password save/update bubble. The reason for that is GetWidget()->GetLayer() only works for animating entire windows if the underlying widget is a `NativeWidgetAura`. DesktopNativeWidgetAura and NativeWidgetMac have an OS-provided "frame" that we can not animate in the same way. Implementing the animation on MacOS and Windows is more complex After CL the animation works on MacOS and Windows in the same way as on Linux. Here is a screencast on MacOS https://drive.google.com/file/d/133bqSrjVA9PIuSDjQNKmfsCHBMXOAo5w/view?usp=sharing Follow up CLs will fix the flickering of the dropdown menu. Bug: 1044038 Change-Id: Id7a24bfb3049e3577c4ea7e2089b6679c41269d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195967 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771757}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/621c33653f8e..de2049e85aec 2020-05-26 eshr@google.com Unflake VideoStreamEncoderTest.StatsTracksCpuAdaptationStatsWhenSwitchingSource_Balanced If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I05d1d9bb16f64735a5a28a376325089d1c6c25e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771756}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b12011da35a3..8ea04b09d5a4 2020-05-26 tvanderlippe@chromium.org Also copy over integration_test_runner.html in BUILD.gn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9052d641cab1561840ec9b6d3cd3c87c4dfb2e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771755}
-
Tanmoy Mollik authored
This cl creates personalized sync promos for the bookmark page when the user is signed in but not syncing. This cl also creates a new vector image and changes the base personalized_signin_promo_view_body.xml file that will be used to make promos in other places, e.g., Recent Tabs, Settings etc. The hooks to show the promo is only added in ReorderBookmarkItemsAdapter as BookmarkItemsAdapter class is scheduled to be deprecated. Screenshot: https://crbug.com/1057603#c8 Bug: 1057603 Change-Id: I148395e8ee1e910b117f64b1b7031254c6146043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173057 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771754}
-
Swapnil authored
The browsertests of Cors policy and signed exchange policy are moved from policy_browsertests to a separate file. Bug: 1086191, 1086192 Change-Id: I0816f7dc1f742bb8cc81664aa2cf23dbc8065a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213579 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771753}
-
Ramin Halavati authored
Profile::ProfileType was redundant (could be driven from other variables), did not cover all types (just has regular/incognito/guest), and was only used in profile class. So it's removed! This CL does not modify the behavior. Bug: 1033903 Change-Id: I4853ef3380fe4e3f61e6e7aca46932473fa8da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213577Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771752}
-
Antonio Gomes authored
... removing RFHI::frame_token(). This is a follow up of https://crrev.com/c/2213115. BUG=1047272 R=avi@chromium.org, dtapuska@chromium.org Change-Id: I678c82479d4ba3f5ce9de379817624f8b099a40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215182 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771751}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/17c11a2291ec..50020926f80d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC marinaciocea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: marinaciocea@google.com Change-Id: I25189edf170a2b62a83804a4b24dd40291dfc92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215737Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771750}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a39e42ab873..621c33653f8e 2020-05-26 mbonadei@webrtc.org Remove //modules/video_coding:nack_module from API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If6ce44cff69728876eddb14caec0a18491c1b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771749}
-
Rune Lillesveen authored
We don't fetch resources for ComputedStyle which is in a display:none subtree or display:contents since [1]. Style adjustments are done to the display type in the StyleAdjuster and we need to make sure we load resources where display changes from a non-rendered value to a rendered one after style adjustments. Specifically, this happens with blockification of :root elements which are display:contents. [1] https://crrev.com/caf740f6c0b57ca102026f40f3cc62f9f3cf5159 Bug: 1085750 Change-Id: I7686c6f8bf4918bec5812d1bf893ad2c4cb9262c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214897Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771748}
-
Benoit Lize authored
Record the sum of CPU overhead of discarding in the first 5 minutes of a renderer lifetime, and the total disk footprint, with and without overhead. Bug: 1029320 Change-Id: I5aa9d1df4fd2aefa4dcd180c378fe462e7297a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209136 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771747}
-
Jit Yao Yap authored
A TestExtensionRegistryObserver is used to wait for the in-session extension to be ready before calling the Javascript test function. Bug: 1075511 Change-Id: I77837f14782f63c69628e3364edaf0a41c99843a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212277Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#771746}
-