- 07 Mar, 2018 40 commits
-
-
Hidehiko Abe authored
BUG=739622 TEST=Ran chromeos_unittests. Change-Id: Id389c09d95edae181f7862174ab58de765b0ee22 Reviewed-on: https://chromium-review.googlesource.com/937741 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541295}
-
Ilya Sherman authored
R=bengr@chromium.org Bug: None Change-Id: I2898d4b57ecf69f93411f8afe14310f9373aa322 Reviewed-on: https://chromium-review.googlesource.com/940438 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541294}
-
Mina Almasry authored
enable_video_with_mixed_audio gn flag has been added to turn on the new CMA backend. Created libcast_media_1.0_video, a target that implements this new CMA backend. AudioDecoderForMixer now owns an instance of a new interface, AvSync. AudioDecoderForMixer will notify AvSync of its current status, and AvSync will call into a new interface, VideoDecoderForMixer. VideoDecoderForMixer will give AvSync enough control over the video clock. BUG=internal 73746352 Change-Id: Id7f991ec9606b6f04dbb68f819ad5bf1c3da9cce Reviewed-on: https://chromium-review.googlesource.com/947258Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#541293}
-
John Abd-El-Malek authored
Bug: 729849, 783982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I245aeff1ca10a77da6debb62fbae4b2dbd0fcd4e Reviewed-on: https://chromium-review.googlesource.com/952480Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#541292}
-
Nate Chapin authored
* Call it directly from DecidePolicyForNavigation() whenever needed, rather than sometimes deferring to FrameLoader. * Remove unused suggested_filename param * Update unit tests to ensure DecidePolicyForNavigation() always returns the same subset of WebNavigationPolicy values whether in unit tests or a real environment. DCHECK this in FrameLoader Change-Id: Ifd9a96c094eacdf090676a522ee858bf0b9ce7b3 Reviewed-on: https://chromium-review.googlesource.com/944917 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541291}
-
Devlin Cronin authored
We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates manifest files under chrome/test/data/extensions/script_and_capture (which are not usually named manifest.json). All files updated cleanly. Bug: 816679 Change-Id: I96cce6762c72eda98148d5aa49a57b2703fe9b63 Reviewed-on: https://chromium-review.googlesource.com/952363Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541290}
-
Corentin Wallez authored
BUG=chromium:811827 BUG=chromium:811806 BUG=chromium:811790 BUG=chromium:811825 BUG=chromium:811872 BUG=chromium:811829 BUG=chromium:811819 BUG=chromium:811810 BUG=chromium:811808 BUG=chromium:811832 BUG=chromium:811797 Change-Id: I4e2d16c4f0cb4009164cf9c365181cb1be550bac Reviewed-on: https://chromium-review.googlesource.com/951919Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541289}
-
Stefan Zager authored
In the non-RLS code path, when the FrameView's scroll offset changes, pending_scroll_delta_ is modified, and some of the work is delayed until the next lifecycle update. Calling FrameRectsChanged() on every overflow scroll has a significant performance impact, so this patch replicates the non-RLS behavior of FrameView by postponing the call to FrameRectsChanged. BUG=770343 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I10cf0782852dcf1c8021a7a62ce0078aae297e39 Reviewed-on: https://chromium-review.googlesource.com/951641 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#541288}
-
Changwan Ryu authored
When a webview-embedding app creates another webview inside WebChromeClient#onCreateWindow(), the navigator does not have a current entry nor pending entry yet, but decides not to override user agent nevertheless, in creating navigation request. Therefore, the intent to override the user agent is ignored in creating navigation request. This can be fixed by looking up the delegate as a fall-back. BUG=614951 Change-Id: I00fe0a26e67116517f59452e89297018a09ffa8e Reviewed-on: https://chromium-review.googlesource.com/846713 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541287}
-
Adrienne Walker authored
Bug: 804301 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3b063e13c7b08b28d3973d1b16a2633101135fa6 Reviewed-on: https://chromium-review.googlesource.com/947046Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#541286}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/462839ea9942..daa76d2f225c $ git log 462839ea9..daa76d2f2 --date=short --no-merges --format='%ad %ae %s' 2018-03-06 ehmaldonado gclient revinfo: Add options to filter by path or url. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie89772727c714a5b77eaff148d50e1b35cbef268 Reviewed-on: https://chromium-review.googlesource.com/952101 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541285}
-
Dale Curtis authored
This introduces GpuMemoryBufferDecoderWrapper which is used to wrap software VideoDecoder implementations. The wrapper copies frames as they are returned from the decoder, but before they are delivered to the renderer. This is an improvement over the current copy done by VideoRendererImpl because the VideoFrameStream (which sits between the renderer and the decoder) may hold undelivered frames until a subsequent Read(). At which point the frame still needs to be copied. Total reduction in read times is ~12.6% (VP9) to ~30.1% (H264) after 4000 frames when tested using local caches of: https://www.youtube.com/watch?v=1La4QzGeaaQ (4K60 VP9) https://www.youtube.com/watch?v=dEaSepKi9SQ (4K60 H264) The real benefit of this approach will come later when we allow parallel decodes for offloaded decoders; since these decoders may accumulate more frames in the decoder stream without this approach. This also allows us to remove a bit of code and specialized tests from the VideoRendererImpl in favor of more compartmentalized tests just for the wrapper. The downside to this approach is each decoder has it's own pool, but this only amounts to ~240 bytes of memory when no frames have been created. Perf bots may detect a memory increase from this change, but only as an artifact of improved throughput and timing changes. BUG=801245 TEST=new unittests, manual tests. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iac5655c9da3e850818f9de83cb2993358fcbd716 Reviewed-on: https://chromium-review.googlesource.com/947383 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#541284}
-
Xi Cheng authored
This CL enables crash reporting for notification_helper.exe by reusing the crashpad handler embedded in chrome.exe. A new crash reporter client is implemented for the notification_helper process as in class NotificationHelperCrashReporterClient. Bug: 734095, 817974 Change-Id: I279e1d7c8e1741fd09af9db9d4915d69b92e56c9 Reviewed-on: https://chromium-review.googlesource.com/924981Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#541283}
-
Donn Denman authored
Poll the UI thread instead of the Intrumentation thread in some cases -- likely there are others that should be changed too. Remove my initials from test names (done for local debugging and accidently submitted). BUG=818374 Change-Id: I5bb80c520b155be94a9c1ecfc0c9c1f3a0e4184e Reviewed-on: https://chromium-review.googlesource.com/950319Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#541282}
-
Hongchan Choi authored
1. Tests moved: From - src/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/ to - src/third_party/WebKit/LayoutTests/external/wpt/webaudio/ 2. All tests were renamed because of the SecureContext requirement. 3. Updated the script paths. 4. Used a variable for the processor script path. Bug: 817869 Test: All existing tests are passing after updating paths. Change-Id: I7bd6c91c365730e453205f2241cb45986e2c7d3b Reviewed-on: https://chromium-review.googlesource.com/944847Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#541281}
-
Robert Ma authored
An upstream change in wpt lint interprets relative paths as relative to CWD instead of the (WPT) repo root, which breaks PRESUBMIT.py. Use absolute paths instead to avoid any ambiguity. Bug: 819349 Change-Id: Idf57e048c30d3143e55ffebfc95df0f774ae4e8f Reviewed-on: https://chromium-review.googlesource.com/951755Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#541280}
-
Yuke Liao authored
This CL fixes two bugs on iOS platform: 1. When running tests using iossim, the application bundle parameter always comes last. 2. When user specifies path to the an .app bundle, if it ends with a '/', os.path.basename returns empty instead of the the basename that we want. Change-Id: I12130dd8e35415c9a9e56e7e47be712b2334ad5f Reviewed-on: https://chromium-review.googlesource.com/951858 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541279}
-
Scott Violet authored
UIControlsFactoryOzone is used to inject events. To make this work better with the Window Service this patch converts it to use RemoteEventDispatcher, which routes the event to the Window Service. BUG=none TEST=none Change-Id: Ib7379b3fb6ee4a81cb01145cf24565ad951c8dbe Reviewed-on: https://chromium-review.googlesource.com/951632 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541278}
-
Sarah Hu authored
Domain info is displayed for public account user in the login screen. This CL adds domain info UI in the LoginUserView. This is split from the following CL which will use this piece of UI: https://chromium-review.googlesource.com/c/chromium/src/+/940623/ Bug: 809635 Change-Id: I7efdd946817d9111597f404eaaa3b3a83140a309 Reviewed-on: https://chromium-review.googlesource.com/945133 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541277}
-
Benjamin Pastene authored
TBR=jbudorick@chromium.org Bug: 817779 Change-Id: Idd7988a2a62635ed2155eaaab5c8e375b455f7f6 Reviewed-on: https://chromium-review.googlesource.com/952294Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#541276}
-
danakj authored
Make SharedBitmap return an UnguessableToken as the shared bitmap-based tracing id, if the SharedBitmap is in fact backed by shared memory for cross-process use. This means ClientSharedBitmapManager always does and ServerSharedBitmapManager returns null if the bitmap was allocated inside the ServerSharedBitmapManager. In ServerSharedBitmapManager memory dumps, if a bitmap is shared memory backed, it dumps the |mapped_id()| which is the UnguessableToken. Otherwise, it dumps the SharedBitmapGUID from the SharedBitmapId. In ResourceProvider, if the SharedBitmap has an UnguessableToken for its shared memory backing, it dumps that, else uses the SharedBitmapID to make a GUID. In ResourcePool, the same thing is done as ResourceProvider. Thus, all child-process bitmaps will be dumped via the shared memory mapped_id() which is an UnguessableToken. And all service-process bitmaps are dumped via the SharedBitmapGUID. R=ericrk@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id4b1c20350a139d36df13743d012756181937c6e Reviewed-on: https://chromium-review.googlesource.com/935428 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Jiaquan He authored
Bug: 733662 Change-Id: Ic0ff68cb6d022e5f82dc7494d8f783a5289736e6 Reviewed-on: https://chromium-review.googlesource.com/952288Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/a32145f1f16b..f8af565a78ee $ git log a32145f1f..f8af565a7 --date=short --no-merges --format='%ad %ae %s' 2018-03-06 dsinclair Rename IFX classes in core/fxge to Iface Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I92e6a4c00a3e415d53d847e1bb681d6d5fe0c8ae Reviewed-on: https://chromium-review.googlesource.com/952073 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541273}
-
Kent Tamura authored
Now all classes for all CSS properties are generated. There are no blockers of renaming. Bug: 578345 Change-Id: I808acbb19c63e8af36be2c9aa7f0ccc0c9c03c32 Reviewed-on: https://chromium-review.googlesource.com/950626Reviewed-by:
-
Derek Cheng authored
Add CastMediaRouteProvider, that interfaces with MediaRouter. It will use CastAppDiscoveryService to handle sink queries. (Per profile). The CastMediaRouteProvider runs on the IO thread, and thread hopping between MediaRouterDesktop and CastMRP is done by Mojo. Add CastAppDiscoveryService (singleton), which runs on the IO thread. It observes sinks from CastMediaSinkService and requests app availability via CastMessageHandler. Bug: 698940 Change-Id: I48c4d1287dcea1ab30e524d71ba7fd947725646a Reviewed-on: https://chromium-review.googlesource.com/899954 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541271}
-
Jian Li authored
When an intent with file:// or content:// URL is opened, a custom offline header will be set to use the file:// or content:// from this intent once the validation passes. OfflinePageRequestJob will try to read from the passing file:// or content:// instead. Bug: 758690 Change-Id: I69c75a73c02377f62ab0c6f97013be78b149ba7e Reviewed-on: https://chromium-review.googlesource.com/942466Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#541270}
-
Sarah Hu authored
Add the following mojo api for chrome to send public session information to LockContentsView in ash. 1. SetPublicSessionDisplayName 2. SetPublicSessionLocales These api will be used in a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/940623 Bug: 809635 Change-Id: I7b83d7188155c4c8547e8fef91aa53121dc760b3 Reviewed-on: https://chromium-review.googlesource.com/941516Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
James Robinson authored
The Fuchsia build reshuffled to unify architecture naming between internal components, so this updates local-sdk.py to reflect those changes. Change-Id: I7534d0a339b99cc0baeeeb5734e3edb63fe97d96 Reviewed-on: https://chromium-review.googlesource.com/951637Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541268}
-
Michael Lippautz authored
Similar to Oilpan, only return a struct of callbacks and don't actually call further into visitors. This reverts commit 559a8e6a. Change-Id: I430c72fd4bee22e7a9f49404f7d461076c613350 Bug: chromium:802273, chromium:819134 Reviewed-on: https://chromium-review.googlesource.com/950904 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541267}
-
Devlin Cronin authored
We record profiles we show the dev mode bubble for in order to avoid showing it multiple times for the same profile. However, we need to ensure we track the original profile, so that we don't show it for an original profile and an incognito profile. Fix this, and add a unittest. Bug: 819309 Change-Id: Ibe33ea6f5587e85463a5a77023387e07b8fdf3ff Reviewed-on: https://chromium-review.googlesource.com/951971 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541266}
-
Reilly Grant authored
This patch removes the Windows-specific support in libusb that provided a translation between the WinUSB API and the HID API. Applications currently depending on this using the chrome.usb API should switch to using the chrome.hid API. Bug: 818592 Change-Id: I82ee6ccdcbccc21d2910dc62845c7785e78b64f6 Reviewed-on: https://chromium-review.googlesource.com/951635Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541265}
-
Michael Spang authored
Chrome makes synchronous queries of screen geometry during startup. To satisfy these requests, assume the the first call to configure the primary display will succeed, and set this geometry in CastScreen synchronously in the startup case. DRM platform goes to great lengths to make this strategy work, by querying display information synchronously in the browser process prior to GPU process startup. It will also work for FakeDisplayDelegate. Cast platform is not affected by this change. BUG=b/74138444 TEST=chromecast browser tests Change-Id: I68f88b78c151f938f99ed393fe630ecfa5b86dbc Reviewed-on: https://chromium-review.googlesource.com/952099 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#541264}
-
Joy Ming authored
Bytes wasted measures the number of bytes used beyond the file size, often as a result of resumptions. Before the in-progress cache, there was no way of maintaining the number of bytes wasted across resumptions on the native side even though Java uses SharedPreferences to do so in DownloadManagerService.updateBytesReceived. This CL implements the bytes wasted count on native utilizing the in-progress cache and reporting these metrics through UKM. Bug: 785557 Change-Id: I79614f1f4fab73d0e526c096e3f68541f7cb1170 Reviewed-on: https://chromium-review.googlesource.com/909288 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#541263}
-
Thomas Guilbert authored
Some manufacturers have a native MediaRouter implementations that causes a StrictModeDiskReadViolation when trying to acquire a MediaRouter instance. This CL temporarily changes the StrictMode policy to allow disk reads when we acquire the native MediaRouter. Bug: 818325 Change-Id: I2b1452c03ef6767d17c243ce5e9c4964cb95c75d Reviewed-on: https://chromium-review.googlesource.com/947542Reviewed-by:
-
Kent Tamura authored
Header files in platform/image-decoders/ and platform/image-encoders/ produced guard symbols like ..._PLATFORM_IMAGE-DECODERS_... Bug: 578345 Change-Id: I266f58dccf511b14dcbff79dc184e49c7311da2d Reviewed-on: https://chromium-review.googlesource.com/949808Reviewed-by:
-
lgcheng authored
Hookup permission dialog view. Add browser_test. Bug: 776476 Change-Id: I30405949ba50591030a4645f0d7feb1f4fefc03d Reviewed-on: https://chromium-review.googlesource.com/907691Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#541260}
-
Robert Liao authored
Fallout from https://chromium-review.googlesource.com/c/chromium/src/+/922662 BUG= Change-Id: Ie77cfd226cc0af218068405190936348907c93cd Reviewed-on: https://chromium-review.googlesource.com/952103Reviewed-by:
-
Nate Fischer authored
This disables two integration tests which depend on device locale. While these tests pass under some locales like en-US and es-MX, they fail when the device is in other locales such as cs-CZ. We should modify the tests to fetch the locale in the same way the security interstitials component does to create the URLs. Bug: 819085 Test: N/A Change-Id: I9a23b810c8783df36c75ce95a733b46b68b84239 Reviewed-on: https://chromium-review.googlesource.com/952269Reviewed-by:
-
Adam Langley authored
The results of client extensions, after some discussion, have settled on being a dictionary returned by a callback on the |PublicKeyCredential|[1]. This change implements that callback and plumbs through the results of the |appid| extension[2], since that's the only extension that we currently implement. [1] https://w3c.github.io/webauthn/#iface-pkcredential [2] https://w3c.github.io/webauthn/#sctn-appid-extension Bug: 818303 Change-Id: Ie7963229cc74fa209cb1c61d00e0ff63e361ace3 Reviewed-on: https://chromium-review.googlesource.com/946732Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541257}
-
Yuke Liao authored
This CL refactors the function that parses args.gn file to cache the results so as to avoid parsing the same file more than once. Change-Id: If8fc60c2f28b94b6d435395b563f0ed750c5f280 Reviewed-on: https://chromium-review.googlesource.com/947925 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
