- 30 Oct, 2018 40 commits
-
-
Meilin Wang authored
Temporarily fix the Assistant UI flyout off the screen to the left when the container width grows larger than the screen width by explicitly setting x-axis value of container to be positive. But the side effect is when the screen is not wide enough, inside views will be clipped. Since it doesn't always make sense to apply a width restriction on Assistant UI to be less than the usable work area width (the workarea could be extremely narrow depending on the physical size and resolution combination), also the server side has assumptions about the card size, we may need a more comprehensive solution to resize the views correctly. In this CL, we just keep the 640 dip width assumption unchanged. Test: local compile and manually test. Bug: b:116807989 Change-Id: I257ac26cd28672ec284ff2555e46db5ab6a46246 Reviewed-on: https://chromium-review.googlesource.com/c/1250087Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#604010}
-
wutao authored
This cl fixes two descriptions of shortcuts. Bug: 896907 Test: manual. Change-Id: I035a4cab3e8315437111f0f72bcdf3bf681e2876 Reviewed-on: https://chromium-review.googlesource.com/c/1298475Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#604009}
-
Matthew Jones authored
This patch removes unused swiple logic experiment flags and implementation from Chrome. Change-Id: Ic59a477a71291a355ac68538693f10b940e22d68 Reviewed-on: https://chromium-review.googlesource.com/c/1305814Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604008}
-
Kevin Strohbehn authored
Bug: 896790 Change-Id: I2d8de828cea27caa210755a0de8304ee293e55f9 Reviewed-on: https://chromium-review.googlesource.com/c/1307233 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604007}
-
John Chen authored
SessionHandlingTest.testGetSessions appears to trigger some race conditions and is flaky. Disabling it until a fix can be found. TBR=zmin@chromium.org Bug: 899919 Change-Id: I3c532559477a3597f20984783eb36acf6355ad7b Reviewed-on: https://chromium-review.googlesource.com/c/1308657Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604006}
-
Jamie Madill authored
This should force DEPS changes in ANGLE to trigger all trybots. ANGLE's bot config is a bit special since we use recursive DEPS. Bug: 850100 Bug: 899737 Change-Id: Iab6e996663386f66f1fa05f2ee10531d6bd85224 Reviewed-on: https://chromium-review.googlesource.com/c/1307734 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604005}
-
erikchen authored
Previously, local_device_test_run.py used SignalHandler() to catch SIGTERM, raise an exception, and then handle the exception. This prevents other SIGTERM handlers from ever receiving the exception. This CL changes local_device_test_run.py to instead use AddSignalHandler(), so that the exception is propagated to the previously registered SIGTERM handler. Bug: 895027 Change-Id: Ia6f84022ee4cf54e7dc36afad012acb3212b51e2 Reviewed-on: https://chromium-review.googlesource.com/c/1308753Reviewed-by:
-
James Hawkins authored
R=dpapad@chromium.org, hansberry@chromium.org Bug: 899324 Test: none Change-Id: I01b9786b3e5f49490660829bd1c3a7659e73f9c7 Reviewed-on: https://chromium-review.googlesource.com/c/1306916 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604003}
-
Wez authored
- Expose WebContentRunner's constructor to derived classes. - Move the common Runner and Component implementations under "common". - Move the scoped service publishing binding into WebContentRunner. - Move the default web.Context creation helper to the WebContentRunner. - Rename the ComponentControllerImpl to WebComponent. - Rename WebComponent::RequestTermination to ...::DestroyComponent. Bug: 893229, 856416 Change-Id: Ia4b8036d5f1b6f00472d201b7cb9dcf063377122 Reviewed-on: https://chromium-review.googlesource.com/c/1301114Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604002}
-
Peter Kvitek authored
Process handle and cumulative CPU usage is returned for browser and all renderer processes. BUG: 899823 Change-Id: I6d44630df3ea9ef80bed17f30367dad929ecaa17 Reviewed-on: https://chromium-review.googlesource.com/c/1303074 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#604001}
-
Sammie Quon authored
Test: none Bug: none Change-Id: Idf8dc27a75ccbf3040e0f5950565d1dc856cc9a8 Reviewed-on: https://chromium-review.googlesource.com/c/1306664Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604000}
-
Alexandr Ilin authored
Recent bug in GpuMemoryBufferHandle deserialization on Android (fixed in [1]) showed that there is no test coverage for seriazliation of native GMB, at least on Android. This CL adds a test checking serialization correctness for all subtypes of GpuMemoryBufferImpl. [1] https://crrev.com/c/1297469 Bug: 863011 Change-Id: I9688c1eed4b6dc7c5f2f7b1a20b08c2d62a35824 Reviewed-on: https://chromium-review.googlesource.com/c/1298209Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603999}
-
Tanja Gornak authored
In the new architecture Android will share most of the codebase with Desktop implementation. The queuing of the messages for the case when Chrome is in the background will be implemented separately, directly in the GCMDriver code on java side. (formerly desktop code) now compiles on Android, hence contributes to the binary size. After the invalidation feature fully launched, the significant part off previous implementation will be removed and binary size will be even smaller than now. Bug: 801985 Binary-Size: The significant chunk of the invalidation code Change-Id: I57009fd7cb83246305d06af13fb72c61fdae459f Reviewed-on: https://chromium-review.googlesource.com/c/1209583Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#603998}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7cba6be85a14..af9dd6080188 git log 7cba6be85a14..af9dd6080188 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 fjhenigman@chromium.org Fix UpdateAttribBindingByVertexAttribDivisor test. Created with: gclient setdep -r src/third_party/angle@af9dd6080188 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibf559a72661c4de1bb654229c41b0b2d8dc665b5 Reviewed-on: https://chromium-review.googlesource.com/c/1308176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603997}
-
Paul Miller authored
Create an empty "WebView Log Verbosifier" app. When installed, WebView will log all registered field trials and their assigned groups, for QA purposes. Check for the dummy app asynchronously, because PackageManager is slow. Skipping presubmit for LOG(INFO). BUG=892870 NOPRESUBMIT=true Change-Id: Ia4fee870aec84a60e9e70642405c5ff8b07da7cf Reviewed-on: https://chromium-review.googlesource.com/c/1266611 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603996}
-
Gauthier Ambard authored
This CL removes the limit on the number of lines used to display the current version in the settings. Bug: 899700 Change-Id: Iab412b30c2e32f5212a05d8b799fdc4cd9777859 Reviewed-on: https://chromium-review.googlesource.com/c/1307439Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#603995}
-
Jimmy Gong authored
- SMB file sharing can still be disable through managed policies. Bug: chromium:896414 Test: end-to-end Change-Id: I4158249d14812a7e28a775af54cc6ed4ee35714f Reviewed-on: https://chromium-review.googlesource.com/c/1297640 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#603994}
-
Eric Aleshire authored
The glob statement in copy_trusted_certificate doesn't catch any simulators like I expect it to; I add a bunch of temporary logging so that I can figure out where it is failing. This only affects my WPR tests. Change-Id: I58e26deb41988d5a9ca2f75b090495aad99303f3 Reviewed-on: https://chromium-review.googlesource.com/c/1308574Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#603993}
-
Morten Stenshorne authored
Walking the ancestry during layout to figure out what size to use doesn't work in LayoutNG. Use the provided override size instead. Modified one test so that it would fail without this fix. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iac990aed33355ecd49d68cc51bd355d2139f3dcb Reviewed-on: https://chromium-review.googlesource.com/c/1307393Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#603992}
-
Owen Min authored
Disable tests on Mac10.12 and Win7 Bug: 899890, 891427, 626703 Change-Id: Iaf47b38dcf45f5fce734325450609a10a9c5d712 Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1308413 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603991}
-
Charlie Harrison authored
This is useful for debugging. Bug: None Change-Id: I8e6260f09b3c17f0a9952739387f70a431571011 Reviewed-on: https://chromium-review.googlesource.com/c/1308013 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603990}
-
Yuri Wiitala authored
This is a temporary code addition to help root-cause a rather elusive crash (see crbug for discussion). It: 1) adds extra checking of the AudioBus that, writing to, causes write access violations on Windows; and 2) adds crash key strings to expose lifecycle/event state leading up to the crash. Bug: 888478 Change-Id: Ie7866e69081623cac9833e59d0aaadf1671ad248 Reviewed-on: https://chromium-review.googlesource.com/c/1306656 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603989}
-
Owen Min authored
This reverts commit 199a6044. Reason for revert: NativeAppWindowCocoaBrowserTest.HideShowWithAppWithShim failed on Mac10.12 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16328 Original change's description: > MacPWAs: Decouple AppShimHost and AppShimHostBootstrap > > Update AppShimHandler::OnShimLaunch to take a AppShimHostBootstrap, > and use that to create an AppShimHost, rather than having the > caller create the AppShimHost. > * Have the method for AppShimHost creation be in the > AppShimHandler::Delegate class for overriding in tests. > * This sets us up to have the AppShimHost be created before the app shim > process has completed launching (and thereby be able to queue up > creating windows in the app shim process). > > Add to AppShimHandler::Host's public interface an OnBootstrapConnected > function, where the AppShimHandler::Host takes ownership of the app > shim process. > * This is currently always called immediately after the AppShimHost's > creation, but that will change in the next patch. > > Make the tests rely more heavily on the real classes instead of fake > stubs. In particular, I plan to remove AppShimHandler::Host as an > abstract interface because the tests cover much more ground when run on > the real test (and the one real implementation, AppShimHost, has no > other public methods). > > Make one subtle change in the tests. In the event of a duplicate app > launch, the app's windows will be focused by the existing AppShimHost, > because we don't create an AppShimHost in the event of any failure. This > has the same user-visible behavior (because the windows being focused > are the same). > > Bug: 896917 > Change-Id: Ideea05d00edc1bf4c11825e70ad44229b1174724 > Reviewed-on: https://chromium-review.googlesource.com/c/1305889 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603821} TBR=ccameron@chromium.org,dominickn@chromium.org Change-Id: I1e60835172d2eac0e402b4de142d16e1edf54dc9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896917 Reviewed-on: https://chromium-review.googlesource.com/c/1308664Reviewed-by:
-
Eric Karl authored
This change adds a feature, EnableGpuRasterizationViewportRestriction, which, when disabled, allows us to enable GPU raster for all content independent of the viewport trigger. TBR=chrishtr@chromium.org, as pdr has reviewed, but owns the .h but not .cc part of features.* Bug: 899399 Change-Id: I986d6e40d93f149cb2d5fc11758ca8b3f0bc1a89 Reviewed-on: https://chromium-review.googlesource.com/c/1303397 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603987}
-
Xida Chen authored
In our previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1066630 We fixed the problem where an element with transform animation and fill-mode being 'forward' or 'both' should be containing block. This CL adds test to ensure that the style has IsStackingContext = true in those cases. Bug: 764783 Change-Id: Ib110c52f3afd5f68028569c528145162b4c48ed1 Reviewed-on: https://chromium-review.googlesource.com/c/1299203Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603986}
-
Gaurav Dhol authored
base/files/file_win.cc(276,40): error: non-constant-expression cannot be narrowed from type 'int' to 'BOOLEAN' (aka 'unsigned char') in initializer list Bug: 893460 Change-Id: Iab503865c0478c36d70fb8b7b9def152f70cfb7f Reviewed-on: https://chromium-review.googlesource.com/c/1301576Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfe69cae695e..2bc2ea919048 git log dfe69cae695e..2bc2ea919048 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 fmayer@google.com Merge "Bump libunwindstack version." Created with: gclient setdep -r src/third_party/perfetto@2bc2ea919048 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4b4191f6a6e92b1adea58070c22782d4bda64412 Reviewed-on: https://chromium-review.googlesource.com/c/1308175Reviewed-by:
-
Willie Koomson authored
This change adds memory footprint information for Arc processes into the chrome task manager. ArcProcessService requests a global dump from Android, and upon receipt provides it to the task manager (through ArcProcessTaskProvider) BUG=799538 TEST=Manual, compared memory footprint in task manager to top Change-Id: I5e10ba05e28185de750b6deb2f46d9227d4cc751 Reviewed-on: https://chromium-review.googlesource.com/c/1263335 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#603983}
-
Owen Min authored
This reverts commit 491ed062. Reason for revert: webkit_unit_tests failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11027 Original change's description: > [DevTools] Merge InspectorSession and DevToolsAgent::Session > > These are not needed as separate entities anymore, after making > workers reuse DevToolsAgent::Session. We merge them into a single > DevToolsSession class. > > Bug: 775132 > Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12 > Reviewed-on: https://chromium-review.googlesource.com/c/1282207 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603869} TBR=dgozman@chromium.org,caseq@chromium.org Change-Id: Iac3edc4bcd3d97e8ed67c5c35249ffd72c2ef1fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775132 Reviewed-on: https://chromium-review.googlesource.com/c/1308659Reviewed-by:
-
John Chen authored
This reverts commit 49c25ee7. Reason for revert: The original CL doesn't have the desired effects. Original change's description: > Disable flaky chromedriver test > > Disable the following test: > SessionHandlingTest.testGetSessions > SessionHandlingTest.testQuitASessionMoreThanOnce > SupportIPv4AndIPv6.testSupportIPv4AndIPv6 > ZChromeStartRetryCountTest.testChromeStartRetryCount > > Bug: 899919 > Change-Id: I4fdebcce8d0784f4a03d740fe75cad489e7cc2f1 > Tbr: johnchen@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1307594 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603893} TBR=zmin@chromium.org,johnchen@chromium.org Change-Id: Ia4d948632cb8141de5a8214569432e066ab7ab90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899919 Reviewed-on: https://chromium-review.googlesource.com/c/1308655Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52a715455181..f5973509ec68 git log 52a715455181..f5973509ec68 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3420dcb0cff1..7cba6be85a14 (1 commits) 2018-10-30 mtklein@google.com Revert "replace SkNVRefCnt with SkRefCnt" 2018-10-30 michaelludwig@google.com Pull out sksl emission logic for per-edge aa from GrTextureOp 2018-10-30 jvanverth@google.com Replace use of SkYUVSizeInfo with SkYUVASizeInfo Created with: gclient setdep -r src/third_party/skia@f5973509ec68 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I707155110ea18460bcf3e430dc1bb72b0262759a Reviewed-on: https://chromium-review.googlesource.com/c/1307879Reviewed-by:
-
Peter Qiu authored
On certain devices, enabling face detection will trigger tuning to provide better exposure around the face area. So expose this configuration to allow an application to enable it if it wants to. Currently, this is only supported by Android Camera2 driver. Bug: b/110420728 Test: Build Change-Id: I6a512740a0bc06fb1b6f6352dd2f65ce6830bf02 Reviewed-on: https://chromium-review.googlesource.com/c/1110268 Commit-Queue: Peter Qiu <zqiu@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#603979}
-
sczs authored
Since the OpenTab commands needs to know if the Tab should be open in Incognito or not, we should send the current BrowserState to the VC so it gets this information. Conversely all other services depend on the OriginalBrowserState, so we make sure to use this one for those. Bug: 895341 Change-Id: Idd7439a81432ec87d201e76d7fd60abec2615bbf Reviewed-on: https://chromium-review.googlesource.com/c/1299928Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#603978}
-
Tommy C. Li authored
LocationBarModel is a much more accurate name for this class than ToolbarModel. We didn't use OmniboxModel because it may be confused with OmniboxEditModel. TBR=sky@chromium.org Bug: 898347 Change-Id: I845e36fc58e4f8f4b951b83379bb355a4d718e9d Reviewed-on: https://chromium-review.googlesource.com/c/1306837 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603977}
-
Daniel Bratell authored
//third_party/abseil-cpp is currently excluded from gn check because of a couple of dependency fails. This patch tries to fix those. Most complicated is the dependency to gmock. The code does include "gmock/gmock.h" which gn will see as a dependency on //third_party/googletest:gmock. Bug: 898837 Change-Id: I2c1d33935511e790e1343cb59db11908cf4fab15 Reviewed-on: https://chromium-review.googlesource.com/c/1307497 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#603976}
-
Lindsay Pasricha authored
Change-Id: I2e8fc39df1a4a94a59e19cdab6ff1e96bcf292a9 Reviewed-on: https://chromium-review.googlesource.com/c/1306473 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603975}
-
Guido Urdaneta authored
This CL updates the SelectVideoTrackAdapterSettings() function to allow configuring VideoTrackAdapters with rescaling disabled. This is in preparation for supporting the resizeMode constrainable property in getUserMedia(). Drive-by: Fix CONTENT_EXPORT style in header. Bug: 854980 Change-Id: Ib9c0d33d14d45382ac38af091b0bc3f59b6f90f9 Reviewed-on: https://chromium-review.googlesource.com/c/1286817 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#603974}
-
rbpotter authored
Bug: 879261 Change-Id: I5513a889df874bef4157245d7ad7454e79777cfa Reviewed-on: https://chromium-review.googlesource.com/c/1211669Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#603973}
-
Lucas Furukawa Gadani authored
Change-Id: I60d5a327f7f0ad22dccdbdcbe15dbfaf89f98918 Reviewed-on: https://chromium-review.googlesource.com/c/1302493Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603972}
-
Tibor Goldschwendt authored
This is a precursor to have AR and VR be in separate dynamic feature modules. Bug: 837965 Change-Id: I0fb15971db49b858d808f78d93b77a72819cad8c Reviewed-on: https://chromium-review.googlesource.com/c/1298238 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603971}
-
