GitLab

This reverts commit 75044a52.

Reason for revert: After this CL Landed in 7603:
https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/7603?blamelist=1#blamelist-tab

All subsequent runs of iphone-simulator ui_eg2tests have failed:
https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator

I tried repro locally but other than some DCHECKs I could make the test
fail, but after I ran this revert using twosided.py the ui_eg2tests
were completed successfully:
https://ci.chromium.org/p/chrome/builders/try/iphone-simulator/229


Original change's description:
> [iOS] Add a new option to non-managed account Sign-Out.
>
> Adds a new option for users in non-managed accounts to clear synced
> data from their local device when signing out.
>
> Bug: 1005509
> Change-Id: Iae3b599b3ca3698b2a176bd56b470c6787c74367
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007695
> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734681}

TBR=sdefresne@chromium.org,jlebel@chromium.org,fernandex@chromium.org

Change-Id: I0d0742663b7b27cfefde24380b3a2c331aafb4e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1005509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020323
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735120}

https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0

git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s'
2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1)

Created with:
  gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium
Please CC bling-p10-rolls@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc
Bug: None
Tbr: bling-p10-rolls@google.com
Change-Id: I1721c8cea3e035192a9dfa05539a86342450d3a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020505Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735119}

This reverts commit bb8e99d0.

Reason for revert: Suspected of causing ozone_unittest failures on ChromeOS MSAN builder:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17456

Original change's description:
> Replace drmModeSetCrtc by Atomic APIs
> 
> If the device supports atomic APIs, use drmModeAtomicCommit to modeset
> and disable instead of drmModeSetCrtc.
> Abstracted Modeset and Disabled code to HDPM to handle both atomic and
> legacy call.
> Updated tests to support Connector and CRTC props.
> 
> BUG=987274
> TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps,
> HardwareDisplayPlaneManagerLegacyTest.Modeset,
> HardwareDisplayPlaneManagerLegacyTest.DisableModeset,
> HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on
> Nautilus(Intel), Grunt(AMD) and Cave(Legacy).
> 
> Change-Id: Ic307c04df4e22d1696abb31ebcd820f6bdcb542a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715751
> Commit-Queue: Mark Yacoub <markyacoub@google.com>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735013}

TBR=dnicoara@chromium.org,dcastagna@chromium.org,markyacoub@google.com

Change-Id: I05afd1f0419d53814889c4968ecbace723829ff5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 987274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020865Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735118}

This reverts commit 8d695b07.

Reason for revert: Suspected of causing multiple webkit_layout_test failures involving scrolling on the Mac bots:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16924

Original change's description:
> [Reland] Make programmatic scrolls respect smooth scroll flag
> 
> Programmatic smooth scrolls should also be instant if the smooth scroll
> flag is explicitly disabled.
> 
> Previously landed in https://crrev.com/c/1536759
> 
> To reland, this CL force enables the scroll animator in Blink web
> tests. Without this, the usual flow for determining if the animator is
> enabled is followed, which leads to inconsistencies. On Mac, the
> animator is enabled in Chrome but not in content shell. This leads to
> inconsistencies with other platforms (Mac tests ran without smooth
> scroll while Linux/Windows ran with) and ensuring we test what we ship.
> 
> This change required some minor fixes to tests that assumed instant
> scroll on Mac (and uncovered one real bug).
> 
> Bug: 944583
> Change-Id: I114d8b882d9855fbe0c43645575a1cdd7c3b6e61
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009842
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735006}

TBR=flackr@chromium.org,nasko@chromium.org,bokan@chromium.org

Change-Id: Ifa361e963dbc536830ad245ef31bfae542954c33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020555Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735117}

This reverts commit fd03e16d.

Reason for revert: crbug.com/1045444

Original change's description:
> Metal: Test offline-compiled shader link time
> 
> Change metal_util::TestShader to test either compile or link, and
> change the default behavior to link.
> 
> Add inline data for a trivial test shader. Add code to modify the
> bitcode, to defeat caching.
> 
> Ensure that the Metal calls for the test are invoked on a thread
> that has base::TaskPriority::HIGHEST.
> 
> TBR=jvanverth
> 
> Bug: 974219
> Change-Id: I35e688c3758af2e03f893a1ccbef7aef6b778b23
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015486
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734645}

TBR=ccameron@chromium.org,jvanverth@chromium.org

Change-Id: I872bad72bfd2bbb4318e032db4b14bf43e14d6e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974219
Bug: 1045444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020567Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735116}

Autogenerate Polymer 3 versions of CrProfileAvatarSelector and its
tests. This will be used by the chrome://settings page in future.

Bug: 1042558
Change-Id: Ic0ccfae7768f5b06ec16e23ae434318e649a764a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016191Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735115}

https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e

git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s'
2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19)
2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18)
2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17)
2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15)

Created with:
  gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium
Please CC bling-p10-rolls@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc
Bug: None
Tbr: bling-p10-rolls@google.com
Change-Id: I4481691a7e492da4e311805c3b3bf76884c5bd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020506Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735114}

- Print server printers are presumbably configured correctly and
  are IPP printers.
- This prevents users from edit a good state printer into a bad
  state.
- Adds browser test to reflect this change.

Bug: 1015628
Test: browser tests
Change-Id: I23878c588655b9325c1a8527df4779a59e493d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015579
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735113}

This browser client will be responsible for downloading conversation
starters from the server when the new V2 feature flag is enabled at the
discretion of the AssistantSuggestionsController.

Note that this CL only adds the bare bones interface/implementation and
follow up CLs will add/make use of new APIs.

Bug: b:148239201
Change-Id: Ifb97461f1eee61c7420f5f2ee652a4092b0d3787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018382
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735112}

Perform copying when a list item is long clicked on instead of just
clicking. Long click sounds more intuitive for copying behaviour.
Short clicks also looked spamy, since it can be an accidental touch
while scrolling, opening or closing a menu.

Also access item data using the recommended API parent.getItemAtPosition
rather than from the data array itself for cleaner code and better
managed variable scope.

Bug: 948923
Test: Manually long press item lists.
Change-Id: Ib54c3c5a1778d9c9d38814f9861f1b6b61b6ba83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020702Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735111}

Bug: 1009523
Change-Id: Ie52edb90f65e4a90007c18be2a3051fc351fb040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018184
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735110}

https://pdfium.googlesource.com/pdfium.git/+log/a793e97ab5e1..09dbeace089e

git log a793e97ab5e1..09dbeace089e --date=short --first-parent --format='%ad %ae %s'
2020-01-24 dhoss@chromium.org Add --disable-xfa flag to test_runner.py
2020-01-24 tsepez@chromium.org Avoid redundant EnumFontList() invocations.
2020-01-24 thestig@chromium.org Replace str[str.GetLength() - 1] with str.Last().
2020-01-24 thestig@chromium.org Remove #defines in cpdf_textpage.h.
2020-01-24 thestig@chromium.org Give a couple CPDF_TextPage members better names.
2020-01-24 maawas@microsoft.com Adding APIs to get name, type and value of form fields

Created with:
  gclient setdep -r src/third_party/pdfium@09dbeace089e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ibd7cfede35d0af8d5f7af23e2af6a95eea0f953d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735109}

This makes it possible to use WebGPU on Linux NVIDIA without disabling
the GPU sandbox. It still requires --use-vulkan so that Chrome loads
the Vulkan driver before creating the GPU sandbox.

Bug: 852089
Change-Id: I80ea898af221e48c5dd6a471a468628b47cc1992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013474
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735108}

This is preparation for cleaning out sdk_forward_declarations.

BUG=1044828

Change-Id: I3b86f376cf489be3f3c2fc3a8ce663043725504e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019766
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735107}

Using wpt-import in Chromium 3ac3f8c4.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
andruud@chromium.org:
  external/wpt/css/css-properties-values-api
dcheng@chromium.org, palmer@chromium.org:
  external/wpt/domxpath
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
jsbell@chromium.org:
  external/wpt/resources
jsbell@chromium.org, mek@chromium.org:
  external/wpt/webstorage
kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc
meade@chromium.org:
  external/wpt/web-animations
mek@chromium.org:
  external/wpt/webmessaging
mkwst@chromium.org:
  external/wpt/trusted-types
msisov@igalia.com:
  external/wpt/webvtt

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: I23a133edf73978ec2a359d12847c8ec4d102ecb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019825Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735106}

This CL uses optimization guide to fetch the public image URLs as hints
and sends to renderer where URL loader throttles allow redirect only
for the subresource URLs in the list.

Change-Id: Id654d041c376420a6e4d2a4daf3fdb51b24056f9
Bug: 1042869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996944
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735105}

https://android.googlesource.com/platform/external/perfetto.git/+log/214a08493a82..0dace75a3e64

git log 214a08493a82..0dace75a3e64 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 treehugger-gerrit@google.com Merge "Remove FrameBuffer name and handle from RenderStage slice name"
2020-01-24 hjd@google.com Merge "ui: Open .trace systrace files directly in legacy UI"

Created with:
  gclient setdep -r src/third_party/perfetto@0dace75a3e64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ib803985d13474c0efc93cc5be6f81c7ba2bf8e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020326Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735104}

This CL explicitly allows blob:null/... and data:... lock URLs when
using CanAccessDataForOrigin to validate precursor of an opaque origin.
This CL has been extracted from a slightly bigger refactoring at
https://crrev.com/c/2007983/11.  This CL helps avoid renderer kills
reported in https://crbug.com/1041880

Bug: 1041880, 1029092
Change-Id: I923512c8fc03491b4f95547240b3b7f8a88f7104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020327
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735103}

We build with the 10.14 SDK, so this is not needed.

BUG=1044838

Change-Id: I81ac8d37ee65d78d4b5a062b251c9fcfec840b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020422
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735102}

These tests all make use of either base::test::TaskEnvironment or
content::BrowserTestBase (via the WebEngineBrowserTest helper), which
already set default ScopedRunTimeouts.

Bug: 1021777
Change-Id: Ifbc5c29fb7dc1380c1d97bf6a49ff71c02b7e7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020642
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735101}

This reverts commit b4d501e3.

Reason for revert: This CL is on the blame list of the first
failures observed for PortalBrowserTest.FocusTransfersAcrossActivation
on Mac, and it is related to focus.

Original change's description:
> Focus tab contents in BeginNavigation case of NTP-initiated navigations.
> 
> Tab contents may get focused during some renderer-initiated navigations
> (e.g. navigations from an NTP-replacement extension - see the regression
> test added in r723022).  This CL ensures that the focus decision is
> applied not only to navigations that go through OpenURL, but also to
> navigations that go through (more freqeuent, usual) BeginNavigation.
> This change helps ensure that we retain the right focus behavior after
> more navigations switch to the BeginNavigation code path (e.g. after
> relanding ShouldFork removal in https://crrev.com/c/1949448).
> 
> The CL covers both the OpenURL and BeginNavigation code paths by
> handling the focus decisions in a newly added TabContentFocusingHelper
> class (replicating/moving the focus decisions from OpenURL-only
> Browser::UpdateUIForNavigationInTab).  Adding a new tab-helper class is
> useful, because the existing, OpenURL/BeginNavigation-shared navigation
> notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot
> distinguish between replaceState and new navigations (see also new steps
> in the OmniboxFocusInteractiveTest.NtpReplacementExtension test).
> 
> While this CL changes how focus behavior is implemented, it should have
> no effect on end-to-end/high-level expectations of focus behavior (as
> observed by end users or browser tests).
> 
> browser_tests do not guarantee window activation and/or focus, but before this
> CL navigation in browser_tests would focus WebContents.  This is not happening
> after this CL, and requires moving a handful of focus-dependent tests from
> browser_tests to interactive_ui_tests.
> 
> Bug: 1029161
> Change-Id: Ib57c260b2f85f276ff1dad3aabedd59d1d864c8a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970834
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735048}

TBR=pkasting@chromium.org,bbudge@chromium.org,creis@chromium.org,rouslan@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,bsheedy@chromium.org

Change-Id: I43362d7689548761154b80b72a0734ca02569794
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1029161, 1045594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020862Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735100}

Current update prevent creating/deleting simulators
if test runs on real devices.
Some bots don't have preinstalled sim-runtimes that match
version of connected real devices, it was a reason of failure like
https://chrome-swarming.appspot.com/task?id=49c31b4eab008710

To determine whether device with UDID is simulator
used `xcrun simctl` command because `idevice_id`
is not installed properly on some bots without real devices, e.g.
https://chromium-swarm.appspot.com/task?id=49c9a229b161d210

Bug: 1042380
Change-Id: I3771af295dadf32068343bdc2691bedf0a5f72a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002895Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735099}

This is a reland which has fixed msan failures by initializing
|target_color_| in hotseat_widget.cc.

In this change, the hotseat background will change color for different
shelf states and will animate between colors when changing. When in-app
shelf is shown the hotseat color should have an alpha value of 90%.
When the home shelf is shown the hotseat color should have an alpha
value of 60%.

Bug: 1041132
Change-Id: I74c1fc9de07d7db1e39400a963d6a5c7c8149320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017913Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735098}

https://skia.googlesource.com/skia.git/+log/cfca5c67f1a7..a7e557f3e353

git log cfca5c67f1a7..a7e557f3e353 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 michaelludwig@google.com Reland "Increase precision of some quad AA calculations"

Created with:
  gclient setdep -r src/third_party/skia@a7e557f3e353

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:10141204
Tbr: benjaminwagner@google.com
Change-Id: I012f8db2f3ffbb1c57356940b328a47404e3ab9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019859Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#735097}

Previously DevUI DFM Java files have locations that are inconsistent
with convention:
* Java files under .../modules/dev_ui/ should be in package
  org.chromium.chrome.features.dev_ui, but were instead placed in
  org.chromium.chrome.modules.dev_ui.
* /chrome/android/features/dev_ui/java should be
  /chrome/android/features/dev_ui/internal/java.

This CL fixes the above.

Change-Id: I523d040b0e1a2a041c2faa589d7606a04491ab1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018248Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Fred Mello <fredmello@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735096}

This adds the host implementation of the WebRtc service in the browser
process. It implements a new SendMessageDelegate that can send Unido
messages via the WebRtc service running in a sandboxed process.

- The service is launched in SharingServiceHost::BindService with
  SandboxType::kUtility
- SharingWebRtcConnectionHost handles sending / receiving data in
  plaintext as of now, with a follow-up CL adding encryption:
  https://crrev.com/c/2011925
- Signaling of WebRTC is done via FCM messages and passed through
  WebRtcSignallingHostFCM to and from the service

Bug: 1031144
Change-Id: I44884b5debdf3001b82c32e467b07bc0de87c938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995660
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735095}

This change replaces inheritance with generics and, in turn,
flips relation between Base- and Specialized ViewBinder classes.

While more verbose, this gives us a better control and protection
over how views and view binders are created and used.
With this change we get:
- better control over what individual viewbinders see,
- better compile-time diagnostics for accidental typos and copy-paste
  errors,
- better support for selective view substitution (enabling us to
  further optimize suggestions mechanism while staying safe).

For the most part this ensures Compiler will catch and report an
error early. In the extreme case where an error is repeated everywhere
the error will be caught and thrown at runtime upon view creation.

This change aligns with the original design proposal for suggestions
refactor.

More details: https://crrev.com/c/2007943
Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8
Bug: 982818

Change-Id: Ic8425512f3904cc29ea410723a9b7a717492e191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017980
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735094}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/300b9ced..516ed977

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I32fcf61627f8cc1f3584efcf397a10f45948a1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019824Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735093}

It looks like this was disabled here:
https://chromium-review.googlesource.com/c/chromium/src/+/2006353

However the test is still being run.  I looked at the original CL and
I suspect there is a missing comma so the last two tests in the
blacklist array aren't separated correctly.  I'm going to try adding
the comma in and see if the flaky failure goes away.

TBR: mythria@chromium.org
Bug: 1043048
Change-Id: I8db21e2fb569193e2653bcc5b28cd2f5ddd32eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019587
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735092}

Enable by default the SafeBrowsingPasswordProtectionForSavedPasswords
and SafeBrowsingPasswordProtectionForSignedInUsers experiments on
desktop only.

Bug: 1026006,914410
Change-Id: If0052bf62af127e94adc24cfdab701559c2293e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017675
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735091}

TBR=govind@chromium.org

Change-Id: I919a40da757400537a10fea0259e4672f542daa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020242Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735090}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5337c2c3980c..829bdae45d24


Created with:
  gclient setdep -r src-internal@829bdae45d24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1028270,chromium:1039877,chromium:1042208,chromium:702834
Tbr: jbudorick@google.com
Change-Id: I37c965744a09f16982a174ad888af23c0978861c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019934Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735089}

Scrollable shelf view was mirroring available_space_ bounds even though
they already were in the right coordinates as calculated in
UpdateAvailableSpace().

What has to be mirrored is the layout offset passed to shelf view, whose
coordinates are flipped (compared to scrollable shelf view) in rtl.

Also fixes drag from apps grid view - the screen coordinates passed to
the drag and drop host (i.e. shelf) by converting location returned by
ExtractDragLocation() to screen coordinates, but which was flipped for
rtl (to correctly match the drag handling inside apps grid view).
Instead, calculate the screen coordinates from the event root location,
to avoid dependency on the ExtractDragLocation() details.

BUG=1039758

Change-Id: I5c74f02d72e5f8e0b13e0c9076bd12361387d5cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020330Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735088}

The snackbar cancel rate is very high. Using a higher threshold does not
reduce the cancel rate, however it reduces the number of times this
snackbar is shown resulting is less users accidentantlly getting into
a never translate state that they don't know how to get out of.

Bug: 1044815
Change-Id: Ibee9c9cb3e0068a3d57b35adfc66b821299332a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016184Reviewed-by: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735087}

The only remaining usage is in tests. Convert the test to
ContextLossObserver instead and delete ContextFactoryObserver.

Bug: 947279
Change-Id: I0ec87d11a011ea315dc1a4cea3b8bf66f1f30f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546269Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735086}

This CL defines Speech On-Device API (SODA)-related file path constants
in //components/soda that will be used by the component updater in
//chrome/browser/component_updater, the SODA sandbox hook in
//content/utility, and the SODA service in //chrome/services.

Bug: 1039824
Change-Id: Ic96c7eb5ec6d458beb4f0bf90982bf4dccc6dc45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015483Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#735085}

Bug: None
Test: None
Change-Id: Ie720aa5c16971f0105504cb089e0b27a46c5d32e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953670Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735084}

When a generated live region event occurs, we currently fire
IA2_EVENT_TEXT_INSERTED. However, as recently discovered via
https://chromium-review.googlesource.com/c/chromium/src/+/2015429
we are not firing IA2_EVENT_TEXT_REMOVED in the generated event
case.

This currently adds a todo rather than attempting to correct the logic
for which events fire, as it is not known to cause any actual screen
reader issues.

Bug: None
Change-Id: I4d74acdf47c5909d3efe0dbf2acb9d20ffb98528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019410Reviewed-by: Ian Prest <iapres@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735083}

When the drag completes in ScrollableShelfView, there are two
possibilities:
1. The drag was Shelf -> Shelf
2. The drag was AppList -> Shelf

For scenario 1:
 - ScrollableShelfView owns a DragIconProxy |drag_icon_|
 - ShelfView treats ScrollableShelfView as the
   ApplicationDragAndDropHost.
 - ShelfView makes its DragImageView |drag_image_| invisible.
When scenario 1's drag completes, there is no issue, ScrollableShelfView
successfully animates |drag_icon_| to the proper bounds.

For scenario 2:
 - AppsGridView treats ShelfView as the ApplicationDragAndDropHost
 - ShelfView creates a DragIconProxy, |drag_image_|.
 - ScrollableShelfView does not create a DragIconProxy.
 - Animation for the scrollable shelf, implemented in
   ScrollableShelfView fails.

To fix scenario 2, pass ShelfView's DragIconProxy
(ShelfView::drag_image_|) and use it within ScrollableShelfView.

This change is not intended to be a full fix, just a change that we can
successfully land without refactoring.

I am avoiding refactoring because:
 - Branch is soon.
 - Kukui is coming out with this milestone
 - This code is already prone to bugs, I am worried there will be
   negative effects to a refactor

I created a follow up bug for this refactoring:
https://bugs.chromium.org/p/chromium/issues/detail?id=1045186

Also in this change:
 - Use a transform instead of a bounds animation.
 - Simplify DragIconDropAnimationDelegate

Bug: 1041999
Change-Id: I63a428f103a888ef019da919407a60533da68c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017923
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735082}

This isn't hooked up to anything yet.

Also this starts on params and features headers which I'll move the
existing stuff into later to avoid merge conflicts.

Bug: 1042829
Change-Id: I59139788243e076432789f8b5ff9c581cf276f38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004956
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735081}