GitLab

Taking into account for strict number checking based on country selected during aggregation.
First 3 phone digits '123' is not considered valid for US numbers.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6961037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86173 0039d316-1c4b-4281-b951-d872f2087c98

The previous way did not fool LTCG optimization.

I tested that this works by doing and LTCG build without this change and verified that the compiler strips out the assignment to program_counter in MessageLoop::RunTask. Then I repeated with this change and verified that the compiler did not strip it out.

TEST=compiles plus the above
BUG=81449
Review URL: http://codereview.chromium.org/7054025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86172 0039d316-1c4b-4281-b951-d872f2087c98

Set content offset using fill_into_edit's length and not the length of the originally typed term.

BUG=82994
TEST=Added unit test. Manual test: 1) Delete the 'History Provider Cache' file, 2) Start Chrome, 3) Type 'about:flags' into omnibox and <ret>, 4) Type 'about:flags/' or 'about:flags@' into omnibox. There should no longer be an assert at this point.
Review URL: http://codereview.chromium.org/7004042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Host plugin accepts connection if Access Code supplied to Viewer is valid.


Review URL: http://codereview.chromium.org/7004046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86170 0039d316-1c4b-4281-b951-d872f2087c98

Add Browser::OnWindowActivated
Add reload in Browser::OnWindowActivated

BUG=chromium-os:12596
TEST=tested manually

Review URL: http://codereview.chromium.org/6973047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86168 0039d316-1c4b-4281-b951-d872f2087c98

The SetToken mock was using the command header as the token value. Also, the ringbuffer test didn't support the jump command, so if the number of entries in the command buffer is too small then the test breaks.

BUG=
TEST=


Review URL: http://codereview.chromium.org/6990002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86167 0039d316-1c4b-4281-b951-d872f2087c98

r66321 silently broke it because we were not running the tests, just listing the
tests and yet returning success.
This fixes it as well as some regressions in the tests themselves.

BUG=none
TEST=ui_tests

Review URL: http://codereview.chromium.org/7055002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83010
TEST=See bug for more details

Review URL: http://codereview.chromium.org/7043023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=local

Review URL: http://codereview.chromium.org/7055017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromeos-partner:3744, chromium-os:15270
TEST=make sure we can play content from file shelf with the media player
Review URL: http://codereview.chromium.org/7058001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86162 0039d316-1c4b-4281-b951-d872f2087c98

Also test that hosted apps do not receive WebUI.

BUG=83289
TEST=AppApiTest.AppProcess

Review URL: http://codereview.chromium.org/7048015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83023
TEST=See bug.

Review URL: http://codereview.chromium.org/7038041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/7034045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86159 0039d316-1c4b-4281-b951-d872f2087c98

The WebKit bug has been fixed.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6961034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86158 0039d316-1c4b-4281-b951-d872f2087c98

Remove useless member from conflictresolver (it was always empty and had no effect).  Add histograms to conflictresolver to verify the hypothesis that this code is unreachable in practice.

BUG=83006
TEST=unittests


Review URL: http://codereview.chromium.org/7042028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86157 0039d316-1c4b-4281-b951-d872f2087c98

 - testPreFetchInstantURLNotInHistory
 - testPreFetchInstantURLGeneratesNoPopups
 - testPreFetchInstantURLSetsNoCookies

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7033039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86156 0039d316-1c4b-4281-b951-d872f2087c98

Previously, all passwords tests were diabled in pyauto.  This CL
re-enables passwords.PasswordTest.testSavePassword (by explicitly
disabling all other passwords tests).

BUG=73078
TEST=None

Review URL: http://codereview.chromium.org/6994005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7037045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86153 0039d316-1c4b-4281-b951-d872f2087c98

No visible changes.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7057012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86152 0039d316-1c4b-4281-b951-d872f2087c98

In webkit_glue::DecodeImage(), the WebImage
is of type SkBitmap instead of CGImage, so
take the general case if USE_SKIA is defined.

The generic version of WebCursor defines
SetCustomData and ImageFromCustomData only if
WEBKIT_USING_SKIA is enabled, so disable the
corresponding routines in the Mac version.

In webkit_glue::WebThemeEngineImpl::paintScrollbarThumb(),
map the WebCanvas (i.e. SkCanvas) to a CGContext
to paint the scrollbar thumb, using the SkiaBitLocker
utility class.

SkiaBitLocker is described in
http://codereview.chromium.org/7031006/

These changes make no functional change to any
existing port, so have no new tests.

BUG=79463
TEST=none

Review URL: http://codereview.chromium.org/6840057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86151 0039d316-1c4b-4281-b951-d872f2087c98

- Remove network section h3 specifics since options_page.css is using
  the latest UI now. And this makes network UI looks the same way as
  other parts. That is, buttons and network list are aligned instead of
  immediately following the section headers.
- Move "-webkit-margin-start: 15px" into the div container
  "network-general-div" and get rid of related css rules from its
  children;
- Remove stale css rules of "details-button", which no longer exists;

BUG=none
TEST=Verify ChroemOS network settings works as before. The only visual
change is the button strip and network lists are now left-aligned
instead of immediately following the section headers.

Review URL: http://codereview.chromium.org/7038043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86150 0039d316-1c4b-4281-b951-d872f2087c98

Linux: split ProxyConfigServiceLinux::SettingGetter::Setting into several enums, one for each type of setting. This provides additional type safety.

Review URL: http://codereview.chromium.org/7033040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86149 0039d316-1c4b-4281-b951-d872f2087c98

Testing the LevelDB backend from the webkit unit tests requires it
create a temporary file system. In order to clean this up
(and on all platforms) we are going to make the scoped_temp_dir
functionallity available to LayoutTestController.


TEST=This is a thin wrapper on ScopedTempDir which is already covered by unit testing. This will be connected to LayoutTestController (a future patch in WebKit).

Review URL: http://codereview.chromium.org/7034047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83430
TEST=none
Review URL: http://codereview.chromium.org/7054021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81916
TEST=Follow repro setps in bug report, verify that crash no longer occurs.
Review URL: http://codereview.chromium.org/7050031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86146 0039d316-1c4b-4281-b951-d872f2087c98

Also cleans up the new directory path format just a bit, and makes the database store relative paths instead of absolute ones, so that if the user moves her profile path, things don't break.

BUG=none
TEST=unit test


Review URL: http://codereview.chromium.org/7042029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82783
TEST=dragging a link onto the tabstrip and dropping it works (ie. loads that link in a new or current tab)

Review URL: http://codereview.chromium.org/7049014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86144 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82965, 82969, 83411
TEST=See bugs description.

Review URL: http://codereview.chromium.org/7033037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86142 0039d316-1c4b-4281-b951-d872f2087c98

We're seeing crashes due to corrupted history items in the session data on ChromeOS, and this is a bandaid to help reduce them.  It's not the real solution, which is to have more corruption-robust history item storage and recovery, but it shouldn't cause any harm.

Our supposition here is that corruption is occurring because we shutdown while session data hasn't been flushed to the disk, thus corrupting the history data, which is fragile, and we crash the next time we read in the session.

This CL will help because we flush after appending system data.  Other CLs will help to clean up the bad history data, and be more robust in the case of corruption.

BUG=chromium-os:15478, chromium-os:15350
TEST=Loaded existing current state, exited, reloaded, ran unit test.

Review URL: http://codereview.chromium.org/7044018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86141 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a regression from r85968.

On my Ubuntu 10.10 box, g_settings_new does not fail gracefully if the schema is not found: it calls an assert. This checks if the schema exists first. The docs for g_settings_list_schemas specify not to modify or release the return value.

BUG=83376
TEST=by hand and trybots


Review URL: http://codereview.chromium.org/6990008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86140 0039d316-1c4b-4281-b951-d872f2087c98

. Make sure if there is no texture and we're told to paint, we paint
  to the whole texture (see comment for details on why we need to do
  this).
. When the transform changes only schedule paint on the widget. By doing
  this we won't trigger updating the texture, only having the
  compositor redraw everything. This currently doesn't matter, but
  will once James lands his changes to SchedulePaint to keep a dirty
  bit.

BUG=none
TEST=none
R=ben@chromium.org,wjmaclean@chromium.org

Review URL: http://codereview.chromium.org/7056013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86139 0039d316-1c4b-4281-b951-d872f2087c98

Patch from Fabien Tassin <fta@sofaraway.org>.

Review URL: http://codereview.chromium.org/7049015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83257, 83259, 82953
TEST=See bug description.

Review URL: http://codereview.chromium.org/7040017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82453
TEST=ui_unittests

Review URL: http://codereview.chromium.org/7055010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86136 0039d316-1c4b-4281-b951-d872f2087c98

Changed getNodeById to getNodesById and added getChildNodeIds.  This
avoids having to loop through a node's children in Javascript, which
is slow.

This speeds up expanding the "Autofill" node in the sync node browser
by 40-50% (with ~2700 elements).  With a debug Chromium, time spent
retrieving the nodes goes from 30s to 18s, and with a release Chromium
time it goes from 2.9s to 1.3s.

This will also speed up search, which will be implemented shortly.

Add timer logs to some sync node browser operations.

Fix docs for some functions called from Javascript.
BUG=76812
TEST=

Review URL: http://codereview.chromium.org/7049028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86135 0039d316-1c4b-4281-b951-d872f2087c98

Downloads while prerendering should no longer
create history items, and this should fix the
flake in the prerendering download tests.

BUG=81798, 81985
TEST=PrerenderBrowserTest.PrerenderDownloadLocation and several others.

Review URL: http://codereview.chromium.org/7004039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86134 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman@chromium.org
BUG=none
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86133 0039d316-1c4b-4281-b951-d872f2087c98

in .cc matches .h. Adds OVERRIDE where applicable. Groups methods in
related sections. And removes a bit of dead code.

TBR=ben@chromium.org
BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7054013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83320
TEST=Manual


Review URL: http://codereview.chromium.org/7057011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86131 0039d316-1c4b-4281-b951-d872f2087c98

Fix ChromeFrame tests which broke after my change to fix empty XHR POST requests to not cache. Reason
an incorrect bind verb check.

BUG=none
TEST=chrome frame tests should pass.
TBR=amit
Review URL: http://codereview.chromium.org/7056018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86129 0039d316-1c4b-4281-b951-d872f2087c98