GitLab

BUG=414554
TEST=Added regression test PrefHashBrowserTestUntrustedAdditionToPrefs which fails without this CL and passes with it.

Review URL: https://codereview.chromium.org/550343004

Cr-Commit-Position: refs/heads/master@{#295048}

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/560123003

Cr-Commit-Position: refs/heads/master@{#295047}

BUG=NONE

Review URL: https://codereview.chromium.org/559053003

Cr-Commit-Position: refs/heads/master@{#295046}

https://chromium.googlesource.com/chromium/blink/+log/aa54489e95cc3512007c6ec9cb58a698cb2b3009..4fa3ffd7f1ab95e97014b6848f8643dd4206e015
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/570223003

Cr-Commit-Position: refs/heads/master@{#295045}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/573973002

Cr-Commit-Position: refs/heads/master@{#295044}

BUG=331367
TEST=manual testing on Linux ChromeOS build

Review URL: https://codereview.chromium.org/571893002

Cr-Commit-Position: refs/heads/master@{#295043}

Adds UMA logging to track how many batteries are reported by
the system at the start of Battery Status API.

BUG=

Review URL: https://codereview.chromium.org/545503002

Cr-Commit-Position: refs/heads/master@{#295042}

BUG=302040
NOTRY=true

Review URL: https://codereview.chromium.org/505083002

Cr-Commit-Position: refs/heads/master@{#295041}

This simply moves the backends in backends/android up one folder.
The current naming structure was redundant and some of the classes
there are not really android specific. Moving up since there is some
work in progress to introduce support for other platforms, so it
doesn't make much sense to keep a folder named 'android'.
No functional change is intended.

BUG=340294
NOTRY=true
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/574663002

Cr-Commit-Position: refs/heads/master@{#295040}

https://chromium.googlesource.com/chromium/blink/+log/d58a9ae43dcf8f670bd8a74aecc3e6e7883ebb6f..aa54489e95cc3512007c6ec9cb58a698cb2b3009
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/577553003

Cr-Commit-Position: refs/heads/master@{#295039}

This is a reland of https://codereview.chromium.org/570563002 with the
gyp build config updated.

R=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/571353002

Cr-Commit-Position: refs/heads/master@{#295038}

PRESUBMIT.py ened up being accidentally part of the last patchset in
crrev.com/549313006. It was not intended as it is still under review
in crrev.com/562553003

BUG=340294
NOTRY=true
TBR=primiano@chromium.org

Review URL: https://codereview.chromium.org/538363006

Cr-Commit-Position: refs/heads/master@{#295037}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/566333002

Cr-Commit-Position: refs/heads/master@{#295036}

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/564113003

Cr-Commit-Position: refs/heads/master@{#295035}

This CL renames ChromeBrowserPluginDelegate to GuestViewContainer and moves it to extensions

This CL moves guest_view_constants to extensions/common/*

This CL also attaches a GuestViewContainer to all GuestViews.

BUG=330264, 352290

Review URL: https://codereview.chromium.org/577453002

Cr-Commit-Position: refs/heads/master@{#295034}

If symbols with the same name appeared in the same "file" (as in
'unknown file') then they collided and only the last such symbol was
remembered. This happened for me with string symbols where all
.L.str21 were in the ?? file.

Store a list of symbol sizes per symbol and file. If there are more
than one symbol size per symbol and file, compare them differently to
see what might have happened.

A bit hard to read code. I hope it won't have to be changed.

BUG=412335
R=andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/551203004

Cr-Commit-Position: refs/heads/master@{#295033}

Introduce the logic which is able to intersect mmap stats (dirty/clean
priv/shared) with allocations. Essentially it contains the math to
calculate the overlap (even partial) between allocations and mmaps
and attribute stats counters to allocations. For the moment only
resident memory is accounted. Finer grained accounting (dirty/clean)
requires some changes to memdump (to have more than one bit per page in
its output bitmap) and will come soon.

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/563183003

Cr-Commit-Position: refs/heads/master@{#295032}

This change moves towards the new libheap_profiler + heap_dump for
profiling native allocations, instead of lib.debug.malloc.
It introduces the code to install the library in the system (wrapping
the Android zygote) and the parsers.
Compared to the lib.debug.malloc, libheap_profiler is much much faster
(less overhead) and able to hook also mmaps. Its output is very
detailed and allows to get stack traces for each VM region. This will
make it possible to intersect, in the near future, mmaps and native
stack traces.
This change also introduces the support to multiple ABIs to support
both arm and arm64.

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/549313006

Cr-Commit-Position: refs/heads/master@{#295031}

BUG=408184
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/556823004

Cr-Commit-Position: refs/heads/master@{#295030}

https://chromium.googlesource.com/chromium/blink/+log/a2b6094b526729ca0c4e4126c628e218cd98163f..d58a9ae43dcf8f670bd8a74aecc3e6e7883ebb6f
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/538363005

Cr-Commit-Position: refs/heads/master@{#295029}

BUG=396001
TEST=tools/perf/run_benchmark --browser=system --also-run-disabled-tests blink_perf.mutation  # Produces 0 tests.
TBR=tonyg
NOTRY=True

Review URL: https://codereview.chromium.org/573983002

Cr-Commit-Position: refs/heads/master@{#295028}

NOTRY=true

Review URL: https://codereview.chromium.org/574623002

Cr-Commit-Position: refs/heads/master@{#295027}

This CL changes the number of rows in the experimental app launcher's
grid view from 3 to 4.

BUG=411775

Review URL: https://codereview.chromium.org/573703003

Cr-Commit-Position: refs/heads/master@{#295026}

https://skia.googlesource.com/skia/+log/ae232a20d74de16baaec356787f968b4f04144c6..49005bf8929dd8ca86431e13414d683b509cd538

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/561703004

Cr-Commit-Position: refs/heads/master@{#295025}

https://chromium.googlesource.com/chromium/blink/+log/aa5e6ea2e1ddb260730d333f555faff0a26df787..a2b6094b526729ca0c4e4126c628e218cd98163f
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/572843003

Cr-Commit-Position: refs/heads/master@{#295024}

When rendering text, we don't have to render glyphs that fall outside of
the display area. This change stops processing glyps when we're outside
the display area, and stops processing further style ranges if those are
outside the display area. Note that the equivalent functionality is
already in place for Windows text rendering.

This fixes an issue where text rendering would become very slow when
rendering big strings.

BUG=413540

Review URL: https://codereview.chromium.org/543073002

Cr-Commit-Position: refs/heads/master@{#295023}

Since we create the WebCredentialManagerClient in //chrome, we need a
tiny mock to ensure that the Blink-side has something it can wire
itself up to. This is that thing.

BUG=400674

Review URL: https://codereview.chromium.org/565943002

Cr-Commit-Position: refs/heads/master@{#295022}

"ctrl + double click" acts on the highlighted/selected bookmark list items
irrespective of on which list item the action is performed. To extend this to
clicked, unhighlighted list item, invoking mouseup event handling functionality
under doubleclick event handling before command execution. mouseup event takes
care of highlighting and unhighlighting list items.

BUG=243221

Review URL: https://codereview.chromium.org/515853002

Cr-Commit-Position: refs/heads/master@{#295021}

Revert of When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden. (patchset #14 id:260001 of https://codereview.chromium.org/564553002/)

Reason for revert:
This seems to cause memory leaks in WebViewUnitTest.TestWebViewAttachDetachWebContents on Linux(ASan/LSan) and ChromiumOS(ASan/LSan)

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7468

Original issue's description:
> When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden.
>
> This occurs in the NativeViewHostAura::NativeViewDetaching code path where we first remove the
> clipping window which is the intermediate parent of the web contents view. The clipping window
> is hidden which causes the RWHVA::Hide function to get called which initiates the hiding sequence.
> Then the web contents view is reparented to the main view which is still visible. Now the RWHVA::Show
> function is called which initiates the show sequence. Eventually the main view is hidden, which then
> initiates the hide sequence.
>
> Addressed this with the following changes.
> 1. WebView::AttachWebContents and WebView::DetachWebContents
>    now show and hide the webcontents native view. The
>    WebContents is shown and hidden as before in
>    WebContentsNativeViewAura::OnWindowVisibilityChanged.
>
> 2. Removed the WebContentsNativeViewAura::OnWindowParentChanged function.
>    This function was present to show and hide the webcontents if the window was visible.
>    This should not be needed with the change in #1 above.
>
> 3. Added a new file webview_unittest.cc. This contains the unittest WebViewUnitTest.TestWebViewAttachDetachWebContents
>    This is run as part of unit_tests.exe.
>
> BUG=412989
> R=sky
>
> Committed: https://crrev.com/99941773a742f62892fc9aad1a1ebfb7cc967164
> Cr-Commit-Position: refs/heads/master@{#294962}

TBR=sky@chromium.org,ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=412989

Review URL: https://codereview.chromium.org/577533003

Cr-Commit-Position: refs/heads/master@{#295020}

Revert of Files.app: Split background.js (patchset #4 id:60001 of https://codereview.chromium.org/562103002/)

Reason for revert:
This patch breaks the test.

Original issue's description:
> Files.app: Split background.js
>
> This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes.
>
> This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future.
>
> BUG=375039
> TEST=browser_test passes
>
> Committed: https://crrev.com/479878c12c436c0bec667483df29fe1f23b710a2
> Cr-Commit-Position: refs/heads/master@{#294998}

TBR=hirono@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375039

Review URL: https://codereview.chromium.org/563743004

Cr-Commit-Position: refs/heads/master@{#295019}

https://skia.googlesource.com/skia/+log/df886ea06f0978e10695b482e658cf3daa9a1fc9..ae232a20d74de16baaec356787f968b4f04144c6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/572843002

Cr-Commit-Position: refs/heads/master@{#295018}

Regression are tiny:
- nacl_helper/nacl_helper (0.04%)
- nacl_helper-text/text (0.06%)

http://build.chromium.org/p/chromium/builders/Linux/builds/53437
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper&rev=294990&checked=all
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-text&rev=294990&checked=all

TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/571313002

Cr-Commit-Position: refs/heads/master@{#295017}

Revert of Perf: Update size expectation for nacl_helper/nacl_helper on linux (patchset #1 id:1 of https://codereview.chromium.org/575603003/)

Reason for revert:
I should have updated the expectation for linux-release (not linux-release-64).

Original issue's description:
> Perf: Update size expectation for nacl_helper/nacl_helper on linux
>
> Regression is tiny (0.04%).
>
> http://build.chromium.org/p/chromium/builders/Linux/builds/53433
> https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all
>
> TBR=nhiroki@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/bd700c84bf9132a96e17e0ea724d1855a8d01740
> Cr-Commit-Position: refs/heads/master@{#294991}

TBR=
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/574633002

Cr-Commit-Position: refs/heads/master@{#295016}

Previously SandboxBPF constructed the CodeGen Instruction sequence
primarily in one large, complex function.  Additionally, it made
extensive use of the CodeGen::JoinInstructions() function to
conditionally arrange various bits of instructions, which made it
harder to follow.

This CL splits the Instruction assembly code into 5 mostly distinct
functions and eliminates all use of JoinInstruction() in favor of
function composition.  E.g., instead of

    foo = gen->MakeInstruction(...);
    bar = gen->MakeInstruction(...);
    gen->JoinInstructions(foo, bar);

this CL favors writing

    MakeFoo(MakeBar())

with the convention that Instruction-constructing functions should
arrange for control to transfer to the Instruction sequence argument
when complete.  (I.e., "continuation-passing style":
http://en.wikipedia.org/wiki/Continuation-passing_style)

BUG=414363

Review URL: https://codereview.chromium.org/568053005

Cr-Commit-Position: refs/heads/master@{#295015}

Discard all useless QUIC retransmissions instead of only the most recent
useless retransmission.

May reduce the chances of truncated acks.

Merge internal change: 75561951
https://codereview.chromium.org/564663005/

Add a separate QUIC_CONNECTION_OVERALL_TIMED_OUT to identify overall
timeouts from idle timeouts and increase the initial overall timeout
from 5s to 10s.

Merge internal change: 75544619
https://codereview.chromium.org/572083003/

Fix QUIC crash on ConnectionClose, protected behind renamed flag
FLAGS_close_quic_connection_unfinished_streams_2 (defaulted to false).

With this change we avoid trying to close the connection while driving
the QUIC internal server response pipeline, as the call to
SendConnectionClose now happens during PostProcessAfterData, which is
only ever called after receiving new data. With a hacky
client/QUIC internal server combo (sending > 100 requests, but never
sending FIN/RST) I've verified that with this change we don't hit the
DFATAL from the attached bug.

Still not entirely sure why Chrome would trigger this, b/17402744 is
open to investigate why it ever opens more than kMaxStreams.

Merge internal change: 75541290
https://codereview.chromium.org/575593002/

Add a LOG(DFATAL) to a case where packets are acked before being sent.

Merge internal change: 75537267
https://codereview.chromium.org/575573003/

Allow number of open QUIC streams to grow 10% beyond configured limit at
the QUIC internal server before closing connection.

In the following situation Chrome may open more streams than the
configured limit:

* opens kMaxStreams streams
* sends a FIN for one of the streams, now has kMaxStreams-1 streams open
* opens a new stream
* FIN gets lost on way to QUIC internal server
* QUIC internal server terminates connection when new stream packet
  arrives

Rather than making Chrome keep track of when the server has acknowledged
a FIN, just give 10% breathing room which should avoid this case.

Merge internal change: 75393293
https://codereview.chromium.org/557363003/

client-only - Change QUIC clients to use the initial RTT estimate that
they provide to the server instead of the default.

Re-enabled LimitCongestionWindowAndRTT end_to_end unittest (since we
have fixed lot of flaky tests). Will test chromeos valgrind.

Merge internal change: 75389539
https://codereview.chromium.org/573763003/
BUG=321870

Increase flow control receive window of quic_client_bin.cc, by adding a
flag that defaults to 10 Mb.

Added --flow-control-window-bytes as argument.

Merge internal change: 75381087
https://codereview.chromium.org/569353003/

Call QuicSentPacketManager's OnPacketSerialized or OnRetransmittedPacket
right before OnPacketSent, in preparation for combining the three
methods into one.

Merge internal change: 75340764
https://codereview.chromium.org/566743003/

Instead of initializing QuicSession::next_stream_id_ to 3 in the
construct, and then setting it to 5 in InitializeSession simply
initialize it to 5 in the constructor.

Merge internal change: 75335114
https://codereview.chromium.org/562793003/

Do not allow a QUIC connection to timeout if no packets have been sent
or received. Protected by FLAGS_quic_timeouts_require_activity.

This seems to happen on windows from time to time and causes problems
there.

Merge internal change: 75304108
https://codereview.chromium.org/571993002/

Minor change to QUIC's retransmission to not link old retransmissions
with new ones when the version or encryption changes.

Allows the least_unacked to be raised more quickly, preventing spurious
acks.

Merge internal change: 75290729
https://codereview.chromium.org/572703003/

Removed unnecessary static_cast and replaced it with "lu".

Minor change to keep the code similar to internal code.

Merge internal change: 75263809
https://codereview.chromium.org/566373003/

QUIC cleanup to remove an unused bool argument in SendOrQueuePacket and
OnSerializedPacket.

Merge internal change: 75208575
https://codereview.chromium.org/553583007/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/559373003

Cr-Commit-Position: refs/heads/master@{#295014}

This cl adds the basic ChromeVox key bindings (Search+Shift+<arrows>). The command names currently serve as a placeholder pending a decision on what we should map them to.

TEST=Manually verify that the onCommand handler gets called for each command on each key combo only on the whitelisted page. Also, verify that ChromeVox uses the automation tree on the whitelisted pages while allowing content script control on all other pages. Desktop tree should always verbalize.

Review URL: https://codereview.chromium.org/536233002

Cr-Commit-Position: refs/heads/master@{#295013}

This CL adds path overrides for shortcut directories in testing environments.
This will ensure tests don't pollute the build bots with shortcuts

BUG=411970

Review URL: https://codereview.chromium.org/565523003

Cr-Commit-Position: refs/heads/master@{#295012}

Revert of Revert CL 117933003. Re-add resource speculative prefetching code. (patchset #10 id:180001 of https://codereview.chromium.org/462423004/)

Reason for revert:
This caused a bunch of memory leaks in following tests:

- ResourcePrefetcherTest.TestPrefetcherFinishes
- ResourcePrefetcherTest.TestPrefetcherStopped

Linux Chromium OS ASan LSan Tests (3)
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/3216

Linux ASan LSan Tests (2)
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7460

Original issue's description:
> Revert CL 117933003. Re-add speculative resource prefetching code.
> https://codereview.chromium.org/117933003/
>
> The speculative resource prefetching code was experimental code developed by
> shishir@. He found that it has little improvement on desktop Chrome (win). We
> though this should be beneficial to mobile browsers. After discussing with
> tburkard@ and kenjibaheux@, we decided to bring the code back and do more
> analysis on mobile devices. Reverting the patchset to re-add the code is the
> first step.
>
> The following design doc has discussed all related approaches and action items.
> https://docs.google.com/a/google.com/document/d/1ie3hu-zNNXvmTXm3aJAtKUGOh6nZfbNjA0aZE1bzzIg/edit?usp=sharing
>
> BUG=408399, 405690
>
> Committed: https://crrev.com/825722d5939dc0832d124b70958501611e6a4628
> Cr-Commit-Position: refs/heads/master@{#294899}

TBR=shishir@chromium.org,tburkard@chromium.org,kenjibaheux@chromium.org,jam@chromium.org,thestig@chromium.org,zhenw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408399, 405690

Review URL: https://codereview.chromium.org/577543002

Cr-Commit-Position: refs/heads/master@{#295011}

https://skia.googlesource.com/skia/+log/44162675ca4b790c2af0fbd9c41f262c8be26b05..df886ea06f0978e10695b482e658cf3daa9a1fc9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/570173004

Cr-Commit-Position: refs/heads/master@{#295010}

In RWHVA::SelectionBoundsChanged, there is a check
for anchor_rect x and y not being 0. Due to this, whenever
the cursor reaches 0 position (either left or top), it
triggers HideAndDisallowShowAutomatically.
This causes the insertion handle not to be shown on
scroll end. Restricting this condition to only check for
the origin minimizes the likelihood of the issue.

BUG=414020

Review URL: https://codereview.chromium.org/569003002

Cr-Commit-Position: refs/heads/master@{#295009}