- 22 Nov, 2019 40 commits
-
-
Daniel Hosseinian authored
Establish the deny list entries as enum string values. Rename the existing 'printing.printer_type_blacklist' to 'printing.printer_type_deny_list'. Previously, there was no part of the code that was able to set the pref; therefore, no migration code is necessary in the renaming. Follow-up of crrev.com/712342 Bug: 487875 Change-Id: I2fc8998772c36d752303c5abd62ea48b4fff6f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884287Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#718272}
-
Maksim Sisov authored
There is a possible race that results in a terminated gpu process. That is, a surface may have been destroyed right before a request that creates or commits buffers. To fix that, always create buffers anonymously aka not attached to any surfaces, and simply remove the pointer that the WaylandBufferManagerHost::Surface has to the WaylandWindow so that it does not try to do anything except the destruction of buffers, the call for which can come later from the GPU process. Bug: 1006813 Change-Id: I9f207ec8dac92b94a1e8f8b9fc9cd3fdb0186580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924247Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#718271}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/102af505dafe..8412598cca10 git log 102af505dafe..8412598cca10 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 dproy@chromium.org Add python inputs for tracing:generate_about_tracing Created with: gclient setdep -r src/third_party/catapult@8412598cca10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1025132 Tbr: oysteine@google.com Change-Id: I49eac51504449d7405e222b3154158aa6318e60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718270}
-
David Tseng authored
Before: File "/usr/local/google/home/dtseng/projects/chrome/src/third_party/chromevox/third_party/closure-library/closure/bin/build/depstree.py", line 56, in __init__ raise NamespaceNotFoundError(require, source) NamespaceNotFoundError: Namespace "cvox.AbstractEarcons" never provided. Required in <jsbundler.SourceWithPaths object at 0x7fcc566aa150> After: File "/usr/local/google/home/dtseng/projects/chrome/src/third_party/chromevox/third_party/closure-library/closure/bin/build/depstree.py", line 56, in __init__ raise NamespaceNotFoundError(require, source) NamespaceNotFoundError: Namespace "cvox.AbstractEarcons" never provided. Required in common/classic_earcons.js Issue: closure-library/closure/bin/build/depstree.py (part of Closure Library code) does: raise NamespaceNotFoundError(require, source) but |source| has no stringification that's friendly so you get the raw jsbundler.SourceWithPaths (which inherits from the Closure Library |Source| class). Fix by providing __str__ in the jsbundler.SourceWithPaths object (so we don't have to mod Closure Library). Change-Id: I72ca69869690661aabebc2b68843d7b2a8e6d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929915Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#718269}
-
Khushal authored
R=fserb@chromium.org Bug: 1018629 Change-Id: I8b552e92456bd8ee79e04f8f55e3c27a2d53e56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922305 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718268}
-
Jae Hoon Kim authored
The fix of multiple cycles of progress is at chromium:1926650. Bug: chromium:1026443 Test: ./out/Default/unit_tests --gtest_filter=DlcserviceClientTest.* Change-Id: I280d8c81041342feeb2a4701b689cae4922a5497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930470 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718267}
-
Ana Salazar authored
Report animation smoothness for the transition into the hotseat in the HomeLauncher. Bug: 1022178, 1022177 Change-Id: I5dc5e76688aa5a88bcabb5d688b419d819932867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917941 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718266}
-
Simon Que authored
Reverted due to "chromeos-*" builders not working with Goma RBE. See crbug.com/1027312 The new version of the CL has had the failing builders removed. ================================================ CI: - ChromiumOS ASAN Release - Libfuzzer Upload Chrome OS ASan - Linux Chromium OS ASan LSan Builder - Linux ChromiumOS Full - Linux ChromiumOS MSan Builder - Mojo ChromiumOS (remaining builders removed) Try: - linux_chromium_chromeos_asan_rel_ng - linux_chromium_chromeos_msan_rel_ng - linux_mojo_chromeos (remaining builders removed) Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413, 1027312 Change-Id: I8bca8bff1af888e5167bb16ebf275920ff2aa30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928386Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#718265}
-
Jonathan Backer authored
The use experience is largely the same, but it is very different from our crash reporting perspective. Lost context shutdowns are clean and don't show up as a crash report. They are treated similarly by GPU blacklisting. Bug: 1026872 Change-Id: I00559c7ef5276fe6c7c9aee832ff016a0a755156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929153 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718264}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff3bbb5d. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie5a2ae60d915b2a7aba393d6d9d08c367b0d7fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930342Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718263}
-
Aga Wronska authored
Using extracted color occasionally causes a11y problems: contrast between background and text is not sufficient (especially error view). New background color is a combination of extracted dark muted color and black. When in session blur is applied. Bug: 999390 Change-Id: Id805a359d76acb9e09ae1c0ad2c392de0d16523c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930107Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#718262}
-
Andrew Grieve authored
Bug: 1027514 Change-Id: I0c4cbb90fae9cc3eecbeeb8f0e8c36702cbcf60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931153 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718261}
-
Jasper Chapman-Black authored
An id_path in the Tiger viewer is either a source path or a source path prepended with some grouping information (a '>'-separated component like "Blink>JavaScript>Runtime", or a template name like "std::vector<>"). Previously these concatenations were constructed and allocated, which was extremely costly if the source path was very long. This change adds a lightweight GroupPath object, which is basically a pair of string_views with some utility methods for obtaining parent paths. This also cleans up a lot of thorny logic for path-parsing: now, source_paths are '/'-split, and the group can have a custom separator ('>' for "group by component", '/' for other/group-by-template, since we don't want to split on '>' characters in templates. Unfortunately, now that id_paths are stored as this lightweight GroupedPath object, TreeBuilder::Open(string path) can no longer do a hashmap lookup by id_path key. In hindsight we could have maintained a hashmap from GroupedPath -> TreeNode* and try all brute-force string-splits of the path passed to Open(), but what I did instead was split the input path into tokens and recurse down the tree looking for nodes with matching names. This regresses tree performance for nodes with many, many children, since tree traversal is doing a linear scan on each level. Definitely not worth addressing in this CL, though. Tests were added in a previous CL to ensure this change is safe. Change-Id: I377d880ca1b8861a88d54bc2a208824fb4b8fb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929533 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#718260}
-
Joshua Pawlicki authored
The downloader can have a retry loop up to 15 requests long, which is almost 36 hours long under the existing strategy. Bug: 899003 Change-Id: Ie585836154094f23e282ff700ad3bfa3dbd51ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922358 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718259}
-
Sergio Villar Senin authored
This CL removes NullValue() from ComputeCurrentTime by returning an Optional. Instead of NaN the method returns now a base::nullopt; Some NullValue() had to be temporarily added in order to limit the amount of required changes. They'll be all removed in a follow up patch that will remove the NullValue() from CurrentTimeInternal(). Bug: 737867 Change-Id: I767e2a24ad7a99a64353acbdd651733ee19c93a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928781Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#718258}
-
Victor Hsieh authored
TEST=calling the API from Tast, saw expected behavior BUG=chromium:893332 Change-Id: Ie44376a1c2e5817a863b359550d1f0eade6e8cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918301Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#718257}
-
evliu authored
Add metrics to track the percentage of VTT sheets that contain embedded style blocks. Bug: 1027239 Change-Id: I3bf549b3d10f7cede611861944536aa1082aff69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928201 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#718256}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe13ca3e67d3..189c98042f16 git log fe13ca3e67d3..189c98042f16 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 michaelludwig@google.com GrQuadPerEdgeAA::Tessellator owns GrVertexWriter Created with: gclient setdep -r src/third_party/skia@189c98042f16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I1597df17e3a7610bce1a3f40a7ec886695e0b474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928798Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718255}
-
Reilly Grant authored
Bug: 1007656 Change-Id: Ibbcb4c8987516f96294243e2a08ebc8c2287f1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924705 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718254}
-
Skipping betty presubmits for now. See crbug.com/1024929 for details. #CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome #CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641, 1024929 TBR=chrome-os-gardeners@google.com Change-Id: I399e3c810b015de581a44145e7ef8083a38d6106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930837 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718253}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=fserb@chromium.org Bug: 1023677 Change-Id: Ibb1d4e3306f0ea0749604ae6ba1d4bd94a0f86b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926816 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718252}
-
Brian Ho authored
WrapVulkanImageOpaqueFD was deprecated in an earlier CL [1] in favor of the new WrapVulkanImage API. Now that the Dawn CL has rolled into Chromium, this CL switches over the call in Chromium. [1] https://dawn-review.googlesource.com/c/dawn/+/13782 BUG=996470 Change-Id: I4b7438c01739ee0fa7fc1908324f6aab376bb581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931145 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718251}
-
Matt Falkenhagen authored
Bug: 1007797 Change-Id: Ic18cf3733c107d3f24f9089095bc27276395ee60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928387 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#718250}
-
James Forshaw authored
This CL adds a new histogram which records whether the APPID driver is running and by extension whether Applocker is running. This metric does not guarantee that Applocker is configured to enforce rules but its a suitable proxy as the driver is not enabled by default. Bug: 1008931 Change-Id: Ie39c2478a8ce0cbd930486c8500e37fe59197140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929650Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#718249}
-
Sergey Ulanov authored
The new test plays a short audio file and verifies that the page finishes playing it. Bug: 1027048 Change-Id: I58a83098812c0e1b280a7ead5fdc7579b827d368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928116Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718248}
-
Sujie Zhu authored
Currently can_fetch_unmask_details_ is resignaled only when refresh/success FIDO auth/success or cancel in CVC auth/after 3min timeout. So if user canceled in verify pending dialog (not reset the signal), and select one card again from the same tab, we won't fire any UnmaskDetail requests and wait for 3s timeout[1] (we do nothing in these 3 seconds), then call CreditCardAccessManager::Authenticate with FALSE (which will show CVC dialog). With this change, we will resignal the can_fetch_unmask_details_ when canceling the verify pending dialog so that user is allowed to fetch UnmaskDetail and try FIDO auth for the second time. Note that later the verify pending dialog will only show/clickable before/after OS dialog. If user cancel OS dialog, we will fall back to CVC automatically (which also reset the signal no matter success/cancel the CVC auth). [1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/credit_card_access_manager.cc?l=322-328&rcl=a797d14e1dc5964d7f5a307b6e6d65b4927e8c64 Bug: 949269 Change-Id: If7b11ac1f31e80e9a4789001856423c67dec1381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930108Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#718247}
-
Jasper Chapman-Black authored
Change-Id: I7b26a634d40becde771a86cd9c1e87484e521cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931154 Auto-Submit: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718246}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d03f9786558e..ea02a5d30e4f Created with: gclient setdep -r src-internal@ea02a5d30e4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I1c5602987770c1bf77dc7ea1d62b559ed68cf235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931114Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718245}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e01c847a7042..8b5853d4f91a git log e01c847a7042..8b5853d4f91a --date=short --no-merges --format='%ad %ae %s' 2019-11-22 cepheus@frii.com Fix #1987: Use large enough built-in buffer to hold vec4 of maxint-64. Created with: gclient setdep -r src/third_party/glslang/src@8b5853d4f91a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I455c6c0fe47bc099d05af02c6961cd491d0ea354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718244}
-
Yun Liu authored
Bug: 1026891 Change-Id: Ib4ab393a8bfc29e10133508d3989300cea449384 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931132Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#718243}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/540ababb6bee..f6eb890f4c9c git log 540ababb6bee..f6eb890f4c9c --date=short --no-merges --format='%ad %ae %s' 2019-11-22 enga@chromium.org Implement getBindGroupLayout 2019-11-22 enga@chromium.org Test TextureComponentType and TextureViewDimension compatibility 2019-11-22 cwallez@chromium.org Remove the concept of "native_methods" in the generators Created with: gclient setdep -r src/third_party/dawn@f6eb890f4c9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I5db1500b8e7e48568348ab93c37c9e1aab963630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718242}
-
evliu authored
Adding metrics to track how many users customize their caption settings. Bug: 1027183 Change-Id: I4c56b7fe83c793631b7d2849f80a93ca89fd7135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928893 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#718241}
-
Michael Spang authored
This is necessary on Linux targets unless you don't want keyboard support or only need support for a hardcoded US layout. Noticed because the CQ broke after building for ozone locally. This reduces the number of flags needed to build as the Linux Ozone builder does. Bug: 1026476 Change-Id: I77352c133b1f7552301b6e1f252d40a4f2c72106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925370Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718240}
-
Matt Mueller authored
Bug: 973650 Change-Id: I2582de3119a22fb32385ed8eb22d097a112d316c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925222Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718239}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=miu@chromium.org Bug: 1023677 Change-Id: I7768ea1e922ef354176a396e34928e57780ad68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927004Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Auto-Submit: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#718238}
-
Randy Rossi authored
The mouse events injected to webviews/castapps from flutter platform views need to be marked for touch accessibility. Bug: NONE Test: Manual display assistant downstream build Change-Id: Iacd04e17c4028079d56e832dd17e3b0273649219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925506Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718237}
-
Rob Buis authored
MathML is only supported when LayoutNG is enabled, so make the dependency between them clear. Bug: 6606 Change-Id: Ifcd1314c22d333a4e4ec584b231be14241ea304a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930800Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#718236}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b868861c3478..4c7db77e0185 git log b868861c3478..4c7db77e0185 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 xinyi.he@arm.com Vulkan: Set limitation on maxComputeWorkGroupCount Created with: gclient setdep -r src/third_party/angle@4c7db77e0185 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I8b93d6d92254dda08c7c8a97287117084c2abb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718235}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/258f61029f40..102af505dafe git log 258f61029f40..102af505dafe --date=short --no-merges --format='%ad %ae %s' 2019-11-22 mmenke@chromium.org netlog_viewer: Trim down cr.js and ui_webui_resources_js_util.js. Created with: gclient setdep -r src/third_party/catapult@102af505dafe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026294 Tbr: oysteine@google.com Change-Id: I0ff17be8f6e2c4c58f6905d81871574ca4d375e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718234}
-
Max Moroz authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/88ea42af73f4..dbd3825b3104 $ git log 88ea42af7..dbd3825b3 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 mmoroz Fix include path for FuzzedDataProvider. Created with: roll-dep src/third_party/icu TBR=inferno@chromium.org,metzman@chromium.org Change-Id: I96042cd235986682ee59dd82ac15bf203f2d4c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930466Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718233}
-