- 05 Jan, 2021 40 commits
-
-
Findit authored
This reverts commit 29ff7965. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840082 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI5ZmY3OTY1MmQ0YTRmMDIxNzc5ZjBlNGIyNDdkNTNiMjgxMDQzZGYM Sample Failed Build: https://ci.chromium.org/b/8858949956473740752 Sample Failed Step: ui_base_unittests Original change's description: > ime: Handle InsertTextCursorBehavior in InputMethodChromeOS. > > TextInputClients now support moving the cursor after committing some > text. This patch adds support for input engines to call the new API. > > There is a slight complication with multiple CommitText calls during > key event handling. Previously, when handling a key event, any calls > to CommitText will be coalesced together and executed once the key > event is handled. However, this coalescing logic doesn't handle > cursor movement. > > Add logic to handle cursor movement when coalescing commits by observing that > any sequence of CommitTexts with cursor movement can be implemented with two > separate CommitTexts. Note that this is a no-op change if the IME never uses > the new cursor movement parameter. > > Bug: 1155331 > Change-Id: I6c89ec1cde5624eca7bf0d5c803085f7d7803c71 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576067 > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840082} Change-Id: If06b84f85826520e8a65ebf908eba18ff7bd2428 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607068 Cr-Commit-Position: refs/heads/master@{#840114}
-
Tanmoy Mollik authored
This cl imports PrimaryAccountChangeEvent from c++ code to java code. Following cls will refactor IdentityManager.Observer.(onPrimaryAccountSet /Cleared) methods to onPrimaryAccountChanged method. That way signin code will be more consistent across all platforms. Bug: 1158855 Change-Id: I2c65e81a369540a9eadf85a9d1ba4c0c716853a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603747 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840113}
-
Stepan Khapugin authored
Fixes the bug which was caused by a mistake in a refactoring. Add a test to prevent regression. Fixed: 1151035 Change-Id: I9f3d00cfdd13321dd289a9944e155c76bc8b6524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600821 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840112}
-
Alice Wang authored
This CL adds a set of JUnit tests for the class ProfileDownloader. Bug: 1161437 Change-Id: Iead7068b730b5ca6c62b7edb8bf893aa7457e60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607108 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840111}
-
Stefan Zager authored
Instead, set contents_opaque directly on the cc::Layer. This makes it more straightforward to migrate the logic to PaintArtifactCompositor. Bug: 1069546 Change-Id: Ifa338b89bb2636b257b34e67e51c7a300c9e5754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607668 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840110}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609735837-54f15795beeae1e22004c8135cf818a537813adc.profdata to chrome-win64-master-1609821402-aadb54447d521b648e35bdaecfd53290f25cbd03.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibcbe9d799408b988b991977b25cca9783c1e591f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840109}
-
Nancy Wang authored
Modify GetSessionIdForRestoreFromWebContents to return session id for all browsers, because we need to save the window stack (z-order) for all browser windows. Modify web apps, and extension apps publishers to save app launch information for system web apps, and platform apps, because the browser session restore can't restore them. For all other apps, no matter opened in tab, or window, the browser session restore can restore them, so we don't need to save the app launch information, we only save the browser session id as the window id, to restore the browser windows, including window stack (z-order), snap, etc. The app ids for apps opened with browsers are saved as the chrome browser's app id, because there could be multiple apps opened as tabs in one browser, and we only need to save one browser window for them. There will be separate CL to handle the chrome browser saving and restoration. BUG=1146900 Change-Id: I9f6d6675a7f7a39bd361f911d1c5cd22e898817e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602038 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840108}
-
Alice Wang authored
This CL adds two render tests for account management view in child account mode when the sign-out option should be hidden. Bug: 1045525 Change-Id: I9e53396fe642c78eaa37dd04457cfcf72730109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597553Reviewed-by:
Victor Vianna (OOO 21/12-05/01) <victorvianna@google.com> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840107}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2949c359547c..e17fd0f0e9bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Idbf727e2cf4e2a023b076ed72f8f8eb393e2ad80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840106}
-
Alex Ilin authored
The profile customization bubble at the end of the sign-in flow allows the user to customize profile name and color. We show the bubble only if the user doesn't already have a synced theme color. We reuse the logic from ProfileCustomizationBubbleSyncController that is used for non-force sign-in profile creation flow. Bug: 1156096 Change-Id: Iae9d84e7f4ca5ca415058023e0b23b1260d96542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603297Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840105}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id04cf297760f30a961d72c30be40bf92c32c6cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610617Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d00a5cd12448..a46fbf8fc541 2021-01-05 patrick.brosset@microsoft.com Set expander icon size in pixels If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1161662 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iebb8acaa6bf34df7c72cd6f4e919d207f4c07db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609873Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/76bebd29..53386e30 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc64c5434ca885a4bf09b38acf97c0c5f2096839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840102}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc1733482433..84cad4eea312 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2b97965af15e150026283b1ae66a2126472c28f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608640Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/92d8ee9b37c0..b54debc350a1 2021-01-05 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-05T04:04:14). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6ba5351b03aa612adb6daf13bd135a77a8b90575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610616Reviewed-by:
-
Peter Marshall authored
Bug: 1046784 Change-Id: Ic0cb2266159d5f6395130555a736fdff1846c26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610597 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#840099}
-
Alex Ilin authored
With the profile picker experiment, the user might get a color theme even if they never interacted with the color picker. This CL adds a new "ChromeColors.ColorApplied" histogram that shows how often users interact with the color picker. Bug: 1063856 Change-Id: I2973199fddf57bedf283bb70f69597ea836d24b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593126Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840098}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f5c581d3b04..2c541cdf0089 2021-01-05 wenbinzhang@google.com [benchmarking] Add android-Pixel-4a as expectation tag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC matthewdeluca@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1162969 Tbr: matthewdeluca@google.com Change-Id: Ic881f223bee50aa425465f83d9420652c19288f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610614Reviewed-by:
-
Alice Wang authored
This CL refactors the method in SigninHelper that is responsible of signing out and then signing in. Bug: 1152460 Change-Id: I37674d6ac5af344c313b743795411e0cca2e5358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606349Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2207edd88cfe..df49e6927b43 2021-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b627347a to 46171be2 (71 revisions) 2021-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bf02c31bec07 to 026a067c38ef (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I29a79e44977fb27b0756c82f6a7421e00a551682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610612Reviewed-by:
-
Victor Costan authored
This CL removes the "using" statements in the implementation (the QuotaClient statement was not used) and avoids some reference churn in the QuotaManagerHost constructor. Bug: 1016065 Change-Id: I9c5f75e9b60c738013a1b49b37eb46ae2e40b651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610484 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840094}
-
Austin Tankiang authored
Tests expect this flag to be disabled, so this change ensures that, and allows the flag to be used in a field trial testing configuration. Bug: 1067346 Change-Id: I403ad113042de65f4ae7c9e888ce94124f7788f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610410Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#840093}
-
Alice Wang authored
This CL removes the methods added to ProfileDownloader in 2014 but are not used anywhere. Bug: 1151860 Change-Id: Ia296fcf6c72dbb1451d14779aee4faa5a66ede61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603851Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ic2a74d372469970d149bca1b2fa18385a15223e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610684Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840091}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4110684aa07a..c120b02dbe14 2021-01-05 hao.x.li@intel.com Remove internal resolve buffer from Timestamp compute shader 2021-01-05 hao.x.li@intel.com Get timestamp period from device If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I1cfe252415c181bb6f226b08e4247539be19be5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610607Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc1733482433..84cad4eea312 2021-01-05 rsavitski@google.com Merge "Move using declaration into anon namespace." 2021-01-05 rsavitski@google.com Merge "Update stale link." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie3f61a6e0ff2be7e2018d17a8a338ae8e7831381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610610Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609804351-3203bece27fc3ccf79be3681f60781e79b3a670b.profdata to chrome-mac-master-1609821402-1a521f5068c0d6782637fa5e747428dbb99c8286.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5962672e6964fb04494a173f8ad9d1918740597a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610609Reviewed-by:
-
Victor Costan authored
Change-Id: Ie8b1bf20fe9994693d4fefd75aed5d68b9a889cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610050Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840087}
-
Mitsuru Oshima authored
Bug: None AX-Relnotes: n/a Change-Id: I92b3aa0070dcdf9b229315046c0b9a0c99a5519c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588835Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Kuo-Hsin Yang <vovoy@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#840086}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609804351-8e613a6255234d0544dc8b2f463c1386e923a27d.profdata to chrome-linux-master-1609821402-4ffa353dbb439d0e8adf0e53cbe86a4c4b758321.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I383b44089afb35a18908c94f8cb996c6801ae022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610605Reviewed-by:
-
chrome://internals/web-appAlan Cutter authored
Change-Id: I19946e78dd3cdc03d4f5991e9aba24f9c6e8167f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610406 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840084}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d7f897b22c2..d00a5cd12448 2021-01-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3e4b9e01bcb151415457ac9c58ebcb0f9046ff6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610338Reviewed-by:
-
Darren Shen authored
TextInputClients now support moving the cursor after committing some text. This patch adds support for input engines to call the new API. There is a slight complication with multiple CommitText calls during key event handling. Previously, when handling a key event, any calls to CommitText will be coalesced together and executed once the key event is handled. However, this coalescing logic doesn't handle cursor movement. Add logic to handle cursor movement when coalescing commits by observing that any sequence of CommitTexts with cursor movement can be implemented with two separate CommitTexts. Note that this is a no-op change if the IME never uses the new cursor movement parameter. Bug: 1155331 Change-Id: I6c89ec1cde5624eca7bf0d5c803085f7d7803c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576067Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#840082}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1497e56c0f3e..2949c359547c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com Change-Id: Id06b24034548cd30a60bda49c57c1edf098fc3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610487Reviewed-by:
-
Nazerke authored
Using |useIncognitoFallback| from the previous change to modify the background image for incognito for iOS12 and less. On iOS 13 there is no need to pick custom incognito assets because |overrideUserInterfaceStyle| is set to dark mode when in incognito. Bug: 1128249 Change-Id: I81e5b6e593766f01037ac6afda8e21986318ef81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596258Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#840080}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8ac69d2..76bebd29 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I716ac4fd5478f40445e8267111035e4ebf02f775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610336Reviewed-by:
-
Nancy Wang authored
BUG=1146900 Change-Id: I31a1b5961cb91c3c5316c69cc75db1f4e51847d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596485 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iebadf4314a5b2df15e5c1e14d96423a7e883bbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610337Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840077}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04ccda6c28c4..2207edd88cfe 2021-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 86980018b3f2 to cdbd295cc6c4 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I1f07b6d58bde3ef83f9f41fab8e4915bb63ffe0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610467Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f424e015364..1497e56c0f3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com Change-Id: I784e2eddf590adbd264923143ef8ad9776ec29ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610148Reviewed-by:
-
