- 28 Sep, 2017 23 commits
-
-
Hiroki Nakagawa authored
This CL upstreams http/tests/worklet to external/wpt/worklets on the WPT repository. Bug: 724907 Change-Id: I0928ea9bd7f615b84cf138a8682816c68a779ed5 Reviewed-on: https://chromium-review.googlesource.com/683714Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#504833}
-
Walter Korman authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I369c6e70116992f61ebc168b5cfad98a8a74168f Reviewed-on: https://chromium-review.googlesource.com/687820Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504832}
-
Xianzhu Wang authored
This ensures repaint of the column rules which will be painted differently for different actual column count. Bug: 764213 Change-Id: Ia4c2d2ec847ba851f05e02cf2f9ac7a44d397dea Reviewed-on: https://chromium-review.googlesource.com/688480Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504831}
-
Tom Anderson authored
This CL: * Fixes the broken symlink. * Adds a check to ensure symlinks are valid. R=thestig@chromium.org BUG=768020 Change-Id: I98060b989b7723179128ccd9ee3b971638be83a7 Reviewed-on: https://chromium-review.googlesource.com/688489Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504830}
-
danakj authored
Since all resources created with ResourceProvider are now immutable, we have no need for the texture hint to request immutability. So remove the hint, and make the DEFAULT behaviour create immutable resources whenever the context supports it for the format. All clients of ResourceProvider will need to assume resources are always immutable. Add some class-level documentation on ResourceProvider to mention this. R=piman@chromium.org Bug: 768976 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I75f98f8225cbde1a38910e3319c641a3a4fb2db6 Reviewed-on: https://chromium-review.googlesource.com/688098Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#504829}
-
Karan Thakkar authored
This change fixes a typo in the DOM Domain devtools protocol doc for `getSearchResults` method: sarch -> search Change-Id: I2b98550a1f955064c56afa80f4356f1d79b8597f Reviewed-on: https://chromium-review.googlesource.com/646806Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#504828}
-
Yue Li authored
Check whether the user is supervised when choosing the search page title in CrOS settings. Do not use the version contains voice interaction if the user is supervised. BUG=b/66913130 Change-Id: Ie631f7e476959f7ce315a627d13c13dca1ffbfd7 Reviewed-on: https://chromium-review.googlesource.com/686040Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#504827}
-
dpapad authored
- Restore 16px left/right padding. - Make progress bar visible again. Bug: 766046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c9f3a6ca5117b0c7ed12ccd0cb9b2c7eae10c58 Reviewed-on: https://chromium-review.googlesource.com/685363Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#504826}
-
David Grogan authored
Most layout objects that have a writing mode orthogonal to their parents are laid out early so that the parents can know the children's widths before computing their own preferred widths. (https://crbug.com/550963) But table parts can't be laid out on their own, only in the context of their table ancestor. Bug: 719211 Change-Id: Ia2a56127c6d4e6c0239324a478cb664ceeed0e30 Reviewed-on: https://chromium-review.googlesource.com/685900Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504825}
-
Nick Carter authored
some of the tricky cases for ReplaceSubstringsAfterOffsets. These tests uncovered a correctness bug involving a sorted vector, which is also fixed. Bug: None Change-Id: Ic96d709e70732705e7bf3be9655e5427bdfe396f Reviewed-on: https://chromium-review.googlesource.com/648215Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#504824}
-
Yuwei Huang authored
Currently MaterialComponents hasn't implemented the pull-to-refresh functionality, but internally we do have a component to provide Googlewide conforming pull-to-refresh UX. This CL: * Creates a RefreshControlProvider framework for providing pull-to- refresh UI depending on the app variant. * Provides the Chromium implementation, i.e. using the standard UIRefreshControl, the flower-like spinning wheel. * Modifies other code to use RefreshControlProviderand cleans up the old refresh button. Once MaterialComponents implements the pull-to-refresh component, we could start using it and get rid of the RefreshControlProvider. Bug: 768480 Change-Id: Ibfc519a5df620f0ecf7dd6250f726c9a0efa096a Reviewed-on: https://chromium-review.googlesource.com/680115Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#504823}
-
spqchan authored
Currently, when the Extension Installed bubble is closed, the BubbleManager is not informed about its closed status and would still hold on to it. This causes a crash in Mac when a relayout causes the BubbleManager to update all of its bubbles. This CL acts as a stopgap to this problem by having Extension Installed bubble to call back to BubbleController, which will then update the BubbleManager with the bubble's close status. Note: The ideal solution is to get rid of BubbleManager since it's an aborted project that needs to be deleted. Bug: 763064 Change-Id: I53bd2691e1e62a6df8b53876a6a4d228fe071064 Reviewed-on: https://chromium-review.googlesource.com/671638 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#504822}
-
Jay Civelli authored
Removing net/proxy/proxy_service_v8 which is unused. Bug: None Change-Id: I540e79f91ad8ba3315b2fee483ec57042a39a08e Reviewed-on: https://chromium-review.googlesource.com/687987Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#504821}
-
MinChen authored
Changes, 1. Show the wallpaper setting row only for login, whitelist types and active users (should satisfy the whole conditions at the same time). 2. Only can open the wallpaper manager if the wallpaper is not policy controlled. 3. Added wallpaper policy indicator. Show it if the wallpaper is policy controlled. Bug: 749755,768319 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I07ffb372bf511411188b847c969cdc2341658bfa Reviewed-on: https://chromium-review.googlesource.com/683221Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#504820}
-
Luis Hector Chavez authored
This change migrates all the ARC Mojo interfaces to use OnceCallback. Bug: 714018 Test: git cl try Change-Id: I44cd6ef8d6f708231bdd92694fce408674672000 Reviewed-on: https://chromium-review.googlesource.com/683225 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Owen Lin <owenlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504819}
-
Weidong Guo authored
Changes: 1. Enable arrow key focus handling in FocusManager. 2. Handle arrow up/down in SearchBoxView to move focus to the first/last focusable element in ContentsView. 3. Handle arrow up/down in AppsGridView. AppsGridView has three states: Peeking, Fullscreen all apps (outside folder) and Fullscreen all apps (inside folder). Do separate handling for them, since they have different layout. Design Doc: go/applist-focus BUG=766810 TEST=AppListViewFocusTest.* Change-Id: I2ace4b3b21a69f10011eba2ed0079e1f7aee48d0 Reviewed-on: https://chromium-review.googlesource.com/687818 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504818}
-
Mathieu Perreault authored
Previously, all card save dialogs under the new UI would have the logo. The logo should only apply to server card uploads, not local saves. Bug: 736944, 768951 Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056 Reviewed-on: https://chromium-review.googlesource.com/685503Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#504817}
-
Yuwei Huang authored
This CL finishes up the fullscreen control UI. It is a transparent-black circular button with a close (X) icon on the middle. It is used both as an indicator for exiting fullscreen when the keyboard lock reserves the ESC key and an actual button to exit fullscreen for touch devices. This CL also implements a FullscreenControlPopup class to show the indicator with a dropdown animation in replacement of the DropdownBarHost implementation. This is the UX spec (Google internal): https://docs.google.com/presentation/d/11D86S87NZK5sAMLhc8WSV9pk_VWkjMAjvnN08uUD5po/edit#slide=id.g23756e43b7_3_0 Bug: 758456 Change-Id: I44dc2d0944386f5f6f5e607831c5ea4e38364357 Reviewed-on: https://chromium-review.googlesource.com/647950 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#504816}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/408b8e44..7c5095aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I3d37fe7c10f4ff01faf9ebda7a3e8f8eebc0fd80 Reviewed-on: https://chromium-review.googlesource.com/688415Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#504815}
-
Sammie Quon authored
name members. It seems some subclass of actionable_view which use SetAccessibleName actually use button's impl of SetAccessibleName which then leaves |accessible_name_| empty in actionable_view, so ChromeVox will then not read anything. There is at least one instance which occurs in system tray, the audio settings button (the other actionable_views are not affected because they have their own GetAVXNodeData impl's). This cl removes SetAccessibleName and accessible_name_ from subclasses of Button. These classes will just use Button::SetAccessibleName and Button::accessible_name() instead. Test: manual Bug: 747469 Change-Id: I03bde6e90ed3b22321585eccccb4cc2c32e5b5ef Reviewed-on: https://chromium-review.googlesource.com/678061 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504814}
-
Eric Caruso authored
Rearrange the loop so that we can use continue to go to the next file. Also factor the copying bits of CopyFile so that CopyDirectory can use them with files that are already open, so it can open/fstat the files itself and be resilient to time-of-check/time-of-use attacks (such as the attacker replacing a file that was just stated but not yet opened with a pipe that it will block reading from). Bug: 767138 Test: existing + new unit tests Change-Id: I0c2164b0165850834323d860d1d390ac895737e9 Reviewed-on: https://chromium-review.googlesource.com/677563 Commit-Queue: Eric Caruso <ejcaruso@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504813}
-
Tomasz Mikolajewski authored
Crossfading recreates the layers and fades out the old ones over the new ones. However, when frame sinks are used, the layers still share the same frame sink and surface id. Drawing to the new layer would draw to the old layer too, making both layers equal. This CL fixes this problem by forcing creating a new surface id for the new layers. TEST=Not used yet. Restoring/maximizing existing windows doesn't regress. BUG=b/29406058 Change-Id: I1cc8546a4c0935d55db4d2a5ae8b16b95041d1af Reviewed-on: https://chromium-review.googlesource.com/647347Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504812}
-
Xida Chen authored
This reverts commit a240cac3. Reason for revert: <INSERT REASONING HERE> Cause build failure: https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux/builds/4848 Original change's description: > New NTLMv2 Implementation. > > - Supports NTLMv2 with Extended Protection for Authentication (EPA) > and Message Integrity Check (MIC). > - Adds required methods to buffer reader/writers to support NTLMv2 > - Adds optional version/mic fields to all messages > - Removes protocol level tests from HttpAuthHandlerNtlmPortableTest. > A previous CL already implemented all those tests directly against > NtlmClient. The tests at that level only existed to validate that > the behavior of the old and new implementation were the same. > - Future CL updates fuzzer to support v2. > - This CL does not activate NTLMv2. The code still defaults to NTLMv1. > > BUG=chromium:22532 > > Change-Id: I5b6dcbf6cdcf8f671008f60ae49c9bacb4e1d2f3 > Reviewed-on: https://chromium-review.googlesource.com/608620 > Commit-Queue: Zentaro Kavanagh <zentaro@google.com> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504808} TBR=rsleevi@chromium.org,zentaro@google.com,asanka@chromium.org Change-Id: Ie6fead019bc26fa2394ba50d19f7c4e10772e566 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:22532 Reviewed-on: https://chromium-review.googlesource.com/688800Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504811}
-
- 27 Sep, 2017 17 commits
-
-
Tom Sepez authored
Bug: 708738 Change-Id: If649a9eb073f63fb5ccff0cdc1226faa27334644 Reviewed-on: https://chromium-review.googlesource.com/685279Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504810}
-
Prashant Malani authored
This patch updates the midis.mojom file with struct definitions and interface functions to pass device information to the ARC client, as well as to request midis for port FDs for subdevices, and to close all client connections to a particular device. BUG=chromium:701005 Change-Id: Id9daeeb36b6c7328b5b332420d3afd163a3b48b5 Reviewed-on: https://chromium-review.googlesource.com/685261Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Prashant Malani <pmalani@google.com> Cr-Commit-Position: refs/heads/master@{#504809}
-
Zentaro Kavanagh authored
- Supports NTLMv2 with Extended Protection for Authentication (EPA) and Message Integrity Check (MIC). - Adds required methods to buffer reader/writers to support NTLMv2 - Adds optional version/mic fields to all messages - Removes protocol level tests from HttpAuthHandlerNtlmPortableTest. A previous CL already implemented all those tests directly against NtlmClient. The tests at that level only existed to validate that the behavior of the old and new implementation were the same. - Future CL updates fuzzer to support v2. - This CL does not activate NTLMv2. The code still defaults to NTLMv1. BUG=chromium:22532 Change-Id: I5b6dcbf6cdcf8f671008f60ae49c9bacb4e1d2f3 Reviewed-on: https://chromium-review.googlesource.com/608620 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#504808}
-
Brian White authored
If "accessibility" is enabled then a pointer to the WebContents- AccessibilityAndroid object is held by an BrowserAccessibility- ManagerAndroid object leaving it dangling if the former is destructed. During destruction of the WCAA object, remove any reference to itself from the BAMA object. Bug: 736675, 727210 Change-Id: I67050e7708abbdfe396a0571bc515a5bda88dcbe Reviewed-on: https://chromium-review.googlesource.com/688035 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#504807}
-
Charles Reis authored
The name is already available from the FrameTreeNode and does not need to be sent up to the browser at commit time. BUG=766262 TEST=No behavior change Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5f9bc8acd50c868b84514f2ae240b5640ff56a83 Reviewed-on: https://chromium-review.googlesource.com/686174Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Reis (catching up) <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#504806}
-
Ted Choc authored
Ensures that any selection state set while the omnibox was focused does not remain after it gets defocused. BUG=769229 Change-Id: I5a674bd2c0b9582f158213559da6a5176ab431cd Reviewed-on: https://chromium-review.googlesource.com/688679Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#504805}
-
Nate Fischer authored
This adds @RetryOnFailure to a flaky Safe Browsing test. This does not flake very often. Bug: 765932 Change-Id: Ic7bc40863d395b76c821ee9c277b17d82e5c5ff4 Reviewed-on: https://chromium-review.googlesource.com/688676 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504804}
-
Lucas Garron authored
Update NavigationThrottle::CancelDeferredNavigation() comment to specifically refer to the ThrottleCheckResult's action. Bug: 762430 Change-Id: Ieaea62732d604ca56fb3cdb97e96a4ac98e76f15 Reviewed-on: https://chromium-review.googlesource.com/686102Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#504803}
-
Xiaochu Liu authored
Instead of downloading container at browser start, we now have a dbus API to download container at any time. BUG=chromium:768009 TEST=manual Change-Id: I00f57024b27e4dc8ad2ba44f7ed7cbb5e374afbc Reviewed-on: https://chromium-review.googlesource.com/688055 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#504802}
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Change-Id: I55a8e2c3f37c5b7c28ba8dea4543c8162bebde3a Reviewed-on: https://chromium-review.googlesource.com/688158 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#504801}
-
Mike Wasserman authored
Make Chrome shelf item context menus open items on the right display. Use a ScopedRootWindowForNewWindows when executing commands in cash. (we'll need another fix for mash, but my first attempt didn't work) Fixes the defect when using --ash-enable-shelf-model-synchronization. Nix the ShelfView codepath that only matches the local menu lifetime. (ShelfModel Sync handles the menu command execution async/remotely) Bug: 768908 Test: Chrome opens on the same display as the shelf item [context menu]. Change-Id: If8c812c892c4c628e9c012ea9e9cd75461d3b71a Reviewed-on: https://chromium-review.googlesource.com/688108Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#504800}
-
Yuke Liao authored
Force layout should happen after load html. This is only a speculative fix of the flake on iPhone 7 iOS 11 devices as I couldn't reproduce the failure locally. Bug: Change-Id: I1c76c7e7ea47d798b125d15ddc2d4f79bc7653c6 Reviewed-on: https://chromium-review.googlesource.com/688634Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#504799}
-
Will Chen authored
I've inlined the handful of tests that used the output API call, which is removed from the new test framework (it was confusing and not available in the new world) Bug: 667560 Change-Id: Ie188797bffe7253ed90dc5ee2ca90c41b495d0e2 Reviewed-on: https://chromium-review.googlesource.com/667805 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504798}
-
Sammie Quon authored
ChromeVox will read .. literally as two dots. Just use the one period from the .grd file string. Test: manual Bug: 747470 Change-Id: Ia5bc2c0a345f1a5b84f4d26bf0141d565f2d1207 Reviewed-on: https://chromium-review.googlesource.com/677567Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#504797}
-
Yuke Liao authored
Test is failing on ipad devices. Bug: 769464 Change-Id: I9b04bb15b5bdb30afa0aa5a484e4eb25eaeea6de Reviewed-on: https://chromium-review.googlesource.com/688500Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#504796}
-
James Cook authored
For go/mustash we need to eliminate in-process ash to chrome delegates. Eliminate the concept from ash, in favor of checking whether multiple users are signed in or whether more users can be added to the session. Rename the chrome method to make it clearer that it's not just a feature that can be enabled or disabled. Eliminate dead code to support initializing the system tray menu for ephemeral users. See issue 312324 for details. Change InactiveUserNotificationBlocker to only block notifications when multiple users are in the session. This is mostly needed to prevent notifications from being blocked in AshTestBase tests but also more closely matches what we want in production. Bug: 312324, 665064 Test: ash_unittests, unit_tests, manually check system tray menu with ephemeral users and with multi-profile, manually test notification blocking for inactive users with http://jsfiddle.net/qjme9dmd/ Change-Id: Ib1c0bcd5da3f9e9c32641b29e95385e696cc415a Reviewed-on: https://chromium-review.googlesource.com/685823 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504795}
-
Scott Violet authored
Doing this for same reason as patchset: https://chromium-review.googlesource.com/c/chromium/src/+/685306 BUG=763529 TEST=none Change-Id: Ifb175f0ce95c04ad34ddfe49cb01765a4e2e30e9 Reviewed-on: https://chromium-review.googlesource.com/687888Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#504794}
-