- 21 Nov, 2019 40 commits
-
-
Hajime Hoshi authored
|disabled_reasons_| should live as long as the frame lives. This CL lets a render frame have |disabled_reasons_|, and record them when frames are swapped or eviction happens. Bug: 1004676 Change-Id: I57b8738df3889846d892ba72900a0d046ebe04f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849612 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717565}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kolos@chromium.org Bug: 1023677 Change-Id: I3c0c4c0da9cd006dea3c80fe0c5bde12dc3e5caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927006 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#717564}
-
Koji Ishii authored
Following bot results are included. 325 327 329 330 331 333 334 340 342 343 344 346 348 352 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I0355b2e2db2e003b2a204aef0db8d496c9316206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923779Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#717563}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Id95f207e11baf222b809a9806b2caeb77f97bcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928371Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#717562}
-
Kenichi Ishibashi authored
This is a preparation for moving ServiceWorkerDatabase into the storage service. ServiceWorkerDatabase depends on some simple structs, enums and constants. These don't have complex dependencies but are defined in mojom files which also contain other interfaces which have complex dependencies. Put direct dependencies of ServiceWorkerDatabase in separate mojom files to make it easier to move ServiceWorkerDatabase into the storage service. The plan is similar to crrev.com/c/1920008. In follow-up CLs, we would add a separate mojom target which contains direct dependencies of ServiceWorkerDatabase (in general, storage serivice). Bug: 1016064 Tbr: lazyboy@chromium.org Change-Id: Ifba7a5e10b81a8607b28754c237ab4266455fd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928092 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#717561}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=rsorokin@chromium.org Bug: 1023677 Change-Id: I1ea6defcfd6a41ebdb3a89e3078a8b6448aae321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927016 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717560}
-
Fredrik Söderquist authored
The |id_| field is always set to 0 (zero) and never accessed. |image_url_| is only used in the constructor and then never accessed. Change-Id: If80d39d3a4318df14ddccb9c16d56bc23642d49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926135Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#717559}
-
sandromaggi authored
Make the touch target 48x48 for a11y. Make the icon and poodle 32x32 to fit the Assistant design spec. Change alignment of elements in header. Before: https://screenshot.googleplex.com/PpW7rjVyNz5 After: https://screenshot.googleplex.com/O8yg4ZTjth1 These changes have been viewed and accepted by UX. Note that the poodle change is not in this CL but has to be done in a different CL. State without poodle change: https://screenshot.googleplex.com/6ys5nL8Jdja Bug: b/144332468 Change-Id: I0324bdb9054d1518ffd9ba9c00b8e0021bbc0e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911749 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#717558}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1023677 Change-Id: I45cdc2bf680f2afd0ea5dfc8b2411bb20593b831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924801 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#717557}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=grt@chromium.org Bug: 1023677 Change-Id: Iecb73bedae1c12c720687ff4bdd43cad7787409b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926910 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717556}
-
Rune Lillesveen authored
When checking if we were outside the flat tree for the style recalc root update, we checked the computed style of the common ancestor instead of the parent element. That lead to a recalc root outside the flat tree which in turn left us with a dirty tree after the lifecycle update. Bug: 1023205 Change-Id: I8687adb6740bf988e4466b783b87b3b8ba3b4ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927811Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#717555}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: If43685ed5d417243b6fd014f25811da574d703b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926850 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717554}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: I5e541cfbd7d200e7e57b9391f2ce1bd13a211e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927047 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717553}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: I742a5ba4d7aad3ad9b654c1f1a1179b890cabebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926819 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717552}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Ia88b463a8685014a22d65c9e0132cb528e4242bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921603Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#717551}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: I1ea903063c171fc143ad483696cfaaaef473d03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927007 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717550}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL makes ServiceWorkerProviderHost take running hosted service worker version as a constructor argument, and calculate |url_|, |site_for_cookies_|, and |top_frame_origin_| in the constructor. This change simplifies getters of these fields, and makes it easier to move them to ServiceWorkerContainerHost. Bug: 931087 Change-Id: Ic14d2af2f57a54344f9998245ae530331532be67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928109Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#717549}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 1023677 Change-Id: Ibaace0daf144250455ce45975cf508a8ad7c4b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926946 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#717548}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=grt@chromium.org Bug: 1023677 Change-Id: I878aae6b13b99aa85f1c10a96822273b8b4f5fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926912 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717547}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 1023677 Change-Id: I7b369565a3b50f81e329c8ef8adb8df727991a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926875 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#717546}
-
Marcin authored
CL is providing necessary changes to scripts to allow them installing necessary libs for building Android version. Change-Id: If93bc950fa5a2c51bc2668cd59f5d12af23cf872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924468Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#717545}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b3b17304bf8..b4f854080375 git log 2b3b17304bf8..b4f854080375 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 99bd10b70422..b8e748be6b94 (17 commits) 2019-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 0db96f99..137e8082 (617 commits) Created with: gclient setdep -r src/third_party/skia@b4f854080375 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: chromium:None,chromium:None Change-Id: I1f6326e0d068b75e187778ccc2dfdf392e84631c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717544}
-
Yoshifumi Inoue authored
This patch changes |NGInlineItemsBuilder::AppendTextReusing()| to restore trailing collapsible space in resuing item from non-collapsible text, e.g. white-space:pre, for correct white space collapsing. Bug: 1021677 Change-Id: Ifa89f379d24db5f2d5bb1d57df2c180e3e33396f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924344 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#717543}
-
Mirko Bonadei authored
Since the component build is finally completed, it is possible to cleanup webrtc_overrides a bit. This CL removes 2 unneeded targets. Bug: 896154 Change-Id: I29659ddf7d4a0659fbe53e8efa912dd9184baf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926950 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#717542}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/604d935d2770..26c7fb61a9db git log 604d935d2770..26c7fb61a9db --date=short --no-merges --format='%ad %ae %s' 2019-11-21 vapier@chromium.org cros_build_lib.run: replace log_stdout_to_file=X with stdout=X Created with: gclient setdep -r src/third_party/chromite@26c7fb61a9db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib08fc0e96134113cb8c95e1bbc938c0cf08961c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717541}
-
Yoshifumi Inoue authored
This patch makes |LayoutText::InvalidateDisplayItemClients()| to utilize |NGInlineCursor| for prepration of migrating to |NGFragmentItem|. This patch also introduces |NGInlineCursor::CurrentDisplayItem()|. Bug: 982194 Change-Id: I13308b9b68f00038d934a7936d41dd8a7cd2fe68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911348 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#717540}
-
Noel Gordon authored
Current FilesApp uses the files16 icon-set, the files-ng version will use the files20 icon-set, in the directory tree. Add a control variable to ease switching between these icon-set, make the tree row .align-right-icon use the active icon-set. No change in behavior, no new tests. Bug: 992819 Change-Id: I3187e961c43c10021b6b83a8f1412b6ec1d0be15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927431 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#717539}
-
Dana Fried authored
Follow-up work after causing view visibility to invalidate layouts. There were two issues: - Some layout managers were not using SetViewVisibility() which is designed to be safe to the new logic and prevents loops. - A view's visibility being re-set to the same value by non-layout code as a result of something that happens during layout, causing another layout an an infinite layout loop. This CL fixes both of the issues. Bug: 1025196 Change-Id: Ib378c28381802d29128cc99653e94fd1f3186d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926945 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#717538}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/98ba76af00d4..4d15609d269e git log 98ba76af00d4..4d15609d269e --date=short --no-merges --format='%ad %ae %s' 2019-11-21 enga@chromium.org Add a toggle to disable Dawn validation Created with: gclient setdep -r src/third_party/dawn@4d15609d269e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I1644892cb39bd7af5282e10dbe5d13624b41fe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717537}
-
Etienne Bergeron authored
This CL is changing the way |layout_text_| is computed. The layout text was recomputed at each text modification. This can cause lot of string copy with a sequence of text append. Example: RenderText render_text; render_text->Append("a"); render_text->Append("b"); render_text->Append("c"); Previously, each call to Append(...) was triggering OnTextAttributeChanged(...) and was causing a whole string copy/rewrite from |text_| to |layout_text_|. The current CL is adding a flag to mark the |layout_text_| as dirty and the layout text is computed on-demand. Bug: 1025561 Change-Id: I185a55cf57d11982c6f80701c904e28886e00c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925950 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#717536}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d502e6ae28d..f2843e0643c5 Created with: gclient setdep -r src-internal@f2843e0643c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iaebcf00a776554340fcd647f124a1d1b9995b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928218Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717535}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=phoglund@chromium.org Bug: 1023677 Change-Id: Ib80453fc3e597cda035157207057512dd6e49128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926878 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#717534}
-
Etienne Bergeron authored
This CL is changing the StyleIterator class. 1) Avoid breaklists copy It is no longer copying the BreakList. Instead, pointers to the original breaklist is kept. 2) Avoid vector scanning The call to UpdatePosition(...) is calling GetBreak(...) which is doing a scan on the vector to find the appropriate position. This scan is overkill since the StyleIterator is moving forward and the break iterator too. This CL replace UpdatePosition(...) by IncrementToPosition(...) which is moving forward break iterator to the right position. Bug: 1025561 Change-Id: I9beac512498af6da991dfba05f66d46b62304b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924618 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#717533}
-
Maggie Chen authored
LoadLibrary() may take long time to fininsh. When the system hard drive is busy, prolonged LoadLibrary triggers the GPU watchdog and the GPU process is killed for a restart. This actually doesn't help anything in a busy system. To prevent this, the GPU watchdog is paused in this situation and resumed later. Bug: 988344 Change-Id: I8baec05f0dccfe68941f542ab9dbbb05ea8d4193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927296Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#717532}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4e0255508749..2b3b17304bf8 git log 4e0255508749..2b3b17304bf8 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7e11f46ddf8e..f2c9ce1e08ed (9 commits) Created with: gclient setdep -r src/third_party/skia@2b3b17304bf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: chromium:None Change-Id: I191f66988e1c591543581a35f5ab6457a41bb518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717531}
-
Alex Danilo authored
CL:1928456 changed the functionality for screen readers for summary panels. Add test to check the correct role attribute setting is made. Bug: 1026501 Tests: browser_test --gtest_filter="*FilesDisplayPanel" Change-Id: I25012e8230f026d32b580a4a84b8c8f21f90d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928102Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#717530}
-
Joel Hockey authored
GetTerminalId will return the old terminal ID, or the new Terminal System App ID if the feature is on. Bug: 1019021 Change-Id: Iee4f3853c746bbe79ad32a05870712418e4c400d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924177 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#717529}
-
nancy authored
Update the pause dialog shown condition: 1. If the app is not running, don't show the pause dialog. 2. Family Link v1 supports Web Apps only. If the Web Apps is opened with browser tabs, don't show the pause dialog. Otherwise, e.g. ARC apps, or Web Apps opened with window, show the pause dialog. The interface ExtensionApps::ShowPauseAppDialog is set as a static, so that Family Link can use that to check whether the app is opened with browser or window. For the Family Link phase 2, the final goal is we support all types of apps, and we should show the pause dialog for all the running apps. Add the interface 'GetWindows' in InstanceRegistry to dump the windows for the app id. It will be used by other functions as well, e.g. close windows when the app is uninstalled, or update windows, when the app is updated. BUG=1011235 Change-Id: I8ec454262d87c5a4350c244fcb9fb67a8b204f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916531 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#717528}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia74b8819d71f5ea0b986d46ada4d4e8fddba7699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717527}
-
Andreas Haas authored
This CL merges IntegralTypedArrayBase and TypedArrayBase and renames the resulting class to TypedArray. There is no more sub-classing happening anymore, so it makes no sense to have the base classes. Additionally, we now use IntegralTypedArrayBase also for Float32Array. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I4661ff7be878ce0d7d40779ca33f8b70588baf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926506Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#717526}
-