GitLab

R=eroman@chromium.org
BUG=300681
TEST=none

Review URL: https://codereview.chromium.org/25637004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226530 0039d316-1c4b-4281-b951-d872f2087c98

With Chrome 31, Chrome will not accept a fallback to SSLv3 for Google
properties. If we wish to be able to depend on AES-GCM and ChaCha20+Poly1305
support then we need to ensure that an attacker cannot downgrade us to TLS 1.1
(which doesn't include those options).

This change prototypes a signal to indicate that fallback should
not be allowed. We know that Google properties don't need fallback and this
change allows us to test that networks are not too broken to deploy such a
scheme.

It's possible that defective MITM proxies will cause issues with this. The
--enable-unrestricted-ssl3-fallback option exists for diagnosis of any bug
reports.

BUG=302739

Review URL: https://codereview.chromium.org/25547003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226529 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/25541006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297184

Review URL: https://codereview.chromium.org/25098009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226527 0039d316-1c4b-4281-b951-d872f2087c98

This is the third of three patches to add a runtime flag for fast text
autosizing. This patch adds the Content-side plumbing to enable
the Blink-side feature.

This patch depends on https://codereview.chromium.org/25452002 landing.

BUG=302005

Review URL: https://codereview.chromium.org/25454002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226525 0039d316-1c4b-4281-b951-d872f2087c98

RootWindowController::CloseChildWindows() was explicitly deleting
windows. It should only do that for windows that are owned by the
parent, otherwise the window should be removed.

BUG=297028
TEST=covered by test now.
R=oshima@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/25736004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226524 0039d316-1c4b-4281-b951-d872f2087c98

The introduction of the MediaRequestPermission (i.e. infobar) has
opened a race window which causes a recognition session to be aborted
twice, causing a consequent crash on the renderer.
The race window is the following:
1) Session 1 is started (SpeechRecognitionManagerImpl::StartSession)
2) Security checks for session 1 are started asynchronously
   (delegate_->CheckRecognitionIsAllowed).
3) Session 2 is started. This causes an immediate abort of session 1.
4) The oustanding security check for session 1 completes and returns
   a nack. The nack causes an abort of session 1 (in
   RecognitionAllowedCallback). However, session 1 was already aborted
   in 3).
5) The double abort is not tolerated by the renderer, which crashes.

This CL closes the race window with a not-so-elegant fix.
A refactoring of the speech_recognition_manager_impl.cc is STRONGLY
adviced (Hint: use and extend the already existing FSM to keep track
of the asynchronous completion of security checks. Don't introduce
extra state with extra variables).

BUG=296690,116954

Review URL: https://codereview.chromium.org/25550003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226523 0039d316-1c4b-4281-b951-d872f2087c98

Remap the <Search> key to <Escape> in chrome://settings/keyboard-overlay and
acknowledge that the <Search> key proudly shows the "Esc" aligned to the left.

BUG=302912

Review URL: https://codereview.chromium.org/25512004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226521 0039d316-1c4b-4281-b951-d872f2087c98

R=rkc@chromium.org
BUG=299015

Review URL: https://codereview.chromium.org/24998007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226520 0039d316-1c4b-4281-b951-d872f2087c98

It's not immediatley clear to me how this broke, since I converted all the
callsites of the old method. However I've verified on each platform that this
now reports command line switches properly.

BUG=77656,298225

Review URL: https://codereview.chromium.org/25733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226519 0039d316-1c4b-4281-b951-d872f2087c98

> Media Galleries API: Fix MediaGalleriesPreferences initialization for fresh profiles.
> 
> BUG=151701, 295880
> R=vandebo@chromium.org
> 
> Review URL: https://codereview.chromium.org/25539003

TBR=tommycli@chromium.org

Review URL: https://codereview.chromium.org/25725004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226517 0039d316-1c4b-4281-b951-d872f2087c98

Fix the adb_gdb script to honor the --gdb flag for a user specified gdb binary according to the existing usage.

BUG=295807

Review URL: https://codereview.chromium.org/23513083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226514 0039d316-1c4b-4281-b951-d872f2087c98

1) Initial shift key sanity checks
2) Highlighting capitalization
3) Chording base cases.
4) Capitalization on long press.
5) Capitalization on double click.
BUG=295049

Review URL: https://codereview.chromium.org/25305003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226513 0039d316-1c4b-4281-b951-d872f2087c98

Chrome starts correctly with start up urls specified by policy regardless of
the session restore settings.

BUG=301711
TEST=Enroll in Retail mode and verify that the StartUpUrls policy is respected as before.

Review URL: https://codereview.chromium.org/25076007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303231
TBR=simon.hong81@gmail.com, miket@chromium.org

Review URL: https://codereview.chromium.org/25769003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151701, 295880
R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/25539003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226509 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302156
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/25756003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226507 0039d316-1c4b-4281-b951-d872f2087c98

We want to understand how showing search terms in the omnibox interacts
with the presence of the bookmark bar. For users in a field trial that's
showing search terms, this change adds a CGI arg &bmbp=1 to search URLs
if the bookmark bar is pinned and &bmbp=0 otherwise.

This isn't privacy-sensitive, because in theory we could get this
information by looking at outerHeight - innerHeight from search page
Javascript. Logging it explicitly this way is just more reliable than
doing that.

BUG=291244
TEST=unit tests,manual

Review URL: https://codereview.chromium.org/25324003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226506 0039d316-1c4b-4281-b951-d872f2087c98

* Print a usage message if called with no (valid) arguments.
* Determine the script name by stripping before either 'base' or
    'third_party', or strip nothing if neither name can be found in
    the path.
* Allow overriding the script name, and use this in the tests to be
  path-agnostic.

TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/23702057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226503 0039d316-1c4b-4281-b951-d872f2087c98

Currently we use SetExternalTexture(NULL) or SetDelegatedFrame(NULL)
to switch back to showing painted content. This is kinda indirect,
and won't play nicely when SetExternalTexture() is removed, and when
we use a FrameProvider for delegated frames instead of pushing them
to the ui::Layer directly one at a time.

Instead, add SetShowPaintedContent() to switch to a content layer,
and disallow setting a NULL/empty texture or delegated frame.

Also View::SetExternalTexture() is not used, remove it so it doesn't
have to think about this change.

R=piman,sadrul
BUG=263069

Review URL: https://codereview.chromium.org/25596002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226502 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226501 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=158675:158697&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/25638004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226500 0039d316-1c4b-4281-b951-d872f2087c98

The DeviceManagementService will be moved along with the policy/ code into a new
component, and thus it can't access //chrome nor //chromeos code. A recent
refactoring in that direction introduced a regression because it called
StatisticsProvider::GetMachineStatistic() before the StatisticsProvider was
initialized.

This used to work before because GetMachineStatistic() was called only once the
first request was sent to the server (which, on enrolled devices, happens in
a task that is immediately posted but the StatisticsProvider is already
initialized by then).

This change introduces a delegate that the DeviceManagementService uses to
get its configuration parameters, so that the call to GetMachineStatistic()
can again be performed only when a request is sent.

BUG=271392,302798

Review URL: https://codereview.chromium.org/25690003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302841
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/25650002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226498 0039d316-1c4b-4281-b951-d872f2087c98

ObserverListThreadSafe will call PostTask on all observer callbacks,
even those on the same thread. So correct the comment in
MemoryPressureListener which states callbacks on the same thread as the
system broadcast are called synchronously.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/25676002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297854

Review URL: https://codereview.chromium.org/25388002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226496 0039d316-1c4b-4281-b951-d872f2087c98

Observed during sheriff shift: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20ChromeOS&testType=browser_tests&tests=LauncherAppBrowserTest.RefocusFilter

BUG=303231
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/25650004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226495 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an extension management policy provider that allows
explicitly whitelisted apps/extensions to be installed in public sessions.
Right now, QuickOffice and all hosted apps are whitelisted.

BUG=296868
TEST=New browser and unit tests

Review URL: https://codereview.chromium.org/24261010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226494 0039d316-1c4b-4281-b951-d872f2087c98

Instead of clearing the textures in GVDA::AssignPictureBuffers, set
them to cleared in PictureReady. This can make OnAssignPictureBuffers
faster. This can reduce the latency when playing a video or starting
webrtc. This also make resolution change faster.

The test was done on Daisy running apprtc.appspot.com with 720p
decode. AssignPictureBuffers is reduced from 142ms to 24ms.
The decode time of the first three frames are reduced from
202ms, 163ms, 144ms to 74ms, 36ms, 26ms respectively.

BUG=298176
TEST=Play video. Run apprtc loopback. Run vda unittest.
Run resolution change in DASH youtube. Test raw resolution switch.

Review URL: https://codereview.chromium.org/24762003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226492 0039d316-1c4b-4281-b951-d872f2087c98

Currently a visible webview has "at" string awkwardly indented.

TBR=pfeldman
BUG=None

Review URL: https://codereview.chromium.org/25680003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226491 0039d316-1c4b-4281-b951-d872f2087c98

The GestureEventFilter now ignores ACKs for GestureTapDown
events. Whenever a GestureTapDown event reaches the front of the
queue, it is immediately fired and removed from the queue.

BUG=288078
TEST=ImmediateInputRouterTest.GestureTapDownIsAsynch, ImmediateInputRouterTest.GestureTapDownIsInOrder

Review URL: https://codereview.chromium.org/25268002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226490 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=295137
NOTRY=true

Review URL: https://codereview.chromium.org/25760002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226488 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following change:

r103 [OTS] Remove unused constants

BUG=
TBR=yusukes@chromium.org

Review URL: https://codereview.chromium.org/25703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226487 0039d316-1c4b-4281-b951-d872f2087c98

This makes the behavior identical to that in aura.

BUG=302738

Review URL: https://codereview.chromium.org/25602002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226485 0039d316-1c4b-4281-b951-d872f2087c98

Pass 'telemetry_page_measurement_results' as measurement for both metrics.
Distinguish them by passing different values as the trace parameter. This
allows us to show both metrics as separate lines in the same graph.

BUG=238864

Review URL: https://codereview.chromium.org/25593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299634
NOTRY=true

Review URL: https://codereview.chromium.org/25389003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226483 0039d316-1c4b-4281-b951-d872f2087c98

Currently there is only support for SO_ERROR which is
used to query the result of non-blocking calls to
connect().  Since out connect() is always blocking
right now this always returns 0.

Also fix a bug in kernel_proxy:socket() where EACCESS
was being returned rather than -1 (with errno set to
EACCESS).

BUG=296972
NOTRY=true

Review URL: https://codereview.chromium.org/23456045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226482 0039d316-1c4b-4281-b951-d872f2087c98

These are needed for https://codereview.chromium.org/24647003/
BUG=287883
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/25035004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226481 0039d316-1c4b-4281-b951-d872f2087c98

compositor_bindings/ will be moved separately since it is its own beast.

cpp_* will also be moved later.

BUG=265753
TEST=None, just moving files around. :/
R=jamesr@chromium.org,avi@chromium.org,jochen@chromium.org

Review URL: https://codereview.chromium.org/25378002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226477 0039d316-1c4b-4281-b951-d872f2087c98