- 02 Oct, 2018 40 commits
-
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:854474 Change-Id: Iae615d06e1c6fe207a889f989df5a396aed72073 Reviewed-on: https://chromium-review.googlesource.com/c/1255574Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595926}
-
Scott Violet authored
This test is flaky on the msan bot, and I suspect it could flake on the non-msan bot as well. BUG=891383 TEST=test only change Change-Id: Ib8bdc7248faab8058fb8c37a02529214cb580f91 Reviewed-on: https://chromium-review.googlesource.com/c/1256987Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595925}
-
Tarun Bansal authored
Set the network quality in the client hints to the holdback value if network quality web holdback experiment is enabled. Change-Id: Ifc6bcef11c9f980c340d4286e4472572e871f6f7 Bug: 880545 Reviewed-on: https://chromium-review.googlesource.com/c/1227684Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#595924}
-
Gang Wu authored
Copy over the files components/ntp_snippets/content_suggestions_metrics.cc components/ntp_snippets/content_suggestions_metrics.h to components/feed/core/feed_logging_metrics.cc components/feed/core/feed_logging_metrics.h Bug: 888047 Change-Id: I7f8baff84c6d23c80f1d079b6f0e33aa69c9a2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1235314Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595923}
-
Torne (Richard Coles) authored
No behaviour change intended. Using JavaRef instead of bare jobject pointers is preferred. These changes are to prepare for an upcoming refactoring. Bug: 519562 Change-Id: Iff019df737a9d3f4edae0f5ede8c068cee3443d0 Reviewed-on: https://chromium-review.googlesource.com/c/1255662 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595922}
-
Yiming Zhou authored
This change disables caching queries to the Chrome autofill server. This will induce Chrome to always use a POST request when querying the Autofill server, instead of switching between GET and POST requests depending on the request length. An unfortunate side effect of this change is that I had to recapture nearly all the sites. Also adding a number of tests. Bug: 847905 Change-Id: Id052cb4945abd177624465e9793f55c8f034c742 Reviewed-on: https://chromium-review.googlesource.com/c/1250058Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#595921}
-
Camillo Bruni authored
Add timeout before and after setting the focus. Otherwise it's quite likely that we drop one or two characters when using InputWithSelector. Bug: 878390 Change-Id: Ib703447425160eb87683143a61e03461af1795b7 Reviewed-on: https://chromium-review.googlesource.com/c/1256984Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#595920}
-
Siddhartha authored
The addresses stored on stack are used while unwinding, which could refer back to the main thread's stack. To avoid this, replace all address on the stack to point to the copied segment. Also remove SA_ONSTACK flag since it causes unnecessary stack copies while unwinding. BUG=888434 Change-Id: I063216673529893a9458ba36d120268145224521 Reviewed-on: https://chromium-review.googlesource.com/c/1256563 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#595919}
-
Oystein Eftevaag authored
Change-Id: I5a4afc31244d701466af8ba673ceb79f1e2a9d5f Reviewed-on: https://chromium-review.googlesource.com/c/1168502 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#595918}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/95d4c855637a..0daedf7758e1 git log 95d4c855637a..0daedf7758e1 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 dpranke@chromium.org Remove agable, bradleynelson from //OWNERS. Created with: gclient setdep -r src/third_party/depot_tools@0daedf7758e1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id5db1ab19d2828ea448b6251ff8b442980e50cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1257382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595917}
-
bsheedy authored
Automates the two manual tests for ensuring that attempting to use keyboard input while in the VR browser without the keyboard APK installed triggers a DOFF prompt to install or updated the APK. As a side effect, also adds the ability to wait for an element in the native UI to change visibility. Bug: 887588 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie4e08317c82fc2f4cc5379a5d18a82994f34a804 Reviewed-on: https://chromium-review.googlesource.com/c/1246279 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#595916}
-
timidger authored
Without the minium version flag the Chrome Cleanup Tool will try to use this method even when it's not available on older versions of Chrome. R=joenotcharles@google.com Change-Id: I67846a30dca37f66f87a0ac04f1c687c739c4723 Reviewed-on: https://chromium-review.googlesource.com/c/1255571 Commit-Queue: Preston Carpenter <timidger@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#595915}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa7c7ba5051f..1ed6f3571d8a Created with: gclient setdep -r src-internal@1ed6f3571d8a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib9ca57e8a7644767d19da9a2fd94e5d6471152f0 Reviewed-on: https://chromium-review.googlesource.com/c/1257343Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595914}
-
Florent Castelli authored
Fields ssrc, rtx and fec are not part of the standard anymore. Bug: 777617 Change-Id: If937b085ec9fe58f6f763e5bf79fdf95d6635a30 Reviewed-on: https://chromium-review.googlesource.com/c/1255625Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595913}
-
Thomas Guilbert authored
This CL adds the boilerplate code to convert Cast.MediaStatus into media::MediaStatus, and propagates it to FlingingRenderer. The CL also adds an "UNKNOWN" and a "STOPPED" state to MediaStatus, to better represent the statuses that can be received. Bug: 790766 Change-Id: Ic14d85e1e2aa93f45ce1ca3cd4dbee4eccb2fd27 Reviewed-on: https://chromium-review.googlesource.com/c/1241695Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#595912}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1ac95546dd12..bfff4bac826c git log 1ac95546dd12..bfff4bac826c --date=short --no-merges --format='%ad %ae %s' 2018-10-02 buildbot@webrtc.org Roll chromium_revision 81efb6d0..24d8c445 (595716:595822) 2018-10-02 kthelgason@webrtc.org Fix RTCAudioDeviceModule tests. 2018-10-02 philipel@webrtc.org Make RtpGenericFrameDescriptor available for E2EE. 2018-10-02 aleloi@webrtc.org Add support for many channels in push_resampler. Created with: gclient setdep -r src/third_party/webrtc@bfff4bac826c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibecc3708f3e90bdcb9e4a3b317d45daa8a3038a6 Reviewed-on: https://chromium-review.googlesource.com/c/1257182Reviewed-by:
-
Xing Liu authored
Currently the AsyncImageView starts to retrieve thumbnails when the view holders are binded before the actual layout happens, which results in the width and height in thumbnail requests to be 0. This CL delays the thumbnail request after the actual layout happens. Also uses centerCrop for image and video view holders. Bug: 890377 Change-Id: I98f3864027553614a40d8211ac72743e66929db5 Reviewed-on: https://chromium-review.googlesource.com/c/1255586 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
chrome://media-internalsJohn Rummell authored
Currently the timestamps are displayed with only 2 digits for the millisecond field if it is less than 100 ms, resulting in misleading numbers (e.g. 00:00:09 62). Updating the display to always show 3 digits for the milliseconds, and adding a period before (e.g. 00:00:09.062). BUG= TEST=tested locally Change-Id: I37e2cf375ce4311623e6a30271f495ebd0fc4d74 Reviewed-on: https://chromium-review.googlesource.com/c/1256205Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595909}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a77bb2e54b35..2a88bcbaff3e git log a77bb2e54b35..2a88bcbaff3e --date=short --no-merges --format='%ad %ae %s' 2018-10-02 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2a88bcbaff3e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iecf84ca4c56ae262cf396355d36c9a2616d7d89d Reviewed-on: https://chromium-review.googlesource.com/c/1257187Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/84f3a15fd9db..20afd180cccb git log 84f3a15fd9db..20afd180cccb --date=short --no-merges --format='%ad %ae %s' 2018-10-02 dgarrett@google.com som-dispatcher: Remove the som-dispatcher builder. 2018-10-02 nya@chromium.org cidb: Include branch info on inserting builds. 2018-10-02 yamaguchi@chromium.org Avoid CommitQueueCompletion failure by ProgrammingError. 2018-10-02 akeshet@chromium.org gerrit: add a key existence check for gerrit search queries 2018-10-02 saklein@chromium.org portage_util: expand CPV handling. 2018-10-02 saklein@chromium.org run_chroot_version_hooks: port to python/chromite Created with: gclient setdep -r src/third_party/chromite@20afd180cccb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2ae3e83e125ffd62999f88e89cde752c4b26432 Reviewed-on: https://chromium-review.googlesource.com/c/1257185Reviewed-by:
-
Glenn Hartmann authored
This is to sync the client/server R.txt files Change-Id: Iaed949845032ec14c951b3d5d45c62839f282826 Reviewed-on: https://chromium-review.googlesource.com/c/1246953 Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595906}
-
Ben Pastene authored
And add a new test "chrome_all_tast_tests" that uses a conditional. And add that test to the FYI bot. Bug: 876587 Change-Id: I9518389338b99207ba045bfc62d87dda02c4e3e9 Reviewed-on: https://chromium-review.googlesource.com/c/1256209Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595905}
-
Abhishek Bhardwaj authored
This change clang formats a subset of network related source files. BUG=891143 TEST=Compile. Change-Id: I131d132dbcd36200310a8c785eab067795e20576 Reviewed-on: https://chromium-review.googlesource.com/c/1252334 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595904}
-
Lei Zhang authored
Change-Id: I46e26e968f8ef512f890faa2d7c88abcfb17f0f6 Reviewed-on: https://chromium-review.googlesource.com/c/1256367Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595903}
-
Jian Li authored
The offline indicator will show up when the network is disconnected, i.e., the bot is put in airplane mode or does not connect to WIFI. This can cause problems to some tests that need to grab UI elements from the page. To avoid this, we disable offline indicator feature in ChromeActivityTestRule. Bug: none Change-Id: I8828ac7ac340acff3cef129f37e4052f7d6c2ba6 Reviewed-on: https://chromium-review.googlesource.com/c/1252362Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#595902}
-
Xi Cheng authored
Bug: 888716, 851163 Change-Id: I0fce8657b8ab41c0ac57bff548a029bab302c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/1256106Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#595901}
-
Daniel Rubery authored
Bug: 882927 Change-Id: I7217526edbe448fd9588ef0b8a2554e1e969651e Reviewed-on: https://chromium-review.googlesource.com/c/1255725 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595900}
-
Ahmed Fakhry authored
Gesture scrolling starts before top-chrome starts sliding. During that small period, the `DoBrowserControlsShrinkRendererSize` bit should remain unchanged. This CL fixes this issue and adds a test to verify the state of the browser while top-chrome sliding is in progress. BUG=884440, 867063 TEST=Added new test Change-Id: I0737b5b38c727dd77fc522d9a52537f70abb16bd Reviewed-on: https://chromium-review.googlesource.com/c/1249729Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#595899}
-
Mason Freed authored
Previous to this CL, these autoscroll/animation tests passed only because there is a default surface deadline (typically 4 frames) in place. Surface activation does not happen automatically, because in layout test mode, rasterization is not performed until the very end of the test, for image capture. For the tests in question, that deadline was previously always being hit, causing the surface to be activated, triggering the monitored scroll events and passing the test. When the --enable-display-compositor-pixel-dump flag is enabled, however, the default surface activation deadline is changed to be infinite (no deadline). As a result, all such autoscroll/animation tests fail. With this CL, those tests that looked at animation behavior have been modified to call a new continuouslyRunAnimations() javascript method, which sets a flag that causes full rasterization to be included in the lifecycle update that was already taking place. This triggers surface activation, and runs the animations, allowing these tests to pass even with an infinite deadline. Bug: 883547, 874162 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d9e1ae7d10fab186207cdfbc8e2f85f60d99f35 Reviewed-on: https://chromium-review.googlesource.com/c/1229354 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#595898}
-
Marcin Wiacek authored
This is a reland of 4b3c7082 (https://chromium-review.googlesource.com/c/chromium/src/+/1154527) after merging https://chromium-review.googlesource.com/c/chromium/src/+/1185461 fixing https://bugs.chromium.org/p/chromium/issues/detail?id=875909 Original change's description: > Replace enum with @IntDef (javatests) > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values. > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing "static final" values, enum > and some classes in one common @IntDef/@StringDef form: > > 1. with @IntDef/@StringDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries if necessary > 4. with comment about numbering from 0 without gaps when necessary > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > Change-Id: I6aeb3571f6e72dd3599a4a6055189a227312d5c4 > Reviewed-on: https://chromium-review.googlesource.com/1154527 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Cr-Commit-Position: refs/heads/master@{#584198} BUG=875909 TBR=agrieve@chromium.org,tedchoc@chromium.org,asimjour@chromium.org Change-Id: I11a6acd33b6363ddf792eadfeaac01e0d8513a01 Reviewed-on: https://chromium-review.googlesource.com/c/1189642 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595897}
-
Eric Aleshire authored
Instead of using a "fake" select field, we integrate it more naturally as per Moe's comments by implementing a select for the month field. See: https://chromium-review.googlesource.com/c/chromium/src/+/1240913 Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I467c0c9c33ef4f4239f39743672d22de6bf66d06 Reviewed-on: https://chromium-review.googlesource.com/1256067Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#595896}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e92782016c4..9f9c2ea4282f git log 9e92782016c4..9f9c2ea4282f --date=short --no-merges --format='%ad %ae %s' 2018-10-02 bungeman@google.com Don't set kCTFontSymbolicTrait. 2018-10-02 borenet@google.com [infra] Add missing symlink target in go_deps asset 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 def1ba96cba4..16c20140e05e (1 commits) 2018-10-02 mtklein@google.com clamp gamut if needed in SkConvertPixels 2018-10-02 mtklein@google.com missed a spot to clamp to gamut 2018-10-02 mtklein@google.com remove DM timestamps 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9d597f8a3a1e..def1ba96cba4 (1 commits) 2018-10-02 jvanverth@google.com Check for degenerate path when calculating shadow transform 2018-10-02 rmistry@google.com [Android compile bot] Break out of loop if JSON successfully loads 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 996628a4a1fd..9d597f8a3a1e (1 commits) 2018-10-02 kjlubick@google.com Have pathkit use libpathkit.a for faster builds 2018-10-02 brianosman@google.com Reland "Reland "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace""" 2018-10-02 rmistry@google.com Add direct log links on milo page for Android compile bot 2018-10-02 rmistry@google.com Update trigger_wait_ac_task.py to use GCS instead of webhooks Created with: gclient setdep -r src/third_party/skia@9f9c2ea4282f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Icddac9ed8c8b8cfc2ca538496b51870b03d8cd84 Reviewed-on: https://chromium-review.googlesource.com/c/1257142Reviewed-by:
-
Chris Harrelson authored
Bug: 823796 Change-Id: Id2f733f1823c03300c343386ad01573ff0b6d69f Reviewed-on: https://chromium-review.googlesource.com/1252326Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595894}
-
Matthew Jones authored
This patch moves the IPH bubble for duet from pointing at the top toolbar to pointing at the bottom. As a result, the special case for the NTP has been removed. Change-Id: Icbe86c1c19dde17de069d1514f9833243be5e32d Reviewed-on: https://chromium-review.googlesource.com/1249816 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Mikel Astiz authored
As suggested in recent reviews, it's desirable to keep the sync-related source code in a dedicated directory, with separate OWNERS file. The files still belong to the same build targets, because there would be cyclic build dependencies otherwise. While moving the files, various trivial changes are introduced to avoid presubmit and linter errors. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8ce0070e2449f4285c3ccaa85e9d550d61433744 Reviewed-on: https://chromium-review.googlesource.com/1256809Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/38f24ee666e1..0da73fedd900 git log 38f24ee666e1..0da73fedd900 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 jmadill@chromium.org Vulkan: Add dumping of the command graph to GraphViz. Created with: gclient setdep -r src/third_party/angle@0da73fedd900 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6743cae4f182c0795f2e11819b40d8199b8f1411 Reviewed-on: https://chromium-review.googlesource.com/1257186Reviewed-by:
-
Lily Chen authored
This change avoids erroneously deleting an equivalent pre-existing (insecure) cookie when attempting to add a new insecure cookie that path-matches a pre-existing secure cookie. Previously, the pre-existing insecure cookie would be deleted because it is equivalent to the new cookie, even if a matching secure cookie was encountered and skipped. This change adds a check that no secure cookie was skipped while attempting to add the new cookie. Bug: 703627 Change-Id: I471f5887fecd84afc4b746ae78bb73fbf4449cdf Reviewed-on: https://chromium-review.googlesource.com/1252866 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595890}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/48348e91f2d7..a115d8de1c98 git log 48348e91f2d7..a115d8de1c98 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 achuith@chromium.org cros_unittest: Update test gaia account. Created with: gclient setdep -r src/third_party/catapult@a115d8de1c98 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879353 TBR=sullivan@chromium.org Change-Id: Ibe3bc0fe3b14f5f805d4bf4b0421dbd07a7c575d Reviewed-on: https://chromium-review.googlesource.com/1256081Reviewed-by:
-
Josh Pratt authored
Updates the string for kErrorStartingTermina and adds strings for kErrorOffline, kErrorFetchingSshKeys and kErrorMountingContainer. Change-Id: I0a1fba8179d4f32f99cb376922633578b332a912 Reviewed-on: https://chromium-review.googlesource.com/1255762 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595888}
-
Fabrice de Gans-Riberi authored
The test launcher creates a /data directory for each of its children. This is implemented as a directory with a unique number in its name. Access to the number was not thread-safe, which this CL fixes by using atomic operations to increase the number. This is a potential fix for the content_unittests failure seen here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/117497 Change-Id: I42614b0de36e65ffb8bc811813132a8781036896 Reviewed-on: https://chromium-review.googlesource.com/1255926Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595887}
-
