- 12 Dec, 2017 40 commits
-
-
Vadym Doroshenko authored
SecurityOrigin in WebKit has port=0 for ports that are default for scheme. But url::SchemeHostPort requires effective port. This CL adds a call to url::DefaultPortForScheme before creating url::SchemeHostPort. Bug: 554927 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3e6ccf17d5b8fc221ff954b3ac39a8fb0d195ca9 Reviewed-on: https://chromium-review.googlesource.com/823082Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#523578}
-
Bailey Forrest authored
tmpfs doesn't support file attributes. BUG=internal b/70425842 TEST=base_unittests Change-Id: I23d0473680f3e8648971ee39f0c38cbff7fe0819 Reviewed-on: https://chromium-review.googlesource.com/821354Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#523577}
-
Vadim Tryshev authored
Multiple improvements for UMA sequence analyzer. Bug: 769416, 763612, 763611, 770427 Change-Id: Ib5141963cd76729ccf833bc52ffadde9b1017db7 Reviewed-on: https://chromium-review.googlesource.com/804406 Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523576}
-
Michael Thiessen authored
We were previously only creating it once on entering VR, so if we switched tabs, or the tab was closed, weird things could happen. Bug: Change-Id: I70187cb56a2fa8e0edc5978c17a760895789ccb4 Reviewed-on: https://chromium-review.googlesource.com/823093Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#523575}
-
Emilio Cobos Álvarez authored
The style of an element should only depend on the closest self-including link ancestor, but we're missing to check for that while walking the ancestors in SelectorChecker. BUG=793298 Change-Id: I0449a4d743f9ab1b747f69679c096e96681548ad Reviewed-on: https://chromium-review.googlesource.com/817597Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523574}
-
Kevin Bailey authored
The Omnibox was calling SwitchToTabWithURL() directly from OpenMatch() for tab-switch suggestions. This change creates a special disposition for the suggestions and adds support for it within the browser stack. Bug: 780835 Change-Id: I4f48e6a7a4b46cf9c1a88baedafc87aaf763ebef Reviewed-on: https://chromium-review.googlesource.com/809527Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523573}
-
Aga Wronska authored
Blur (without dimming) is applied when the lock screen animation starts. Blur is removed when unlock screen animation finishes. Dimming is applied only on lock screen. This cl is smoothing the transition, but wider revision and update is planned for the future (crbug.com/793171). Bug: 789320 Change-Id: Ib79bf348a837af7814095136155183b74aafc87a Reviewed-on: https://chromium-review.googlesource.com/812112 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523572}
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true Bug: 786010 Change-Id: I9d9d9d38c99537f17833fe8de0e50f95e50a8279 Reviewed-on: https://chromium-review.googlesource.com/823230Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523571}
-
Lukasz Anforowicz authored
This CL makes sure that RenderViewImpl::GetURLForGraphicsContext3D doesn't crash if |webview()->MainFrame()| is null. This restores the behavior of the code from r187650 which used to do the null check (the check was dropped later in https://codereview.chromium.org/444503002/patch/80001/90022). Bug: 793999 Change-Id: I2027b69ff533fcdbc3bd7fedefc21059f032d023 Reviewed-on: https://chromium-review.googlesource.com/822911Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#523570}
-
Nate Chapin authored
This lets us get rid of the last non-trival usage of ResourceClient::SetResource in ClassicPendingScript Bug: 793028 Change-Id: I39a4859cb1b941ff6a399fad88d40e353df4d462 Reviewed-on: https://chromium-review.googlesource.com/822176Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#523569}
-
Erik Luo authored
DevTools currently bails out when trying to autocomplete large TypedArrays. This relaxes our condition to bail out on large regular Arrays, too. The original condition is introduced here: https://crbug.com/444116 Bug: 740488 Change-Id: I65e04fc8497fe848d25a78cfad049fcc1e1919a9 Reviewed-on: https://chromium-review.googlesource.com/820935Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#523568}
-
Derek Cheng authored
The feature is default enabled in crrev.com/c/794715. Next step is to remove extension-side DIAL discovery logic. Bug: 718154 Change-Id: I67569a9a4acf0a68c461307592b229c5b91e45d1 Reviewed-on: https://chromium-review.googlesource.com/809925 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523567}
-
Sergey Poromov authored
The CHECK was introduced to trace all unexpected paths to create OTR profile and launch incognito. However, it didn't allow creation of system OTR profile, e.g. for User Manager. See crbug.com/794154 for the crash report. BUG=794154 TEST=Run trybots Change-Id: I4c1159fd5f25ea97fe5dacf9df3bdb4596418bb4 Reviewed-on: https://chromium-review.googlesource.com/822654Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523566}
-
Sergio Collazos authored
This reverts commit ff34ceb7. Reason for revert: Breaking downstream ExternalURLSigninTestCase test suite. Original change's description: > [Cronet] Populate cronet metrics object with data from net/. > > Currently this only creates the an appropriater delegate in net/, calling it from there. > There still needs to be created code in cronet which registers and appropriate delegate, > and then populates the metrics object that will finally be given to the client. > > Bug: 702796 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I33a8ce1f489a7bfb74b4c9561a57b7b5a71013e0 > Reviewed-on: https://chromium-review.googlesource.com/763934 > Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> > Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> > Reviewed-by: Misha Efimov <mef@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523430} TBR=mef@chromium.org,eugenebut@chromium.org,kapishnikov@chromium.org,lilyhoughton@chromium.org Change-Id: Ic9cb928a24a1577c506542c18b15261aa0d96126 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/822922Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#523565}
-
Robert Sesek authored
After internal cl/170262399, the crash collector will automatically stitch together values named "key__1"..."key__N". Chromium's existing "key-1".."key-N" syntax is special-cased in the processor on a per-key basis. By switching to the key syntax handled by the collector, it will make converting to the new crash key API easier for values that have to be chunked in Breakpad (like the active URL and variations hashes). When the crash key reaches the processor, it will already be assembled into a single value, rather than needing to be joined by the processor. Bug: 598854 Change-Id: I393cc621bab61aafa4ea08602653807f448ff125 Reviewed-on: https://chromium-review.googlesource.com/822293Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523564}
-
Theresa Wellington authored
When the sheet is closed, add an accessibility description to the toolbar so that it provides useful information when focused during swipe-explore. BUG=748357 Change-Id: Ie7fb7221b75e86fb19423455cfe8c3449201dc67 Reviewed-on: https://chromium-review.googlesource.com/820593 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#523563}
-
Sunny Sachanandani authored
ScopedMakeCurrent and ScopedReleaseCurrent don't check for errors when restoring the previous context. In most cases the MakeCurrent that restores the previous context should not fail, and if it fails we don't return errors up the stack so we CHECK that MakeCurrent succeeds. However, for DirectComposition, we use ScopedReleaseCurrent when reallocating the drawing surface. Restoring the context can fail in this case. This CL adds a Restore method to both classes whose return value must be handled. This prevents the CHECK in the destructor. The lack of error checking is causing a crash in SetSwapInterval, due to null-dereference of GLContext::GetCurrent. This was found by adding a crash key to get the stack trace for SetCurrent(NULL). BUG=724999 R=piman Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I370ff470c78afa76bd000de60a6a63295746ee1b Reviewed-on: https://chromium-review.googlesource.com/818533Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#523562}
-
Devlin Cronin authored
The entire suite of externally-connectable messaging tests has been disabled on Windows. I'm unable to reproduce any failures locally, and all the logs have dried up. Try re-enabling one, and see how it goes. Bug: 350517 Change-Id: Ib08941ad1b5c6fd007056d2c9af8a8c349c08e05 Reviewed-on: https://chromium-review.googlesource.com/823012 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523561}
-
Devlin Cronin authored
ExtensionPrefs::GetExtensionsFrom() is never used. It was originally exposed for the ProtectedPrefsWatcher, but that was removed in crrev.com/102253f8. Remove it. Bug: None Change-Id: Ibc1f246f81e5826762d6183cca3c37c7a6b38624 Reviewed-on: https://chromium-review.googlesource.com/822517Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523560}
-
clamy authored
This CL ensures that the base URL is properly used as the first_party_for_cookies URL in Android WebView if it is non-null. This fixes an issue with cookies being unproperly set for iframes if their parent was loaded through LoadDataWithBaseURL. BUG=793648 Change-Id: I0f7da293f1e102f7b414ae799f701d48667eefc1 Reviewed-on: https://chromium-review.googlesource.com/822572 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523559}
-
Joel Einbinder authored
If a workspace root was exluded, it would instead exclude "undefined" Change-Id: Ib82e11f2182a1fcced176735ae714212a153d5b2 Reviewed-on: https://chromium-review.googlesource.com/822457Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523558}
-
Devlin Cronin authored
v8_helpers::CallFunction wraps v8::Function::Call. However, we should be avoiding using v8::Function::Call whenever possible, since it doesn't account for all possible state in the renderer (e.g., script suspension, etc). Remove v8_helpers::CallFunction and inline the v8::Function::Call at the two places it was used, along with a TODO to update them. Bug: None Change-Id: If3358bfda74126c3898cea2483fc6a012bdd6f24 Reviewed-on: https://chromium-review.googlesource.com/823010Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523557}
-
Konstantin Ganenko authored
CompletionHandler is used in CacheThread_BlockFile. CacheThread_BlockFile is lazy + leaky instance, thus, there was race condition when all lazy instances are already destroyed, but message io pump still processes some io overlapped operation,leading to using IOHandler after free. Make completion handler to be refcounted and add ref to each overlapped operation it participates with. R=jkarlin@chromium.org, morlovich@chromium.org Bug: Change-Id: I7bd5fbdc83aae05489d5089ee16a94857ea1b104 Reviewed-on: https://chromium-review.googlesource.com/793158Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#523556}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/7f5c3eb76834..3c613c0d79fa $ git log 7f5c3eb76..3c613c0d7 --date=short --no-merges --format='%ad %ae %s' 2017-11-16 fjhenigman Update docs for GN standalone and GYP deprecation. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I56bd58391a560f0f938e0006f850a7758ddd7f24 Reviewed-on: https://chromium-review.googlesource.com/822178Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523555}
-
Bret Sepulveda authored
As per the Harmony spec, the arrow is removed. This patch also includes related cleanup. Bug: 605657 Change-Id: Icdca8e14ee135578d57840cafc4397987262a141 Reviewed-on: https://chromium-review.googlesource.com/817952Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#523554}
-
Robert Hogan authored
Bug: 180722 Change-Id: I187155b0076d8f4e7d9e7c9e7b80d9686a12ad2c Reviewed-on: https://chromium-review.googlesource.com/808929 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523553}
-
John Chen authored
Currently, the ChromeDriver water shows green status even when some tests have failed. Updating the build script to fix that. Bug: 768880 Change-Id: I5f3ccadd00a119390dd9fbd625172f987a1100eb Reviewed-on: https://chromium-review.googlesource.com/809726 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#523552}
-
Robert Sesek authored
Bug: 598854 Change-Id: Ie1774cca339e3a0a169cc367e21b113aab6a8b70 Reviewed-on: https://chromium-review.googlesource.com/821250Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523551}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f7aa204aafe9..ebcbb85ea364 $ git log f7aa204aa..ebcbb85ea --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dsinclair Move Script_Som_Border{Width|Color} to CJX_Object 2017-12-12 thestig Roll DEPS for Skia to 40ca2087. 2017-12-12 thestig Combine WideString::operator< and Compare(). 2017-12-12 dsinclair Move Script_Attribute_Integer to CJX_Object 2017-12-12 thestig Use early returns in pdf_parser_decode.cpp. 2017-12-12 dsinclair Remove unused script attribute methods 2017-12-12 dsinclair Move Script_Attribute_BOOL to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I892e5f50dc275d95a080f6962e2072f82e36828f Reviewed-on: https://chromium-review.googlesource.com/822177 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523550}
-
Will Chen authored
This enables the new integration test framework to support startup tests that need to exercise activities in the inspected page prior to starting the DevTools session. This migrates console-format-startup.js as an example test. Bug: 667560 Change-Id: Ifdd82135494ef7e05879297197e210a9b812d3ea Reviewed-on: https://chromium-review.googlesource.com/803909 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523549}
-
Alice Boxhall authored
Bug: 793225 Change-Id: I888f166d099b7829b942fc8d31c16fec8a3df411 Reviewed-on: https://chromium-review.googlesource.com/821950Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#523548}
-
Brian Salomon authored
These factories don't require casting of GrGLInterface/GrVkBackendContext to GrBackendContext and return a sk_sp<GrContext> rather than a bare pointer. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie0673c724a9d1d853a571e68ad001ce491860e85 Reviewed-on: https://chromium-review.googlesource.com/817677 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523547}
-
Ben Chan authored
The notification view for SMS messages is limited to show at most 3 lines, which is not sufficient to show the full content of a SMS message with multiple line breaks. As a workaround, this CL collapses whitespaces in a SMS message to minimize the number of lines needed to show the SMS message in the notification view. Bug: 775786 Change-Id: I807a50c888a1d36439b19805e946d7fb261de633 Reviewed-on: https://chromium-review.googlesource.com/821850 Commit-Queue: Ben Chan <benchan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523546}
-
Joel Einbinder authored
We shouldn't mess with the folder structure while the user is inside it. They might be crushed. Bug: none Change-Id: Iaa03fc58d2992d849b3fc097747549e938c7761d Reviewed-on: https://chromium-review.googlesource.com/821560Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523545}
-
Penny MacNeil authored
- kFileNotFound and kArraySizeZero now treated as kSuccess. - Updated shared definitions in whitelist_packed_format source set. New timestamp to track last load attempt in local cache. Added relative path and file name too. - Decision made to check is_sorted on array during init. The array will be smaller than in original design, so speed hit will be minimal. - New tests. BUG=769590 TEST=chrome_elf_unittests.exe, WhitelistFileTest.* Change-Id: I45c4321ccdf89d8768509c0dad21c9c15f73c4e3 Reviewed-on: https://chromium-review.googlesource.com/794551 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#523544}
-
Dominick Ng authored
https://crrev.com/c/737610 fixed a performance issue in WebsitePermissionsFetcher by overriding android.util.Pair's hashCode method. This allowed a previous fix for a NullPointerException crash on Android pre-Kitkat to be removed. Unfortunately, the pre-KitKat crash occurs not only in the hashCode() method, but also in the equals() method. This CL overrides equals() with an implementation that correctly handles nulls. The implementation is taken from the CL which introduced correct null handling to android.util.Pair - https://android.googlesource.com/platform/frameworks/base/+/162fabbcf81157fddab1c38de09bdabaff8c068a%5E%21/#F0 BUG=793974 Change-Id: Ica6b102146222fbeac98c3179dbcf0c9ef101f85 Reviewed-on: https://chromium-review.googlesource.com/821330Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#523543}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/8cc672aa9c1c..d076c5980367 $ git log 8cc672aa9..d076c5980 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 simonhatch Dashboard - Parallelize some things in /add_histograms_queue Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I92852cee232fa1d454ada70f4b221038d067c430 Reviewed-on: https://chromium-review.googlesource.com/822452 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523542}
-
Sadrul Habib Chowdhury authored
Start running content_unittests with the --mus flags on linux-chromeos bots. BUG=786453 Change-Id: Ied53b0f651dbec49ee7a3224623bb69343eaf891 Reviewed-on: https://chromium-review.googlesource.com/817691Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523541}
-
Paul Miller authored
UpdateEnabledState is really 2 functions in one: UpdateEnabledState(true) is only called from Enable, and UpdateEnabledState(false) is only called from ~Connector. Despite its name, UpdateEnabledState(false) must not actually disable accessibility, because of bugs 775532 and 792269. So fold the 2 parts into their respective call sites. BUG=792269 Change-Id: Ie7afcebda79820d4856a8b050f9b865c2bd1f5c3 Reviewed-on: https://chromium-review.googlesource.com/812084Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523540}
-
Tarun Bansal authored
A URLRequest is heuristically marked as hanging if its value is M times more than the transport RTT estimate, and/or N times the HTTP RTT estimate. A throughput observation window is marked as hanging by comparing the duration of the window with the HTTP RTT estimate, and the number of bytes received during the window with the expected congestion window size. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 765378 Change-Id: Ia215102194a4426cf6c447a629e29145fa8cb13c Reviewed-on: https://chromium-review.googlesource.com/777855Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#523539}
-