GitLab

TBR=ddorwin@chromium.org
BUG=none
TEST=Tested on Linux x64 on Youtube.

Review URL: https://codereview.chromium.org/12223085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181881 0039d316-1c4b-4281-b951-d872f2087c98

Before, it was only in the context menu, what was not so user friendly. This patch adds this item on top of the gear menu to improve its visibility.

TEST=Enter Files.app, click on the gear menu.
BUG=174623

Review URL: https://codereview.chromium.org/12211124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181880 0039d316-1c4b-4281-b951-d872f2087c98

That space is only used in maximized mode of Files.app. When the extension acts as an open dialog, then there is no need for this space. Along the way, increased the space in Files.app mode to look better.

TEST=Open a browser, press ctrl-o. Verify that there is no extra space like on the screenshot in the bug's description.
BUG=175666

Review URL: https://codereview.chromium.org/12208125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181879 0039d316-1c4b-4281-b951-d872f2087c98

This is the last CL to get rid of BrowserList::const_iterator, BrowserList::begin(), and BrowserList::end() entirely (hopefully -- i.e., I can now build chrome, browser_tests, and unit_tests without these 3 methods -- there are 3 other CLs in the pipeline in parallel, I will land a CL to remove those methods for good once ToT no longer requires them)!

Various browser tests were already making explicit assumptions about native-desktop, hardcoding that some more in some places. Otherwise just replacing all the iterators by BrowserIterator (which in theory is multi-desktop, but in browser tests only the native desktop's list will have browsers for now).

Further changes can be made independently later if multi-desktop browser tests are desired.

BUG=129187

Review URL: https://chromiumcodereview.appspot.com/12210067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181878 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Manual, see steps below.

Test steps:
1) Start cycling using three fingers vertically on the track pad.
2) Ensure that lifting said fingers ends cycling. 

Review URL: https://chromiumcodereview.appspot.com/12209109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181877 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash when DecrementCapturerCount() makes a delayed WasHidden() call during WebContentsImpl destruction.

Two parts:

1. WebContentsImpl::DecrementCapturerCount() will restore the true "WasHidden" status of the RenderWidgetHost once the counter reaches zero.  However, DecrementCapturerCount() can be called [indirectly] from the WebContentsImpl destructor.  In this case, it should not attempt to change/notify anything.

2. It's possible for ThumbnailTabHelper::WidgetHidden() to call ThumbnailTabHelper::UpdateThumbnailIfNecessary() with a NULL pointer.  Added a NULL check.

BUG=175275,130097


Review URL: https://chromiumcodereview.appspot.com/12209104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181876 0039d316-1c4b-4281-b951-d872f2087c98

This change also moves some UI code from chrome/browser/extensions into
/chrome/browser/ui/, and cleans up the app_launcher.* code.

BUG=159366


Review URL: https://chromiumcodereview.appspot.com/12095052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181875 0039d316-1c4b-4281-b951-d872f2087c98

Extended crash-on-hang-threads command line switch to
accept the unresponsive seconds. 

For example, if  --crash-on-hang-threads=UI:3:18,IO:3:18 is passed as
command line argument, ThreadWatcher crashes the browser if UI or IO
is not responsive for 18 seconds and the number of browser threads that
are responding is less than or equal to 3.

If there is no command line switch, it defaults to
"UI:3:18,IO:3:18,FILE:3,90" as the value in Canary and Dev.

It defaults to empty string in STABLE channel (i.e., we don't crash
the browser due to jankiness).

For beta channel it defaults to "UI:3:36,IO:3:36,FILE:3:180".

Deleted crash-on-hang-threads command line switch because
crash-on-hang-threads supports this.

R=jar@chromium.org
TEST=unit tests for ThreadWatcher

Review URL: https://chromiumcodereview.appspot.com/12183008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181874 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181873 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=142523&stop_rev=142427&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/12223078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181872 0039d316-1c4b-4281-b951-d872f2087c98

Typo fix, style fix, unused #include/forward-declarations clean up,
adding const, reordering declarations properly, etc.

BUG=none.
TEST=it compiles.

Review URL: https://codereview.chromium.org/12229002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181871 0039d316-1c4b-4281-b951-d872f2087c98

The update script can now be easily updated to build new Chrome-specific
clang tools. The intended use for this is to make it easier to write
tools based on LibTooling to do large-scale refactorings across the
entire Chrome codebase.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/12223047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181870 0039d316-1c4b-4281-b951-d872f2087c98

Inside of TileManager.

BUG=175597


Review URL: https://chromiumcodereview.appspot.com/12220112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181869 0039d316-1c4b-4281-b951-d872f2087c98

page has started but hasn't finished loading.

BUG=175116


Review URL: https://chromiumcodereview.appspot.com/12220109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181868 0039d316-1c4b-4281-b951-d872f2087c98

When docked to the right the dev tool's web view would be cropped.

This bug was due to the way I implemented view layout in r181301.

The dev tool view was being correctly layed out but the subview was not.

To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead.

BUG=173205
TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out.

Review URL: https://codereview.chromium.org/12226086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181867 0039d316-1c4b-4281-b951-d872f2087c98

Currently the Mac omnibox only allows up and down arrow when the popup is open.

With this CL up and down arrow work even if the popup is not open. This matches the behavior of Windows and ChromeOS.

BUG=174690
TEST=Typed something in the omnibox. Clicked on the web page to close the omnibox popup. Clicked in the omnibox and pressed down arrow. Verified that the omnibox popup was displayed.

Review URL: https://codereview.chromium.org/12221124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181866 0039d316-1c4b-4281-b951-d872f2087c98

Opening a link in a new tab from instant search results would cause the instant search result shadow to stay visible.

The problem was that there were three ways the shadow could be hidden:
   (1) -showPreview:..:drawDropShadow:NO
   (2) - hidePreview
   (3) - onActivateTabWithContents:
(1) and (2) correctly hid the shadow but (3) didn't.

Fix was consolidate all the code into (1) and have everyone call that method.

BUG=173778
TEST=See comment 7 in bug 173778 for an easy way to reproduce this bug. Verified that without my fix the shadow is not removed and with my fix the shadow is removed.

Review URL: https://codereview.chromium.org/12224052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181865 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that while the screen is actively being captured,
the host system will not suspend, e.g. due to inactivity.

BUG=129912


Review URL: https://chromiumcodereview.appspot.com/12211101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181864 0039d316-1c4b-4281-b951-d872f2087c98

Patch originally by Sam Dutton <dutton@google.com>.

TBR=dutton@google.com

Review URL: https://chromiumcodereview.appspot.com/12220106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174479


Review URL: https://chromiumcodereview.appspot.com/12217121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181862 0039d316-1c4b-4281-b951-d872f2087c98

Validate all things credit card. (Number, CSC, Expiration)
BUG=170467


Review URL: https://chromiumcodereview.appspot.com/12213077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181861 0039d316-1c4b-4281-b951-d872f2087c98

In slide view we have nice sliding transition effect, while in mosaic view not. This patch adds a simple sliding animation, which is especially visible when using a keyboard. Along the way, adds scrolling margins, so it is possible to navigate without using keyboard. Refer to a screenshot in the bug description.

TEST=Open a directory (on Drive) with lots of pictures, enter mosaic view, scroll using keyboard.
BUG=174575

Review URL: https://codereview.chromium.org/12208042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181860 0039d316-1c4b-4281-b951-d872f2087c98

- check all extensions at once on startup (checking one at a time was
  thrashing the message loop),
- check before installing rather than after (prevent blacklisted extensions
  from ever being installed), and
- show an infobar ala the policy blacklist warning when an extension is
  blacklisted.


Review URL: https://chromiumcodereview.appspot.com/12211029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181859 0039d316-1c4b-4281-b951-d872f2087c98

This menu became redundant after moving the remaining space indicator to the gear button menu.

TEST=Check if Files.app is not broken. Context menu should be also gone.
BUG=174622

Review URL: https://codereview.chromium.org/12208084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181858 0039d316-1c4b-4281-b951-d872f2087c98

The first time through ManageTilings, raster scale is zero, so you can't
use it to find a ratio.  This DCHECKS because the ratio is infinite.
If the raster scale is zero, we already create new tilings, so skipping
this check will just avoid the DCHECK.

R=reveman@chromium.org
BUG=174236


Review URL: https://chromiumcodereview.appspot.com/12209103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181857 0039d316-1c4b-4281-b951-d872f2087c98

This is a port of some of the changes made to the common.mk
system when it was ported to support building nacltoons.

Also, change oshelpers "rm -f" so that is doesn't output
anything when it can't find files (this matches /bin/rm
behavior).

Also, remove redundant nmf build rules from host_vc.mk and
host_gcc.mk.

Also, add .mk files to exclusion list in top level
PRESUBMIT.py since they contain lines longer than 80 chars
and fixing this would make them harder to read.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12209097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181856 0039d316-1c4b-4281-b951-d872f2087c98

I'm concerned that the original histograms are skewed by sample bias,
since most localStorage DBs are probably small.

Also introduce browser and renderer specific histograms. Kept the original histogram for the renderer one in order to maintain histogram data continuity.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/12209085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181855 0039d316-1c4b-4281-b951-d872f2087c98

TBR=agl@chromium.org
BUG=66835
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12220114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181854 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=benm@chromium.org

BUG=

Review URL: https://codereview.chromium.org/12210130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181853 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181852 0039d316-1c4b-4281-b951-d872f2087c98

- Deprecate is_fetching_changes_ flag
- Add a new flag: may_have_unfetched_changes_ which is turned on
  at the beginning and when an event is fired
- Call StartBatchSyncForOrigin() and FetchChangesForIncrementalSync()
  only from MaybeStartFetchTask() with more strict conditions.

Partialy integrating the change proposal made by tzik:
https://codereview.chromium.org/12221088/

* It ALWAYS sets may_have_unfetched_changes_ true and call MaybeStartFetchTask()
in XMPP/Timer/Auth/Network event handlers, so it has to be able to kick
StartBatchSyncForOrigin() or FetchChangesForIncrementalSync() whenever an
event happens even if the service state is in TEMPORARY_UNAVAILABLE.

* It ALWAYS sets may_have_unfetched_changes_ false in StartBatchSyncForOrigin()
and FetchChangesForIncrementalSync(), so that it won't get stuck in an infinite
loop calling one of the methods again and again when the service state is
TEMPORARY_UNAVAILABLE (e.g. network is offline).

* It does NOT queue fetch tasks to the pending_tasks_ when another task is
running, so the service has not to be overloaded by unifinished pending fetch
tasks.

* NotifyTaskDone() ALWAYS calls SchedulePolling() (which starts the timer
if it hasn't been started) so it should not miss the tminigs where one of
fetch-change methods have to be called.

== State transition map:

{ OK, !batch.empty(), _ }
  -> NotifyTaskDone() calls StartBatchSyncForOrigin() until batch.empty() becomes true

{ TEMPORARY_UNAVAILABLE, !batch.empty(), _ }
  -> NotifyTaskDone() calls nothing
  -> XMPP/Timer/Auth/Network event handler calls StartBatchSyncForOrigin() if no task is running, otherwise let NotifyTaskDone() call it at most once

{ !DISABLED, batch.empty(), !incremental.empty() }
  -> NotifyTaskDone() calls nothing
  -> XMPP/Timer/Auth/Network event handler calls FetchChangesForIncrementalSync() if no task is running, otherwise let NotifyTaskDone() call it at most once

BUG=175047
TEST=manual

Review URL: https://codereview.chromium.org/12210109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181851 0039d316-1c4b-4281-b951-d872f2087c98

Also roll CDM DEPS to r181763.

TEST=Test page plays; content_browsertests pass.

Review URL: https://codereview.chromium.org/12212079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181850 0039d316-1c4b-4281-b951-d872f2087c98

classes to extensions/common/

TBR=ben@chromium.org
BUG=162530

Review URL: https://chromiumcodereview.appspot.com/12208078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172050


Review URL: https://chromiumcodereview.appspot.com/12181005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172705
TEST=on device, login, and press Shift-Alt-n. Also make sure NOT toggling when login/lock-screens.


Review URL: https://chromiumcodereview.appspot.com/12096027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181847 0039d316-1c4b-4281-b951-d872f2087c98

The "code" holds the identification of physical key.
Unlike to "key" value, this value is not affected on current keyboard layout or modifier state.

BUG=169993

Review URL: https://codereview.chromium.org/12224031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181846 0039d316-1c4b-4281-b951-d872f2087c98

Add url prefix to AutofillQuery requests when autocheckout enabled, and set accepts="a" (autocheckout) rather than "e" (experiment)

BUG=172143,172186


Review URL: https://chromiumcodereview.appspot.com/11953100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181845 0039d316-1c4b-4281-b951-d872f2087c98

New icons are smaller and do not look good with vertical centering. This patch aligns them to the label's baseline and also adds small margin between icons and labels.

TEST=Enter Files.app and check icons in the left nav.
BUG=None

Review URL: https://codereview.chromium.org/12208122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181844 0039d316-1c4b-4281-b951-d872f2087c98

Allow downloading of metadata even if drive is disabled on LTE

BUG=175068

Review URL: https://codereview.chromium.org/12220073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181843 0039d316-1c4b-4281-b951-d872f2087c98

Before, only Drive had a gear menu. This menu contains remaining space and help item. For consistency, the same button should appear on any other volume, but without Drive related items. As a result, the help menu item as well as the remaining size are in one place for each volume.

TEST=Check the gear button in Downloads, Drive and some removeable media. It should contain only 2 items for non-Drive volumes: space and help. Check if space is correct.
BUG=172813

Review URL: https://codereview.chromium.org/12221082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181841 0039d316-1c4b-4281-b951-d872f2087c98