- 27 Sep, 2018 40 commits
-
-
Jun Choi authored
Replace the current string "To see your security key, it needs to be in pairing mode. Press the button on your key for at least 5 seconds." with the string "If your security key isn't listed, press the key's button for at least 5 seconds". Bug: 890004 Change-Id: Idef5ef4c390236079f261bc9bf23b9ebdca6d21e Reviewed-on: https://chromium-review.googlesource.com/1249490Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594908}
-
Devlin Cronin authored
In practice, Extension objects are pretty much always const. Update the native bindings unit tests to use const Extension objects, rather than mutable ones. This makes the tests consistent (and removes the need for a "mutable_extension" hack), and gets these ready for ExtensionBuilder returning a const Extension. Bug: 889925 Change-Id: I44e1100515b055f5452f3ef90871a23d587b3f07 Reviewed-on: https://chromium-review.googlesource.com/1249528Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594907}
-
David Benjamin authored
We're only shipping the final version in Chrome 70. The vast majority of incompatibilities will have been dealt with by then, but give some extra time for any non-compliance that only showed up then. Bug: none Change-Id: Icdfd6a4190813a77276b40c1b167d97e69532a6a Reviewed-on: https://chromium-review.googlesource.com/1244165 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#594906}
-
Wenzhao Zang authored
This is a workaround. The bug should keep open until a better solution is found. Verified on both eve (high PPI) and paine (low PPI). Also, "margin-bottom" is a no-op so it's removed. Bug: 889655 Change-Id: I424d1c15ba2ee15a62b098f5bffc28037707ef97 Reviewed-on: https://chromium-review.googlesource.com/1247193Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594905}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/beb0c946de6d..e8dd07969872 git log beb0c946de6d..e8dd07969872 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 jmadill@chromium.org Vulkan: Make vk::FramebufferHelper the graph resource. 2018-09-27 jmadill@chromium.org Vulkan: Make Buffer/Image be CommandGraphResources. 2018-09-27 jmadill@chromium.org Vulkan: Move LineLoopHelper graph work into BufferVk. Created with: gclient setdep -r src/third_party/angle@e8dd07969872 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ic8baae6546c11c0bdcf3decb003fad8f6f9dee4e Reviewed-on: https://chromium-review.googlesource.com/1249515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594904}
-
Peter Kotwicz authored
This CL: - changes Context#startActivity() to use the app context. - sets the Intent.FLAG_ACTIVITY_NEW_TASK flag on the launch intent in order to address error when using app context Change-Id: Ie3091e9aafd50e95c1081376ac7ba4a51c1b1a7c Reviewed-on: https://chromium-review.googlesource.com/1244072 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594903}
-
kylechar authored
InProcessCommandBuffer is being used for the display compositor with OOP-D. Add trace events for key functions, similar to the existing traces in CommandBufferProxyImpl and [GLES2]CommandBufferStub, to help diagnose performance issues. Bug: 832243, 890013 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I34b962b48ad4eb10b112a9c979056993868637a4 Reviewed-on: https://chromium-review.googlesource.com/1250043 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594902}
-
Vladimir Levin authored
Since we don't support MSVC, and since it seems that's the only compiler that causes inefficient packing, I think we can remove the presubmit check that enforces no mixing of unsigned and bool bitfields. R=pdr@chromium.org, wangxianzhu@chromium.org Change-Id: I176bded0da8fe5430029044ff96ec497ee28b999 Reviewed-on: https://chromium-review.googlesource.com/1250051Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594901}
-
Dan Sanders authored
VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED must be retained until all reads have been completed. Such frames are produced when software frames are uploaded to GpuMemoryBuffers. The VideoResourceUpdater handles this, but PaintCanvasVideoRenderer implemented only sync tokens. As a result, WebGL reads of software-decoded frames can tear when the storage is reused for later frames. This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to the VideoFrame until it completes. This ensures that the memory is not reused until after the reads complete in the GPU process. Bug: 819914 Change-Id: I3e6e5f83cff86beedbd76a406aa31c4eb84a0929 Reviewed-on: https://chromium-review.googlesource.com/1244835Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#594900}
-
erikchen authored
Previously, there was separate logic for OZONE and X11. This simplifies the existing logic, while also adding support for mash. Change-Id: I0f652360457e27dcdcdcc4e3afb131626aa07429 Reviewed-on: https://chromium-review.googlesource.com/1246726Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594899}
-
Scott Chen authored
Original CL got reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1248142 Bug: 874122 Change-Id: I547e4c209ec35c6a0a19c67d6194663c1bf3e604 Reviewed-on: https://chromium-review.googlesource.com/1249908Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594898}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/56db013e24cf..377b26ec65be git log 56db013e24cf..377b26ec65be --date=short --no-merges --format='%ad %ae %s' 2018-09-27 srte@webrtc.org Revert "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." 2018-09-27 srte@webrtc.org Makes new congestion controller work with rtp sender tests. 2018-09-27 srte@webrtc.org Removes deprecated functions from legacy SendSideCongestionController. Created with: gclient setdep -r src/third_party/webrtc@377b26ec65be The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie2fec3b353f108b4106e88f56c8a1012b1f4a528 Reviewed-on: https://chromium-review.googlesource.com/1249633Reviewed-by:
-
wutao authored
This cl revises the tab spacing in vertical mode to match the spacing in the wallpaper picker. Images before and after changes are uploaded in the bug. Bug: 889559 Test: manual. Change-Id: I33a73809a9c674b009c5fdf1f9367645d395af87 Reviewed-on: https://chromium-review.googlesource.com/1249818Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#594896}
-
dpapad authored
Bug: 875525 Change-Id: I2bc1181d19b7bc3841da6d7306c85983f6656927 Reviewed-on: https://chromium-review.googlesource.com/1249903Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594895}
-
Seth Hampson authored
This includes subclassing the QuicStream to be used by the RTCQuicStream web API. It is a very basic implementation for the stream, and does not include the functionality that will be needed for reaading and writing. Bug: 874296 Change-Id: I25b69c06986cd68728b966ec28b67684ace5a87b Reviewed-on: https://chromium-review.googlesource.com/1199765 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#594894}
-
Evan Stade authored
Use a pre-existing window property instead of ash::ShellObserver to observe overview mode changes. Bug: 854704 Change-Id: I4b178f892b7a30c6de6a4e5f8a8521133651e799 Reviewed-on: https://chromium-review.googlesource.com/1244890Reviewed-by:
-
Mustaq Ahmed authored
Bug: 817027 Change-Id: I0a7e3fb3014017a07158225082aab19b51ccdf24 Reviewed-on: https://chromium-review.googlesource.com/1240199Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594892}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 093e5cfc. With Chromium commits locally applied on WPT: 16f78349 "Move target-in-different-window.html into wpt/" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25393 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Iebeed982408d2dbc24baaeb5a81dbf2d65b8a034 Reviewed-on: https://chromium-review.googlesource.com/1249806 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594891}
-
Nate Fischer authored
No change to behavior. This adds real constructors to create a Java AwWebResourceRequest, and clearly documents that isRedirect is typically false due to a lack of information. This was proposed as as an alternate solution in https://docs.google.com/document/u/1/d/1f-uoNx4X8JvJeXwwRopPGlGSkLVyuUsDRkU1n3ykeGg/edit# Test: N/A Change-Id: Ia8c8c6a1ca53dd8c0265165640226585a742298f Reviewed-on: https://chromium-review.googlesource.com/1244837Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594890}
-
Dana Fried authored
Half of requested cleanup following text scaling issues with Windows Text Zoom accessibility feature. Removes calls to GetNonClientMetrics() sprinkled around the code, as well as most uses of the Windows LOGFONT struct outside of platform_font_win and its callbacks. The remainder of the cleanup will be in a followup CL, which will consolidate all of the fiddly scaling and other uses of LOGFONT into platform_font_win. Bug: 888788 Change-Id: Iff47d2037b6a70210bd1eb0f24ab2f0430c59f86 Reviewed-on: https://chromium-review.googlesource.com/1246824Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
This reverts commit 1ef23c93. Reason for revert: Caused several styling breakages across WebUI surfaces, see https://bugs.chromium.org/p/chromium/issues/detail?id=890030 Original change's description: > Make :host account for its own pseudo-class specificity. > > Otherwise `:host div` is equally specific to `div`, which seems undesirable and > doesn't match any spec. > > Bug: 857415 > Change-Id: I0a012ada134acb022dab85c3912b33ac5d0bd1dd > Reviewed-on: https://chromium-review.googlesource.com/1238445 > Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594745} TBR=emilio@chromium.org,futhark@chromium.org,andruud@chromium.org Change-Id: I98ce78a982a1d71356f18ec60a01e9616d5f9eec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857415 Reviewed-on: https://chromium-review.googlesource.com/1250054Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594888}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf257cec18f0..95d4c855637a git log cf257cec18f0..95d4c855637a --date=short --no-merges --format='%ad %ae %s' 2018-09-27 enne@chromium.org Add skia reviews to my_activity Created with: gclient setdep -r src/third_party/depot_tools@95d4c855637a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I95dabb93c078fb1fdba002e293586353e38773cf Reviewed-on: https://chromium-review.googlesource.com/1249514Reviewed-by:
-
Robert Ma authored
The flaky lower-case font matching ("ahem") has been fixed in https://crrev.com/c/1249385 , so we can unskip this test now. Bug: 724392 Change-Id: I2a005fe055684aa9e8662a0324a6f7ad84935a1a Reviewed-on: https://chromium-review.googlesource.com/1249276Reviewed-by:Erik Chen <erikchen@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#594886}
-
Mikel Astiz authored
We ancitipate future changes where certain bridges will lack the support for client tag hashes. Hence, let's accomodate that in the bridge interface and update the processor to honor the new contract. Bug: 870624,881289 Change-Id: Ic871d7a9fd7cf9c9a989624e1691409aed400e39 Reviewed-on: https://chromium-review.googlesource.com/1249023 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#594885}
-
Varun Khaneja authored
Bug: 867518 R: jialiul Change-Id: Ie6cd84e046f00f384c966e8dd6182cee41541c80 Reviewed-on: https://chromium-review.googlesource.com/1249817Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#594884}
-
Aga Wronska authored
Change-Id: I9f0b101c57bcba075149a876e9d74e6fca721788 Reviewed-on: https://chromium-review.googlesource.com/1235374Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#594883}
-
wutao authored
This cl calls new API in sound level input value provider. Bug: b/115800133 Test: manual Change-Id: I375b3421c6f3d34d5f0d512a99a335420d9586af Reviewed-on: https://chromium-review.googlesource.com/1250086Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#594882}
-
Ted Choc authored
BUG=800033 Change-Id: Ia139fc7abbefea00e3b6a806a02b367f81a5337f Reviewed-on: https://chromium-review.googlesource.com/1249073Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594881}
-
Becky Zhou authored
+ NewTabPageTest#testRender_FocusFakeBox + NewTabPageTest#testRender_ArticleSectionHeader Bug: 888129, 888997 Change-Id: Ic7d66bf90c1fe0a42c22224a5a889a04e6ffb7d1 Reviewed-on: https://chromium-review.googlesource.com/1249129Reviewed-by:
-
Mathias Carlen authored
Before this patch, a misconfigured wait_for_dom action with an empty selector would trigger a DCHECK in the web_controller. This patch fails a wait_for_dom action early when there is no selector. After the patch, we will stop a misconfigured script alreday in the wait for dom action. R=rouslan@chromium.org Bug: 806868 Change-Id: I13d7498cd08e3239777d00946e2bf6176a9680d4 Reviewed-on: https://chromium-review.googlesource.com/1249028 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594879}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3ca11d72..c0b96b43 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I77d6f27c228587381e0213b8d9a904c70eb53413 Reviewed-on: https://chromium-review.googlesource.com/1249804Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594878}
-
Qingsi Wang authored
This CL adds utilities to DnsQuery to allow the parsing of a DNS query in the wire format if it is a valid query with a single question. A new constructor of DnsResponder is also added to generate DNS responses in the wire format with multiple resource record as answers. Name compression in multiple answers are not yet implemented in this CL. Combined with the existing utilities in //net/dns/, we now have a full set of capabilities to parse and generate DNS/mDNS queries and response. Bug: 878465 Change-Id: Ifeae0d17243df037af7a3ea0bffb1079018ea714 Reviewed-on: https://chromium-review.googlesource.com/1203320 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#594877}
-
Yuri Wiitala authored
Adds a memcpy (unfortunately) to allow content::VideoEncodeAccelerator to pass VideoFrame data to a HW encoder. Commit 4a74fb0f had migrated the VIZ screen capturer to use the new read-only shmem API; but, unfortunately, the VEA framework for HW video encode still expects/requires the use of the legacy shmem API. Also added a little extra logic to more-gracefully halt encoding once a fatal error occurs. This issue was revealed while diagnosing the above problem, and is being fixed here since it is related. TBR=pthatcher@chromium.org Bug: 888153, 888829 Change-Id: I7e37c024f4c8b2648769b98040e3d28597b199fc Reviewed-on: https://chromium-review.googlesource.com/1242396Reviewed-by:
-
Scott Violet authored
When IME runs remotely there is a callback that is used to signal if the event was handled. This callback is passed around number places. InputMethodChromeOS injects its own callback that does some processing. InputMethodBase was running the callback immediately, not passing it through. This meant some processing was happening that should have been conditional based on the response from the remote client. BUG=888740 TEST=none Change-Id: I51804626cf5bce3bec9690ef33b75d94229228a4 Reviewed-on: https://chromium-review.googlesource.com/1243671 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594875}
-
Lindsay Pasricha authored
ios12-beta-simulator.json ios12-sdk-device.json ios12-sdk-simulator.json ios12-sdk-xcode-clang.json xcode10.1 (10o23u) Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id0dac987f4f4c6cda6e1ff4149dd612be5c65bea Reviewed-on: https://chromium-review.googlesource.com/1249397 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594874}
-
Xi Cheng authored
These two metrics are used to estimate the time cost of notification image file deletion, which provides insight about whether the image folder is corrupted or not. Bug: 888276 Change-Id: I65eee40cae08007ef6dba056b3698436f0d563e7 Reviewed-on: https://chromium-review.googlesource.com/1246783Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#594873}
-
Etienne Bergeron authored
This CL is adding the support for the stack sampling profiler to the GPU main thread. The |tracing_sampler_profiler| is an adaptor that forward stack sample as trace events. These events are collected by slow-reports. This code is only running when the trace category "cpu_sampler" is activated and should not affect performance otherwise. R=piman@chromium.org, ssid@chromium.org Bug: 888580 Change-Id: Ie703d965c1d158581da6fac1ac0f6ea2157ed6f1 Reviewed-on: https://chromium-review.googlesource.com/1249534Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
This reverts commit ab21d472. Reason for revert: Broke - Print preview 'esc' behavior when dialog is open - Settings add-language-dialog ctrl+f behavior Original change's description: > Don't propagate keydown events when dialog is open > > We shouldn't propagate keydown events so that it can > behave modally. > > Bug: 883221 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I4aa5257b4bf6c417123d659ba911cb01641a4cc7 > Reviewed-on: https://chromium-review.googlesource.com/1230493 > Reviewed-by: Scott Chen <scottchen@chromium.org> > Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593619} TBR=calamity@chromium.org,scottchen@chromium.org,sangwoo108@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 883221 Change-Id: I8f044d3e62ffce565a0761327b6aa877d1463224 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1249809Reviewed-by:
-
dpapad authored
Bug: 739532,875525 Change-Id: I4bf43b572eb7a9417f373b414ef101d1d580ef4b Reviewed-on: https://chromium-review.googlesource.com/1249840Reviewed-by:
-
Nico Weber authored
Bug: 887392 Change-Id: I5de7b4d218cd31fe637d52d94f9ba888b88a4c1d Reviewed-on: https://chromium-review.googlesource.com/1249446 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#594869}
-
