GitLab

Revert of NTP Zombie Code Slayer Part IV: Most Visited (patchset #6 id:100001 of https://codereview.chromium.org/1129903008/)

Reason for revert:
Duplicate pref registration on Android somehow.

Original issue's description:
> NTP Zombie Code Slayer Part IV: Most Visited
>
> This is where things get complicated.
>
> NTP4 had a most visited pane.  It showed your top sites.
> So does the current NTP; so I'm trying to remove everything
> that deals with most visited tiles on NTP4 without accidentally
> breaking the same named thing on the current NTP.
>
> Here's what used to exist that I'm trying to remove:
> http://bostandjiev.com/Content/Google/chrome.jpg
>
> Here's what currently exists that I'm trying not to break:
> http://cdn.ghacks.net/wp-content/uploads/2013/04/chrome-new-tab-page.jpg
>
> BUG=329637
>
> Committed: https://crrev.com/1fc345cd960f7efd4e6b07d1f050615239d82d60
> Cr-Commit-Position: refs/heads/master@{#330845}

TBR=samarth@chromium.org,rdevlin.cronin@chromium.org,sky@chromium.org,xiyuan@chromium.org,gab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=329637

Review URL: https://codereview.chromium.org/1151563005

Cr-Commit-Position: refs/heads/master@{#330876}

Moved flags initialization from FakePortAllocatorSession into FakePortAllocator,
so that they are passed to the PortAllocatorSession ctor rather than being set via
set_flags() in the FakePortAllocatorSession ctor. This is required because some
flags (specifically PORTALLOCATOR_ENABLE_SHARED_UFRAG) are ignored if applied to
PortAllocatorSession via set_flags().

Review URL: https://codereview.chromium.org/1143893002

Cr-Commit-Position: refs/heads/master@{#330875}

NTPLoginHandler was originally used to handle login from the NTP. It now
handles login on chrome://apps and chrome://history and employs a dirty
little hack to be re-used.

Undo that hack (exposing of ntp.updateLogin on chrome://history) and
split the handler logically, slimming the history handler
(which runs on mobile).

R=mad@chromium.org
BUG=329637

Review URL: https://codereview.chromium.org/1143963002

Cr-Commit-Position: refs/heads/master@{#330874}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a7b3901..07b5cd0

TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/1143253006

Cr-Commit-Position: refs/heads/master@{#330873}

Review URL: https://codereview.chromium.org/1149763003

Cr-Commit-Position: refs/heads/master@{#330872}

Replacing the unwieldy "he/she" with "they".

TBR=brettw@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1144413002

Cr-Commit-Position: refs/heads/master@{#330871}

Log platform errors so that it is possible to determine from logs what
caused the chrome.serial API to return the generic "system_error"
message.

Review URL: https://codereview.chromium.org/1147223002

Cr-Commit-Position: refs/heads/master@{#330870}

These two methods were being obfuscated or removed by proguard, which
cause the release build to fail for chrome_public_test_apk.

BUG=484934
R=pvalenzuela@chromium.org

Review URL: https://codereview.chromium.org/1150853003

Cr-Commit-Position: refs/heads/master@{#330869}

Update the set of known roots for Windows and Mac. This affects the
|is_issued_by_known_roots| check on these platforms, which controls
things such as the enforcement of Baseline Requirements.

BUG=481573
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/1141173003

Cr-Commit-Position: refs/heads/master@{#330868}

Stop calling BluetoothAdapter::IsDiscoverable() on non-ChromeOS platforms, as
this method is only implemented on ChromeOS, and the feature code that was
calling it currently only runs on ChromeOS.

BUG=488263
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/1148713002

Cr-Commit-Position: refs/heads/master@{#330867}

BUG=490440

This test started failing consistently, and I could not find the reason.
Since it was already disabled on win platforms, now I am disabling
completely.

TBR=miket@chromium.org

Review URL: https://codereview.chromium.org/1144083003

Cr-Commit-Position: refs/heads/master@{#330866}

List of changes:

https://chromium.googlesource.com/chromium/buildtools/+log/b73e5f70d7ac..dc487f429cb9

commit dc487f429cb90cac92ec7a9cd9d49db13648064d
Author: Dirk Pranke <dpranke@chromium.org>
Date:   Wed May 20 14:44:08 2015 -0700

    Roll GN 329298:330790 (c947c407..9d04333f)

    List of changes in tools/gn:

    https://chromium.googlesource.com/chromium/src/+log/c947c40710fe..9d04333fe102/tools/gn

    This roll mostly pulls in two new GN features:

    1) a new 'gn path' command for finding the dependencies
    linking two targets

    2) the 'runtime_deps' option to 'gn desc', which will compute
    the list of files needed to for a target to run based
    on the dependencies and data files listed on the targets. If
    --runtime-deps-list-file is specified when 'gn gen' is run,
    GN will also write out the dependencies for the targets listed
    in the file to $target.runtime_deps files.

    TBR=brettw@chromium.org
    BUG=480053

R=brettw@chromium.org
BUG=480053
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1148283002

Cr-Commit-Position: refs/heads/master@{#330865}

Previously we were doing them inside html_viewer because NavigatorHost was throwing out that extra data before it got to the network service. The fix is to pass through this url request information.

Also:
-add support for netlog to make debugging network issues easier. Use --log-net-log=file_path
-ensure that mojo shell uses the same user agent as html_viewer. since this UA is sent to websites, they need to match or else there are bugs with Gmail (since it sees different UAs when logging in)

BUG=481153

Review URL: https://codereview.chromium.org/1121783003

Cr-Commit-Position: refs/heads/master@{#330864}

We'll add an upstart job on the Chrome OS side to log whether the failure
is seen on each boot.

BUG=458878
R=jrbarnette@chromium.org,vapier@chromium.org,semenzato@chromium.org,olofj@chromium.org,ejcaruso@chromium.org,isherman@chromium.org
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>

Review URL: https://codereview.chromium.org/1133493008

Cr-Commit-Position: refs/heads/master@{#330863}

This adds the tests on the GN bots that are currently configured
recipe-side in the chromium_gn recipe to //testing/scripts, so
that they can be configured repo-side and we will need to modify
the recipe less often.

R=phajdan.jr@chromium.org
BUG=481693

Review URL: https://codereview.chromium.org/1145513005

Cr-Commit-Position: refs/heads/master@{#330862}

user-agent may not present in URlRequest->extra_request_headers() if the field is not overriden.
In this case, we should pass browser's UA to the android download manager.
We have done something similar in MediaPlayerBridge too.

BUG=488444

Review URL: https://codereview.chromium.org/1145303004

Cr-Commit-Position: refs/heads/master@{#330861}

Single-thread compositing is only used in layout tests which also wants
synchronous compositing. So remove the optionality of synchronous
single-thread in the renderer and just always use the two together when
the thread is disabled there.

Also move the decision to use zero copy in synchronous single threaded
mode out to the browser process and just DCHECK it in cc, so that the
browser can make decisions based on using zero or one copy
authoritively.

R=enne
BUG=489447

Review URL: https://codereview.chromium.org/1149803002

Cr-Commit-Position: refs/heads/master@{#330860}

This icon now matches the icon in the omnibox, making it easier to
understand where the downgraded security status has come from.

BUG=413552

Review URL: https://codereview.chromium.org/1146903002

Cr-Commit-Position: refs/heads/master@{#330859}

BUG=None

Review URL: https://codereview.chromium.org/1150723004

Cr-Commit-Position: refs/heads/master@{#330858}

BUG=487866

Review URL: https://codereview.chromium.org/1137623006

Cr-Commit-Position: refs/heads/master@{#330857}

BUG=474397

Review URL: https://codereview.chromium.org/1065763002

Cr-Commit-Position: refs/heads/master@{#330856}

BUG=489442

Review URL: https://codereview.chromium.org/1151603003

Cr-Commit-Position: refs/heads/master@{#330855}

Use subprocess.call() rather than Popen + communicate.
The shell argument to Popen defaults to False so was
redundant.

Use any() rather than explicit loop.

Review URL: https://codereview.chromium.org/1144383002

Cr-Commit-Position: refs/heads/master@{#330854}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/22483d9..f2539d5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1149893002

Cr-Commit-Position: refs/heads/master@{#330853}

Review URL: https://codereview.chromium.org/1135833004

Cr-Commit-Position: refs/heads/master@{#330852}

This reverts commit 0e80c361,
which appears to be causing blink test failures.  Example:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/41877

TBR=hans@chromium.org,dpranke@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG=483026

Review URL: https://codereview.chromium.org/1149913003

Cr-Commit-Position: refs/heads/master@{#330851}

audio_unittests.isolate includes xdisplaycheck so audio_unittests should depend
on it.

BUG=416594

Review URL: https://codereview.chromium.org/1137933006

Cr-Commit-Position: refs/heads/master@{#330850}

This CL implements a ConnectionDroppedDialog using HTML5 dialog element.
The dialog will be shown to the user whenever a connection is dropped.

BUG=486888

Review URL: https://codereview.chromium.org/1146833002

Cr-Commit-Position: refs/heads/master@{#330849}

Disable multisampled_render_to_texture extension on Adreno.

This extension is buggy in Android 5.0 on Nexus6.  We'll turn it off
for 43 by merging this revert, then land a more nuanced blacklist for
44.

R=kbr@chromium.org
BUG=490379

Review URL: https://codereview.chromium.org/1149943002

Cr-Commit-Position: refs/heads/master@{#330848}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a240d64..a7b3901

TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/1144343003

Cr-Commit-Position: refs/heads/master@{#330847}

This CL fixes:
- WebSocketReadQueue may discard data unexpectedly.
- WebSocket{Read,Write}Queue: may stop processing queued operations.

BUG=490196,490200
TEST=None

Review URL: https://codereview.chromium.org/1148913002

Cr-Commit-Position: refs/heads/master@{#330846}

This is where things get complicated.

NTP4 had a most visited pane.  It showed your top sites.
So does the current NTP; so I'm trying to remove everything
that deals with most visited tiles on NTP4 without accidentally
breaking the same named thing on the current NTP.

Here's what used to exist that I'm trying to remove:
http://bostandjiev.com/Content/Google/chrome.jpg

Here's what currently exists that I'm trying not to break:
http://cdn.ghacks.net/wp-content/uploads/2013/04/chrome-new-tab-page.jpg

BUG=329637

Review URL: https://codereview.chromium.org/1129903008

Cr-Commit-Position: refs/heads/master@{#330845}

BUG=422305

Review URL: https://codereview.chromium.org/1150803002

Cr-Commit-Position: refs/heads/master@{#330844}

I audited the code in the process of removing this.  It seems safe to me.

Note that HistoryURL provider isn't the only provider to create a match
of type URL_WHAT_YOU_TYPED--ZeroSuggest does too.  I thought about
creating a helper function that tests for URL_WHAT_YOU_TYPED from the
HistoryURL provider and using that where is_history_what_you_typed_match
is currently used.  Doing so would be exactly equivalent to the current
logic.  However, I looked at all the places is_history_what_you_typed_match
is used, and I see no harm in doing the simpler test (i.e., check only for
URL_WHAT_YOU_TYPED, not URL_WHAT_YOU_TYPED from HistoryURL provider).

TBR=estade
for trivial change to omnibox.js

BUG=471360

Review URL: https://codereview.chromium.org/1129733006

Cr-Commit-Position: refs/heads/master@{#330843}

This CL dramatically improves the ability to verify local Sync data in
Java Android tests. This is done by plumbing through the
ProfileSyncService's GetAllNodes method through JNI.

This new util will also allow for the server-side modification and
deletion of Sync entities in a future CL.

An older version of local data verification
(relying only on entity counts) has been removed.

BUG=365774

Review URL: https://codereview.chromium.org/1127233008

Cr-Commit-Position: refs/heads/master@{#330842}

Adds several new histograms for Contextual Search to track:
The total number of taps before ever opening the promo panel,
the number of times the promo panel was opened, the number
of taps since any panel was opened, and information about the
search term resolution (protocol, and single/multi-word).

There's a downstream CL dependent on this change: https://chrome-internal-review.googlesource.com/#/c/216388/

BUG=477827

Review URL: https://codereview.chromium.org/1131653005

Cr-Commit-Position: refs/heads/master@{#330841}

Also adds DISALLOW_COPY() to Request.

BUG=475153

Review URL: https://codereview.chromium.org/1131173005

Cr-Commit-Position: refs/heads/master@{#330840}

The header checker will now automatically accept any headers not known in the
current toolchain. The previous code would do this but required it to not be
present in any toolchain in the entire build.

See the long comment added in header_checker.cc for details.

Adds a dependency fix for the Android build in base.

BUG=

Review URL: https://codereview.chromium.org/1142423004

Cr-Commit-Position: refs/heads/master@{#330839}

BUG=489751

Review URL: https://codereview.chromium.org/1146813003

Cr-Commit-Position: refs/heads/master@{#330838}

glGetIntegerv with GL_GPU_DISJOINT_EXT causes GL_INVALID_ENUM error
which leaked into the FeatureInfo's Initialize.

BUG=462553

Review URL: https://codereview.chromium.org/1150463003

Cr-Commit-Position: refs/heads/master@{#330837}