- 18 Aug, 2020 40 commits
-
-
Yuke Liao authored
This CL disables 2 more interactive_ui_tests that are failing. Bug: 1111979 Change-Id: I5d6d3fb393acd827be6f3cafcd713faff00c20b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363062 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799184}
-
Moe Ahmadi authored
Beta finch config: cr/322802704 Change-Id: I626064d11e0a5d681db64111adad26aabf94dd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353522 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799183}
-
Haiyang Pan authored
This test suite is pretty stable on fyi MM for the past 200 builds, except for the failures caused by offending CLs And the test pool has enough capacity. Keep it running on 8 core to shorten the test runtime. Bug: 997376, 1098111 Change-Id: I02b9d2cc2ae9dd4e4635b5cb231291e7b6925d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355568 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#799182}
-
Roman Sorokin authored
Bug: b/162972077 Change-Id: I6b206a78bd5efe3eecb74767ec86e069914ce815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340973Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799181}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: Ie14f5f199af160aee865570b364ef8387e5a0499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359993Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#799180}
-
John Delaney authored
Adds new owners file specifically for the AdsPLMO directory. Change-Id: I01028ae59ee4b27211f8deb189199c0ae05fd65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359587Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799179}
-
Eric Seckler authored
Augments the existing Power.CpuTimeSecondsPerCoreTypeAndFrequency with an equivalent metric that is approximated from per-core time_in_state instead of per-thread time_in_state. The latter is not widely supported (only on newer Pixel devices). For this purpose, extends base's CPU class to support reading and parsing the time_in_state stats file in /sys. Bug: 1081760 Change-Id: I8cfb2510a0a6be59cd515e8704033de903898e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359078 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#799178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/297207f64cc3..a651373fa953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC csharp@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041781,chromium:1057100,chromium:1075562 Tbr: csharp@google.com,guidou@google.com Change-Id: Ia1c894bdfe1c77e1107727c5d5b0481f54a0abf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363058Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799177}
-
ziyangch authored
BUG=internal b/163629769 Test=Locally build. Change-Id: I3a6a7bd9f9a34299b98d753058072afed64547d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350495Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#799176}
-
Omer Katz authored
Ephemeron tracing used to be only on mutator thread. We recently restructured it in a way that allows for concurrenncy. This, the TraceEphemeron method can be concurrent and should use GetSafe. Bug: 986235 Change-Id: Ib10ad7eef383f41d2a70d966d04904a54bc96e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358970 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#799175}
-
Nela Kaczmarek authored
This change creates a struct AffiliationFetcherDelegate::Result to support both affiliations and groupings. Bug: 1108279 Change-Id: I0b02ba3dc606204c9b8e5a25394a7e9cab02eb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357809 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799174}
-
David Bokan authored
A text fragment occurs in a URL fragment and begins with ":~:text=...". It is used to highlight and scroll the provided text into view when the page is loaded. For user privacy reasons, we restrict scrolling the text into view unless the navigation occurred via a user gesture. See: https://github.com/WICG/scroll-to-text-fragment#security-considerations for more details. However, it is common (particularly on social and messaging services where content is user-generated) for links to be served via a redirect. A typical example (from chat.google.com) works like this: 1. User receives and clicks a link to https://example.com#:~:text=foo" 2. chat.google.com opens a new tab using window.open("", "_blank") 3. chat.google.com calls document.write on the newly opened window to write a <meta> tag-based client redirect to google.com/url?url=https://example.com... which is the URL redirection service with the destination URL as a query param. 4. google.com/url then calls window.location and writes "https://example.com#:~:text=foo" into it 5. the new tab finally navigates to example.com The only navigation that had a user gesture attached to it is the initial empty document navigation in step 2. This means the example.com page is navigated to without a user gesture and the text fragment is blocked. A similar pattern is seen on many popular services: Twitter, Instagram, Facebook Messenger, etc. This CL solves the above scenario by introducing a "text fragment token". This token grants its holder permission to invoke a text fragment. The token can be used during load to invoke the text fragment, or it can be passed into a navigation to grant permission to the next page without requiring a user gesture. However, in either case, the token is consumed so a page cannot both invoke a text fragment and pass the token. The token is created in only in DocumentLoader's constructor and while processing a same-document navigation. For regular navigations, it is only created if the current navigation was user initiated. For same-document navigations, it's created only if browser-initiated and the navigation has a text fragment. This mechanism can be thought of as a user gesture that applies only to text fragment and whose lifetime extends across navigations but cannot be copied and is always consumed on use. Bug: 1055455 Change-Id: Icddd849937d24b579bbeb5a4b9f87539d8339905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159324Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799173}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/88816e373d30..552d3e3d5ee9 2020-08-18 peah@webrtc.org Reland "Add ability to state whether the APM output will be used" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8f1de19bb7b318b044df7e80301e96784292581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799172}
-
Dirk Pranke authored
It turns out the work I did on the "wrapped_*" targets in gn_isolate_map was somewhat overlapping with the already-existing iOS work to declare things as "generated_scripts". However, the generated_scripts did not include test_env.py. So, this CL rearranges things so that the generated script will call test_env.py, and then we can share logic between the generated_script targets (and every target on iOS and LaCrOS) and use that as the basis for the rest of the work going forward. Bug: 816629 Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917Reviewed-by:
-
Daniel Rubery authored
This CL extends the expiry of SBClientDownload.DownloadRequestDuration, since it is a generally useful top-level metric for Safe Browsing's download protection. It marks obsolete SBClientDownload.ArchiveDownloadExtensions, which is not as useful and was not being used. Fixed: 1109837, 1105086 Change-Id: Ib3f4081a8a5d1ef733243ac7c41ba2011526fd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361002 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This is not needed. The Java code checks to see if the package string is not empty to determine whether the credential is an app credential or not. Bug: 1102025 Change-Id: I38dbdc771a4bcce6eed2a4e18d3ee38d21b5e73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359139Reviewed-by:
-
Philipp Hancke authored
Adds a test which verifies that setCodecPreferences changes the order of codecs in the SDP generated by createOffer. Drive-by: close all peerconnections after the tests, https://bugs.chromium.org/p/chromium/issues/detail?id=836871 BUG=None Change-Id: I75d252bc43919ba2f27c6bd97493f94b3b5a2587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362024Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#799168}
-
Ella Ge authored
This CL changes the how the TWA quality enforcement enabled with the flag and enable the flag for now: * If flag is not enabled: * Show a Toast if local build * If flag is enabled: * if TWA client enabled quality enforcement: * crash * client not enabled, forced flag enabled: * crash * show a toast if local build * otherwise * show a Toast if local build The NOTIFY callback is not needed and removed. Bug: 1109609 Change-Id: I6959092f97d2c2f55cc3b57dbd152147527ae829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353171 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#799167}
-
David Roger authored
The profiles were named after the email of the account. This CL changes to use localized string "Work" instead. Bug: 1076880 Change-Id: I5a0782ae83d6660bcabcea041761f2f3b493ee04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362827 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#799166}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: I06c026e4788c8225d1acdfa1792d4f221806c2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359018 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799165}
-
Xianzhu Wang authored
This mainly fixes the crash when we tried to update the property of a GraphicsLayer that ShouldCreateLayersAfterPaint. The crash could be fixed by checking if the pending layer's paint artifact is the same as the passed in paint artifact, but marking the compositing type of the pending layer can also simplify the code. Change-Id: I3deef1c60057b1925c7a8d9d891904404f5509bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360506Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799164}
-
Sebastien Lalancette authored
Now that the feature is almost completed (but not rolled-out anywhere), fixing up the enum values and adding histograms for the new context menus. Bug: 1093302 Change-Id: Ib3e32c703ed18ddd24c6f7f75c19505cf4e9e343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354530 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799163}
-
James Vecore authored
This adds the contact visibility component which will be hosted in the on-boarding experience as well as in settings. This is just a roughed in version of the component without the back end/mojo functionality to retrieve contacts yet. String, a11y, and final specs are still pending. Eventually this component we need to support a compact layout for on-boarding and a full layout for settings. Screenshots: Zero-state (no-selection): https://screenshot.googleplex.com/079678b4-8a72-43db-a46b-b853286a41ba.png All contacts selected: https://screenshot.googleplex.com/cfd1c5ee-565a-4908-99f1-cd3b7ef5683a.png Change-Id: I6c3558e8f747fade5ee7f7d0c0e0d5a710d77457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352520Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#799162}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9fb0716512d..a8b16365f92a 2020-08-18 csmartdalton@google.com Stop discarding stencil buffers on tilers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I0f7d3135cb55c6f60a6ba7b9fde0d5bf418a3ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363048Reviewed-by:
-
Jonathan Backer authored
This is mostly based on the OOM detection added to SharedContextState, but may apply to Skia detected errors as well. If we detect |driver_needs_reset_|, we should have |GpuChannelManager::OnContextLost(false)| called to LoseAllContexts when context virtualization is enabled. Change-Id: Ife7e6c4db744b24ab2ed55476bed90b05eb1aebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363071Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799160}
-
kylechar authored
Change kInProcessCommandBufferClientId to kDisplayCompositorClientId. InProcessCommandBuffer is no longer used for the display compositor with SkiaRenderer so the constant name is inaccurate. Bug: 1114763 Change-Id: I03b9680930c61e1cb922d97c76959eb06e689638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352761Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#799159}
-
George Steel authored
Animated properties are now counted in the KeyframeEffect constructor and in SetKeyframes instead of in ProcessKeyframesRule. This makes WebAnimations trigger the use counters as well as CSS animations/transitions. Bug: 992430 Change-Id: I7f0d453d7cde1333863a1127c3dcc68931814c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354946 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#799158}
-
Adam Langley authored
EIDs will no longer just contain nonces, thus extracting a single value no longer sufficies. Additionally, caBLEv2 will no longer be based on |FidoCableDevice| and thus we don't need a special handshake handler for v2. This change tweaks the handling of received BLE adverts in several ways to accommodate this. BUG=1002262 Change-Id: I6af0a9a3990f8fabd2144f4b8a69687538ee08b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340387 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799157}
-
Chris Lu authored
When Chrome is the default browser, it will receive all URL opens, which is likely to change certain stability metrics. Thus, it will be good to filter those metrics by default browser status. This metrics records whether the user was deemed to have set Chrome as the device's default browser. Bug: 1107489 Change-Id: Ie0bc34e7ac2979a82c67267e80fb8318dd2c6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347954 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799156}
-
Himanshu Jaju authored
- Posts a delayed task to close connection - Adds a test to check kTimedOut status in TransferMetadata Bug: 1085068 Change-Id: I7c74b19533a97272d0aede9940eaa3f477e47827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359129Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#799155}
-
Karandeep Bhatia authored
Document::domWindow() can be null when a Document is constructed without a browsing context. To prevent this possible derference, use Document::GetExecutionContext which is guaranteed to be non-null. BUG=1116743 Change-Id: Ib679e9689692f6b24a046ba43a17e16b2db858f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360493 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#799154}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008180800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/50LmdZ87Aei15bQBU0QVN59IeJPvU-acRxSAEOTzcrYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163948970 Tbr: help-app@grotations.appspotmail.com Change-Id: I8c005ecbf906685b044a9a4d8d3e9dd5292e2c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363060Reviewed-by:
-
sauski authored
To support not showing a user a survey too soon, the preferences checked by the HatsService to determine survey eligibility are updated when the HaTSNextWebDialog shows a survey. Bug: 1110888 Change-Id: I54a977a1aebf7b2345abace84c2c66aa3c2cb600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326171Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#799152}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/988f19e208bb..9aed03dcb02f 2020-08-18 dpranke@google.com Fix visibility rules for configs enforced by latest GN. 2020-08-18 cwallez@chromium.org OpenGL: Unconditionally set glFrontFace 2020-08-17 rharrison@chromium.org Roll 4 dependencies 2020-08-17 enga@chromium.org D3D12: only lazy clear OutputAttachment textures with render target ops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I724187c67fcf79b1401f7e7be199a4db2ca27479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363052Reviewed-by:
-
Brandon Jones authored
The "mapAtCreation" attribute that the warning currently recommends doesn't exist. Spec and Blink implementation both specify that the correct name is "mappedAtCreation". Change-Id: Ibd4eafac535390afe410d55d5ce922c8d7ae2247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363267 Commit-Queue: Brandon Jones <bajones@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799150}
-
kylechar authored
SurfaceAggregator can enforce a maximum texture size but this was only plumbed in for GLRenderer. Add this value to OutputSurface::Capabilities and implement for both GLRenderer, with the value from gpu::Capabilities, and SkiaRenderer, with the value from GrContext. Also add an arbitrary limit for SoftwareRenderer. If we get an OOM while allocating a RenderPass texture it will crash the GPU process, so placing an upper limit will hopefully reduce OOM crashes. Bug: 1116745, 1099158 Change-Id: Ie12dedeb2e64ce6b24859adc12a3d73d69c18c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359152 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799149}
-
Saurabh Nijhara authored
This change was introduced in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2302639 All OOBE dialogs may not use the same color for subtitle and footer slots. Having color in top level css is affecting some OOBE screens as the Network screen. Hence, reverting the change for now. Bug: 1112744 Change-Id: I00cf2fc673bfeb01513705b232fa278087c3494e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358670Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/12c6d67a4298..e0a44a28c5be 2020-08-18 cjmcdonald@chromium.org pytest: Clean up & remove 'sigterm' marker 2020-08-18 cjmcdonald@chromium.org Migrate depgraph visualization project to contrib 2020-08-18 bpastene@chromium.org cache: Pass quiet=True to cros_build_lib.run() when extracting tarballs. 2020-08-17 rrangel@chromium.org ap_firmware_config/zork: Use futility 2020-08-17 zhuohao@chromium.org puff: add factory branch builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I55a683ca4ed01c6a0c1cf2b1c90ca804a153b591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363055Reviewed-by:
-
Dan Harrington authored
We already have sequential numbers for actions, we just weren't populating the proto yet. Bug: b/155774256 Change-Id: Ie12b718079e44e9c8f2d702d5eb1e216c396db48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359375 Auto-Submit: Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#799146}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b30e90492c5..c2cee61d1ff6 2020-08-18 jleconte@google.com Revert "Chrome Perf Dashboard UI links to Monorail bugs are missing project id." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: rmhasan@google.com Change-Id: Ief910339cd2ab131ee12adcbf69f1b653e0d298b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363056Reviewed-by:
-
