- 05 Aug, 2019 40 commits
-
-
Yuri Wiitala authored
This change ensures a more-complete nil-ing out of the the external references to ServiceWatcher's internally-owned NetServiceBrowserDelegate instance before destroying it. Root cause analysis: ServiceDiscoveryClientMac was destroying an existing ServiceWatcher instance before re-creating a new one (to redo the discovery). When it destroyed the prior one, Mac-specific implementation of the ServiceWatcher was freeing memory without nil'ing out all external references to its owned NetServiceBrowserDelegate. This was causing the Objective-C runtime (objc_storeWeak()) to intermittently crash the whole browser, whenever the routine detected memory corruption: The freed memory was already re-used/changed by the time the runtime looked at it, and so a consistency check failed. Bug: 932337,657495 Change-Id: I109df345c502044ea93fd05ad53a63441473fc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733104 Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684031}
-
Chris Sharp authored
TBR=aboxhall@chromium.org BUG: 990847 Change-Id: I9ac7c2470f77a5b94f4298a0fa5f06e567ea858d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737089Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#684030}
-
Charlene Yan authored
Change-Id: I076b81fe5884590a1dbcb598f89c60276b30fa19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733013Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684029}
-
Greg Thompson authored
The policy settings corresponding to these prefs indicate that they are not per-profile settings. This change moves the pref to which the policies are mapped from Profile into Local State. BUG=958893 Change-Id: Ied34063f83629a896d9a08bfa34af09e834d3577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730156Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#684028}
-
Eugene But authored
Additionally, change appLaunchManagerDidRelaunchApp: API contract to call only when app got relaunched and not call when app got launched for the firts time. This is because +setUpHelper and -resetAppState should not be called unless the app was shut down. Bug: 989743 Change-Id: Id33e5e60a693580269a0f6d5504bfc0427b34c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730954 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#684027}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b8a27c5e6bb1..9031bdd9ba3b git log b8a27c5e6bb1..9031bdd9ba3b --date=short --no-merges --format='%ad %ae %s' 2019-08-05 clemendeng@google.com Use perfect-hash module in gen_builtin_symbols.py Created with: gclient setdep -r src/third_party/angle@9031bdd9ba3b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: None Change-Id: Ic694e3834eef488916f3f1e5dbbfcca9350d9890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684026}
-
Clark DuVall authored
This is a reland of f37f7fde crrev.com/c/1728889 no longer uses CreateURLLoaderThrottlesOnIO. Original change's description: > Remove unused members of ProfileIOData > > These are no longer used after http://crrev.com/c/1731919 > > Bug: 824840 > Change-Id: I7163336861c227fb7fa7aab9fe297898d92067c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731180 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683474} TBR=jam@chromium.org Bug: 824840 Change-Id: I4d68b7d10ea49bfa220bfd16400f891a06c1fabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735058Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#684025}
-
Maksim Sisov authored
There was a wrong gn arg in the ozone/linux config, which had been removed (ozone_platform = "X11"). Also, ozone_platform_headless has been added to be able to run tests with headless backend. Bug: 700309 Change-Id: I66ba98ab7cc55631a0af1ddfb8a06e38e4b7eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735463Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#684024}
-
James Cook authored
The go/splitsettings project is moving Chrome OS settings to a new WebUI settings surface. Migrate the OS icons into their own file. This reduces the number of <if> conditions in settings/icons.html and makes it clearer these are Chrome OS-only. Use viewBox to avoid having separate os-settings20 and os-settings24 iconsets. I have a request out to UX to re-export the SVGs at 20 pixels so we don't need to use viewBox anymore. Screenshots, just to illustrate that nothing changed: Chrome OS combined: http://screen/ipZ38gvF1S1 SplitSettings OS: http://screen/VXoRW8y16eR SplitSettings browser: http://screen/0nqDyMMt2qg Linux: http://screen/j91ivK0YigV Bug: 990394 Change-Id: Ica5976d5b4650b191ea1746e3f7b41983a2ca45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733465 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#684023}
-
Allen Bauer authored
Change-Id: Ibf08fc766626d6c80ca6dc24d8a56dc1555a5f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737009Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#684022}
-
Chris Sharp authored
TBR=blundell@chromium.org Bug: 990844 Change-Id: Ic5a6ecce26e1ee48e4501a2f89c99ed6d00362bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737010Reviewed-by:
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=jamesr@chromium.org Change-Id: I42fce9f4258109d5d381858f28b8ef60961bc4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733497Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#684020}
-
Marc Treib authored
This was only ever enabled in some experiments, and is not intended for launch. Time to clean it up. Bug: 983940 Change-Id: I20e037c2617468793a27f2bb00672156912c5042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722942Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#684019}
-
Mia Glaese authored
Bug: 895542 Change-Id: I892dc63f438e77d865813758303d7f249600f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695968Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#684018}
-
Jesse Schettler authored
See https://crrev.com/c/1704282 for context. Change-Id: I54fd3eae5e96cc6018f6378c9db40025c33000d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735979Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#684017}
-
Rune Lillesveen authored
The placeholder style was removed in [1]. Remove unnecessary SetNeedsStyleRecalc to handle it. [1] https://crrev.com/4f35b999c1e4159ded31f7c16b71ca3e0e7ddfee Change-Id: I04f401e8b080d715b1a2adbcb8751a36bdb86d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735573Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#684016}
-
Chris Sharp authored
TBR=jityao@google.com Bug: 990819 Change-Id: I59a6f048da73dcab633739d77a9770935047c2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735973Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f69a6724..dd07fe70 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22457a126000af20118e304afe9264c0b2368b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736926Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684014}
-
Robbie Gibson authored
These colors are all used in the omnibox popup Bug: 976662 Change-Id: I7b4ed329d069ae341c49a2715f5974cc9f67856b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735370 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684013}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d351c688586..8d4105850c66 git log 3d351c688586..8d4105850c66 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 mbonadei@webrtc.org Remove unused rtc_tools/video_analysis.py. 2019-08-05 chxg@google.com Remove the old `ContributingSources` class. Created with: gclient setdep -r src/third_party/webrtc@8d4105850c66 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ibff74229a41e0eb63e42387ca5377f36270831c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736799Reviewed-by:
-
Matt Jones authored
Change-Id: I96d4b52033828c8e9bb62fc184827da20bbe7b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732795Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#684011}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=scottmg@chromium.org Change-Id: I6aaf63a8b1094b302aad010f3e48e009fe8a04fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733549 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=thakis@chromium.org Change-Id: I55e7922bb8f294bd9286a0ea3dab4753815089ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733608 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Carlos Caballero authored
Remove references of MessageLoopForIO in /fuchsia/mojom/fidl_interface_request_mojom_traits_unittest.cc MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=dominickn@chromium.org Change-Id: I9d67cc20b478d774cd08d1b6101a4da882b7e71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733614 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#684008}
-
Takuto Ikuta authored
The entry is only for linux_layout_tests_root_layer_scrolls try builder. Bug: 846740 Change-Id: I4b9c7ea84e15d5dea02569d6785b46b7fe20e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734834 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#684007}
-
Takuto Ikuta authored
I think it is sufficient to specify dimensions_sets only in builders config. No behavior change intended. Change-Id: I36c50d22f5d5b56f49d54c838848eb59565b7a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735451 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Currently default os dimension seems to be specified in chromium_swarming module. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_swarming/api.py?l=460&rcl=4134bbc385e6082a8b1ad3ebaa0fb9872e1d4915 So this does not change os dimension of swarming tests triggered from bots. Bug: 954450 Change-Id: I67f184fb125a15a2b8c9396bfa7c1d98c3080617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574876 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
This changed ensures that 'hour' and 'minute' are always specified when using the 'Time' property. BUG=924762 TEST=Unit tests. Change-Id: I8c3ed78c4d8decbf1fb758d532af8014c5fd9cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732680Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#684004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00c9f0dc9225..96555343063b git log 00c9f0dc9225..96555343063b --date=short --no-merges --format='%ad %ae %s' 2019-08-05 egdaniel@google.com Put read and output swizzle back on gl format table. Created with: gclient setdep -r src/third_party/skia@96555343063b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I7ff010067c4b2df8829bde3b3e0f6ebf5728182d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736616Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Change-Id: Icc08efd9ec16d63e4ba841778a90ce10d662b6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733583 Auto-Submit: Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684002}
-
Theresa authored
BUG= Change-Id: If1a47d7a8b4825afc6ba9b0e1f42832cb0f28281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733859 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684001}
-
Aaron Gable authored
This reverts commit 68c22826. Reason for revert: This breaks PRESUBMIT.py / the chromium-presubmit bot. Unclear why this was able to pass those checks while landing, but now new tryjobs on top of this are failing. Original change's description: > Add comment to bnc in net/OWNERS. > > See https://crrev.com/c/1704282 for context. > > Change-Id: Ifcfd3b7b9b7867176a90a092056f453fb74124c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736692 > Auto-Submit: Bence Béky <bnc@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683980} TBR=rch@chromium.org,bnc@chromium.org Change-Id: I7398c0c42f872f747e6be40fe7ed3bcf08ef028f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737007Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#684000}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a81193b1377..0453b000cc33 Created with: gclient setdep -r src-internal@0453b000cc33 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I1c2fa3cc128646669d5c97287c7bf63a3469f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736614Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683999}
-
jongkwon.lee authored
Re-enable interactive uitests that were disabled for crbug/823543 and crbug/824418. These issues are because of crbug/641969 which is no longer reproduced on MacViews browser. BUG=823543, 824418, 641969 Change-Id: Id5de29e9d95962f98748d140469f4709fcbd4fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699665 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683998}
-
Chris Sharp authored
This test is often failing on Linux ChromiumOS MSan Tests. TBR=pmarko@chromium.com Bug: 990817 Change-Id: I3bffd39a40823d7ea2dbb80f4f03b2bbf434b891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736435Reviewed-by:
-
Ivana Zuzic authored
A new signature for ChangeSavedPassword takes the index of a password entry, instead of its sort_key, because Android finds passwords by index, rather than by sort_key. Bug: 377410 Change-Id: I972091c7f59c6a0d3c9cc4cbbabea276fcba5c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731829Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#683996}
-
Matt Jones authored
The ModelListAdapter now uses data providers, this patch updates the tutorial to reflect that. Bug: 967054 Change-Id: I012e0451dc0d72102fdc8b07d05ecbb9d051fa37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680652Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 976645 Change-Id: Id5de30ade3821d6ace315411a41932841b2370c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735583 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#683994}
-
Javier Ernesto Flores Robles authored
Also adds a dark color for iOS 12 compatibility. Bug: 976645 Change-Id: Ia5fca38c00fa9f5cbe7275093695ab4c979e4a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731846Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#683993}
-
chrome://omniboxmanuk authored
Change-Id: Idd54e0d77d3e7a5949db9c284acb319c208f33da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733092Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
