GitLab

With this CL we finally use v8::BackingStore as the backing store
implementation of blink::ArrayBuffer.

Changes:
* Use v8::BackingStore as the backing store for ArrayBufferContents.
* Remove ArraybufferContents::DataHolder and
  ArrayBufferContents::DataHandle.
* Replace all uses of DataHolder in ArraybufferContents with uses of
  v8::BackingStore.
* Replace the use of DataHandle in the V8 bindings.
* Add an exception to the presubmit check to allow std::shared_ptr in
  ArrayBufferContents. It is contained there and does not escape.

R=haraken@chromium.org, ulan@chromium.org

Bug: chromium:1008840
Change-Id: Iffa31e889daf4ae54de96f55b4612833d096a884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886858
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712571}

This reverts commit 9d925716.

Reason for revert: a deflaking attempt has landed prior to this
patch, hoping that the test is no longer flaky.

Original change's description:
> Reland "Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest."
> 
> This is a reland of c7dc2cd8
> 
> Original change's description:
> > Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest.
> > 
> > This TwoClientPreferencesSyncTestWithSelfNotifications test case is
> > flaky.
> > 
> > TBR=mastiz@chromium.org
> > 
> > Bug: 1012688
> > Change-Id: I33f1956523be55f3f77db0560aac4c3de6721341
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859635
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Commit-Queue: Lei Zhang <thestig@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#705625}
> 
> Bug: 1012688
> Change-Id: Idb70d277042bcb98a94130da3f2bab59ffaf0d20
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898651
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712514}

TBR=thestig@chromium.org,mastiz@chromium.org

Change-Id: I9a7cd1cf5079a164285d7f6242c1ae310f7d13f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899465Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712570}

The NaCl build doesn't seem to accept the the clang flag
-fdebug-info-profiling, so we need to make sure not to pass that
flag to NaCl builds when clang_emit_debug_info_for_profiling = true

Change-Id: Ib38f58c7a71939a9a8a124df5b6f2b798a93dab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890076Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Johnny (Jianning) Ding <jnd@chromium.org>
Commit-Queue: Jonathan Wright <jonathan.wright@arm.com>
Cr-Commit-Position: refs/heads/master@{#712569}

BUG=546640
R=csharrison@chromium.org


Change-Id: I8e06696bf0ccc29ab291c43528fc373d2ad18b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898656
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712568}

On the Windows Deterministic bot, any ppapi/ changes will make this DLL
non-deterministic. Suppress this for now so ppapi/ changes can land.

Bug: 429358
Change-Id: I165a528a226402fb49e9126ddf221099b7cef029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899566
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712567}

The current logging doesn't distinguish between a failed initialisation
of the preferred backend and a system where there is no expected backend.

Bug: 1018911
Change-Id: Id67a53261e16afa133409312745a6b97f82c9e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897929
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712566}

https://skia.googlesource.com/skia.git/+log/e8356ad35d3c..fb9146ffc7fc

git log e8356ad35d3c..fb9146ffc7fc --date=short --no-merges --format='%ad %ae %s'
2019-11-05 mtklein@google.com merge key() and CanBuild() into CacheKey()

Created with:
  gclient setdep -r src/third_party/skia@fb9146ffc7fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: I4a6b75c5c09650963339ef74080fd603603b265d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899181Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712565}

We have observed ::GetThreadPriority returning 3 after the thread
priority is set to NORMAL on Windows 7. This CL adds code to
correctly map 3 to ThreadPriority::NORMAL in
PlatformThread::GetCurrentThreadPriority(). From documentation,
that should only happen in a REALTIME_PRIORITY_CLASS process,
but since we can't get the thread and process priority atomically,
we can hardly add a robust DCHECK for that.

Bug: 1014659, 872820
Change-Id: If43b9d46fd766dd1d22e0efaeafe0b738ee57d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898209
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712564}

This includes:
1. Factoring out preference-specific logic away from the shared SyncTest
   class.
2. Improved failure messages for the case where engine initialization
   fails.
3. Rewrite the test to just test the intended behavior under test,
   which is about two clients having a mismatching preference type.

Bug: 1012688
Change-Id: I7679a6c2b7963bdb181a35e2f327944320781896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898655
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712563}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0262cc7eb2a2..3b1f341d0028


Created with:
  gclient setdep -r src-internal@3b1f341d0028

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ic614011bcc07db694d6523249918ee76ea96d518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899179Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712562}

Bug: 959157
Change-Id: I8d46c9bb884ae4eb5986876cfbf290c63cd7899d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892958Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712561}

This reverts commit 5fd0e6ed.

Reason for revert: Breaks linux-chromeos-google-rel build

First failing build:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8657

Original change's description:
> Fix browser test EulaTest.LoadOffline
> 
> This commit improves the reliability of the EULA browser test
> EulaTest.LoadOffline. This test was disabled due to its flakiness
> in the past and is now enabled again.
> 
> Tested locally. Ran 100 tests under stress without any errors.
> 
> Bug: 1015948
> Change-Id: I59bc8612da9f5be526a2aa28d13ee70400dbb01e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892775
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Commit-Queue: Renato Silva <rrsilva@google.com>
> Cr-Commit-Position: refs/heads/master@{#712516}

TBR=rsorokin@chromium.org,rrsilva@google.com

Change-Id: I7ef72ddd859ba5689557a8b2157edd13527c0328
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899772Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712560}

SameThreadCheckedMember is never used and just adds complexity to
the codebase

Bug: 986235
Change-Id: I3f7e870c6a6ebdfc9a312531636573c0042f4074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899620Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712559}

TBR=csharrison@chromium.org

Bug: 1021511
Change-Id: Iba23b174a15abcf0dfe8c0f64431aea4a4b0e5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899461Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712558}

Fixed: 890321
Change-Id: I58a5f82adb70ceaf47edcc6b45c8ddd499dd357e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893258
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712557}

SVGListPropertyHelper::AdjustFromToListValues only need to know if the
current animation mode is 'to' or not. Pass a bool with that information
instead and avoid pulling in svg_animation_element.h.

Bug: 1017723
Change-Id: Id9cfacd44b22eaf928d27ac8f1732dd9e7c43507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893205Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#712556}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=bashi@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I5a2520de651ab0f3786f4a25203ee62cc755fb0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895643
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712555}

Splits the contents of example.py into interface.py and
several files.

blink_v8_bridge.py will support Blink-V8 type and value
conversions.

codegen_utils.py is currently a collection of misc util
functions, and should be better organized later.

Bug: 839389
Change-Id: I609be076533106e4e98865add162f40f965398dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892974Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712554}

The concurrent marking tasks used to get an ids as an
argument. With the new jobs api we can no longer pass
the id that way.
This CL updates to tasks to get an id from a collection
of available ids. This way all tasks only need to get a
pointer to the ThreadState (so tasks don't get unique
arguments anymore).

Bug: 986235
Change-Id: Ibd7146840c74297dc4531a1b4c6c1475c647464d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884850
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712553}

Before this CL, FindFormControlElementsByUniqueRendererId did many
linear searches over its vector parameter |form_control_renderer_ids|,
and accordingly had a DCHECK that the vector doesn't contain more than
10 elements.
This CL changes the implementation to build and use a map instead for
the lookups, thus avoiding the linear searches, and making
FindFormControlElementsByUniqueRendererId appropriate for larger
inputs.

Bug: 1004777
Change-Id: I0699d87de7202f42269c3504ecf08356ee880601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899455Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712552}

Object size and mark bit reside in the same half word. Reading the size
during marking causes data races. Specifically, the size is read from
the write barrier and from Member's CheckPointer method.
Adding an atomic version to accessing the size. This version is used by
FindHeaderFromObject in the write barrier slow path and by CheckPointer
in member methods other than allocation (members during allocation will
not be traced yet so atomics are not needed there).
Note that since the size never changed during marking (added a DCHECK to
verify that incremental marking is off during size change), it is safe
to read the size relaxed.

Bug: 986235
Change-Id: I73019f9f9bfeb9562d4d1f29fc020a9b6f71866a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893202
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712551}

SVGAnimateElement is the "most specific subclass" which uses this
SVGPropertyBase interface.

Bug: 1017723
Change-Id: I7537c7cfd8d07175b5aca91c98f6db2ac084ba47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893062Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#712550}

https://android.googlesource.com/platform/external/perfetto.git/+log/30b5b3814199..d66586f24210

git log 30b5b3814199..d66586f24210 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 treehugger-gerrit@google.com Merge "Increase max buffer to 128mb size when uploading"

Created with:
  gclient setdep -r src/third_party/perfetto@d66586f24210

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I6c3ca297780374995da4c222b00c9e453e9ed616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899155Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712549}

TBR=agawronska@chromium.org

Bug: 1021505
Change-Id: I2138a2e645652a4fc0c1e1ff0bf2babba247b4b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899621Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712548}

TBR=dsinclair@chromium.org

Bug: 1021499
Change-Id: If63ffc383d907f8d00a530c0ef4d95e363bf9b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899459Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712547}

On iOS 13, when preloading a PDF, the WebView is getting the focus,
preventing the user from typing in the omnibox.
This CL fixes it by not pre-loading the PDF pages.

Bug: 1017352
Change-Id: Ifd787ee57458df61381fff65eea3b6ed858da874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892215Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712546}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1dfdd03d..9ab48dcc

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I545f8c708292281b47d4eaf05c74b5a976668e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898183Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712545}

Using wpt-import in Chromium 174e5e8b.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
fbfd83be "expose `destination` value on `Request` objects."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I1d32b2e4eb5fa4161202389498c60d9de11cd6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898182Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712544}

After https://chromium-review.googlesource.com/c/chromium/src/+/1826301,
module service worker script fetch would be started via common
ServiceWorkerGlobalScope::FetchAndRunModuleScript() entry point, but
all fetches would be started with kWorkerConstructor param.

This CL adds usage of other ModuleScriptCustomFetchType for already installed
service workers so they would be used InstalledServiceWorkerModuleScriptFetcher
instead of WorkerModuleScriptFetcher in this case.

BUG=938219

Change-Id: I81c17ff8ececa333957398f7f9d8927677245789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893261Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712543}

https://skia.googlesource.com/skia.git/+log/f3d4109a793b..e8356ad35d3c

git log f3d4109a793b..e8356ad35d3c --date=short --no-merges --format='%ad %ae %s'
2019-11-05 mtklein@google.com indent loop so it stands out

Created with:
  gclient setdep -r src/third_party/skia@e8356ad35d3c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: Ib580eb9b8861ca4dceb928eee3a38f486ec49c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899153Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712542}

Bug https://crbug.com/1018385 is caused by navigation initially
classified as "same-document" committing error pages.

During the commit phase of the navigation, the NavigationRequest is
transfered in one of these RenderFrameHostImpl's bucket:
 - same_document_navigation_request_
 - navigation_requests_

A navigation classified as "same-document" ends up in the bucket
incompatible with error pages.
DidCommitPerNavigationMojoInterfaceNavigation expects to find the
navigation is the other bucket.

Add several regressions tests, including WPT tests.

Bug: 1018385
Change-Id: I3d92af1dd487f7b60a3e50a792716a07b074e5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886339
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712541}

Add integration test to check that the bottomsheet behaves correctly when minimized and restored.
Also verify that the page is showed as intended when the visual or layout viewport is resized.

Bug: b/143265578
Change-Id: If79e40b28ed885b70f353d787e05fb4b1a62f5fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890333
Commit-Queue: Luca Hunkeler <hluca@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#712540}

These got fixed by CL:1869445 , presumably because we'd previously enter
the NGPaintFragment code path (when the multicol container had inline
children), rather than falling back to legacy painting, which we now do.

TBR=ikilpatrick@chromium.org

Change-Id: I59e68d762b8f43b05a2de5a2d2bf653c1160ab8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899496Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712539}

This CL
 - adds the source file to sources list,
 - makes test source file be backward compatible with EG1,
 - adds required gn dependencies,
 - links to both eg1 and eg2 frameworks.

Bug: 866147
Change-Id: I5c6dc64c783db7a8863c53e69174257e35b719bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897830
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Auto-Submit: Nazerke Kalidolda <nazerke@google.com>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712538}

https://webrtc.googlesource.com/src.git/+log/ca585bb45729..d5a7838926b8

git log ca585bb45729..d5a7838926b8 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 peah@webrtc.org Reland "Correct AEC3 multichannel functionality activation"

Created with:
  gclient setdep -r src/third_party/webrtc@d5a7838926b8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I15331ce786d75a910e763c7a1742cce5445eccd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712537}

Spec change PR: https://github.com/whatwg/fetch/pull/915
Chromium change CL: https://chromium-review.googlesource.com/c/chromium/src/+/1796367/

Bug: 796192
Change-Id: I05579dc417b384b48ab7aca8537fe68c3ac40ff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682223Reviewed-by: Eero Häkkinen <eero.hakkinen@intel.com>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#712536}

Bug: none
Change-Id: I7ee732c1c123ee1a18fa51adf235ccbd5d3efe1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899494
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712535}

CrElementsLottieTest.All and CrSettingsPasswordsSectionTest_Cros.All

TBR=dpapad@chromium.org

Bug: 1021474b
Change-Id: I25d075b7fb3e99eab14e14bb443f658bf6fd2f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899609
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712534}

TBR=achuith@chromium.org

Bug: 1021492
Change-Id: I92ac9a593b0fb03263c3df3cffa8f06354454f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899454
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712533}

Change-Id: Ib9fc6ab6deaa75a4a668b4a18cfc4650a1ce69d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897655
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712532}